Re: [R-pkg-devel] Acknowledging small functions from another package

2023-05-04 Thread Ben Bolker
In fact Martin Maechler added this in 2021: https://github.com/wch/r-source/blob/trunk/src/library/utils/R/str.R#L19-L21 ## A pearl from ggplot2 et al. NB: often needs '(.)' :%||% ( ) ## *not exported* [should rather be in 'base' than exported here] `%||%` <- function(L,R)

Re: [R-pkg-devel] Acknowledging small functions from another package

2023-05-04 Thread Hadley Wickham
IMO those functions are so small that you don't need to call them out in your DESCRIPTION. Just note in a nearby comment where they came from. Hadley On Thu, May 4, 2023 at 3:21 AM David Hugh-Jones wrote: > > Hi, > > One of my packages copy-pasted some small functions (stuff like `%||%` for >

Re: [R-pkg-devel] Acknowledging small functions from another package

2023-05-04 Thread David Hugh-Jones
Thank you both. This sounds sensible. Yeah, add my vote for `base::%||%`!! David On Thu, 4 May 2023 at 10:00, Duncan Murdoch wrote: > On 04/05/2023 4:53 a.m., Ivan Krylov wrote: > > On Thu, 4 May 2023 09:21:17 +0100 > > David Hugh-Jones wrote: > > > >> One of my packages copy-pasted some

Re: [R-pkg-devel] How to declare Bioconductor Dependencies in the Description File of my R Package

2023-05-04 Thread Uwe Ligges
On 03.05.2023 23:00, Simon Urbanek wrote: On May 4, 2023, at 3:36 AM, Martin Morgan wrote: CRAN is fine with Bioconductor Depends: and Imports: dependencies, as previously mentioned. This is because the CRAN maintainers explicitly configure their system to know about Bioconductor

Re: [R-pkg-devel] Acknowledging small functions from another package

2023-05-04 Thread Duncan Murdoch
On 04/05/2023 4:53 a.m., Ivan Krylov wrote: On Thu, 4 May 2023 09:21:17 +0100 David Hugh-Jones wrote: One of my packages copy-pasted some small functions (stuff like `%||%` for is.null) from ggplot2. (Both packages are MIT-licensed.) What is an appropriate way to acknowledge this in the

Re: [R-pkg-devel] Acknowledging small functions from another package

2023-05-04 Thread Ivan Krylov
On Thu, 4 May 2023 09:21:17 +0100 David Hugh-Jones wrote: > One of my packages copy-pasted some small functions (stuff like > `%||%` for is.null) from ggplot2. (Both packages are MIT-licensed.) > > What is an appropriate way to acknowledge this in the DESCRIPTION > Author: or Authors@R section?

[R-pkg-devel] Acknowledging small functions from another package

2023-05-04 Thread David Hugh-Jones
Hi, One of my packages copy-pasted some small functions (stuff like `%||%` for is.null) from ggplot2. (Both packages are MIT-licensed.) What is an appropriate way to acknowledge this in the DESCRIPTION Author: or Authors@R section? (Note that the list of ggplot2 authors is long and changing.)