Re: [R-pkg-devel] R CHECK warning about new S3 generic/method consistency

2024-03-11 Thread Duncan Murdoch
On 11/03/2024 2:13 p.m., CRAN.r wrote: On Monday, March 11th, 2024 at 12:43 PM, Diego Hernangómez Herrero wrote: Shouldn’t you include the y argument also inmyscale.default ? Your generic is defining that argument as well. I assume (hopefully correctly) that methods don't need to include

Re: [R-pkg-devel] R CHECK warning about new S3 generic/method consistency

2024-03-11 Thread CRAN.r
On Monday, March 11th, 2024 at 12:43 PM, Diego Hernangómez Herrero wrote: > Shouldn’t you include the y argument also inmyscale.default ? Your generic is > defining that argument as well. I assume (hopefully correctly) that methods don't need to include all the arguments of the generic. I

Re: [R-pkg-devel] R CHECK warning about new S3 generic/method consistency

2024-03-11 Thread Diego Hernangómez Herrero
Usually when I write a generic I use … in the definition to allow using additional arguments in specific methods, see as_bibentry <- function(x, ...) { UseMethod("as_bibentry") } as_bibentry.cff <- function(x, ..., what = c("preferred", "references", "all")) { } but in any case the method

Re: [R-pkg-devel] R CHECK warning about new S3 generic/method consistency

2024-03-11 Thread CRAN.r
> No, your assumption is backwards. The methods do need to include all > arguments of the generic. As Writing R Extensions says near the start > of section 7, "A method must have all the arguments of the generic, > including … if the generic does." That's embarrassing. I was worried it was

Re: [R-pkg-devel] M1mac check logs

2024-03-11 Thread Uwe Ligges
Unfortunately, due to a temporary bug in R-devel, the check result changed before you looked at it. Now foxed and back to the older state where the check.log was sufficient to see the issue. Best, Uwe Ligges On 11.03.2024 17:09, Maciej Nasinski wrote: Hey All, I want to help fix the

Re: [R-pkg-devel] M1mac check logs

2024-03-11 Thread Maciej Nasinski
Thanks a lot for your response. Yes, I see the check print is different and clear now. KR Maciej Nasinski > On 11 Mar 2024, at 20:49, Uwe Ligges wrote: > > Unfortunately, due to a temporary bug in R-devel, the check result changed > before you looked at it. > Now foxed and back to the older

Re: [R-pkg-devel] RFC: C backtraces for R CMD check via just-in-time debugging

2024-03-11 Thread Ivan Krylov via R-package-devel
Vladimir, Thank you for the example and for sharing the ideas regarding symbol-relative offsets! On Thu, 7 Mar 2024 09:38:18 -0500 (EST) Vladimir Dergachev wrote: > unw_get_reg(, UNW_REG_IP, ); Is it ever possible for unw_get_reg() to fail (return non-zero) for UNW_REG_IP? The

Re: [R-pkg-devel] R CHECK warning about new S3 generic/method consistency

2024-03-11 Thread Uwe Ligges
On 11.03.2024 19:34, CRAN.r wrote: No, your assumption is backwards. The methods do need to include all arguments of the generic. As Writing R Extensions says near the start of section 7, "A method must have all the arguments of the generic, including … if the generic does." That's

Re: [R-pkg-devel] RFC: C backtraces for R CMD check via just-in-time debugging

2024-03-11 Thread Vladimir Dergachev
On Tue, 12 Mar 2024, Ivan Krylov wrote: Vladimir, Thank you for the example and for sharing the ideas regarding symbol-relative offsets! On Thu, 7 Mar 2024 09:38:18 -0500 (EST) Vladimir Dergachev wrote: unw_get_reg(, UNW_REG_IP, ); Is it ever possible for unw_get_reg() to

Re: [R-pkg-devel] confusion over spellchecking

2024-03-11 Thread Diego Hernangómez Herrero
As per 'The DESCRIPTION file'[1]: As with the ‘Title’ field, double quotes should be used for quotations (including titles of books and articles), and single quotes for non-English usage, including names of other packages and external software. Enclose that words in single quote, it should

[R-pkg-devel] M1mac check logs

2024-03-11 Thread Maciej Nasinski
Hey All, I want to help fix the M1mac-related issue. The URL to issue is https://www.stats.ox.ac.uk/pub/bdr/M1mac/teal.reporter.out I am one of the coauthors of the teal reporter package. The question is how I can access ‘/Users/ripley/R/packages/tests-devel/teal.reporter.Rcheck/00install.out’

Re: [R-pkg-devel] [EXTERN] Re: [EXTERN] Re: [EXTERN] Re: @doctype is deprecated. need help for r package documentation

2024-03-11 Thread Ruff, Sergej
yes. I apologize it took so long to reply. I uploaded the old version of the package to my repo: https://github.com/SergejRuff/boot Von: Ivan Krylov Gesendet: Freitag, 8. März 2024 08:36:43 An: Ruff, Sergej Cc: r-package-devel@r-project.org Betreff:

[R-pkg-devel] R CHECK warning about new S3 generic/method consistency

2024-03-11 Thread CRAN.r
I'm trying to define a new generic, and keep getting an S3 generic/method consistency when running R CHECK. All of the code seems to be working, and I'm not getting any note, errors, or other warnings. This minimal example shows the warning I'm getting. The functions are myscale <-

Re: [R-pkg-devel] R CHECK warning about new S3 generic/method consistency

2024-03-11 Thread Diego Hernangómez Herrero
Shouldn’t you include the y argument also in myscale.default ? Your generic is defining that argument as well. Have a nice day! El El lun, 11 mar 2024 a las 18:25, CRAN.r escribió: > I'm trying to define a new generic, and keep getting an S3 generic/method > consistency when running R