Re: How to post review comment using changed file line number and WebAPI

2013-12-10 Thread Mahen
On Monday, December 9, 2013 6:34:48 PM UTC+5:30, Mahen wrote: Hi, I am trying to post a review comment using WebAPI and python script. I first find out filediff_id and then I send review comment using line number which is with respect to modified file but what I am observing in GUI is

Re: How to post review comment using changed file line number and WebAPI

2013-12-10 Thread Mahen
Thank you David, This was helpful and appreciate quick reply from you. On Tuesday, December 10, 2013 2:33:58 AM UTC+5:30, David Trowbridge wrote: The ReviewBot codebase does this same thing. I suggest looking at _translate_line_num in

How to post review comment using changed file line number and WebAPI

2013-12-09 Thread Mahen
Hi, I am trying to post a review comment using WebAPI and python script. I first find out filediff_id and then I send review comment using line number which is with respect to modified file but what I am observing in GUI is that, my comment is posted with respect to original file and not with

Re: How to post review comment using changed file line number and WebAPI

2013-12-09 Thread David Trowbridge
The ReviewBot codebase does this same thing. I suggest looking at _translate_line_num in https://github.com/reviewboard/ReviewBot/blob/master/bot/reviewbot/processing/review.py -David On Mon, Dec 9, 2013 at 5:04 AM, Mahen mahenk...@gmail.com wrote: Hi, I am trying to post a review comment