[kudu-CR] KUDU-2514 Part 1: Support extra config for table.

2019-06-07 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12468 ) Change subject: KUDU-2514 Part 1: Support extra config for table. .. KUDU-2514 Part 1: Support extra config for table. We have

[kudu-CR] KUDU-2514 Part 1: Support extra config for table.

2019-06-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12468 ) Change subject: KUDU-2514 Part 1: Support extra config for table. .. Patch Set 20: Code-Review+2 (1 comment)

[kudu-CR] KUDU-2514 Part 1: Support extra config for table.

2019-06-07 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12468 ) Change subject: KUDU-2514 Part 1: Support extra config for table. .. Patch Set 20: (4 comments)

[kudu-CR] [java] Favor column ids over column names in scan tokens

2019-06-07 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13562 ) Change subject: [java] Favor column ids over column names in scan tokens .. Patch Set 1: (1 comment)

[kudu-CR] [java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped

2019-06-07 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13565 ) Change subject: [java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped .. Patch Set 2:

[kudu-CR] [c++] Support table rename between scan token creation and rehydration

2019-06-07 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13521 ) Change subject: [c++] Support table rename between scan token creation and rehydration .. [c++] Support table rename between

[kudu-CR] KUDU-2514 Part 1: Support extra config for table.

2019-06-07 Thread Yao Xu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12468 to look at the new patch set (#20). Change subject: KUDU-2514 Part 1: Support extra config for table.

[kudu-CR] sentry: allow caching of COLUMN/TABLE privileges when checking higher scopes

2019-06-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13552 ) Change subject: sentry: allow caching of COLUMN/TABLE privileges when checking higher scopes .. Patch Set 2: (2 comments)

[kudu-CR] [HIVE-12971] add a hive serde for kudu

2019-06-07 Thread Grant Henke (Code Review)
Grant Henke has abandoned this change. ( http://gerrit.cloudera.org:8080/13230 ) Change subject: [HIVE-12971] add a hive serde for kudu .. Abandoned This is being carried forward in https://gerrit.cloudera.org/#/c/13483/ and

[kudu-CR] KUDU-2809 (1/6): temporarily disable TestKuduScanner.testDiffScan

2019-06-07 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13533 ) Change subject: KUDU-2809 (1/6): temporarily disable TestKuduScanner.testDiffScan .. KUDU-2809 (1/6): temporarily disable

[kudu-CR] KUDU-2809 (5/6): add diff scan support to fuzz-itest

2019-06-07 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13537 ) Change subject: KUDU-2809 (5/6): add diff scan support to fuzz-itest .. KUDU-2809 (5/6): add diff scan support to fuzz-itest

[kudu-CR] KUDU-2809 (3/6): C++ private API for diff scans

2019-06-07 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13535 ) Change subject: KUDU-2809 (3/6): C++ private API for diff scans .. KUDU-2809 (3/6): C++ private API for diff scans This patch

[kudu-CR] KUDU-2809 (2/6): skip unobservable rows when iterating an MRS

2019-06-07 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13534 ) Change subject: KUDU-2809 (2/6): skip unobservable rows when iterating an MRS .. KUDU-2809 (2/6): skip unobservable rows when

[kudu-CR] KUDU-2809 (4/6): skip unobservable rows when iterating a DRS

2019-06-07 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13536 ) Change subject: KUDU-2809 (4/6): skip unobservable rows when iterating a DRS .. KUDU-2809 (4/6): skip unobservable rows when

[kudu-CR] [hms] Adjust storage handler package

2019-06-07 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13540 ) Change subject: [hms] Adjust storage handler package .. Patch Set 6: Verified-1 -- To view, visit

[kudu-CR] schema: cache first is deleted virtual column index

2019-06-07 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13554 ) Change subject: schema: cache first is_deleted virtual column index .. schema: cache first is_deleted virtual column index This

[kudu-CR] KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan

2019-06-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13538 ) Change subject: KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan .. Patch Set 9: Code-Review+2 (1 comment)

[kudu-CR] [hms] Adjust storage handler package

2019-06-07 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13540 ) Change subject: [hms] Adjust storage handler package .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13540

[kudu-CR] [java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped

2019-06-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13565 ) Change subject: [java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped .. Patch Set 2: (2

[kudu-CR] KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan

2019-06-07 Thread Adar Dembo (Code Review)
Hello Will Berkeley, Mike Percy, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13538 to look at the new patch set (#9). Change subject: KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan

[kudu-CR] KUDU-2841. Expose HMS DB UUID to clients in HiveMetastoreConfig

2019-06-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13556 ) Change subject: KUDU-2841. Expose HMS DB UUID to clients in HiveMetastoreConfig .. Patch Set 1: Code-Review+1 (1 comment)

[kudu-CR] KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan

2019-06-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13538 ) Change subject: KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan .. Patch Set 8: (1 comment)

[kudu-CR] [java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped

2019-06-07 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13565 to look at the new patch set (#2). Change subject: [java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped

[kudu-CR] foo

2019-06-07 Thread Will Berkeley (Code Review)
Will Berkeley has abandoned this change. ( http://gerrit.cloudera.org:8080/13564 ) Change subject: foo .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/13564 To unsubscribe, visit

[kudu-CR] foo

2019-06-07 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13564 Change subject: foo .. foo Change-Id: Icea1d2487210d54485715cdb059e5cd2f41561c2 --- M

[kudu-CR] [java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped

2019-06-07 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13565 Change subject: [java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped .. [java] Add unit

[kudu-CR] [rebalance] Add '--ignored tservers' flag to rebalancer

2019-06-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13539 ) Change subject: [rebalance] Add '--ignored_tservers' flag to rebalancer .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] [java] Favor column ids over column names in scan tokens

2019-06-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13562 ) Change subject: [java] Favor column ids over column names in scan tokens .. Patch Set 2: (1 comment)

[kudu-CR] [java] Favor column ids over column names in scan tokens

2019-06-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13562 ) Change subject: [java] Favor column ids over column names in scan tokens .. Patch Set 2: (1 comment)

[kudu-CR] [java] Favor column ids over column names in scan tokens

2019-06-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13562 ) Change subject: [java] Favor column ids over column names in scan tokens .. Patch Set 2: Code-Review+1 I'm OK with this approach because

[kudu-CR] [c++] Support table rename between scan token creation and rehydration

2019-06-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13521 ) Change subject: [c++] Support table rename between scan token creation and rehydration .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] [rebalance] Add '--ignored tservers' flag to rebalancer

2019-06-07 Thread Yifan Zhang (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13539 to look at the new patch set (#4). Change subject: [rebalance] Add '--ignored_tservers' flag to rebalancer

[kudu-CR] [hms] Adjust storage handler package

2019-06-07 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13540 to look at the new patch set (#6). Change subject: [hms] Adjust storage handler package .. [hms] Adjust

[kudu-CR] [backup] Make KuduBackupCLI executable

2019-06-07 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13551 ) Change subject: [backup] Make KuduBackupCLI executable .. [backup] Make KuduBackupCLI executable This patch changes the

[kudu-CR] [backup] Make KuduBackupCLI executable

2019-06-07 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13551 ) Change subject: [backup] Make KuduBackupCLI executable .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan

2019-06-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13538 ) Change subject: KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan .. Patch Set 8: (1 comment)

[kudu-CR] KUDU-2809 (5/6): add diff scan support to fuzz-itest

2019-06-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13537 ) Change subject: KUDU-2809 (5/6): add diff scan support to fuzz-itest .. Patch Set 8: Code-Review+2 (1 comment)

[kudu-CR] [java] Favor column ids over column names in scan tokens

2019-06-07 Thread Will Berkeley (Code Review)
Hello Mike Percy, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13562 to look at the new patch set (#2). Change subject: [java] Favor column ids over column names in scan tokens

[kudu-CR] [java] Favor column ids over column names in scan tokens

2019-06-07 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13562 ) Change subject: [java] Favor column ids over column names in scan tokens .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-2809 (4/6): skip unobservable rows when iterating a DRS

2019-06-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13536 ) Change subject: KUDU-2809 (4/6): skip unobservable rows when iterating a DRS .. Patch Set 7: Code-Review+2 -- To view, visit

[kudu-CR] [java] Favor column ids over column names in scan tokens

2019-06-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13562 ) Change subject: [java] Favor column ids over column names in scan tokens .. Patch Set 1: (2 comments)

[kudu-CR] [backup] Fix backup CLI dependencies

2019-06-07 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13547 ) Change subject: [backup] Fix backup CLI dependencies .. [backup] Fix backup CLI dependencies This patch fixes the backup

[kudu-CR] [c++] Support table rename between scan token creation and rehydration

2019-06-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13521 ) Change subject: [c++] Support table rename between scan token creation and rehydration .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2809 (4/6): skip unobservable rows when iterating a DRS

2019-06-07 Thread Adar Dembo (Code Review)
Hello Will Berkeley, Mike Percy, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13536 to look at the new patch set (#7). Change subject: KUDU-2809 (4/6): skip unobservable rows when iterating a DRS

[kudu-CR] KUDU-2809 (5/6): add diff scan support to fuzz-itest

2019-06-07 Thread Adar Dembo (Code Review)
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13537 to look at the new patch set (#8). Change subject: KUDU-2809 (5/6): add diff scan support to fuzz-itest

[kudu-CR] KUDU-2809 (5/6): add diff scan support to fuzz-itest

2019-06-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13537 ) Change subject: KUDU-2809 (5/6): add diff scan support to fuzz-itest .. Patch Set 8: (3 comments)

[kudu-CR] KUDU-2809 (4/6): skip unobservable rows when iterating a DRS

2019-06-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13536 ) Change subject: KUDU-2809 (4/6): skip unobservable rows when iterating a DRS .. Patch Set 6: (1 comment)

[kudu-CR] KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan

2019-06-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13538 ) Change subject: KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan .. Patch Set 7: (1 comment)

[kudu-CR] Support SPNEGO for web server

2019-06-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13341 ) Change subject: Support SPNEGO for web server .. Support SPNEGO for web server SPNEGO is a protocol for securing HTTP requests

[kudu-CR] [c++] Support table rename between scan token creation and rehydration

2019-06-07 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13521 ) Change subject: [c++] Support table rename between scan token creation and rehydration .. Patch Set 4: (7 comments)

[kudu-CR] [java] Support table rename between scan token creation and rehydration

2019-06-07 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13518 ) Change subject: [java] Support table rename between scan token creation and rehydration .. [java] Support table rename

[kudu-CR] [c++] Support table rename between scan token creation and rehydration

2019-06-07 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13521 to look at the new patch set (#4). Change subject: [c++] Support table rename between scan token creation and rehydration

[kudu-CR] [c++] Support table rename between scan token creation and rehydration

2019-06-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13521 ) Change subject: [c++] Support table rename between scan token creation and rehydration .. Patch Set 3: (5 comments)

[kudu-CR] KUDU-2841. Expose HMS DB UUID to clients in HiveMetastoreConfig

2019-06-07 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13556 ) Change subject: KUDU-2841. Expose HMS DB UUID to clients in HiveMetastoreConfig .. Patch Set 1: (1 comment) LGTM, just one minor nit.

[kudu-CR] KUDU-2841. Expose HMS DB UUID to clients in HiveMetastoreConfig

2019-06-07 Thread Hao Hao (Code Review)
Hao Hao has removed Anonymous Coward (314) from this change. ( http://gerrit.cloudera.org:8080/13556 ) Change subject: KUDU-2841. Expose HMS DB UUID to clients in HiveMetastoreConfig .. Removed reviewer null. -- To view,

[kudu-CR] [java] Support table rename between scan token creation and rehydration

2019-06-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13518 ) Change subject: [java] Support table rename between scan token creation and rehydration .. Patch Set 2: Code-Review+2 -- To view,

[kudu-CR] sentry: avoid authorizing every table in ListTables

2019-06-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13549 ) Change subject: sentry: avoid authorizing every table in ListTables .. Patch Set 3: (1 comment)

[kudu-CR] Support SPNEGO for web server

2019-06-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13341 ) Change subject: Support SPNEGO for web server .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13341 To

[kudu-CR] [hms] Adjust storage handler package

2019-06-07 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13540 to look at the new patch set (#5). Change subject: [hms] Adjust storage handler package .. [hms] Adjust

[kudu-CR] [hms] Adjust storage handler package

2019-06-07 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13540 ) Change subject: [hms] Adjust storage handler package .. Patch Set 4: (2 comments)

[kudu-CR] [hms] Adjust storage handler package

2019-06-07 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13540 ) Change subject: [hms] Adjust storage handler package .. Patch Set 4: Code-Review+1 (3 comments) LGTM, just nits.

[kudu-CR] [hms] Adjust storage handler package

2019-06-07 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13540 to look at the new patch set (#4). Change subject: [hms] Adjust storage handler package .. [hms] Adjust

[kudu-CR] Support SPNEGO for web server

2019-06-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13341 ) Change subject: Support SPNEGO for web server .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/13341

[kudu-CR] [java] Favor column ids over column names in scan tokens

2019-06-07 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13562 Change subject: [java] Favor column ids over column names in scan tokens .. [java] Favor column ids over column names in scan tokens

[kudu-CR] [hms] Adjust storage handler package

2019-06-07 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13540 to look at the new patch set (#3). Change subject: [hms] Adjust storage handler package .. [hms] Adjust

[kudu-CR] KUDU-2809 (1/6): temporarily disable TestKuduScanner.testDiffScan

2019-06-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13533 ) Change subject: KUDU-2809 (1/6): temporarily disable TestKuduScanner.testDiffScan .. Patch Set 6: Verified+1 Overriding Jenkins,

[kudu-CR] KUDU-2809 (1/6): temporarily disable TestKuduScanner.testDiffScan

2019-06-07 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13533 ) Change subject: KUDU-2809 (1/6): temporarily disable TestKuduScanner.testDiffScan .. Removed reviewer Kudu Jenkins with the

[kudu-CR] sentry: avoid authorizing every table in ListTables

2019-06-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13549 ) Change subject: sentry: avoid authorizing every table in ListTables .. Patch Set 3: (1 comment)

[kudu-CR] [hms] Adjust storage handler package

2019-06-07 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13540 to look at the new patch set (#2). Change subject: [hms] Adjust storage handler package .. [hms] Adjust

[kudu-CR] [backup] Fix backup CLI dependencies

2019-06-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13547 ) Change subject: [backup] Fix backup CLI dependencies .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [backup] Fix backup CLI dependencies

2019-06-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13547 ) Change subject: [backup] Fix backup CLI dependencies .. Patch Set 2: (1 comment)

[kudu-CR] [java] Support table rename between scan token creation and rehydration

2019-06-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13518 ) Change subject: [java] Support table rename between scan token creation and rehydration .. Patch Set 2: Code-Review+2 lgtm, might want

[kudu-CR] [c++] Support table rename between scan token creation and rehydration

2019-06-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13521 ) Change subject: [c++] Support table rename between scan token creation and rehydration .. Patch Set 3: Code-Review+2 lgtm, might want

[kudu-CR] Support SPNEGO for web server

2019-06-07 Thread Todd Lipcon (Code Review)
Hello Thomas Marshall, Tidy Bot, Lars Volker, Alexey Serbin, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13341 to look at the new patch set (#6). Change subject: Support SPNEGO for web server

[kudu-CR] [java] Support table rename between scan token creation and rehydration

2019-06-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13518 ) Change subject: [java] Support table rename between scan token creation and rehydration .. Patch Set 2: Code-Review+1 -- To view,

[kudu-CR] KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan

2019-06-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13538 ) Change subject: KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan .. Patch Set 7: (1 comment) Are

[kudu-CR] KUDU-2809 (3/6): C++ private API for diff scans

2019-06-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13535 ) Change subject: KUDU-2809 (3/6): C++ private API for diff scans .. Patch Set 6: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2809 (2/6): skip unobservable rows when iterating an MRS

2019-06-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13534 ) Change subject: KUDU-2809 (2/6): skip unobservable rows when iterating an MRS .. Patch Set 6: Code-Review+2 (1 comment)

[kudu-CR] KUDU-2809 (1/6): temporarily disable TestKuduScanner.testDiffScan

2019-06-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13533 ) Change subject: KUDU-2809 (1/6): temporarily disable TestKuduScanner.testDiffScan .. Patch Set 6: Code-Review+2 -- To view, visit

[kudu-CR] schema: cache first is deleted virtual column index

2019-06-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13554 ) Change subject: schema: cache first is_deleted virtual column index .. Patch Set 4: Code-Review+2 lgtm -- To view, visit

[kudu-CR] KUDU-2809 (5/6): add diff scan support to fuzz-itest

2019-06-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13537 ) Change subject: KUDU-2809 (5/6): add diff scan support to fuzz-itest .. Patch Set 7: Code-Review+1 (3 comments)

[kudu-CR] [java] Support table rename between scan token creation and rehydration

2019-06-07 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13518 ) Change subject: [java] Support table rename between scan token creation and rehydration .. Patch Set 2: (1 comment)

[kudu-CR] [c++] Support table rename between scan token creation and rehydration

2019-06-07 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13521 ) Change subject: [c++] Support table rename between scan token creation and rehydration .. Patch Set 2: (5 comments)

[kudu-CR] [c++] Support table rename between scan token creation and rehydration

2019-06-07 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13521 to look at the new patch set (#3). Change subject: [c++] Support table rename between scan token creation and rehydration

[kudu-CR] [java] Support table rename between scan token creation and rehydration

2019-06-07 Thread Will Berkeley (Code Review)
Hello Mike Percy, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13518 to look at the new patch set (#2). Change subject: [java] Support table rename between scan token creation and rehydration

[kudu-CR] KUDU-2809 (4/6): skip unobservable rows when iterating a DRS

2019-06-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13536 ) Change subject: KUDU-2809 (4/6): skip unobservable rows when iterating a DRS .. Patch Set 6: (2 comments)

[kudu-CR] schema: cache first is deleted virtual column index

2019-06-07 Thread Adar Dembo (Code Review)
Hello Will Berkeley, Mike Percy, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13554 to look at the new patch set (#4). Change subject: schema: cache first is_deleted virtual column index

[kudu-CR] [java] small fixes for diff scan setup logic

2019-06-07 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13553 ) Change subject: [java] small fixes for diff scan setup logic .. Removed reviewer Kudu Jenkins with the following votes: *

[kudu-CR] [java] small fixes for diff scan setup logic

2019-06-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13553 ) Change subject: [java] small fixes for diff scan setup logic .. Patch Set 2: Verified+1 Overriding Jenkins, one dist-test host's NTP was

[kudu-CR] [java] small fixes for diff scan setup logic

2019-06-07 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13553 ) Change subject: [java] small fixes for diff scan setup logic .. [java] small fixes for diff scan setup logic Change-Id:

[kudu-CR] [rebalance] Add '--ignored tservers' flag to rebalancer

2019-06-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13539 ) Change subject: [rebalance] Add '--ignored_tservers' flag to rebalancer .. Patch Set 3: Looks good but there was an IWYU failure to

[kudu-CR] Add seek before mode for CBTree to accelerate CheckRowDeleted in dms.

2019-06-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13516 ) Change subject: Add seek before mode for CBTree to accelerate CheckRowDeleted in dms. .. Add seek before mode for CBTree to

[kudu-CR] Add seek before mode for CBTree to accelerate CheckRowDeleted in dms.

2019-06-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13516 ) Change subject: Add seek before mode for CBTree to accelerate CheckRowDeleted in dms. .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] [rebalance] Add '--ignored tservers' flag to rebalancer

2019-06-07 Thread Yifan Zhang (Code Review)
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13539 ) Change subject: [rebalance] Add '--ignored_tservers' flag to rebalancer .. Patch Set 3: (7 comments)

[kudu-CR] [rebalance] Add '--ignored tservers' flag to rebalancer

2019-06-07 Thread Yifan Zhang (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13539 to look at the new patch set (#3). Change subject: [rebalance] Add '--ignored_tservers' flag to rebalancer

[kudu-CR] KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan

2019-06-07 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13538 ) Change subject: KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan .. Patch Set 6: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2809 (3/6): C++ private API for diff scans

2019-06-07 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13535 ) Change subject: KUDU-2809 (3/6): C++ private API for diff scans .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2809 (1/6): temporarily disable TestKuduScanner.testDiffScan

2019-06-07 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13533 ) Change subject: KUDU-2809 (1/6): temporarily disable TestKuduScanner.testDiffScan .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] schema: cache first is deleted virtual column index

2019-06-07 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13554 ) Change subject: schema: cache first is_deleted virtual column index .. Patch Set 3: Code-Review+1 Looks like there is an ASAN issue

[kudu-CR] [rebalance] Add '--ignored tservers' flag to rebalancer

2019-06-07 Thread Yifan Zhang (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13539 to look at the new patch set (#2). Change subject: [rebalance] Add '--ignored_tservers' flag to rebalancer

  1   2   >