[kudu-CR] KUDU-2192: Enable TCP keepalive for all outbound connections

2019-06-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13702 ) Change subject: KUDU-2192: Enable TCP keepalive for all outbound connections .. Patch Set 4: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-25 Thread helifu (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13426 to look at the new patch set (#18). Change subject: KUDU-2797: the master aggregates tablet statistics

[kudu-CR](branch-1.10.x) thirdparty: fix build-if-necessary in tarballs pt 2

2019-06-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13732 ) Change subject: thirdparty: fix build-if-necessary in tarballs pt 2 .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] Modify table scan tool to collect and surface errors instead of crashing

2019-06-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13733 ) Change subject: Modify table scan tool to collect and surface errors instead of crashing .. Patch Set 2: (11 comments) Looks pretty

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-25 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet statistics .. Patch Set 17: (3 comments)

[kudu-CR] Modify table scan tool to collect and surface errors instead of crashing

2019-06-25 Thread Hannah Nguyen (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13733 to look at the new patch set (#2). Change subject: Modify table scan tool to collect and surface errors instead of crashing

[kudu-CR] Modify table scan tool to collect and surface errors instead of crashing.

2019-06-25 Thread Anonymous Coward (Code Review)
hannahvnguye...@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13733 Change subject: Modify table scan tool to collect and surface errors instead of crashing. .. Modify table scan tool to

[kudu-CR](branch-1.10.x) thirdparty: fix build-if-necessary in tarballs pt 2

2019-06-25 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13732 Change subject: thirdparty: fix build-if-necessary in tarballs pt 2 .. thirdparty: fix build-if-necessary in tarballs pt 2 This is a

[kudu-CR] thirdparty: fix build-if-necessary in tarballs pt 2

2019-06-25 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13729 ) Change subject: thirdparty: fix build-if-necessary in tarballs pt 2 .. thirdparty: fix build-if-necessary in tarballs pt 2 This

[kudu-CR] thirdparty: fix build-if-necessary in tarballs pt 2

2019-06-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13729 ) Change subject: thirdparty: fix build-if-necessary in tarballs pt 2 .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] webserver: update to latest squeasel build

2019-06-25 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13728 ) Change subject: webserver: update to latest squeasel build .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] thirdparty: fix build-if-necessary in tarballs pt 2

2019-06-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13729 ) Change subject: thirdparty: fix build-if-necessary in tarballs pt 2 .. Patch Set 1: -Code-Review Ah nevermind, I was confused because

[kudu-CR] thirdparty: fix build-if-necessary in tarballs pt 2

2019-06-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13729 ) Change subject: thirdparty: fix build-if-necessary in tarballs pt 2 .. Patch Set 1: Code-Review-2 Hrm, hang on, I'm looking into this a

[kudu-CR] thirdparty: fix build-if-necessary in tarballs pt 2

2019-06-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13729 ) Change subject: thirdparty: fix build-if-necessary in tarballs pt 2 .. Patch Set 1: Code-Review+2 Woops, sorry! -- To view, visit

[kudu-CR] thirdparty: fix build-if-necessary in tarballs pt 2

2019-06-25 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Grant Henke, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13729 to review the following change. Change subject: thirdparty: fix build-if-necessary in tarballs pt 2

[kudu-CR] webserver: update to latest squeasel build

2019-06-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13728 ) Change subject: webserver: update to latest squeasel build .. Patch Set 1: Code-Review+1 LGTM, but it seems LSAN is not happy and

[kudu-CR] KUDU-2192: Enable TCP keepalive for all outbound connections

2019-06-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13702 ) Change subject: KUDU-2192: Enable TCP keepalive for all outbound connections .. Patch Set 4: (5 comments) I tested with this patch with

[kudu-CR] webserver: update to latest squeasel build

2019-06-25 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13728 to review the following change. Change subject: webserver: update to latest squeasel build .. webserver: update to

[kudu-CR] KUDU-2192: Enable TCP keepalive for all outbound connections

2019-06-25 Thread Michael Ho (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13702 to look at the new patch set (#4). Change subject: KUDU-2192: Enable TCP keepalive for all outbound connections

[kudu-CR] KUDU-2483 (part 1/3) Add bloom filter predicate for Java API

2019-06-25 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13703 ) Change subject: KUDU-2483 (part 1/3) Add bloom filter predicate for Java API .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet statistics .. Patch Set 17: (3 comments) Thanks for making the change!

[kudu-CR](gh-pages) [site] Adjust social media entries

2019-06-25 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13719 ) Change subject: [site] Adjust social media entries .. [site] Adjust social media entries This patch adds a link for Reddit to

[kudu-CR] KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock

2019-06-25 Thread ZhangYao (Code Review)
ZhangYao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13721 Change subject: KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock .. KUDU-2847: Optimize iteration over selection

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-25 Thread helifu (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13426 to look at the new patch set (#17). Change subject: KUDU-2797: the master aggregates tablet statistics

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-25 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet statistics .. Patch Set 16: (1 comment)

[kudu-CR] [docs] Add docs for extra configuration properties

2019-06-25 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13704 ) Change subject: [docs] Add docs for extra configuration properties .. [docs] Add docs for extra configuration properties

[kudu-CR] KUDU-2483 (part 1/3) Add bloom filter predicate for Java API

2019-06-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13703 ) Change subject: KUDU-2483 (part 1/3) Add bloom filter predicate for Java API .. Patch Set 1: (2 comments)