[kudu-CR] KUDU-2192: Enable TCP keepalive for all outbound connections

2019-06-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13702 ) Change subject: KUDU-2192: Enable TCP keepalive for all outbound connections .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] webserver: update to latest squeasel build

2019-06-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13728 ) Change subject: webserver: update to latest squeasel build .. Patch Set 1: fixed in this upstream PR:

[kudu-CR] [docs] Add new Docker based quickstart page

2019-06-26 Thread Grant Henke (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Greg Solovyev, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13747 to look at the new patch set (#2). Change subject: [docs] Add new Docker based quickstart page

[kudu-CR](branch-1.10.x) [tablet] reinforce the CountLiveRows API

2019-06-26 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13741 ) Change subject: [tablet] reinforce the CountLiveRows API .. [tablet] reinforce the CountLiveRows API In the recent patch 13426,

[kudu-CR] [docs] Add new Docker based quickstart page

2019-06-26 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13747 Change subject: [docs] Add new Docker based quickstart page .. [docs] Add new Docker based quickstart page This patch adds back the

[kudu-CR] KUDU-2851: modify table scan and copy tools to surface errors

2019-06-26 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13733 ) Change subject: KUDU-2851: modify table scan and copy tools to surface errors .. Patch Set 8: -Code-Review (1 comment)

[kudu-CR] KUDU-2851: modify table scan and copy tools to surface errors

2019-06-26 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13733 ) Change subject: KUDU-2851: modify table scan and copy tools to surface errors .. Patch Set 8: Code-Review+2 -- To view, visit

[kudu-CR] [loadgen] don't report per-row timing if errors happened

2019-06-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13742 ) Change subject: [loadgen] don't report per-row timing if errors happened .. Patch Set 2: Verified+1 unrelated flake in

[kudu-CR] [loadgen] don't report per-row timing if errors happened

2019-06-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13742 ) Change subject: [loadgen] don't report per-row timing if errors happened .. Removed reviewer Kudu Jenkins with the following

[kudu-CR] [loadgen] don't report per-row timing if errors happened

2019-06-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13742 ) Change subject: [loadgen] don't report per-row timing if errors happened .. Patch Set 2: > Thanks for updating that, Alexey! Thank

[kudu-CR] [loadgen] don't report per-row timing if errors happened

2019-06-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13742 ) Change subject: [loadgen] don't report per-row timing if errors happened .. [loadgen] don't report per-row timing if errors

[kudu-CR] KUDU-2851: modify table scan and copy tools to surface errors

2019-06-26 Thread Hannah Nguyen (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, helifu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13733 to look at the new patch set (#8). Change subject: KUDU-2851: modify table scan and copy tools to surface errors

[kudu-CR] KUDU-2851: modify table scan and copy tools to surface errors

2019-06-26 Thread Hannah Nguyen (Code Review)
Hannah Nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13733 ) Change subject: KUDU-2851: modify table scan and copy tools to surface errors .. Patch Set 7: (1 comment)

[kudu-CR] KUDU-2851: modify table scan and copy tools to surface errors

2019-06-26 Thread Hannah Nguyen (Code Review)
Hannah Nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13733 ) Change subject: KUDU-2851: modify table scan and copy tools to surface errors .. Patch Set 7: (3 comments)

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-26 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet statistics .. Patch Set 19: Verified+1 The failed pre-commit looks like an

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-26 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: KUDU-2797: the master aggregates tablet statistics .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13426 To

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-26 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet statistics .. Patch Set 19: Code-Review+1 (1 comment)

[kudu-CR] [loadgen] don't report per-row timing if errors happened

2019-06-26 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13742 ) Change subject: [loadgen] don't report per-row timing if errors happened .. Patch Set 2: Code-Review+2 Thanks for updating that,

[kudu-CR] KUDU-2851: modify table scan and copy tools to surface errors

2019-06-26 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13733 ) Change subject: KUDU-2851: modify table scan and copy tools to surface errors .. Patch Set 7: (1 comment)

[kudu-CR] KUDU-2851: modify table scan and copy tools to surface errors

2019-06-26 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13733 ) Change subject: KUDU-2851: modify table scan and copy tools to surface errors .. Patch Set 7: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2851: modify table scan and copy tools to surface errors

2019-06-26 Thread Hannah Nguyen (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13733 to look at the new patch set (#7). Change subject: KUDU-2851: modify table scan and copy tools to surface errors

[kudu-CR] KUDU-2823 Place tablet replicas based on deminsion

2019-06-26 Thread Yao Xu (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13632 to look at the new patch set (#10). Change subject: KUDU-2823 Place tablet replicas based on deminsion

[kudu-CR] KUDU-2851: modify table scan and copy tools to surface errors

2019-06-26 Thread Hannah Nguyen (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13733 to look at the new patch set (#6). Change subject: KUDU-2851: modify table scan and copy tools to surface errors

[kudu-CR] KUDU-2851: modify table scan and copy tools to surface errors

2019-06-26 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13733 ) Change subject: KUDU-2851: modify table scan and copy tools to surface errors .. Patch Set 5: Seems like there's a merge conflict with

[kudu-CR] KUDU-2851: modify table scan and copy tools to surface errors

2019-06-26 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13733 ) Change subject: KUDU-2851: modify table scan and copy tools to surface errors .. Patch Set 5: Code-Review+2 (2 comments)

[kudu-CR] KUDU-2851: modify table scan and copy tools to surface errors

2019-06-26 Thread Hannah Nguyen (Code Review)
Hannah Nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13733 ) Change subject: KUDU-2851: modify table scan and copy tools to surface errors .. Patch Set 5: (2 comments)

[kudu-CR] [loadgen] don't report per-row timing if errors happened

2019-06-26 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13742 to look at the new patch set (#2). Change subject: [loadgen] don't report per-row timing if errors happened

[kudu-CR] KUDU-2851: modify table scan and copy tools to surface errors

2019-06-26 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13733 ) Change subject: KUDU-2851: modify table scan and copy tools to surface errors .. Patch Set 5: Code-Review+1 (2 comments)

[kudu-CR] KUDU-2851: modify table scan and copy tools to surface errors

2019-06-26 Thread Hannah Nguyen (Code Review)
Hannah Nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13733 ) Change subject: KUDU-2851: modify table scan and copy tools to surface errors .. Patch Set 5: (4 comments)

[kudu-CR] KUDU-2851: modify table scan and copy tools to surface errors

2019-06-26 Thread Hannah Nguyen (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13733 to look at the new patch set (#5). Change subject: KUDU-2851: modify table scan and copy tools to surface errors

[kudu-CR] KUDU-2867. Optimize delta timestamp decoding

2019-06-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13667 ) Change subject: KUDU-2867. Optimize delta timestamp decoding .. KUDU-2867. Optimize delta timestamp decoding When using hybrid

[kudu-CR] [loadgen] don't report per-row timing if errors happened

2019-06-26 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13742 ) Change subject: [loadgen] don't report per-row timing if errors happened .. Patch Set 1: Code-Review+2 I was confused at first about

[kudu-CR] KUDU-2851: modify table scan tool to surface errors instead of crashing

2019-06-26 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13733 ) Change subject: KUDU-2851: modify table scan tool to surface errors instead of crashing .. Patch Set 4: (4 comments)

[kudu-CR] KUDU-2851: modify table scan tool to surface errors instead of crashing

2019-06-26 Thread Hannah Nguyen (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13733 to look at the new patch set (#4). Change subject: KUDU-2851: modify table scan tool to surface errors instead of crashing

[kudu-CR] [loadgen] don't report per-row timing if errors happened

2019-06-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13742 Change subject: [loadgen] don't report per-row timing if errors happened .. [loadgen] don't report per-row timing if errors happened

[kudu-CR] KUDU-2867. Optimize delta timestamp decoding

2019-06-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13667 ) Change subject: KUDU-2867. Optimize delta timestamp decoding .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2851: modify table scan tool to surface errors instead of crashing

2019-06-26 Thread Hannah Nguyen (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13733 to look at the new patch set (#3). Change subject: KUDU-2851: modify table scan tool to surface errors instead of crashing

[kudu-CR](branch-1.10.x) [tablet] reinforce the CountLiveRows API

2019-06-26 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13741 ) Change subject: [tablet] reinforce the CountLiveRows API .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [tablet] reinforce the CountLiveRows API

2019-06-26 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13734 ) Change subject: [tablet] reinforce the CountLiveRows API .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.10.x) [tablet] reinforce the CountLiveRows API

2019-06-26 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13741 Change subject: [tablet] reinforce the CountLiveRows API .. [tablet] reinforce the CountLiveRows API In the recent patch 13426, I found

[kudu-CR] [tablet] reinforce the CountLiveRows API

2019-06-26 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13734 ) Change subject: [tablet] reinforce the CountLiveRows API .. [tablet] reinforce the CountLiveRows API In the recent patch 13426,

[kudu-CR] [tablet] reinforce the CountLiveRows API

2019-06-26 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13734 ) Change subject: [tablet] reinforce the CountLiveRows API .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [tablet] reinforce the CountLiveRows API

2019-06-26 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13734 ) Change subject: [tablet] reinforce the CountLiveRows API .. Patch Set 1: > Patch Set 1: > > (2 comments) That said, I spoke with Grant

[kudu-CR](branch-1.10.x) thirdparty: fix build-if-necessary in tarballs pt 2

2019-06-26 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13732 ) Change subject: thirdparty: fix build-if-necessary in tarballs pt 2 .. thirdparty: fix build-if-necessary in tarballs pt 2 This

[kudu-CR] [tablet] reinforce the CountLiveRows API

2019-06-26 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13734 ) Change subject: [tablet] reinforce the CountLiveRows API .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock

2019-06-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13721 ) Change subject: KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock .. Patch Set 1: I chatted with Zhang Yao last

[kudu-CR] KUDU-2823 Place tablet replicas based on deminsion

2019-06-26 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13632 ) Change subject: KUDU-2823 Place tablet replicas based on deminsion .. Patch Set 9: (10 comments) I refactored this patch to make it more

[kudu-CR] KUDU-2823 Place tablet replicas based on deminsion

2019-06-26 Thread Yao Xu (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13632 to look at the new patch set (#9). Change subject: KUDU-2823 Place tablet replicas based on deminsion

[kudu-CR] KUDU-2823 Place tablet replicas based on deminsion

2019-06-26 Thread Yao Xu (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13632 to look at the new patch set (#8). Change subject: KUDU-2823 Place tablet replicas based on deminsion

[kudu-CR] [tablet] reinforce the CountLiveRows API

2019-06-26 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13734 Change subject: [tablet] reinforce the CountLiveRows API .. [tablet] reinforce the CountLiveRows API In the recent patch 13426, I found that

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-26 Thread helifu (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13426 to look at the new patch set (#19). Change subject: KUDU-2797: the master aggregates tablet statistics