[kudu-CR] KUDU-2823 Place tablet replicas based on dimension

2019-07-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13632 ) Change subject: KUDU-2823 Place tablet replicas based on dimension .. Patch Set 17: (1 comment)

[kudu-CR] KUDU-2823 Place tablet replicas based on dimension

2019-07-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13632 ) Change subject: KUDU-2823 Place tablet replicas based on dimension .. Patch Set 17: Code-Review+1 OK sure. I think Alexey should take

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-07-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13580 ) Change subject: [metrics] Merge metrics by the same attribute .. Patch Set 6: (5 comments)

[kudu-CR](branch-1.10.x) Autogenerate the release index.md file

2019-07-11 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: Autogenerate the release index.md file .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13847 To unsubscribe, visit

[kudu-CR] [docs] Fix quickstart IP one liner

2019-07-11 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: [docs] Fix quickstart IP one liner .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13848 To unsubscribe, visit

[kudu-CR] [docs] Fix quickstart IP one liner

2019-07-11 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13848 ) Change subject: [docs] Fix quickstart IP one liner .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13848

[kudu-CR](branch-1.10.x) Autogenerate the release index.md file

2019-07-11 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13847 ) Change subject: Autogenerate the release index.md file .. Patch Set 1: Verified+1 -- To view, visit

[kudu-CR] [docs] Fix quickstart IP one liner

2019-07-11 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13848 Change subject: [docs] Fix quickstart IP one liner .. [docs] Fix quickstart IP one liner It was reported that on Linux an extra

[kudu-CR](branch-1.10.x) Autogenerate the release index.md file

2019-07-11 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13847 Change subject: Autogenerate the release index.md file .. Autogenerate the release index.md file When building the docs for a release,

[kudu-CR] Autogenerate the release index.md file

2019-07-11 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13844 ) Change subject: Autogenerate the release index.md file .. Autogenerate the release index.md file When building the docs for a

[kudu-CR] Autogenerate the release index.md file

2019-07-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13844 ) Change subject: Autogenerate the release index.md file .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] Autogenerate the release index.md file

2019-07-11 Thread Grant Henke (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13844 to look at the new patch set (#2). Change subject: Autogenerate the release index.md file

[kudu-CR] Autogenerate the release index.md file

2019-07-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13844 ) Change subject: Autogenerate the release index.md file .. Patch Set 1: (2 comments)

[kudu-CR] Autogenerate the release index.md file

2019-07-11 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13844 ) Change subject: Autogenerate the release index.md file .. Patch Set 1: (2 comments)

[kudu-CR] Autogenerate the release index.md file

2019-07-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13844 ) Change subject: Autogenerate the release index.md file .. Patch Set 1: (2 comments)

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-07-11 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13580 ) Change subject: [metrics] Merge metrics by the same attribute .. Patch Set 6: (37 comments)

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-07-11 Thread Yingchun Lai (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13580 to look at the new patch set (#6). Change subject: [metrics] Merge metrics by the same attribute

[kudu-CR] Separate benchmark to single test

2019-07-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13832 ) Change subject: Separate benchmark to single test .. Separate benchmark to single test Separate the total benchmark to single

[kudu-CR] Separate benchmark to single test

2019-07-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13832 ) Change subject: Separate benchmark to single test .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2722 (table level): Support new 'write enabled' table extra config

2019-07-11 Thread XiaokaiWang (Code Review)
XiaokaiWang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13796 ) Change subject: KUDU-2722 (table level): Support new 'write_enabled' table extra config .. Patch Set 8: > I will add some context to

[kudu-CR] KUDU-2722 (table level): Support new 'write enabled' table extra config

2019-07-11 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13796 ) Change subject: KUDU-2722 (table level): Support new 'write_enabled' table extra config .. Patch Set 8: I will add some context to

[kudu-CR] KUDU-2689: Made PartialRow setters use a fluent-style.

2019-07-11 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12949 ) Change subject: KUDU-2689: Made PartialRow setters use a fluent-style. .. Patch Set 5: This change does break binary compatibility. We

[kudu-CR] [docs] update the upgrade documentation

2019-07-11 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13820 ) Change subject: [docs] update the upgrade documentation .. Patch Set 3: (5 comments) I added a few comments. I would also be

[kudu-CR] KUDU-2823 Place tablet replicas based on dimension

2019-07-11 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13632 ) Change subject: KUDU-2823 Place tablet replicas based on dimension .. Patch Set 17: (1 comment)

[kudu-CR] KUDU-2722 (table level): Support new 'write enabled' table extra config

2019-07-11 Thread XiaokaiWang (Code Review)
Hello Tidy Bot, Yingchun Lai, Kudu Jenkins, Yao Xu, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13796 to look at the new patch set (#8). Change subject: KUDU-2722 (table level): Support new 'write_enabled' table extra config

[kudu-CR] KUDU-2823 Place tablet replicas based on dimension

2019-07-11 Thread Yao Xu (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13632 to look at the new patch set (#17). Change subject: KUDU-2823 Place tablet replicas based on dimension

[kudu-CR] KUDU-2722 (table level): Support new 'write enabled' table extra config

2019-07-11 Thread XiaokaiWang (Code Review)
XiaokaiWang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13796 ) Change subject: KUDU-2722 (table level): Support new 'write_enabled' table extra config .. Patch Set 7: (2 comments)

[kudu-CR] Autogenerate the release index.md file

2019-07-11 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13844 Change subject: Autogenerate the release index.md file .. Autogenerate the release index.md file When building the docs for a release,

[kudu-CR] KUDU-2622 Validate read and write default value sizes when deserializing ColumnSchemaPB

2019-07-11 Thread Yao Xu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13842 to look at the new patch set (#2). Change subject: KUDU-2622 Validate read and write default value sizes when deserializing ColumnSchemaPB

[kudu-CR](branch-1.10.x) [doxygen] fix KuduScanTokenBuilder::SetDiffScan (take two)

2019-07-11 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13843 Change subject: [doxygen] fix KuduScanTokenBuilder::SetDiffScan (take two) .. [doxygen] fix KuduScanTokenBuilder::SetDiffScan (take two)

[kudu-CR](branch-1.10.x) Fix KuduScanTokenBuilder::SetDiffScan docs

2019-07-11 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13839 ) Change subject: Fix KuduScanTokenBuilder::SetDiffScan docs .. Fix KuduScanTokenBuilder::SetDiffScan docs It looks like Doxygen

[kudu-CR](branch-1.10.x) [docs] Update the site build to use the release directory

2019-07-11 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13840 ) Change subject: [docs] Update the site build to use the release directory .. [docs] Update the site build to use the release

[kudu-CR] KUDU-2622 Validate read and write default value sizes when deserializing ColumnSchemaPB

2019-07-11 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13842 ) Change subject: KUDU-2622 Validate read and write default value sizes when deserializing ColumnSchemaPB .. Patch Set 1: Emmm, I’m not sure

[kudu-CR] KUDU-2622 Validate read and write default value sizes when deserializing ColumnSchemaPB

2019-07-11 Thread Yao Xu (Code Review)
Yao Xu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13842 Change subject: KUDU-2622 Validate read and write default value sizes when deserializing ColumnSchemaPB .. KUDU-2622 Validate read and write