[kudu-CR] [docs] update the upgrade documentation

2019-07-15 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13820 ) Change subject: [docs] update the upgrade documentation .. Patch Set 5: (2 comments)

[kudu-CR] KUDU-1938 Add CHAR/VARCHAR to C++ client pt 2

2019-07-15 Thread Attila Bukor (Code Review)
Attila Bukor has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13869 Change subject: KUDU-1938 Add CHAR/VARCHAR to C++ client pt 2 .. KUDU-1938 Add CHAR/VARCHAR to C++ client pt 2 Adds support for CHAR

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-07-15 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13760 to look at the new patch set (#18). Change subject: KUDU-1938 Add support for CHAR/VARCHAR

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-07-15 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 .. Patch Set 18: (11 comments)

[kudu-CR] benchmarks.sh: fix wire protocol-test runs

2019-07-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13867 ) Change subject: benchmarks.sh: fix wire_protocol-test runs .. benchmarks.sh: fix wire_protocol-test runs Change-Id:

[kudu-CR] benchmarks.sh: fix wire protocol-test runs

2019-07-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13867 ) Change subject: benchmarks.sh: fix wire_protocol-test runs .. Patch Set 1: Code-Review+2 Thank you for the fix! -- To view, visit

[kudu-CR] [docs] update the upgrade documentation

2019-07-15 Thread helifu (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, Priyanka Chheda, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13820 to look at the new patch set (#5). Change subject: [docs] update the upgrade documentation

[kudu-CR] [docs] update the upgrade documentation

2019-07-15 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13820 ) Change subject: [docs] update the upgrade documentation .. Patch Set 4: (6 comments)

[kudu-CR] benchmarks.sh: fix wire protocol-test runs

2019-07-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13867 ) Change subject: benchmarks.sh: fix wire_protocol-test runs .. Patch Set 1: -Verified Code-Review+2 Oops wrong button -- To view,

[kudu-CR] benchmarks.sh: fix wire protocol-test runs

2019-07-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13867 ) Change subject: benchmarks.sh: fix wire_protocol-test runs .. Patch Set 1: Verified+1 -- To view, visit

[kudu-CR] [docs] update the upgrade documentation

2019-07-15 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13820 ) Change subject: [docs] update the upgrade documentation .. Patch Set 4: (6 comments)

[kudu-CR] KUDU-2823 Place tablet replicas based on dimension

2019-07-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13632 ) Change subject: KUDU-2823 Place tablet replicas based on dimension .. Patch Set 22: Code-Review+2 (1 comment) Looks good to me!

[kudu-CR] KUDU-2823 Place tablet replicas based on dimension

2019-07-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13632 ) Change subject: KUDU-2823 Place tablet replicas based on dimension .. KUDU-2823 Place tablet replicas based on dimension When

[kudu-CR] KUDU-2625: Support per-row error check in prepare stage

2019-07-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13864 ) Change subject: KUDU-2625: Support per-row error check in prepare stage .. Patch Set 1: (7 comments)

[kudu-CR] benchmarks.sh: fix wire protocol-test runs

2019-07-15 Thread Adar Dembo (Code Review)
Hello ZhangYao, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13867 to review the following change. Change subject: benchmarks.sh: fix wire_protocol-test runs .. benchmarks.sh: fix

[kudu-CR] [net util] fix comment on maximum PID in 18-bit space

2019-07-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13859 ) Change subject: [net_util] fix comment on maximum PID in 18-bit space .. [net_util] fix comment on maximum PID in 18-bit space

[kudu-CR] [net util] fix comment on maximum PID in 18-bit space

2019-07-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13859 ) Change subject: [net_util] fix comment on maximum PID in 18-bit space .. Patch Set 2: Verified+1 Unrelated flake in

[kudu-CR] [net util] fix comment on maximum PID in 18-bit space

2019-07-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [net_util] fix comment on maximum PID in 18-bit space .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13859 To

[kudu-CR] KUDU-2622 Validate read and write default value sizes when deserializing ColumnSchemaPB

2019-07-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13842 ) Change subject: KUDU-2622 Validate read and write default value sizes when deserializing ColumnSchemaPB .. Patch Set 2: Code-Review+2

[kudu-CR] KUDU-2622 Validate read and write default value sizes when deserializing ColumnSchemaPB

2019-07-15 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13842 ) Change subject: KUDU-2622 Validate read and write default value sizes when deserializing ColumnSchemaPB .. KUDU-2622 Validate

[kudu-CR] KUDU-2635: treat failure to delete failed blocks as OK

2019-07-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13858 ) Change subject: KUDU-2635: treat failure to delete failed blocks as OK .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2823 Place tablet replicas based on dimension

2019-07-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13632 ) Change subject: KUDU-2823 Place tablet replicas based on dimension .. Patch Set 22: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-07-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 .. Patch Set 17: (9 comments)

[kudu-CR] [net util] fix comment on maximum PID in 18-bit space

2019-07-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13859 ) Change subject: [net_util] fix comment on maximum PID in 18-bit space .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2635: treat failure to delete failed blocks as OK

2019-07-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13858 ) Change subject: KUDU-2635: treat failure to delete failed blocks as OK .. Patch Set 2: Code-Review+1 (1 comment) Overall LGTM, just

[kudu-CR] KUDU-2635: treat failure to delete failed blocks as OK

2019-07-15 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13858 ) Change subject: KUDU-2635: treat failure to delete failed blocks as OK .. Patch Set 2: (1 comment)

[kudu-CR] [net util] fix comment on maximum PID in 18-bit space

2019-07-15 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13859 to look at the new patch set (#2). Change subject: [net_util] fix comment on maximum PID in 18-bit space ..

[kudu-CR] KUDU-2635: treat failure to delete failed blocks as OK

2019-07-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13858 ) Change subject: KUDU-2635: treat failure to delete failed blocks as OK .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2635: treat failure to delete failed blocks as OK

2019-07-15 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, helifu, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13858 to look at the new patch set (#2). Change subject: KUDU-2635: treat failure to delete failed blocks as OK

[kudu-CR] KUDU-2635: treat failure to delete failed blocks as OK

2019-07-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13858 ) Change subject: KUDU-2635: treat failure to delete failed blocks as OK .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-2635: treat failure to delete failed blocks as OK

2019-07-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13858 ) Change subject: KUDU-2635: treat failure to delete failed blocks as OK .. Patch Set 1: (1 comment)

[kudu-CR] [maintenance] Add extra config for maintenance manager task priority

2019-07-15 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13659 ) Change subject: [maintenance] Add extra config for maintenance manager task priority .. Patch Set 3: Verified+1 -- To view, visit

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-07-15 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 .. Patch Set 17: (12 comments)

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-07-15 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13760 to look at the new patch set (#17). Change subject: KUDU-1938 Add support for CHAR/VARCHAR

[kudu-CR] [docs] update the upgrade documentation

2019-07-15 Thread helifu (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, Priyanka Chheda, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13820 to look at the new patch set (#4). Change subject: [docs] update the upgrade documentation

[kudu-CR] [docs] update the upgrade documentation

2019-07-15 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13820 ) Change subject: [docs] update the upgrade documentation .. Patch Set 3: (10 comments)

[kudu-CR] KUDU-2625: Support per-row error check in prepare stage

2019-07-15 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13864 Change subject: KUDU-2625: Support per-row error check in prepare stage .. KUDU-2625: Support per-row error check in prepare stage

[kudu-CR] KUDU-2823 Place tablet replicas based on dimension

2019-07-15 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13632 ) Change subject: KUDU-2823 Place tablet replicas based on dimension .. Patch Set 22: (18 comments)

[kudu-CR] KUDU-2823 Place tablet replicas based on dimension

2019-07-15 Thread Yao Xu (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13632 to look at the new patch set (#22). Change subject: KUDU-2823 Place tablet replicas based on dimension

[kudu-CR] KUDU-2823 Place tablet replicas based on dimension

2019-07-15 Thread Yao Xu (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13632 to look at the new patch set (#21). Change subject: KUDU-2823 Place tablet replicas based on dimension

[kudu-CR] [docs] update the upgrade documentation

2019-07-15 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13820 ) Change subject: [docs] update the upgrade documentation .. Patch Set 3: (4 comments)