[kudu-CR] KUDU-2625: Support per-row error check in prepare stage

2019-07-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13864 ) Change subject: KUDU-2625: Support per-row error check in prepare stage .. Patch Set 1: (11 comments)

[kudu-CR] KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock

2019-07-16 Thread ZhangYao (Code Review)
Hello Kudu Jenkins, Yao Xu, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13721 to look at the new patch set (#4). Change subject: KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock

[kudu-CR] KUDU-2882: Increase the timeout value for TestSentryClientMetrics.Basic

2019-07-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13770 ) Change subject: KUDU-2882: Increase the timeout value for TestSentryClientMetrics.Basic .. Patch Set 1: Code-Review+1 (1 comment) In

[kudu-CR] KUDU-2882: Increase the timeout value for TestSentryClientMetrics.Basic

2019-07-16 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: KUDU-2882: Increase the timeout value for TestSentryClientMetrics.Basic .. Removed Code-Review+2 by Andrew Wong -- To view, visit

[kudu-CR] KUDU-2882: Increase the timeout value for TestSentryClientMetrics.Basic

2019-07-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13770 ) Change subject: KUDU-2882: Increase the timeout value for TestSentryClientMetrics.Basic .. Patch Set 1: Code-Review+2 -- To view,

[kudu-CR] [docs] fix typo in ntpq output description

2019-07-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13871 ) Change subject: [docs] fix typo in ntpq output description .. [docs] fix typo in ntpq output description Change-Id:

[kudu-CR] [docs] fix typo in ntpq output description

2019-07-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13871 ) Change subject: [docs] fix typo in ntpq output description .. Patch Set 2: Verified+1 Unrelated failures: * in case of TSAN builds

[kudu-CR] [docs] fix typo in ntpq output description

2019-07-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13871 ) Change subject: [docs] fix typo in ntpq output description .. Removed reviewer Kudu Jenkins with the following votes: *

[kudu-CR] [docs] fix typo in ntpq output description

2019-07-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13871 ) Change subject: [docs] fix typo in ntpq output description .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [docs] fix typo in ntpq output description

2019-07-16 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13871 to look at the new patch set (#2). Change subject: [docs] fix typo in ntpq output description ..

[kudu-CR] [docs] fix typo in ntpq output description

2019-07-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13871 ) Change subject: [docs] fix typo in ntpq output description .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2635: ignore failures to delete orphaned blocks

2019-07-16 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13858 ) Change subject: KUDU-2635: ignore failures to delete orphaned blocks .. KUDU-2635: ignore failures to delete orphaned blocks It

[kudu-CR] KUDU-2635: ignore failures to delete orphaned blocks

2019-07-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13858 ) Change subject: KUDU-2635: ignore failures to delete orphaned blocks .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-2635: ignore failures to delete orphaned blocks

2019-07-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13858 ) Change subject: KUDU-2635: ignore failures to delete orphaned blocks .. Patch Set 4: Code-Review+2 (1 comment)

[kudu-CR] KUDU-2635: ignore failures to delete orphaned blocks

2019-07-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13858 ) Change subject: KUDU-2635: ignore failures to delete orphaned blocks .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-2635: ignore failures to delete orphaned blocks

2019-07-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13858 ) Change subject: KUDU-2635: ignore failures to delete orphaned blocks .. Patch Set 4: (1 comment)

[kudu-CR] [docs] fix typo in ntpq output description

2019-07-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13871 ) Change subject: [docs] fix typo in ntpq output description .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-07-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 .. Patch Set 19: (3 comments) I had some questions about how CHAR padding

[kudu-CR] [docs] fix typo in ntpq output description

2019-07-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13871 Change subject: [docs] fix typo in ntpq output description .. [docs] fix typo in ntpq output description Change-Id:

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-07-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet statistics .. Patch Set 20: (1 comment) Seems like Mike won't be able to get

[kudu-CR] [docs] update the upgrade documentation

2019-07-16 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13820 ) Change subject: [docs] update the upgrade documentation .. [docs] update the upgrade documentation The process of upgrading the

[kudu-CR] [maintenance] Add extra config for maintenance manager task priority

2019-07-16 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13659 ) Change subject: [maintenance] Add extra config for maintenance manager task priority .. [maintenance] Add extra config for

[kudu-CR] KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock

2019-07-16 Thread ZhangYao (Code Review)
ZhangYao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13721 ) Change subject: KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock .. Patch Set 3: > I played a bit with this patch

[kudu-CR] KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock

2019-07-16 Thread ZhangYao (Code Review)
ZhangYao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13721 ) Change subject: KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock .. Patch Set 3: (4 comments)

[kudu-CR] KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock

2019-07-16 Thread ZhangYao (Code Review)
Hello Kudu Jenkins, Yao Xu, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13721 to look at the new patch set (#3). Change subject: KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock

[kudu-CR] [docs] update the upgrade documentation

2019-07-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13820 ) Change subject: [docs] update the upgrade documentation .. Patch Set 6: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2635: ignore failures to delete orphaned blocks

2019-07-16 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, helifu, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13858 to look at the new patch set (#4). Change subject: KUDU-2635: ignore failures to delete orphaned blocks

[kudu-CR] KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock

2019-07-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13721 ) Change subject: KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock .. Patch Set 2: I played a bit with this

[kudu-CR] KUDU-2635: ignore failures to delete orphaned blocks

2019-07-16 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, helifu, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13858 to look at the new patch set (#3). Change subject: KUDU-2635: ignore failures to delete orphaned blocks

[kudu-CR] KUDU-2635: ignore failures to delete orphaned blocks

2019-07-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13858 ) Change subject: KUDU-2635: ignore failures to delete orphaned blocks .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock

2019-07-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13721 ) Change subject: KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock .. Patch Set 2: (3 comments)

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-07-16 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13760 to look at the new patch set (#19). Change subject: KUDU-1938 Add support for CHAR/VARCHAR