[kudu-CR] KUDU-2797 p2: the master aggregates tablet statistics

2019-07-19 Thread helifu (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13426 to look at the new patch set (#24). Change subject: KUDU-2797 p2: the master aggregates tablet statistics

[kudu-CR] test: deflake ksck remote-test TestChecksumSnapshotCurrentTimestamp

2019-07-19 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13887 Change subject: test: deflake ksck_remote-test TestChecksumSnapshotCurrentTimestamp .. test: deflake ksck_remote-test

[kudu-CR] KUDU-2897 Making the -mavx2 flag contingent on the architecture rather than the OS alone

2019-07-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13884 ) Change subject: KUDU-2897 Making the -mavx2 flag contingent on the architecture rather than the OS alone .. KUDU-2897 Making

[kudu-CR] KUDU-2897 Making the -mavx2 flag contingent on the architecture rather than the OS alone

2019-07-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13884 ) Change subject: KUDU-2897 Making the -mavx2 flag contingent on the architecture rather than the OS alone .. Patch Set 2:

[kudu-CR] KUDU-2897 Making the -mavx2 flag contingent on the architecture rather than the OS alone

2019-07-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13884 ) Change subject: KUDU-2897 Making the -mavx2 flag contingent on the architecture rather than the OS alone .. Patch Set 2: Code-Review+2

[kudu-CR] KUDU-2897 Making the -mavx2 flag contingent on the architecture rather than the OS alone

2019-07-19 Thread Ritwik Yadav (Code Review)
Ritwik Yadav has posted comments on this change. ( http://gerrit.cloudera.org:8080/13884 ) Change subject: KUDU-2897 Making the -mavx2 flag contingent on the architecture rather than the OS alone .. Patch Set 2: Code-Review+1

[kudu-CR] KUDU-2897 Making the -mavx2 flag contingent on the architecture rather than the OS alone

2019-07-19 Thread Ritwik Yadav (Code Review)
Ritwik Yadav has removed a vote on this change. Change subject: KUDU-2897 Making the -mavx2 flag contingent on the architecture rather than the OS alone .. Removed Code-Review+1 by Ritwik Yadav -- To view, visit

[kudu-CR] KUDU-2897 Making the -mavx2 flag contingent on the architecture rather than the OS alone

2019-07-19 Thread Ritwik Yadav (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13884 to look at the new patch set (#2). Change subject: KUDU-2897 Making the -mavx2 flag contingent on the architecture rather than the OS alone

[kudu-CR] Making the -mavx2 flag contingent on the architecture rather than the OS alone

2019-07-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13884 ) Change subject: Making the -mavx2 flag contingent on the architecture rather than the OS alone .. Patch Set 1: (1 comment) a few

[kudu-CR] Making the -mavx2 flag contingent on the architecture rather than the OS alone

2019-07-19 Thread Ritwik Yadav (Code Review)
Ritwik Yadav has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13884 Change subject: Making the -mavx2 flag contingent on the architecture rather than the OS alone .. Making the -mavx2 flag contingent on

[kudu-CR] KUDU-2797 p2: the master aggregates tablet statistics

2019-07-19 Thread helifu (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13426 to look at the new patch set (#23). Change subject: KUDU-2797 p2: the master aggregates tablet statistics

[kudu-CR] KUDU-1938 Add CHAR/VARCHAR to C++ client pt 2

2019-07-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13869 ) Change subject: KUDU-1938 Add CHAR/VARCHAR to C++ client pt 2 .. Patch Set 5: (1 comment) Looks good but I'm still hoping you can add

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-07-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 .. Patch Set 22: (4 comments)

[kudu-CR] KUDU-2823 [java client] Support setting dimension for the newly created tablet

2019-07-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13875 ) Change subject: KUDU-2823 [java client] Support setting dimension for the newly created tablet .. Patch Set 4: Code-Review+1 (1

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-07-19 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13760 to look at the new patch set (#22). Change subject: KUDU-1938 Add support for CHAR/VARCHAR

[kudu-CR] KUDU-1938 Add CHAR/VARCHAR to C++ client pt 2

2019-07-19 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/13869 ) Change subject: KUDU-1938 Add CHAR/VARCHAR to C++ client pt 2 .. Patch Set 4: (5 comments)

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-07-19 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 .. Patch Set 21: (9 comments)

[kudu-CR] KUDU-1938 Add CHAR/VARCHAR to C++ client pt 2

2019-07-19 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13869 to look at the new patch set (#4). Change subject: KUDU-1938 Add CHAR/VARCHAR to C++ client pt 2

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-07-19 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13760 to look at the new patch set (#21). Change subject: KUDU-1938 Add support for CHAR/VARCHAR

[kudu-CR] KUDU-2797 p2: the master aggregates tablet statistics

2019-07-19 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797 p2: the master aggregates tablet statistics .. Patch Set 22: (2 comments) Two questions remain: 1. More unit

[kudu-CR] KUDU-2797 p2: the master aggregates tablet statistics

2019-07-19 Thread helifu (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13426 to look at the new patch set (#22). Change subject: KUDU-2797 p2: the master aggregates tablet statistics

[kudu-CR] KUDU-2823 [java client] Support setting dimension for the newly created tablet

2019-07-19 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13875 ) Change subject: KUDU-2823 [java client] Support setting dimension for the newly created tablet .. Patch Set 4: (1 comment)

[kudu-CR] [docs]: Delete invalid link

2019-07-19 Thread XiaokaiWang (Code Review)
XiaokaiWang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13881 ) Change subject: [docs]: Delete invalid link .. Patch Set 1: > (1 comment) Hmm, this will return back to 'Dictionary encoding' title,

[kudu-CR] [docs]: Delete invalid link

2019-07-19 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13881 ) Change subject: [docs]: Delete invalid link .. Patch Set 1: (1 comment)