[kudu-CR] subprocess: enable log4j debug logging

2020-03-31 Thread Andrew Wong (Code Review)
Hello Attila Bukor, Grant Henke, Hao Hao, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15627 to review the following change. Change subject: subprocess: enable log4j debug logging ..

[kudu-CR] KUDU-3099: Remove System.exit() calls in KuduBackup/KuduRestore

2020-03-31 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15626 ) Change subject: KUDU-3099: Remove System.exit() calls in KuduBackup/KuduRestore .. Patch Set 1: (2 comments) I understand unit testing

[kudu-CR] KUDU-3099: Remove System.exit() calls in KuduBackup/KuduRestore

2020-03-31 Thread Anonymous Coward (Code Review)
waleed.fat...@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15626 Change subject: KUDU-3099: Remove System.exit() calls in KuduBackup/KuduRestore .. KUDU-3099: Remove System.exit() calls in

[kudu-CR] encoding-test: Clean up bitshuffle tests a little

2020-03-31 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded a new patch set (#3) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/15043 ) Change subject: encoding-test: Clean up bitshuffle tests a little .. encoding-test:

[kudu-CR] [subprocess] Fix shutdown behavior

2020-03-31 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15615 ) Change subject: [subprocess] Fix shutdown behavior .. Patch Set 3: Verified+1 Nothing to add upon Andrew's comment. -- To view, visit

[kudu-CR] [ranger] authorize list tables should never throw NotAuthorized

2020-03-31 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15609 ) Change subject: [ranger] authorize list tables should never throw NotAuthorized .. Patch Set 3: (1 comment)

[kudu-CR] [ranger] authorize list tables should never throw NotAuthorized

2020-03-31 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15609 ) Change subject: [ranger] authorize list tables should never throw NotAuthorized .. [ranger] authorize list tables should never throw

[kudu-CR] [ranger] authorize list tables should never throw NotAuthorized

2020-03-31 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15609 ) Change subject: [ranger] authorize list tables should never throw NotAuthorized .. Patch Set 3: Code-Review+2 (1 comment)

[kudu-CR] [ranger] Use unique loopback for MiniRanger

2020-03-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15625 ) Change subject: [ranger] Use unique loopback for MiniRanger .. Patch Set 1: (2 comments)

[kudu-CR] [subprocess] Fix shutdown behavior

2020-03-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15615 ) Change subject: [subprocess] Fix shutdown behavior .. Patch Set 3: Code-Review+1 -- To view, visit

[kudu-CR] [subprocess] Fix shutdown behavior

2020-03-31 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15615 ) Change subject: [subprocess] Fix shutdown behavior .. Patch Set 3: Code-Review+1 (1 comment)

[kudu-CR] KUDU-3081 Add Kerberos support to MiniRanger

2020-03-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15601 ) Change subject: KUDU-3081 Add Kerberos support to MiniRanger .. Patch Set 6: (2 comments)

[kudu-CR] [ranger] Use unique loopback for MiniRanger

2020-03-31 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15625 ) Change subject: [ranger] Use unique loopback for MiniRanger .. Patch Set 1: (3 comments)

[kudu-CR] KUDU-3081 Add Kerberos support to MiniRanger

2020-03-31 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15601 ) Change subject: KUDU-3081 Add Kerberos support to MiniRanger .. Patch Set 6: (4 comments)

[kudu-CR] client: add support for columnar format scan

2020-03-31 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15622 ) Change subject: client: add support for columnar format scan .. Patch Set 2: (11 comments)

[kudu-CR] [subprocess] Fix shutdown behavior

2020-03-31 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15615 ) Change subject: [subprocess] Fix shutdown behavior .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-3081 Add Kerberos support to MiniRanger

2020-03-31 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15601 ) Change subject: KUDU-3081 Add Kerberos support to MiniRanger .. Patch Set 6: (6 comments)

[kudu-CR] [subprocess] Fix shutdown behavior

2020-03-31 Thread Attila Bukor (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15615 to look at the new patch set (#3). Change subject: [subprocess] Fix shutdown behavior

[kudu-CR] [ranger] Use unique loopback for MiniRanger

2020-03-31 Thread Attila Bukor (Code Review)
Attila Bukor has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15625 Change subject: [ranger] Use unique loopback for MiniRanger .. [ranger] Use unique loopback for MiniRanger Other services use a unique

[kudu-CR] KUDU-3081 Add Kerberos support to MiniRanger

2020-03-31 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15601 to look at the new patch set (#6). Change subject: KUDU-3081 Add Kerberos support to MiniRanger

[kudu-CR] client: add support for columnar format scan

2020-03-31 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15622 to look at the new patch set (#2). Change subject: client: add support for columnar format scan

[kudu-CR] KUDU-3097 kudu master should delete table record when deleting table

2020-03-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15616 ) Change subject: KUDU-3097 kudu master should delete table record when deleting table .. Patch Set 3: (1 comment) This needs a unit

[kudu-CR] KUDU-3081 Add Kerberos support to MiniRanger

2020-03-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15601 ) Change subject: KUDU-3081 Add Kerberos support to MiniRanger .. Patch Set 5: (6 comments)

[kudu-CR] tserver: add support for returning scan result in columnar layout

2020-03-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15602 ) Change subject: tserver: add support for returning scan result in columnar layout .. tserver: add support for returning scan

[kudu-CR] client: add support for columnar format scan

2020-03-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15622 ) Change subject: client: add support for columnar format scan .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-3081 Add Kerberos support to MiniRanger

2020-03-31 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15601 to look at the new patch set (#5). Change subject: KUDU-3081 Add Kerberos support to MiniRanger

[kudu-CR] tserver: add support for returning scan result in columnar layout

2020-03-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15602 ) Change subject: tserver: add support for returning scan result in columnar layout .. Patch Set 4: Verified+1 Test failure was

[kudu-CR] [subprocess] Fix shutdown behavior

2020-03-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15615 ) Change subject: [subprocess] Fix shutdown behavior .. Patch Set 2: (1 comment)

[kudu-CR] tserver: add support for returning scan result in columnar layout

2020-03-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: tserver: add support for returning scan result in columnar layout .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit

[kudu-CR] client: add support for columnar format scan

2020-03-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15622 ) Change subject: client: add support for columnar format scan .. Patch Set 1: (3 comments) Just looked at the new APIs.

[kudu-CR] tserver: add support for returning scan result in columnar layout

2020-03-31 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15602 ) Change subject: tserver: add support for returning scan result in columnar layout .. Patch Set 4: Code-Review+2 (3 comments)

[kudu-CR] [subprocess] Fix shutdown behavior

2020-03-31 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15615 ) Change subject: [subprocess] Fix shutdown behavior .. Patch Set 2: (3 comments)

[kudu-CR] [subprocess] Fix shutdown behavior

2020-03-31 Thread Attila Bukor (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15615 to look at the new patch set (#2). Change subject: [subprocess] Fix shutdown behavior

[kudu-CR] client: add support for columnar format scan

2020-03-31 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15622 to review the following change. Change subject: client: add support for columnar format scan .. client:

[kudu-CR] tserver: add support for returning scan result in columnar layout

2020-03-31 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15602 to look at the new patch set (#4). Change subject: tserver: add support for returning scan result in columnar layout

[kudu-CR] [ranger] authorize list tables should never throw NotAuthorized

2020-03-31 Thread Hao Hao (Code Review)
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15609 to look at the new patch set (#3). Change subject: [ranger] authorize list tables should never throw NotAuthorized

[kudu-CR] [ranger] authorize list tables should never throw NotAuthorized

2020-03-31 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15609 ) Change subject: [ranger] authorize list tables should never throw NotAuthorized .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-3081 Add Kerberos support to MiniRanger

2020-03-31 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15601 ) Change subject: KUDU-3081 Add Kerberos support to MiniRanger .. Patch Set 4: (10 comments)

[kudu-CR] KUDU-3081 Add Kerberos support to MiniRanger

2020-03-31 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15601 to look at the new patch set (#4). Change subject: KUDU-3081 Add Kerberos support to MiniRanger

[kudu-CR] [subprocess] Fix shutdown behavior

2020-03-31 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15615 ) Change subject: [subprocess] Fix shutdown behavior .. Patch Set 1: (3 comments)

[kudu-CR] tserver: add support for returning scan result in columnar layout

2020-03-31 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15602 to look at the new patch set (#3). Change subject: tserver: add support for returning scan result in columnar layout

[kudu-CR] tserver: add support for returning scan result in columnar layout

2020-03-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15602 ) Change subject: tserver: add support for returning scan result in columnar layout .. Patch Set 3: (11 comments)

[kudu-CR] KUDU-3097 kudu master should delete table record when deleting table

2020-03-31 Thread wangning (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15616 to look at the new patch set (#3). Change subject: KUDU-3097 kudu master should delete table record when deleting table

[kudu-CR] KUDU-3097 kudu master should delete table when deleting table

2020-03-31 Thread wangning (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15616 to look at the new patch set (#2). Change subject: KUDU-3097 kudu master should delete table when deleting table ..

[kudu-CR] KUDU-3097 kudu master should delete table instead of keeping them

2020-03-31 Thread wangning (Code Review)
wangning has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15616 Change subject: KUDU-3097 kudu master should delete table instead of keeping them .. KUDU-3097 kudu master should delete table instead of

[kudu-CR] [subprocess] Fix shutdown behavior

2020-03-31 Thread Attila Bukor (Code Review)
Hello Andrew Wong, Adar Dembo, Grant Henke, Hao Hao, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15615 to review the following change. Change subject: [subprocess] Fix shutdown behavior

[kudu-CR] [thirdparty] root can run postgres

2020-03-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15613 ) Change subject: [thirdparty] root can run postgres .. [thirdparty] root can run postgres Sometimes Kudu development

[kudu-CR] KUDU-3007. Support building Kudu on aarch64 platform

2020-03-31 Thread liusheng (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, huangtianhua...@gmail.com, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14964 to look at the new patch set (#11). Change subject: KUDU-3007. Support building Kudu on aarch64 platform

[kudu-CR] external mini cluster: actually default to system unsync time source

2020-03-31 Thread Adar Dembo (Code Review)
Adar Dembo has abandoned this change. ( http://gerrit.cloudera.org:8080/14836 ) Change subject: external_mini_cluster: actually default to system_unsync time source .. Abandoned -- To view, visit

[kudu-CR] WIP: use ExternalProject Add to define thirdparty deps

2020-03-31 Thread Adar Dembo (Code Review)
Adar Dembo has abandoned this change. ( http://gerrit.cloudera.org:8080/9931 ) Change subject: WIP: use ExternalProject_Add to define thirdparty deps .. Abandoned If we wanted to revisit our thirdparty dependency system,

[kudu-CR] [ranger] allow subprocess to log to a file

2020-03-31 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15525 ) Change subject: [ranger] allow subprocess to log to a file .. Patch Set 2: (1 comment)

[kudu-CR] [ranger] allow subprocess to log to a file

2020-03-31 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15525 ) Change subject: [ranger] allow subprocess to log to a file .. Patch Set 2: (1 comment)

[kudu-CR] [thirdparty] root can run postgres

2020-03-31 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15613 ) Change subject: [thirdparty] root can run postgres .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [ranger] allow subprocess to log to a file

2020-03-31 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15525 ) Change subject: [ranger] allow subprocess to log to a file .. Patch Set 2: (1 comment)

[kudu-CR] [ranger] allow subprocess to log to a file

2020-03-31 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15525 ) Change subject: [ranger] allow subprocess to log to a file .. Patch Set 2: (1 comment)

[kudu-CR] [ranger] authorize list tables should never throw NotAuthorized

2020-03-31 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15609 ) Change subject: [ranger] authorize list tables should never throw NotAuthorized .. Patch Set 2: (1 comment)

[kudu-CR] [ranger] authorize list tables should never throw NotAuthorized

2020-03-31 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15609 ) Change subject: [ranger] authorize list tables should never throw NotAuthorized .. Patch Set 2: (1 comment)

[kudu-CR] [ranger] authorize list tables should never throw NotAuthorized

2020-03-31 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15609 ) Change subject: [ranger] authorize list tables should never throw NotAuthorized .. Patch Set 2: (1 comment)

[kudu-CR] [thirdparty] root can run postgres

2020-03-31 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15613 ) Change subject: [thirdparty] root can run postgres .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [ranger] authorize list tables should never throw NotAuthorized

2020-03-31 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15609 ) Change subject: [ranger] authorize list tables should never throw NotAuthorized .. Patch Set 2: (1 comment)

[kudu-CR] [ranger] authorize list tables should never throw NotAuthorized

2020-03-31 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15609 ) Change subject: [ranger] authorize list tables should never throw NotAuthorized .. Patch Set 2: (1 comment)

[kudu-CR] [thirdparty] root can run postgres

2020-03-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15613 ) Change subject: [thirdparty] root can run postgres .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [ranger] authorize list tables should never throw NotAuthorized

2020-03-31 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15609 ) Change subject: [ranger] authorize list tables should never throw NotAuthorized .. Patch Set 2: (1 comment)

[kudu-CR] [ranger] authorize list tables should never throw NotAuthorized

2020-03-31 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15609 ) Change subject: [ranger] authorize list tables should never throw NotAuthorized .. Patch Set 2: (1 comment)

[kudu-CR] [ranger] authorize list tables should never throw NotAuthorized

2020-03-31 Thread Hao Hao (Code Review)
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15609 to look at the new patch set (#2). Change subject: [ranger] authorize list tables should never throw NotAuthorized

[kudu-CR] [thirdparty] root can run postgres

2020-03-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15613 Change subject: [thirdparty] root can run postgres .. [thirdparty] root can run postgres Sometimes Kudu development environment is run