[kudu-CR] KUDU-3078 Add Ranger tests to master authz-itest

2020-04-08 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15681 ) Change subject: KUDU-3078 Add Ranger tests to master_authz-itest .. Patch Set 13: Code-Review+1 (3 comments)

[kudu-CR] KUDU-3078 Refactor Sentry integration tests

2020-04-08 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15671 ) Change subject: KUDU-3078 Refactor Sentry integration tests .. Patch Set 8: I think it's worth squashing this into the next patch --

[kudu-CR] KUDU-3078 Add Ranger tests to master authz-itest

2020-04-08 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: KUDU-3078 Add Ranger tests to master_authz-itest .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15681 To unsubscribe,

[kudu-CR] KUDU-3078 Add Ranger tests to master authz-itest

2020-04-08 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15681 ) Change subject: KUDU-3078 Add Ranger tests to master_authz-itest .. Patch Set 13: Verified+1 Unrelated flake:

[kudu-CR] KUDU-3078 Add Ranger tests to master authz-itest

2020-04-08 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15681 ) Change subject: KUDU-3078 Add Ranger tests to master_authz-itest .. Patch Set 13: (8 comments)

[kudu-CR] net: make Sockaddr more generic for other address families

2020-04-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15690 ) Change subject: net: make Sockaddr more generic for other address families .. Patch Set 2: (7 comments)

[kudu-CR] KUDU-3078 Add Ranger tests to master authz-itest

2020-04-08 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new patch set (#13) to the change originally created by Attila Bukor. ( http://gerrit.cloudera.org:8080/15681 ) Change subject: KUDU-3078 Add Ranger tests to master_authz-itest .. KUDU-3078 Add Ranger

[kudu-CR] KUDU-3078 Add Ranger tests to master authz-itest

2020-04-08 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new patch set (#12) to the change originally created by Attila Bukor. ( http://gerrit.cloudera.org:8080/15681 ) Change subject: KUDU-3078 Add Ranger tests to master_authz-itest .. KUDU-3078 Add Ranger

[kudu-CR] encoding-test: Clean up bitshuffle tests a little

2020-04-08 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15043 ) Change subject: encoding-test: Clean up bitshuffle tests a little .. encoding-test: Clean up bitshuffle tests a little Also

[kudu-CR] net: make Sockaddr more generic for other address families

2020-04-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15690 ) Change subject: net: make Sockaddr more generic for other address families .. Patch Set 2: Code-Review+2 (1 comment) Looks like a step

[kudu-CR] KUDU-3078 Add Ranger tests to master authz-itest

2020-04-08 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new patch set (#11) to the change originally created by Attila Bukor. ( http://gerrit.cloudera.org:8080/15681 ) Change subject: KUDU-3078 Add Ranger tests to master_authz-itest .. KUDU-3078 Add Ranger

[kudu-CR] encoding-test: Clean up bitshuffle tests a little

2020-04-08 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15043 ) Change subject: encoding-test: Clean up bitshuffle tests a little .. Patch Set 12: Code-Review+2 (1 comment)

[kudu-CR] encoding-test: Clean up bitshuffle tests a little

2020-04-08 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15043 ) Change subject: encoding-test: Clean up bitshuffle tests a little .. Patch Set 12: (1 comment)

[kudu-CR] encoding-test: Clean up bitshuffle tests a little

2020-04-08 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded a new patch set (#12) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/15043 ) Change subject: encoding-test: Clean up bitshuffle tests a little .. encoding-test:

[kudu-CR] cfile: change BlockBuilder API to yield a vector of Slices

2020-04-08 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15042 ) Change subject: cfile: change BlockBuilder API to yield a vector of Slices .. cfile: change BlockBuilder API to yield a vector

[kudu-CR] cfile: clean up encoding-test to use fewer templates

2020-04-08 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15044 ) Change subject: cfile: clean up encoding-test to use fewer templates .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] encoding-test: Clean up bitshuffle tests a little

2020-04-08 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15043 ) Change subject: encoding-test: Clean up bitshuffle tests a little .. Patch Set 11: (1 comment)

[kudu-CR] encoding-test: Clean up bitshuffle tests a little

2020-04-08 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15043 ) Change subject: encoding-test: Clean up bitshuffle tests a little .. Patch Set 11: > Patch Set 11: Verified-1 > > Build Failed > >

[kudu-CR] KUDU-3078 Add Ranger tests to master authz-itest

2020-04-08 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new patch set (#10) to the change originally created by Attila Bukor. ( http://gerrit.cloudera.org:8080/15681 ) Change subject: KUDU-3078 Add Ranger tests to master_authz-itest .. KUDU-3078 Add Ranger

[kudu-CR] encoding-test: Clean up bitshuffle tests a little

2020-04-08 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded a new patch set (#11) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/15043 ) Change subject: encoding-test: Clean up bitshuffle tests a little .. encoding-test:

[kudu-CR] net: make Sockaddr more generic for other address families

2020-04-08 Thread Volodymyr Verovkin (Code Review)
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15690 ) Change subject: net: make Sockaddr more generic for other address families .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] encoding-test: Clean up bitshuffle tests a little

2020-04-08 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15043 ) Change subject: encoding-test: Clean up bitshuffle tests a little .. Patch Set 10: (3 comments)

[kudu-CR] WIP: Add basic support for unix sockets

2020-04-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15691 Change subject: WIP: Add basic support for unix sockets .. WIP: Add basic support for unix sockets so far can't seem to reproduce any

[kudu-CR] KUDU-3078 Add Ranger tests to master authz-itest

2020-04-08 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new patch set (#9) to the change originally created by Attila Bukor. ( http://gerrit.cloudera.org:8080/15681 ) Change subject: KUDU-3078 Add Ranger tests to master_authz-itest .. KUDU-3078 Add Ranger

[kudu-CR] net: make Sockaddr more generic for other address families

2020-04-08 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15690 ) Change subject: net: make Sockaddr more generic for other address families .. Patch Set 2: (1 comment)

[kudu-CR](branch-1.12.x) WIP [docs] Kudu 1.12 release notes draft

2020-04-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#4) to the change originally created by Hao Hao. ( http://gerrit.cloudera.org:8080/15685 ) Change subject: WIP [docs] Kudu 1.12 release notes draft .. WIP [docs] Kudu 1.12 release

[kudu-CR] net: make Sockaddr more generic for other address families

2020-04-08 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15690 ) Change subject: net: make Sockaddr more generic for other address families .. Patch Set 2: (4 comments)

[kudu-CR] cfile: clean up encoding-test to use fewer templates

2020-04-08 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15044 ) Change subject: cfile: clean up encoding-test to use fewer templates .. Patch Set 4: Code-Review+2 (1 comment)

[kudu-CR] encoding-test: Clean up bitshuffle tests a little

2020-04-08 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15043 ) Change subject: encoding-test: Clean up bitshuffle tests a little .. Patch Set 10: (4 comments)

[kudu-CR] cfile: change BlockBuilder API to yield a vector of Slices

2020-04-08 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15042 ) Change subject: cfile: change BlockBuilder API to yield a vector of Slices .. Patch Set 7: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-3078 Add Ranger tests to master authz-itest

2020-04-08 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15681 ) Change subject: KUDU-3078 Add Ranger tests to master_authz-itest .. Patch Set 8: (1 comment)

[kudu-CR] KUDU-3078 Add Ranger tests to master authz-itest

2020-04-08 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15681 ) Change subject: KUDU-3078 Add Ranger tests to master_authz-itest .. Patch Set 7: (6 comments)

[kudu-CR] cfile: change BlockBuilder API to yield a vector of Slices

2020-04-08 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded a new patch set (#7) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/15042 ) Change subject: cfile: change BlockBuilder API to yield a vector of Slices .. cfile:

[kudu-CR] cfile: clean up encoding-test to use fewer templates

2020-04-08 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded a new patch set (#4) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/15044 ) Change subject: cfile: clean up encoding-test to use fewer templates .. cfile: clean up

[kudu-CR] encoding-test: Clean up bitshuffle tests a little

2020-04-08 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded a new patch set (#10) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/15043 ) Change subject: encoding-test: Clean up bitshuffle tests a little .. encoding-test:

[kudu-CR] encoding-test: Clean up bitshuffle tests a little

2020-04-08 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15043 ) Change subject: encoding-test: Clean up bitshuffle tests a little .. Patch Set 9: (7 comments)

[kudu-CR] cfile: clean up encoding-test to use fewer templates

2020-04-08 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15044 ) Change subject: cfile: clean up encoding-test to use fewer templates .. Patch Set 3: (2 comments)

[kudu-CR] KUDU-3078 Add Ranger tests to master authz-itest

2020-04-08 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15681 to look at the new patch set (#8). Change subject: KUDU-3078 Add Ranger tests to master_authz-itest

[kudu-CR] net: make Sockaddr more generic for other address families

2020-04-08 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15690 to look at the new patch set (#2). Change subject: net: make Sockaddr more generic for other address families

[kudu-CR] net: make Sockaddr more generic for other address families

2020-04-08 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15690 to review the following change. Change subject: net: make Sockaddr more generic for other address families

[kudu-CR] KUDU-3078 Refactor Sentry integration tests

2020-04-08 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15671 ) Change subject: KUDU-3078 Refactor Sentry integration tests .. Patch Set 8: (1 comment)

[kudu-CR] KUDU-3078 Add Ranger tests to master authz-itest

2020-04-08 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15681 to look at the new patch set (#7). Change subject: KUDU-3078 Add Ranger tests to master_authz-itest

[kudu-CR] KUDU-3078 Refactor Sentry integration tests

2020-04-08 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15671 to look at the new patch set (#8). Change subject: KUDU-3078 Refactor Sentry integration tests

[kudu-CR] KUDU-3078 Add Ranger tests to master authz-itest

2020-04-08 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15681 to look at the new patch set (#6). Change subject: KUDU-3078 Add Ranger tests to master_authz-itest

[kudu-CR] KUDU-3078 Add Ranger tests to master authz-itest

2020-04-08 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15681 to look at the new patch set (#5). Change subject: KUDU-3078 Add Ranger tests to master_authz-itest

[kudu-CR] columnar serialization: fix optimized GCC build

2020-04-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15680 ) Change subject: columnar_serialization: fix optimized GCC build .. Patch Set 2: (1 comment)

[kudu-CR](branch-1.12.x) WIP [docs] Kudu 1.12 release notes draft

2020-04-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#3) to the change originally created by Hao Hao. ( http://gerrit.cloudera.org:8080/15685 ) Change subject: WIP [docs] Kudu 1.12 release notes draft .. WIP [docs] Kudu 1.12 release

[kudu-CR](branch-1.12.x) WIP [docs] Kudu 1.12 release notes draft

2020-04-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 ) Change subject: WIP [docs] Kudu 1.12 release notes draft .. Patch Set 2: (6 comments)

[kudu-CR] WIP: KUDU-3097 whether master keep record could be configurable

2020-04-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15616 ) Change subject: WIP: KUDU-3097 whether master keep record could be configurable .. Patch Set 4: > But it would cause some inconsistent

[kudu-CR](branch-1.12.x) WIP [docs] Kudu 1.12 release notes draft

2020-04-08 Thread Hannah Nguyen (Code Review)
Hannah Nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 ) Change subject: WIP [docs] Kudu 1.12 release notes draft .. Patch Set 2: (1 comment) Drafted a release note for auto-rebalancing!

[kudu-CR] KUDU-3078 Refactor Sentry integration tests

2020-04-08 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15671 ) Change subject: KUDU-3078 Refactor Sentry integration tests .. Patch Set 7: (15 comments)

[kudu-CR] KUDU-3078 Refactor Sentry integration tests

2020-04-08 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15671 to look at the new patch set (#7). Change subject: KUDU-3078 Refactor Sentry integration tests

[kudu-CR] KUDU-3078 Add Ranger tests to master authz-itest

2020-04-08 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15681 ) Change subject: KUDU-3078 Add Ranger tests to master_authz-itest .. Patch Set 4: (11 comments)

[kudu-CR] KUDU-3078 Add Ranger tests to master authz-itest

2020-04-08 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15681 to look at the new patch set (#4). Change subject: KUDU-3078 Add Ranger tests to master_authz-itest

[kudu-CR] tserver: add locking around an RPC's usage of a Scanner

2020-04-08 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15677 to look at the new patch set (#2). Change subject: tserver: add locking around an RPC's usage of a Scanner

[kudu-CR](branch-1.12.x) WIP [docs] Kudu 1.12 release notes draft

2020-04-08 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 ) Change subject: WIP [docs] Kudu 1.12 release notes draft .. Patch Set 2: (5 comments)

[kudu-CR] KUDU-3007. Support building Kudu on aarch64 platform

2020-04-08 Thread liusheng (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, huangtianhua...@gmail.com, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14964 to look at the new patch set (#15). Change subject: KUDU-3007. Support building Kudu on aarch64 platform