[kudu-CR] client/tserver: add support for connecting over unix domain sockets

2020-04-09 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Andrew Wong, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15701 to look at the new patch set (#2). Change subject: client/tserver: add support for connecting over unix domain sockets

[kudu-CR] Add basic support for unix domain sockets

2020-04-09 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Mike Percy, Andrew Wong, Kudu Jenkins, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15691 to look at the new patch set (#4). Change subject: Add basic support for unix domain sockets

[kudu-CR] [catalog manager] cache masters' addresses

2020-04-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15704 Change subject: [catalog manager] cache masters' addresses .. [catalog manager] cache masters' addresses While troubleshooting one

[kudu-CR] [catalog manager] reduce contention in ScopedLeaderSharedLock

2020-04-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15698 ) Change subject: [catalog_manager] reduce contention in ScopedLeaderSharedLock .. [catalog_manager] reduce contention in

[kudu-CR] [catalog manager] reduce contention in ScopedLeaderSharedLock

2020-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15698 ) Change subject: [catalog_manager] reduce contention in ScopedLeaderSharedLock .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] [catalog manager] reduce contention in ScopedLeaderSharedLock

2020-04-09 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15698 to look at the new patch set (#3). Change subject: [catalog_manager] reduce contention in ScopedLeaderSharedLock

[kudu-CR] [catalog manager] reduce contention in ScopedLeaderSharedLock

2020-04-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15698 ) Change subject: [catalog_manager] reduce contention in ScopedLeaderSharedLock .. Patch Set 2: (1 comment)

[kudu-CR] Use unix domain socket for local client/server communication

2020-04-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has abandoned this change. ( http://gerrit.cloudera.org:8080/957 ) Change subject: Use unix domain socket for local client/server communication .. Abandoned took a new approach of this here:

[kudu-CR] Add basic support for unix domain sockets

2020-04-09 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Mike Percy, Andrew Wong, Kudu Jenkins, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15691 to look at the new patch set (#3). Change subject: Add basic support for unix domain sockets

[kudu-CR] client/tserver: add support for connecting over unix domain sockets

2020-04-09 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15701 to review the following change. Change subject: client/tserver: add support for connecting over unix domain sockets

[kudu-CR] [catalog manager] reduce contention in ScopedLeaderSharedLock

2020-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15698 ) Change subject: [catalog_manager] reduce contention in ScopedLeaderSharedLock .. Patch Set 2: Code-Review+2 (1 comment)

[kudu-CR] [ranger] Fix and refactor RangerClient

2020-04-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15696 ) Change subject: [ranger] Fix and refactor RangerClient .. Patch Set 1: (1 comment)

[kudu-CR] [catalog manager] reduce contention in ScopedLeaderSharedLock

2020-04-09 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15698 to look at the new patch set (#2). Change subject: [catalog_manager] reduce contention in ScopedLeaderSharedLock

[kudu-CR] [catalog manager] reduce contention in ScopedLeaderSharedLock

2020-04-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15698 ) Change subject: [catalog_manager] reduce contention in ScopedLeaderSharedLock .. Patch Set 1: (1 comment)

[kudu-CR] [catalog manager] reduce contention in ScopedLeaderSharedLock

2020-04-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15698 ) Change subject: [catalog_manager] reduce contention in ScopedLeaderSharedLock .. Patch Set 1: (1 comment) Good catch!

[kudu-CR] [catalog manager] reduce contention in ScopedLeaderSharedLock

2020-04-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15698 Change subject: [catalog_manager] reduce contention in ScopedLeaderSharedLock .. [catalog_manager] reduce contention in

[kudu-CR] net: make Sockaddr more generic for other address families

2020-04-09 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Mike Percy, Alexey Serbin, Kudu Jenkins, Bankim Bhavsar, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15690 to look at the new patch set (#3). Change subject: net: make Sockaddr more generic for other address families

[kudu-CR] Add basic support for unix domain sockets

2020-04-09 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15691 to look at the new patch set (#2). Change subject: Add basic support for unix domain sockets

[kudu-CR] cfile: clean up encoding-test to use fewer templates

2020-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15044 ) Change subject: cfile: clean up encoding-test to use fewer templates .. cfile: clean up encoding-test to use fewer templates

[kudu-CR] cfile: clean up encoding-test to use fewer templates

2020-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15044 ) Change subject: cfile: clean up encoding-test to use fewer templates .. Patch Set 6: Verified+1 Failed test was a tracked, unrelated

[kudu-CR] cfile: clean up encoding-test to use fewer templates

2020-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: cfile: clean up encoding-test to use fewer templates .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15044 To

[kudu-CR] cfile: clean up encoding-test to use fewer templates

2020-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: cfile: clean up encoding-test to use fewer templates .. Removed -Verified by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15044 To

[kudu-CR] [ranger] Fix and refactor RangerClient

2020-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15696 ) Change subject: [ranger] Fix and refactor RangerClient .. Patch Set 2: (5 comments)

[kudu-CR] KUDU-3078 Add Ranger tests to master authz-itest

2020-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15681 ) Change subject: KUDU-3078 Add Ranger tests to master_authz-itest .. Patch Set 15: (1 comment)

[kudu-CR] KUDU-3078 Add Ranger tests to master authz-itest

2020-04-09 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15681 ) Change subject: KUDU-3078 Add Ranger tests to master_authz-itest .. Patch Set 15: (5 comments)

[kudu-CR] [ranger] Fix and refactor RangerClient

2020-04-09 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15696 ) Change subject: [ranger] Fix and refactor RangerClient .. Patch Set 2: (5 comments)

[kudu-CR] KUDU-3078 Add Ranger tests to master authz-itest

2020-04-09 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15681 to look at the new patch set (#15). Change subject: KUDU-3078 Add Ranger tests to master_authz-itest

[kudu-CR] [ranger] Fix and refactor RangerClient

2020-04-09 Thread Attila Bukor (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15696 to look at the new patch set (#2). Change subject: [ranger] Fix and refactor RangerClient

[kudu-CR] net: make Sockaddr more generic for other address families

2020-04-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15690 ) Change subject: net: make Sockaddr more generic for other address families .. Patch Set 2: (12 comments)

[kudu-CR] cfile: clean up encoding-test to use fewer templates

2020-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15044 ) Change subject: cfile: clean up encoding-test to use fewer templates .. Patch Set 6: Code-Review+2 -- To view, visit

[kudu-CR] [ranger] Fix and refactor RangerClient

2020-04-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15696 ) Change subject: [ranger] Fix and refactor RangerClient .. Patch Set 1: (1 comment)

[kudu-CR](branch-1.12.x) [docker] Fix Docker build on the centOS 8 base image

2020-04-09 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15697 ) Change subject: [docker] Fix Docker build on the centOS 8 base image .. [docker] Fix Docker build on the centOS 8 base image In

[kudu-CR] WIP: Remove limit on number of sidecar slices

2020-04-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has abandoned this change. ( http://gerrit.cloudera.org:8080/5895 ) Change subject: WIP: Remove limit on number of sidecar slices .. Abandoned I ended up implementing this in

[kudu-CR](branch-1.12.x) [docker] Fix Docker build on the centOS 8 base image

2020-04-09 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15697 ) Change subject: [docker] Fix Docker build on the centOS 8 base image .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-3078 Add Ranger tests to master authz-itest

2020-04-09 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15681 ) Change subject: KUDU-3078 Add Ranger tests to master_authz-itest .. Patch Set 14: (1 comment)

[kudu-CR](branch-1.12.x) [docker] Fix Docker build on the centOS 8 base image

2020-04-09 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15697 Change subject: [docker] Fix Docker build on the centOS 8 base image .. [docker] Fix Docker build on the centOS 8 base image In order to

[kudu-CR] [docker] Fix Docker build on the centOS 8 base image

2020-04-09 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15695 ) Change subject: [docker] Fix Docker build on the centOS 8 base image .. [docker] Fix Docker build on the centOS 8 base image In

[kudu-CR] KUDU-3078 Add Ranger tests to master authz-itest

2020-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15681 ) Change subject: KUDU-3078 Add Ranger tests to master_authz-itest .. Patch Set 14: (2 comments)

[kudu-CR] [docker] Fix Docker build on the centOS 8 base image

2020-04-09 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15695 ) Change subject: [docker] Fix Docker build on the centOS 8 base image .. Patch Set 1: (1 comment)

[kudu-CR] [docker] Fix Docker build on the centOS 8 base image

2020-04-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15695 ) Change subject: [docker] Fix Docker build on the centOS 8 base image .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [ranger] Fix and refactor RangerClient

2020-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15696 ) Change subject: [ranger] Fix and refactor RangerClient .. Patch Set 1: (3 comments)

[kudu-CR] KUDU-3078 Add Ranger tests to master authz-itest

2020-04-09 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15681 ) Change subject: KUDU-3078 Add Ranger tests to master_authz-itest .. Patch Set 14: (3 comments)

[kudu-CR] [ranger] Fix and refactor RangerClient

2020-04-09 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15696 ) Change subject: [ranger] Fix and refactor RangerClient .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15696/1//COMMIT_MSG

[kudu-CR] KUDU-3078 Refactor Sentry integration tests

2020-04-09 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15671 ) Change subject: KUDU-3078 Refactor Sentry integration tests .. Patch Set 8: > Patch Set 8: > > I think it's worth squashing this into

[kudu-CR] KUDU-3078 Refactor Sentry integration tests

2020-04-09 Thread Attila Bukor (Code Review)
Attila Bukor has abandoned this change. ( http://gerrit.cloudera.org:8080/15671 ) Change subject: KUDU-3078 Refactor Sentry integration tests .. Abandoned squashed into another commit -- To view, visit

[kudu-CR] KUDU-3078 Add Ranger tests to master authz-itest

2020-04-09 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15681 ) Change subject: KUDU-3078 Add Ranger tests to master_authz-itest .. Patch Set 13: (13 comments)

[kudu-CR] [ranger] Fix and refactor RangerClient

2020-04-09 Thread Attila Bukor (Code Review)
Attila Bukor has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15696 Change subject: [ranger] Fix and refactor RangerClient .. [ranger] Fix and refactor RangerClient While working on integration tests we

[kudu-CR](branch-1.12.x) WIP [docs] Kudu 1.12 release notes draft

2020-04-09 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 ) Change subject: WIP [docs] Kudu 1.12 release notes draft .. Patch Set 4: (4 comments) I added a few comments here and added entries to

[kudu-CR] [docker] Fix Docker build on the centOS 8 base image

2020-04-09 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15695 ) Change subject: [docker] Fix Docker build on the centOS 8 base image .. Patch Set 1: Code-Review+1 (1 comment)

[kudu-CR] [docker] Fix Docker build on the centOS 8 base image

2020-04-09 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15695 Change subject: [docker] Fix Docker build on the centOS 8 base image .. [docker] Fix Docker build on the centOS 8 base image In order to

[kudu-CR] WIP: Add basic support for unix sockets

2020-04-09 Thread Volodymyr Verovkin (Code Review)
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15691 ) Change subject: WIP: Add basic support for unix sockets .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-3078 Add Ranger tests to master authz-itest

2020-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15681 ) Change subject: KUDU-3078 Add Ranger tests to master_authz-itest .. Patch Set 13: (8 comments)

[kudu-CR] tserver: add locking around an RPC's usage of a Scanner

2020-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15677 ) Change subject: tserver: add locking around an RPC's usage of a Scanner .. Patch Set 2: (3 comments)