[kudu-CR](branch-1.12.x) KUDU-3078: parameterize ts sentry-itest to use Ranger

2020-04-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15727 ) Change subject: KUDU-3078: parameterize ts_sentry-itest to use Ranger .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.12.x) [catalog manager] reduce contention in ScopedLeaderSharedLock

2020-04-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15723 ) Change subject: [catalog_manager] reduce contention in ScopedLeaderSharedLock .. [catalog_manager] reduce contention in

[kudu-CR](branch-1.12.x) KUDU-3078: parameterize ts sentry-itest to use Ranger

2020-04-13 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15727 Change subject: KUDU-3078: parameterize ts_sentry-itest to use Ranger .. KUDU-3078: parameterize ts_sentry-itest to use Ranger Following the

[kudu-CR](branch-1.12.x) [catalog manager] cache masters' addresses

2020-04-13 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15725 ) Change subject: [catalog manager] cache masters' addresses .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.12.x) [catalog manager] cache masters' addresses

2020-04-13 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15725 ) Change subject: [catalog manager] cache masters' addresses .. [catalog manager] cache masters' addresses While troubleshooting one

[kudu-CR](branch-1.12.x) [common] update on HostPortFromPB()/HostPortToPB()

2020-04-13 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15724 ) Change subject: [common] update on HostPortFromPB()/HostPortToPB() .. [common] update on HostPortFromPB()/HostPortToPB()

[kudu-CR](branch-1.12.x) [common] update on HostPortFromPB()/HostPortToPB()

2020-04-13 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15724 ) Change subject: [common] update on HostPortFromPB()/HostPortToPB() .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.12.x) [catalog manager] reduce contention in ScopedLeaderSharedLock

2020-04-13 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15723 ) Change subject: [catalog_manager] reduce contention in ScopedLeaderSharedLock .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.12.x) [catalog manager] cache masters' addresses

2020-04-13 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15725 ) Change subject: [catalog manager] cache masters' addresses .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] WIP: KUDU-3097 whether master keep record could be configurable

2020-04-13 Thread wangning (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15616 to look at the new patch set (#9). Change subject: WIP: KUDU-3097 whether master keep record could be configurable

[kudu-CR] [cfile] Add SimpleEncodingTraits to remove boiler plate code in type encodings.cc

2020-04-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15722 ) Change subject: [cfile] Add SimpleEncodingTraits to remove boiler plate code in type_encodings.cc .. Patch Set 1: (3 comments)

[kudu-CR] [cfile] Add SimpleEncodingTraits to remove boiler plate code in type encodings.cc

2020-04-13 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15722 ) Change subject: [cfile] Add SimpleEncodingTraits to remove boiler plate code in type_encodings.cc .. Patch Set 1: Code-Review+2 (1

[kudu-CR](branch-1.12.x) [catalog manager] cache masters' addresses

2020-04-13 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, Bankim Bhavsar, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15725 to review the following change. Change subject: [catalog manager] cache masters' addresses

[kudu-CR](branch-1.12.x) [common] update on HostPortFromPB()/HostPortToPB()

2020-04-13 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15724 to review the following change. Change subject: [common] update on HostPortFromPB()/HostPortToPB() ..

[kudu-CR](branch-1.12.x) [catalog manager] reduce contention in ScopedLeaderSharedLock

2020-04-13 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15723 to review the following change. Change subject: [catalog_manager] reduce contention in ScopedLeaderSharedLock

[kudu-CR] [cfile] Add SimpleEncodingTraits to remove boiler plate code in type encodings.cc

2020-04-13 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15722 Change subject: [cfile] Add SimpleEncodingTraits to remove boiler plate code in type_encodings.cc .. [cfile] Add SimpleEncodingTraits

[kudu-CR] rpc: avoid an extra epoll cycle when data can be sent immediately

2020-04-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15716 ) Change subject: rpc: avoid an extra epoll cycle when data can be sent immediately .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] rpc: avoid an extra epoll cycle when data can be sent immediately

2020-04-13 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Andrew Wong, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15716 to look at the new patch set (#3). Change subject: rpc: avoid an extra epoll cycle when data can be sent immediately

[kudu-CR] [common] update on HostPortFromPB()/HostPortToPB()

2020-04-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15713 ) Change subject: [common] update on HostPortFromPB()/HostPortToPB() .. Patch Set 3: Thank you for the review, Andrew! -- To view,

[kudu-CR] [common] update on HostPortFromPB()/HostPortToPB()

2020-04-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15713 ) Change subject: [common] update on HostPortFromPB()/HostPortToPB() .. [common] update on HostPortFromPB()/HostPortToPB()

[kudu-CR] [catalog manager] cache masters' addresses

2020-04-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15704 ) Change subject: [catalog manager] cache masters' addresses .. [catalog manager] cache masters' addresses While

[kudu-CR] rpc: avoid an extra epoll cycle when data can be sent immediately

2020-04-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15716 ) Change subject: rpc: avoid an extra epoll cycle when data can be sent immediately .. Patch Set 2: Code-Review+1 (1 comment) iwyu

[kudu-CR] [common] update on HostPortFromPB()/HostPortToPB()

2020-04-13 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15713 ) Change subject: [common] update on HostPortFromPB()/HostPortToPB() .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] rpc: avoid an extra epoll cycle when data can be sent immediately

2020-04-13 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15716 to look at the new patch set (#2). Change subject: rpc: avoid an extra epoll cycle when data can be sent immediately

[kudu-CR] KUDU-3078: parameterize ts sentry-itest to use Ranger

2020-04-13 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15714 ) Change subject: KUDU-3078: parameterize ts_sentry-itest to use Ranger .. KUDU-3078: parameterize ts_sentry-itest to use Ranger

[kudu-CR] columnar serialization: avoid preallocating 8MB per column

2020-04-13 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15679 ) Change subject: columnar_serialization: avoid preallocating 8MB per column .. Patch Set 2: (1 comment)

[kudu-CR] Avoid calling Schema::find column() once per RowBlock in columnar serialization

2020-04-13 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15678 ) Change subject: Avoid calling Schema::find_column() once per RowBlock in columnar serialization .. Patch Set 1: Code-Review+1 (2

[kudu-CR] KUDU-3078: parameterize ts sentry-itest to use Ranger

2020-04-13 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15714 ) Change subject: KUDU-3078: parameterize ts_sentry-itest to use Ranger .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-3078: parameterize ts sentry-itest to use Ranger

2020-04-13 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15714 to look at the new patch set (#5). Change subject: KUDU-3078: parameterize ts_sentry-itest to use Ranger

[kudu-CR] KUDU-3078: parameterize ts sentry-itest to use Ranger

2020-04-13 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15714 ) Change subject: KUDU-3078: parameterize ts_sentry-itest to use Ranger .. Patch Set 5: (3 comments)