[kudu-CR](branch-1.12.x) mini-cluster: exclude libpcre for license check

2020-04-15 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15744 ) Change subject: mini-cluster: exclude libpcre for license check .. Patch Set 1: Unrelated flaky test. -- To view, visit

[kudu-CR](branch-1.12.x) mini-cluster: exclude libpcre for license check

2020-04-15 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15744 ) Change subject: mini-cluster: exclude libpcre for license check .. Patch Set 1: Verified+1 -- To view, visit

[kudu-CR](branch-1.12.x) mini-cluster: exclude libpcre for license check

2020-04-15 Thread Hao Hao (Code Review)
Hao Hao has removed a vote on this change. Change subject: mini-cluster: exclude libpcre for license check .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15744 To unsubscribe,

[kudu-CR](branch-1.12.x) mini-cluster: exclude libpcre for license check

2020-04-15 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15744 ) Change subject: mini-cluster: exclude libpcre for license check .. mini-cluster: exclude libpcre for license check While building

[kudu-CR](branch-1.12.x) Bump version to 1.12.0 (non-SNAPSHOT)

2020-04-15 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15742 ) Change subject: Bump version to 1.12.0 (non-SNAPSHOT) .. Bump version to 1.12.0 (non-SNAPSHOT) Change-Id:

[kudu-CR](branch-1.12.x) mini-cluster: exclude libpcre for license check

2020-04-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15744 ) Change subject: mini-cluster: exclude libpcre for license check .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] mini-cluster: exclude libpcre for license check

2020-04-15 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15738 ) Change subject: mini-cluster: exclude libpcre for license check .. Patch Set 2: (1 comment)

[kudu-CR](branch-1.12.x) mini-cluster: exclude libpcre for license check

2020-04-15 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15744 Change subject: mini-cluster: exclude libpcre for license check .. mini-cluster: exclude libpcre for license check While building mini

[kudu-CR] mini-cluster: exclude libpcre for license check

2020-04-15 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15738 ) Change subject: mini-cluster: exclude libpcre for license check .. mini-cluster: exclude libpcre for license check While building

[kudu-CR] columnar serialization: avoid preallocating 8MB per column

2020-04-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15679 ) Change subject: columnar_serialization: avoid preallocating 8MB per column .. Patch Set 4: Code-Review+2 (1 comment) It seems I'm

[kudu-CR] mini-cluster: exclude libpcre for license check

2020-04-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15738 ) Change subject: mini-cluster: exclude libpcre for license check .. Patch Set 2: Code-Review+2 (1 comment)

[kudu-CR](branch-1.12.x) [examples] use org.apache.kudu packages v1.12.0

2020-04-15 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15743 ) Change subject: [examples] use org.apache.kudu packages v1.12.0 .. [examples] use org.apache.kudu packages v1.12.0 Change-Id:

[kudu-CR] Avoid calling Schema::find column() once per RowBlock in columnar serialization

2020-04-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15678 ) Change subject: Avoid calling Schema::find_column() once per RowBlock in columnar serialization .. Avoid calling

[kudu-CR](branch-1.12.x) Bump version to 1.12.0 (non-SNAPSHOT)

2020-04-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15742 ) Change subject: Bump version to 1.12.0 (non-SNAPSHOT) .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.12.x) [examples] use org.apache.kudu packages v1.12.0

2020-04-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15743 ) Change subject: [examples] use org.apache.kudu packages v1.12.0 .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] mini-cluster: exclude libpcre for license check

2020-04-15 Thread Hao Hao (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15738 to look at the new patch set (#2). Change subject: mini-cluster: exclude libpcre for license check

[kudu-CR] mini-cluster: exclude libpcre for license check

2020-04-15 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15738 ) Change subject: mini-cluster: exclude libpcre for license check .. Patch Set 1: (1 comment)

[kudu-CR] Avoid calling Schema::find column() once per RowBlock in columnar serialization

2020-04-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15678 ) Change subject: Avoid calling Schema::find_column() once per RowBlock in columnar serialization .. Patch Set 3: Verified+1 (2

[kudu-CR] columnar serialization: avoid preallocating 8MB per column

2020-04-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15679 ) Change subject: columnar_serialization: avoid preallocating 8MB per column .. columnar_serialization: avoid preallocating 8MB

[kudu-CR] Avoid calling Schema::find column() once per RowBlock in columnar serialization

2020-04-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: Avoid calling Schema::find_column() once per RowBlock in columnar serialization .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit

[kudu-CR](branch-1.12.x) [examples] use org.apache.kudu packages v1.12.0

2020-04-15 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15743 Change subject: [examples] use org.apache.kudu packages v1.12.0 .. [examples] use org.apache.kudu packages v1.12.0 Change-Id:

[kudu-CR](branch-1.12.x) Bump version to 1.12.0 (non-SNAPSHOT)

2020-04-15 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15742 Change subject: Bump version to 1.12.0 (non-SNAPSHOT) .. Bump version to 1.12.0 (non-SNAPSHOT) Change-Id:

[kudu-CR] [cfile] Add EncodingTraits to remove boiler plate code in type encodings.cc

2020-04-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15722 ) Change subject: [cfile] Add EncodingTraits to remove boiler plate code in type_encodings.cc .. Patch Set 3: Code-Review+2 (1

[kudu-CR] mini-cluster: exclude libpcre for license check

2020-04-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15738 ) Change subject: mini-cluster: exclude libpcre for license check .. Patch Set 1: (1 comment)

[kudu-CR](branch-1.12.x) Revert "[catalog manager] cache masters' addresses"

2020-04-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15739 ) Change subject: Revert "[catalog manager] cache masters' addresses" .. Revert "[catalog manager] cache masters' addresses"

[kudu-CR](branch-1.12.x) Revert "[catalog manager] reduce contention in ScopedLeaderSharedLock"

2020-04-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15741 ) Change subject: Revert "[catalog_manager] reduce contention in ScopedLeaderSharedLock" .. Revert "[catalog_manager] reduce

[kudu-CR](branch-1.12.x) Revert "[common] update on HostPortFromPB()/HostPortToPB()"

2020-04-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15740 ) Change subject: Revert "[common] update on HostPortFromPB()/HostPortToPB()" .. Patch Set 1: Verified+1 -- To view, visit

[kudu-CR](branch-1.12.x) Revert "[catalog manager] cache masters' addresses"

2020-04-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15739 ) Change subject: Revert "[catalog manager] cache masters' addresses" .. Patch Set 1: Verified+1 -- To view, visit

[kudu-CR](branch-1.12.x) Revert "[common] update on HostPortFromPB()/HostPortToPB()"

2020-04-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15740 ) Change subject: Revert "[common] update on HostPortFromPB()/HostPortToPB()" .. Revert "[common] update on

[kudu-CR] mini-cluster: exclude libpcre for license check

2020-04-15 Thread Hao Hao (Code Review)
Hao Hao has removed a vote on this change. Change subject: mini-cluster: exclude libpcre for license check .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15738 To unsubscribe,

[kudu-CR] columnar serialization: avoid preallocating 8MB per column

2020-04-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15679 ) Change subject: columnar_serialization: avoid preallocating 8MB per column .. Patch Set 3: (2 comments)

[kudu-CR] mini-cluster: exclude libpcre for license check

2020-04-15 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15738 ) Change subject: mini-cluster: exclude libpcre for license check .. Patch Set 1: Verified+1 Unrelated flaky test. -- To view, visit

[kudu-CR] client/tserver: add support for connecting over unix domain sockets

2020-04-15 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Mike Percy, Andrew Wong, Kudu Jenkins, Andrew Wong, Grant Henke, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15701 to look at the new patch set (#5). Change subject: client/tserver: add support for connecting over unix

[kudu-CR] Add basic support for UNIX domain sockets

2020-04-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15691 ) Change subject: Add basic support for UNIX domain sockets .. Patch Set 9: Code-Review+2 Forwarding Andrew's +2 -- To view, visit

[kudu-CR] columnar serialization: avoid preallocating 8MB per column

2020-04-15 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15679 ) Change subject: columnar_serialization: avoid preallocating 8MB per column .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] Avoid calling Schema::find column() once per RowBlock in columnar serialization

2020-04-15 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15678 to look at the new patch set (#2). Change subject: Avoid calling Schema::find_column() once per RowBlock in columnar serialization

[kudu-CR] columnar serialization: avoid preallocating 8MB per column

2020-04-15 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Andrew Wong, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15679 to look at the new patch set (#3). Change subject: columnar_serialization: avoid preallocating 8MB per column

[kudu-CR] mini-cluster: exclude libpcre for license check

2020-04-15 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15738 ) Change subject: mini-cluster: exclude libpcre for license check .. Patch Set 1: (1 comment)

[kudu-CR] Avoid calling Schema::find column() once per RowBlock in columnar serialization

2020-04-15 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15678 ) Change subject: Avoid calling Schema::find_column() once per RowBlock in columnar serialization .. Patch Set 3: Code-Review+2 -- To

[kudu-CR] Avoid calling Schema::find column() once per RowBlock in columnar serialization

2020-04-15 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15678 to look at the new patch set (#3). Change subject: Avoid calling Schema::find_column() once per RowBlock in columnar serialization

[kudu-CR] mini-cluster: exclude libpcre for license check

2020-04-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15738 ) Change subject: mini-cluster: exclude libpcre for license check .. Patch Set 1: (1 comment)

[kudu-CR] Avoid calling Schema::find column() once per RowBlock in columnar serialization

2020-04-15 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15678 ) Change subject: Avoid calling Schema::find_column() once per RowBlock in columnar serialization .. Patch Set 2: Code-Review+2 (1

[kudu-CR](branch-1.12.x) Revert "[catalog manager] cache masters' addresses"

2020-04-15 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15739 ) Change subject: Revert "[catalog manager] cache masters' addresses" .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.12.x) Revert "[common] update on HostPortFromPB()/HostPortToPB()"

2020-04-15 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15740 ) Change subject: Revert "[common] update on HostPortFromPB()/HostPortToPB()" .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.12.x) Revert "[catalog manager] reduce contention in ScopedLeaderSharedLock"

2020-04-15 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15741 ) Change subject: Revert "[catalog_manager] reduce contention in ScopedLeaderSharedLock" .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] Add basic support for UNIX domain sockets

2020-04-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15691 ) Change subject: Add basic support for UNIX domain sockets .. Add basic support for UNIX domain sockets This adds support to

[kudu-CR](branch-1.12.x) Revert "[catalog manager] cache masters' addresses"

2020-04-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15739 Change subject: Revert "[catalog manager] cache masters' addresses" .. Revert "[catalog manager] cache masters' addresses" This

[kudu-CR](branch-1.12.x) Revert "[catalog manager] reduce contention in ScopedLeaderSharedLock"

2020-04-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15741 Change subject: Revert "[catalog_manager] reduce contention in ScopedLeaderSharedLock" .. Revert "[catalog_manager] reduce contention

[kudu-CR](branch-1.12.x) Revert "[common] update on HostPortFromPB()/HostPortToPB()"

2020-04-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15740 Change subject: Revert "[common] update on HostPortFromPB()/HostPortToPB()" .. Revert "[common] update on

[kudu-CR] mini-cluster: exclude libpcre for license check

2020-04-15 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15738 Change subject: mini-cluster: exclude libpcre for license check .. mini-cluster: exclude libpcre for license check While building mini

[kudu-CR](branch-1.12.x) WIP [docs] Kudu 1.12 release notes draft

2020-04-15 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 ) Change subject: WIP [docs] Kudu 1.12 release notes draft .. Patch Set 5: (1 comment)

[kudu-CR] [cfile] Add EncodingTraits to remove boiler plate code in type encodings.cc

2020-04-15 Thread Bankim Bhavsar (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15722 to look at the new patch set (#3). Change subject: [cfile] Add EncodingTraits to remove boiler plate code in type_encodings.cc

[kudu-CR] [cfile] Add SimpleEncodingTraits to remove boiler plate code in type encodings.cc

2020-04-15 Thread Bankim Bhavsar (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15722 to look at the new patch set (#2). Change subject: [cfile] Add SimpleEncodingTraits to remove boiler plate code in type_encodings.cc

[kudu-CR] [cfile] Add SimpleEncodingTraits to remove boiler plate code in type encodings.cc

2020-04-15 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15722 ) Change subject: [cfile] Add SimpleEncodingTraits to remove boiler plate code in type_encodings.cc .. Patch Set 1: (3 comments)

[kudu-CR](branch-1.12.x) WIP [docs] Kudu 1.12 release notes draft

2020-04-15 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 ) Change subject: WIP [docs] Kudu 1.12 release notes draft .. Patch Set 5: (8 comments) Just noting some improvements/fixes that should

[kudu-CR](branch-1.12.x) WIP [docs] Kudu 1.12 release notes draft

2020-04-15 Thread Greg Solovyev (Code Review)
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 ) Change subject: WIP [docs] Kudu 1.12 release notes draft .. Patch Set 5: (3 comments)

[kudu-CR] Add basic support for UNIX domain sockets

2020-04-15 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15691 ) Change subject: Add basic support for UNIX domain sockets .. Patch Set 9: Code-Review+1 -- To view, visit

[kudu-CR] Add basic support for UNIX domain sockets

2020-04-15 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Mike Percy, Andrew Wong, Kudu Jenkins, Andrew Wong, Grant Henke, Volodymyr Verovkin, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15691 to look at the new patch set (#9). Change subject: Add basic support for UNIX domain

[kudu-CR] client/tserver: add support for connecting over unix domain sockets

2020-04-15 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Andrew Wong, Kudu Jenkins, Andrew Wong, Grant Henke, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15701 to look at the new patch set (#4). Change subject: client/tserver: add support for connecting over unix domain

[kudu-CR] client/tserver: add support for connecting over unix domain sockets

2020-04-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15701 ) Change subject: client/tserver: add support for connecting over unix domain sockets .. Patch Set 3: (9 comments) > Patch Set 3: > >

[kudu-CR] Add basic support for UNIX domain sockets

2020-04-15 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Mike Percy, Andrew Wong, Kudu Jenkins, Andrew Wong, Grant Henke, Volodymyr Verovkin, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15691 to look at the new patch set (#8). Change subject: Add basic support for UNIX domain

[kudu-CR] Add basic support for UNIX domain sockets

2020-04-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15691 ) Change subject: Add basic support for UNIX domain sockets .. Patch Set 7: (10 comments)

[kudu-CR](branch-1.12.x) WIP [docs] Kudu 1.12 release notes draft

2020-04-15 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 ) Change subject: WIP [docs] Kudu 1.12 release notes draft .. Patch Set 5: (1 comment)

[kudu-CR](branch-1.12.x) WIP [docs] Kudu 1.12 release notes draft

2020-04-15 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 ) Change subject: WIP [docs] Kudu 1.12 release notes draft .. Patch Set 5: (2 comments)