[kudu-CR] KUDU-3090: Native owner metadata in Kudu

2020-07-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15841 ) Change subject: KUDU-3090: Native owner metadata in Kudu .. Patch Set 10: (10 comments)

[kudu-CR] Upgrade C++ to protobuf 3.12

2020-07-06 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16135 to look at the new patch set (#4). Change subject: Upgrade C++ to protobuf 3.12

[kudu-CR] Use protobuf arenas for CommitMsgs

2020-07-06 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/16147 to review the following change. Change subject: Use protobuf arenas for CommitMsgs .. Use protobuf arenas for

[kudu-CR] Enable arenas for RPC request and response

2020-07-06 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16136 to look at the new patch set (#4). Change subject: Enable arenas for RPC request and response

[kudu-CR] Upgrade C++ to protobuf 3.12

2020-07-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16135 ) Change subject: Upgrade C++ to protobuf 3.12 .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-3090: Native owner metadata in Kudu

2020-07-06 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15841 ) Change subject: KUDU-3090: Native owner metadata in Kudu .. Patch Set 10: I think there are 2 valid options. 1. leave the check and

[kudu-CR] [docs][docker] KUDU-3159 Fix missing devtoolset3 package on el6

2020-07-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16114 ) Change subject: [docs][docker] KUDU-3159 Fix missing devtoolset3 package on el6 .. Patch Set 2: (3 comments)

[kudu-CR] test: fix flakiness of TestDeletedRowsetGc

2020-07-06 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16145 ) Change subject: test: fix flakiness of TestDeletedRowsetGc .. test: fix flakiness of TestDeletedRowsetGc The test would

[kudu-CR] test: fix flakiness of TestDeletedRowsetGc

2020-07-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16145 ) Change subject: test: fix flakiness of TestDeletedRowsetGc .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] test: fix flakiness of TestDeletedRowsetGc

2020-07-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16145 ) Change subject: test: fix flakiness of TestDeletedRowsetGc .. Patch Set 2: (1 comment)

[kudu-CR] test: fix flakiness of TestDeletedRowsetGc

2020-07-06 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16145 to look at the new patch set (#2). Change subject: test: fix flakiness of TestDeletedRowsetGc

[kudu-CR] test: fix flakiness of TestDeletedRowsetGc

2020-07-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16145 ) Change subject: test: fix flakiness of TestDeletedRowsetGc .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] test: fix flakiness of TestDeletedRowsetGc

2020-07-06 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16145 ) Change subject: test: fix flakiness of TestDeletedRowsetGc .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] test: fix flakiness of TestDeletedRowsetGc

2020-07-06 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16145 Change subject: test: fix flakiness of TestDeletedRowsetGc .. test: fix flakiness of TestDeletedRowsetGc The test would sometimes fail

[kudu-CR] KUDU-3090: Native owner metadata in Kudu

2020-07-06 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15841 ) Change subject: KUDU-3090: Native owner metadata in Kudu .. Patch Set 10: > Patch Set 10: > > The test failures look legitimate: >

[kudu-CR] KUDU-3090 Ownership support in Java client

2020-07-06 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16125 ) Change subject: KUDU-3090 Ownership support in Java client .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-3090 Support backing up ownership info

2020-07-06 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16126 ) Change subject: KUDU-3090 Support backing up ownership info .. Patch Set 6: I think it makes sense to add the flag as an optional

[kudu-CR] KUDU-3090: Native owner metadata in Kudu

2020-07-06 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15841 ) Change subject: KUDU-3090: Native owner metadata in Kudu .. Patch Set 10: The test failures look legitimate: Invalid argument: Error

[kudu-CR] KUDU-3090: Native owner metadata in Kudu

2020-07-06 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15841 ) Change subject: KUDU-3090: Native owner metadata in Kudu .. Patch Set 10: Code-Review+1 (1 comment)

[kudu-CR] KUDU-3090 Support backing up ownership info

2020-07-06 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16126 ) Change subject: KUDU-3090 Support backing up ownership info .. Patch Set 6: > Patch Set 4: Code-Review+2 > > Are you planning to add a

[kudu-CR] KUDU-3090 Ownership support in Java client

2020-07-06 Thread Attila Bukor (Code Review)
Hello Kudu Jenkins, Andrew Wong, Greg Solovyev, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16125 to look at the new patch set (#6). Change subject: KUDU-3090 Ownership support in Java client

[kudu-CR] KUDU-3090 Ownership support in Java client

2020-07-06 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16125 ) Change subject: KUDU-3090 Ownership support in Java client .. Patch Set 6: (2 comments)

[kudu-CR] KUDU-3090: Native owner metadata in Kudu

2020-07-06 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15841 ) Change subject: KUDU-3090: Native owner metadata in Kudu .. Patch Set 10: (1 comment) > Patch Set 9: > > (1 comment) > > Should we

[kudu-CR] KUDU-3090: Native owner metadata in Kudu

2020-07-06 Thread Attila Bukor (Code Review)
Attila Bukor has uploaded a new patch set (#10) to the change originally created by Grant Henke. ( http://gerrit.cloudera.org:8080/15841 ) Change subject: KUDU-3090: Native owner metadata in Kudu .. KUDU-3090: Native owner

[kudu-CR] KUDU-3090 Ownership support in Java client

2020-07-06 Thread Attila Bukor (Code Review)
Hello Kudu Jenkins, Andrew Wong, Greg Solovyev, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16125 to look at the new patch set (#5). Change subject: KUDU-3090 Ownership support in Java client

[kudu-CR] KUDU-3090 Support backing up ownership info

2020-07-06 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16126 ) Change subject: KUDU-3090 Support backing up ownership info .. Patch Set 4: Code-Review+2 Are you planning to add a flag to the restore

[kudu-CR] KUDU-3090 Ownership support in Java client

2020-07-06 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16125 ) Change subject: KUDU-3090 Ownership support in Java client .. Patch Set 4: (2 comments)

[kudu-CR] KUDU-3090: Native owner metadata in Kudu

2020-07-06 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15841 ) Change subject: KUDU-3090: Native owner metadata in Kudu .. Patch Set 9: (1 comment) Should we constrain the maximum owner length to

[kudu-CR] [maintenance] use workload statistics to scale perf improvement

2020-07-06 Thread Yifan Zhang (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15995 to look at the new patch set (#5). Change subject: [maintenance] use workload statistics to scale perf_improvement