[kudu-CR] KUDU-2612 proper handling of transient errors from TxnManager

2020-11-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16783 Change subject: KUDU-2612 proper handling of transient errors from TxnManager .. KUDU-2612 proper handling of transient errors from

[kudu-CR] KUDU-3214 Parallelize DownloadWALs in tablet copy operation

2020-11-24 Thread wangning (Code Review)
wangning has posted comments on this change. ( http://gerrit.cloudera.org:8080/16726 ) Change subject: KUDU-3214 Parallelize DownloadWALs in tablet copy operation .. Patch Set 12: Can I get some help with the failed ASAN

[kudu-CR] KUDU-3108: fix invalid memory accesses in merge iterator

2020-11-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16777 ) Change subject: KUDU-3108: fix invalid memory accesses in merge iterator .. Patch Set 6: (1 comment)

[kudu-CR] KUDU-3108: fix invalid memory accesses in merge iterator

2020-11-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16777 ) Change subject: KUDU-3108: fix invalid memory accesses in merge iterator .. Patch Set 6: I seem to recall that adar had a simpler

[kudu-CR] KUDU-3108: fix invalid memory accesses in merge iterator

2020-11-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16777 ) Change subject: KUDU-3108: fix invalid memory accesses in merge iterator .. Patch Set 6: Code-Review+2 Looks good to me. I guess it

[kudu-CR] KUDU-3108: fix invalid memory accesses in merge iterator

2020-11-24 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16777 ) Change subject: KUDU-3108: fix invalid memory accesses in merge iterator .. Patch Set 6: (3 comments)

[kudu-CR] KUDU-3108: fix invalid memory accesses in merge iterator

2020-11-24 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Lieber-Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16777 to look at the new patch set (#6). Change subject: KUDU-3108: fix invalid memory accesses in merge iterator

[kudu-CR] KUDU-3214 Parallelize DownloadWALs in tablet copy operation

2020-11-24 Thread wangning (Code Review)
wangning has posted comments on this change. ( http://gerrit.cloudera.org:8080/16726 ) Change subject: KUDU-3214 Parallelize DownloadWALs in tablet copy operation .. Patch Set 9: (1 comment)

[kudu-CR] KUDU-3214 Parallelize DownloadWALs in tablet copy operation

2020-11-24 Thread wangning (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16726 to look at the new patch set (#12). Change subject: KUDU-3214 Parallelize DownloadWALs in tablet copy operation

[kudu-CR] KUDU-3108: fix invalid memory accesses in merge iterator

2020-11-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16777 ) Change subject: KUDU-3108: fix invalid memory accesses in merge iterator .. Patch Set 5: Code-Review+1 (3 comments)

[kudu-CR] KUDU-3108: fix invalid memory accesses in merge iterator

2020-11-24 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16777 ) Change subject: KUDU-3108: fix invalid memory accesses in merge iterator .. Patch Set 4: (8 comments)

[kudu-CR] KUDU-3108: fix invalid memory accesses in merge iterator

2020-11-24 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Lieber-Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16777 to look at the new patch set (#4). Change subject: KUDU-3108: fix invalid memory accesses in merge iterator

[kudu-CR] [partitioning] KUDU-2671: Support for range specific HashSchemas.

2020-11-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16596 ) Change subject: [partitioning] KUDU-2671: Support for range specific HashSchemas. .. Patch Set 8: (4 comments)

[kudu-CR] [partitioning] KUDU-2671: Support for range specific HashSchemas.

2020-11-24 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16596 ) Change subject: [partitioning] KUDU-2671: Support for range specific HashSchemas. .. Patch Set 8: The ASAN errors will be alleviated

[kudu-CR] [partitioning] KUDU-2671: Support for range specific HashSchemas.

2020-11-24 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16596 ) Change subject: [partitioning] KUDU-2671: Support for range specific HashSchemas. .. Patch Set 8: Code-Review+1 (4 comments)

[kudu-CR] [partitioning] KUDU-2671: Support for range specific HashSchemas.

2020-11-24 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16596 ) Change subject: [partitioning] KUDU-2671: Support for range specific HashSchemas. .. Patch Set 8: > Uploaded patch set 8. Refactored

[kudu-CR] [partitioning] KUDU-2671: Support for range specific HashSchemas.

2020-11-24 Thread Mahesh Reddy (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16596 to look at the new patch set (#8). Change subject: [partitioning] KUDU-2671: Support for range specific

[kudu-CR] WIP [partitioning] KUDU-2671: Support for range specific HashSchemas.

2020-11-24 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16596 ) Change subject: WIP [partitioning] KUDU-2671: Support for range specific HashSchemas. .. Patch Set 7: (6 comments)

[kudu-CR] KUDU-3108: fix invalid memory accesses in merge iterator

2020-11-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16777 ) Change subject: KUDU-3108: fix invalid memory accesses in merge iterator .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-3108: fix invalid memory accesses in merge iterator

2020-11-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16777 ) Change subject: KUDU-3108: fix invalid memory accesses in merge iterator .. Patch Set 3: (1 comment)

[kudu-CR] WIP KUDU-2612 keep-alive txn heartbeating for C++ client

2020-11-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16779 ) Change subject: WIP KUDU-2612 keep-alive txn heartbeating for C++ client .. Patch Set 2: > I like that the heartbeating is abstracted

[kudu-CR] KUDU-3108: fix invalid memory accesses in merge iterator

2020-11-24 Thread Adar Lieber-Dembo (Code Review)
Adar Lieber-Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/16777 ) Change subject: KUDU-3108: fix invalid memory accesses in merge iterator .. Patch Set 3: (6 comments) Good find, thanks for this

[kudu-CR] Explictly use boost::make optional

2020-11-24 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16772 ) Change subject: Explictly use boost::make_optional .. Explictly use boost::make_optional This patch is in preparation for

[kudu-CR] Explictly use boost::make optional

2020-11-24 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16772 ) Change subject: Explictly use boost::make_optional .. Patch Set 2: Code-Review+2 Carrying Bankim's +2 through the rebase. -- To view,

[kudu-CR] [build] Support and require C++17

2020-11-24 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16776 ) Change subject: [build] Support and require C++17 .. Patch Set 6: I ran dist_tests from Centos 7 with devtoolset-8 here:

[kudu-CR] KUDU-2700: Add a LSAN suppression

2020-11-24 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16781 ) Change subject: KUDU-2700: Add a LSAN suppression .. KUDU-2700: Add a LSAN suppression OpenSSL 1.1 has a leak in libcrypto.so

[kudu-CR] KUDU-2700: Add a LSAN suppression

2020-11-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16781 ) Change subject: KUDU-2700: Add a LSAN suppression .. Patch Set 2: Code-Review+2 (1 comment)

[kudu-CR] KUDU-2700: Add a LSAN suppression

2020-11-24 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16781 ) Change subject: KUDU-2700: Add a LSAN suppression .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2700: Add a LSAN suppression

2020-11-24 Thread Grant Henke (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16781 to look at the new patch set (#2). Change subject: KUDU-2700: Add a LSAN suppression .. KUDU-2700:

[kudu-CR] KUDU-2700: Add a LSAN suppression

2020-11-24 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16781 ) Change subject: KUDU-2700: Add a LSAN suppression .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2700: Add a LSAN suppression

2020-11-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16781 ) Change subject: KUDU-2700: Add a LSAN suppression .. Patch Set 1: Code-Review+1 (1 comment)

[kudu-CR] [build] Support and require C++17

2020-11-24 Thread Grant Henke (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16776 to look at the new patch set (#6). Change subject: [build] Support and require C++17 .. [build] Support

[kudu-CR] WIP KUDU-2612 keep-alive txn heartbeating for C++ client

2020-11-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16779 ) Change subject: WIP KUDU-2612 keep-alive txn heartbeating for C++ client .. Patch Set 2: I like that the heartbeating is abstracted

[kudu-CR] [build] Support and require C++17

2020-11-24 Thread Grant Henke (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16776 to look at the new patch set (#5). Change subject: [build] Support and require C++17 .. [build] Support

[kudu-CR] KUDU-2700: Add a LSAN suppression

2020-11-24 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16781 Change subject: KUDU-2700: Add a LSAN suppression .. KUDU-2700: Add a LSAN suppression OpenSSL 1.1 has a leak in libcrypto.so when

[kudu-CR] KUDU-3214 Parallelize DownloadWALs in tablet copy operation

2020-11-24 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16726 ) Change subject: KUDU-3214 Parallelize DownloadWALs in tablet copy operation .. Patch Set 9: (1 comment)

[kudu-CR] KUDU-3214 Parallelize DownloadWALs in tablet copy operation

2020-11-24 Thread wangning (Code Review)
wangning has posted comments on this change. ( http://gerrit.cloudera.org:8080/16726 ) Change subject: KUDU-3214 Parallelize DownloadWALs in tablet copy operation .. Patch Set 9: (1 comment)

[kudu-CR] KUDU-3214 Parallelize DownloadWALs in tablet copy operation

2020-11-24 Thread wangning (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16726 to look at the new patch set (#11). Change subject: KUDU-3214 Parallelize DownloadWALs in tablet copy operation

[kudu-CR] KUDU-3214 Parallelize DownloadWALs in tablet copy operation

2020-11-24 Thread wangning (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16726 to look at the new patch set (#10). Change subject: KUDU-3214 Parallelize DownloadWALs in tablet copy operation

[kudu-CR] KUDU-3214 Parallelize DownloadWALs in tablet copy operation

2020-11-24 Thread wangning (Code Review)
wangning has posted comments on this change. ( http://gerrit.cloudera.org:8080/16726 ) Change subject: KUDU-3214 Parallelize DownloadWALs in tablet copy operation .. Patch Set 8: (4 comments)

[kudu-CR] KUDU-3214 Parallelize DownloadWALs in tablet copy operation

2020-11-24 Thread wangning (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16726 to look at the new patch set (#9). Change subject: KUDU-3214 Parallelize DownloadWALs in tablet copy operation

[kudu-CR] KUDU-2612 keep-alive tracking for transactions

2020-11-24 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16729 ) Change subject: KUDU-2612 keep-alive tracking for transactions .. Patch Set 5: (6 comments)