[kudu-CR] [maintenance] use workload statistics to scale perf score of flushes/compactions

2020-07-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15995 ) Change subject: [maintenance] use workload statistics to scale perf score of flushes/compactions .. Patch Set 12: (4 comments) Sorry

[kudu-CR] KUDU-2612 p6: add coordination calls to system client

2020-07-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16194 ) Change subject: KUDU-2612 p6: add coordination calls to system client .. Patch Set 6: (7 comments) mostly nits

[kudu-CR] Add .clang-format file

2020-07-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16260 ) Change subject: Add .clang-format file .. Patch Set 1: (1 comment)

[kudu-CR] [loadgen] Separate flags to insert random values for PK and non-PK cols

2020-07-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16253 ) Change subject: [loadgen] Separate flags to insert random values for PK and non-PK cols .. Patch Set 5: Code-Review+2 (2 comments)

[kudu-CR] [loadgen] Separate flags to insert random values for PK and non-PK cols

2020-07-30 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16253 ) Change subject: [loadgen] Separate flags to insert random values for PK and non-PK cols .. Patch Set 5: (3 comments)

[kudu-CR] [loadgen] Separate flags to insert random values for PK and non-PK cols

2020-07-30 Thread Bankim Bhavsar (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16253 to look at the new patch set (#5). Change subject: [loadgen] Separate flags to insert random values for PK and non-PK cols

[kudu-CR] Remove last vestiges of gscoped ptr

2020-07-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16261 ) Change subject: Remove last vestiges of gscoped_ptr .. Remove last vestiges of gscoped_ptr Adar did most of the work here a

[kudu-CR] [loadgen] Add separate flags to populate random values for PK and non-PK cols

2020-07-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16253 ) Change subject: [loadgen] Add separate flags to populate random values for PK and non-PK cols .. Patch Set 4: (3 comments)

[kudu-CR] Remove last vestiges of gscoped ptr

2020-07-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16261 ) Change subject: Remove last vestiges of gscoped_ptr .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] Remove last vestiges of gscoped ptr

2020-07-30 Thread Adar Lieber-Dembo (Code Review)
Adar Lieber-Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/16261 ) Change subject: Remove last vestiges of gscoped_ptr .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] Add .clang-format file

2020-07-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16260 ) Change subject: Add .clang-format file .. Patch Set 1: (2 comments)

[kudu-CR] Optimize GetTableLocations for better arena use

2020-07-30 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16137 to look at the new patch set (#12). Change subject: Optimize GetTableLocations for better arena use

[kudu-CR] [rpc] per-method counter of dropped RPC requests

2020-07-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16250 ) Change subject: [rpc] per-method counter of dropped RPC requests .. [rpc] per-method counter of dropped RPC requests This

[kudu-CR] [rpc] per-method counter of dropped RPC requests

2020-07-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16250 ) Change subject: [rpc] per-method counter of dropped RPC requests .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] [loadgen] Add separate flags to populate random values for PK and non-PK cols

2020-07-30 Thread Bankim Bhavsar (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16253 to look at the new patch set (#4). Change subject: [loadgen] Add separate flags to populate random values for PK and non-PK cols

[kudu-CR] [tool] Add option in loadgen to populate random values only for non-pk columns

2020-07-30 Thread Bankim Bhavsar (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16253 to look at the new patch set (#3). Change subject: [tool] Add option in loadgen to populate random values only for non-pk columns

[kudu-CR] [tool] Add option in loadgen to populate random values only for non-pk columns

2020-07-30 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16253 ) Change subject: [tool] Add option in loadgen to populate random values only for non-pk columns .. Patch Set 2: (3 comments)

[kudu-CR](gh-pages) site: add bui...@kudu.apache.org

2020-07-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16262 ) Change subject: site: add bui...@kudu.apache.org .. Patch Set 1: Rendered version can be found here:

[kudu-CR](gh-pages) site: add bui...@kudu.apache.org

2020-07-30 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16262 Change subject: site: add bui...@kudu.apache.org .. site: add bui...@kudu.apache.org Along the way I removed some "incubating" mentions

[kudu-CR] Remove last vestiges of gscoped ptr

2020-07-30 Thread Todd Lipcon (Code Review)
Hello Adar Lieber-Dembo, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/16261 to review the following change. Change subject: Remove last vestiges of gscoped_ptr .. Remove

[kudu-CR] Add .clang-format file

2020-07-30 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/16260 to review the following change. Change subject: Add .clang-format file .. Add .clang-format file

[kudu-CR] Optimize GetTableLocations for better arena use

2020-07-30 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16137 to look at the new patch set (#11). Change subject: Optimize GetTableLocations for better arena use

[kudu-CR](gh-pages) Update Jekyll and site-tool

2020-07-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16256 ) Change subject: Update Jekyll and site-tool .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/16256/4/Gemfile File

[kudu-CR](gh-pages) Update Jekyll and site-tool

2020-07-30 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16256 ) Change subject: Update Jekyll and site-tool .. Patch Set 4: Code-Review+1 (1 comment) Thanks for fixing this, Attila!

[kudu-CR](gh-pages) Update Jekyll and site-tool

2020-07-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16256 ) Change subject: Update Jekyll and site-tool .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/16256 To

[kudu-CR] KUDU-2612 p6: add coordination calls to system client

2020-07-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16194 ) Change subject: KUDU-2612 p6: add coordination calls to system client .. Patch Set 6: Verified+1 Unrelated failure of

[kudu-CR] KUDU-2612 p6: add coordination calls to system client

2020-07-30 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: KUDU-2612 p6: add coordination calls to system client .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/16194 To

[kudu-CR](gh-pages) Update Jekyll and site-tool

2020-07-30 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16256 ) Change subject: Update Jekyll and site-tool .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/16256 To

[kudu-CR](gh-pages) Update Jekyll and site-tool

2020-07-30 Thread Attila Bukor (Code Review)
Hello Alexey Serbin, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16256 to look at the new patch set (#4). Change subject: Update Jekyll and site-tool .. Update Jekyll and

[kudu-CR](gh-pages) Update Jekyll and site-tool

2020-07-30 Thread Attila Bukor (Code Review)
Hello Alexey Serbin, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16256 to look at the new patch set (#3). Change subject: Update Jekyll and site-tool .. Update Jekyll and

[kudu-CR](gh-pages) Update Jekyll and site-tool

2020-07-30 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16256 ) Change subject: Update Jekyll and site-tool .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/16256/1/site_tool File

[kudu-CR](gh-pages) Update Jekyll and site-tool

2020-07-30 Thread Attila Bukor (Code Review)
Hello Alexey Serbin, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16256 to look at the new patch set (#2). Change subject: Update Jekyll and site-tool .. Update Jekyll and