[kudu-CR] KUDU-3184:Fix GetFQDN() when canonical name returns null [net]

2020-08-25 Thread Mahesh Reddy (Code Review)
Hello Tidy Bot, Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16364 to look at the new patch set (#3). Change subject: KUDU-3184:Fix GetFQDN() when canonical name returns null [net]

[kudu-CR] KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena

2020-08-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15802 ) Change subject: KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena .. KUDU-2844 (3/3): avoid copying

[kudu-CR] KUDU-1587 part 1: load meter for ThreadPool

2020-08-25 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16332 to look at the new patch set (#10). Change subject: KUDU-1587 part 1: load meter for ThreadPool

[kudu-CR] KUDU-3184:Fix GetFQDN() when canonical name returns null [net]

2020-08-25 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16364 ) Change subject: KUDU-3184:Fix GetFQDN() when canonical name returns null [net] .. Patch Set 2: (3 comments)

[kudu-CR] KUDU-3184:Fix GetFQDN() when canonical name returns null [net]

2020-08-25 Thread Mahesh Reddy (Code Review)
Hello Tidy Bot, Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16364 to look at the new patch set (#2). Change subject: KUDU-3184:Fix GetFQDN() when canonical name returns null [net]

[kudu-CR] [build] Adjust JAVA HOME candidates

2020-08-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16354 ) Change subject: [build] Adjust JAVA_HOME candidates .. Patch Set 1: (1 comment)

[kudu-CR] [build] Adjust JAVA HOME candidates

2020-08-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16354 ) Change subject: [build] Adjust JAVA_HOME candidates .. Patch Set 1: Code-Review+1 (1 comment)

[kudu-CR] KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena

2020-08-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15802 ) Change subject: KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena .. Patch Set 7: Code-Review+2 -- To view, visit

[kudu-CR] [docker] Support building and pushing multi-arch images

2020-08-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16361 ) Change subject: [docker] Support building and pushing multi-arch images .. Patch Set 1: (1 comment)

[kudu-CR] WIP: support keys not at the front of a schema

2020-08-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15748 ) Change subject: WIP: support keys not at the front of a schema .. Patch Set 2: I think this needs some more fixup to have better test

[kudu-CR] KUDU-3184: Added null check

2020-08-25 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16364 ) Change subject: KUDU-3184: Added null check .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/16364/1//COMMIT_MSG

[kudu-CR] WIP: support keys not at the front of a schema

2020-08-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/15748 ) Change subject: WIP: support keys not at the front of a schema .. WIP: support keys not at the front of a schema Change-Id:

[kudu-CR] KUDU-3184: Added null check

2020-08-25 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16364 Change subject: KUDU-3184: Added null check .. KUDU-3184: Added null check Issue occurred if hostname didn't have a separator (ex. a

[kudu-CR] [docker] Support building and pushing multi-arch images

2020-08-25 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16361 ) Change subject: [docker] Support building and pushing multi-arch images .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] Add .clang-format file

2020-08-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16260 ) Change subject: Add .clang-format file .. Add .clang-format file This clang-format file seems to capture our existing style

[kudu-CR] Add .clang-format file

2020-08-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16260 ) Change subject: Add .clang-format file .. Patch Set 2: Verified+1 Not waiting for Jenkins since there's no code change here. -- To

[kudu-CR] Add .clang-format file

2020-08-25 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16260 ) Change subject: Add .clang-format file .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16260 To

[kudu-CR] [build] Adjust JAVA HOME candidates

2020-08-25 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16354 ) Change subject: [build] Adjust JAVA_HOME candidates .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] Add .clang-format file

2020-08-25 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16260 to look at the new patch set (#2). Change subject: Add .clang-format file

[kudu-CR] Add .clang-format file

2020-08-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16260 ) Change subject: Add .clang-format file .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/16260/1/docs/contributing.adoc

[kudu-CR] [docker] Generate all tags in a single build command

2020-08-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16298 ) Change subject: [docker] Generate all tags in a single build command .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena

2020-08-25 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Andrew Wong, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15802 to look at the new patch set (#7). Change subject: KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena

[kudu-CR] [build] Adjust JAVA HOME candidates

2020-08-25 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16354 ) Change subject: [build] Adjust JAVA_HOME candidates .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-1587 part 1: load meter for ThreadPool

2020-08-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16332 ) Change subject: KUDU-1587 part 1: load meter for ThreadPool .. Patch Set 8: (2 comments)

[kudu-CR] KUDU-1587 part 1: load meter for ThreadPool

2020-08-25 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16332 to look at the new patch set (#9). Change subject: KUDU-1587 part 1: load meter for ThreadPool

[kudu-CR] KUDU-1587 part 2: reject write ops if apply queue is overloaded

2020-08-25 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16343 ) Change subject: KUDU-1587 part 2: reject write ops if apply queue is overloaded .. Patch Set 6: (3 comments)

[kudu-CR] [tserver] add test to reproduce KUDU-1587 conditions

2020-08-25 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16312 ) Change subject: [tserver] add test to reproduce KUDU-1587 conditions .. Patch Set 5: Code-Review+1 -- To view, visit

[kudu-CR] [docker] Support building and pushing multi-arch images

2020-08-25 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16361 ) Change subject: [docker] Support building and pushing multi-arch images .. Patch Set 1: I will push sample images to my docker hub repo

[kudu-CR] [docker] Support building and pushing multi-arch images

2020-08-25 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16361 Change subject: [docker] Support building and pushing multi-arch images .. [docker] Support building and pushing multi-arch images This

[kudu-CR] KUDU-2612 p9: anchor participant ops in WAL

2020-08-25 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16358 to look at the new patch set (#3). Change subject: KUDU-2612 p9: anchor participant ops in WAL .. KUDU-2612 p9: