[GitHub] spark pull request: [SPARK-10412][SQL] report memory usage for tun...

2015-09-28 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/8931#issuecomment-143942004 jenkins test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10865][SPARK-10866][SQL]Fix bug of ceil...

2015-09-28 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/8933#issuecomment-143944099 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10688][ML][PySpark] Python API for AFTS...

2015-09-28 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/8926#discussion_r40635952 --- Diff: python/pyspark/ml/regression.py --- @@ -608,6 +609,141 @@ class GBTRegressionModel(TreeEnsembleModels): .. versionadded:: 1.4.0 """

[GitHub] spark pull request: [SPARK-10688][ML][PySpark] Python API for AFTS...

2015-09-28 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/8926#discussion_r40635977 --- Diff: python/pyspark/ml/regression.py --- @@ -608,6 +609,141 @@ class GBTRegressionModel(TreeEnsembleModels): .. versionadded:: 1.4.0 """

[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...

2015-09-28 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-143951236 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-10670] [ML] [Doc] add api reference for...

2015-09-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8901 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-10738][ML] Refactoring `Instance` out f...

2015-09-28 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8853#issuecomment-143951133 @dbtsai The main question would be where we should put `Instance`. I'm not sure `ml.feature` is a good place for it, though I don't have good alternatives. Another place

[GitHub] spark pull request: [SPARK-4122][STREAMING] Add a library that can...

2015-09-28 Thread harishreedharan
Github user harishreedharan commented on the pull request: https://github.com/apache/spark/pull/2994#issuecomment-143944627 I will get back to this one in a week or so --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-10852][PySpark][SQL] Override built-in ...

2015-09-28 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/8934 [SPARK-10852][PySpark][SQL] Override built-in methods for special column names JIRA: https://issues.apache.org/jira/browse/SPARK-10852 For few special columns such as `count` and `index`,

[GitHub] spark pull request: [SPARK-10688][ML][PySpark] Python API for AFTS...

2015-09-28 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/8926#discussion_r40636077 --- Diff: python/pyspark/ml/regression.py --- @@ -608,6 +609,141 @@ class GBTRegressionModel(TreeEnsembleModels): .. versionadded:: 1.4.0 """

[GitHub] spark pull request: [SPARK-10258] [DOCUMENTATION, ML] Adding Since...

2015-09-28 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8505#issuecomment-143951301 @martinbrown I think initially it was some Jenkins caching problem, then a flaky test. Let's try again. --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-10412][SQL] report memory usage for tun...

2015-09-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8931#issuecomment-143942865 [Test build #1823 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1823/consoleFull) for PR 8931 at commit

[GitHub] spark pull request: [SPARK-10412][SQL] report memory usage for tun...

2015-09-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8931#issuecomment-143945594 [Test build #1823 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1823/console) for PR 8931 at commit

[GitHub] spark pull request: [SPARK-10688][ML][PySpark] Python API for AFTS...

2015-09-28 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/8926#discussion_r40636024 --- Diff: python/pyspark/ml/regression.py --- @@ -608,6 +609,141 @@ class GBTRegressionModel(TreeEnsembleModels): .. versionadded:: 1.4.0 """

[GitHub] spark pull request: [SPARK-10688][ML][PySpark] Python API for AFTS...

2015-09-28 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/8926#discussion_r40636011 --- Diff: python/pyspark/ml/regression.py --- @@ -608,6 +609,141 @@ class GBTRegressionModel(TreeEnsembleModels): .. versionadded:: 1.4.0 """

[GitHub] spark pull request: [SPARK-9468][Yarn][Core] Avoid scheduling task...

2015-09-28 Thread jerryshao
Github user jerryshao commented on the pull request: https://github.com/apache/spark/pull/7786#issuecomment-143934782 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9741][SQL] Approximate Count Distinct u...

2015-09-28 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/8362#issuecomment-143945761 @yhuai can we make non-codegen path use tungsten aggregate as well? Otherwise we would need to maintain two entirely separate codepath. --- If your project is set up for

[GitHub] spark pull request: [SPARK-10079][SPARKR] Make 'column' and 'col' ...

2015-09-28 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/8864#discussion_r40635657 --- Diff: R/pkg/R/DataFrame.R --- @@ -946,15 +946,36 @@ setMethod("foreachPartition", ## SELECT

[GitHub] spark pull request: [SPARK-10670] [ML] [Doc] add api reference for...

2015-09-28 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8901#issuecomment-143950949 merged into master. thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-7021 Add JUnit output for Python tests

2015-09-28 Thread shaneknapp
Github user shaneknapp commented on the pull request: https://github.com/apache/spark/pull/8323#issuecomment-143935192 i'll take a look at the config tomorrow On Mon, Sep 28, 2015 at 6:02 PM, gliptak wrote: > >

[GitHub] spark pull request: SPARK-7021 Add JUnit output for Python tests

2015-09-28 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8323#issuecomment-143948538 @gliptak We use `**/target/test-reports/*.xml` on Jenkins to locate XML reports. So `target/surefire-reports` may not work. (@shaneknapp please correct me if I'm wrong.)

[GitHub] spark pull request: [SPARK-9384] [core] Easier setting of executor...

2015-09-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/7739#discussion_r40593338 --- Diff: core/src/main/scala/org/apache/spark/deploy/Client.scala --- @@ -67,8 +67,15 @@ private class ClientEndpoint( // people call

[GitHub] spark pull request: [SPARK-10807][SPARKR] Added as.data.frame as a...

2015-09-28 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/8908#issuecomment-143849747 @shivaram Thanks a lot for your comments! I have addressed them. -Oscar --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-09-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r40595711 --- Diff: core/src/main/scala/org/apache/spark/crypto/AesCtrCryptoCodec.scala --- @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-09-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r40595673 --- Diff: core/src/main/scala/org/apache/spark/crypto/AesCtrCryptoCodec.scala --- @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-09-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r40596221 --- Diff: core/src/main/scala/org/apache/spark/crypto/CipherSuite.scala --- @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-09-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r40596818 --- Diff: core/src/main/scala/org/apache/spark/crypto/CipherSuite.scala --- @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-09-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r40597441 --- Diff: core/src/main/scala/org/apache/spark/crypto/CryptoCodec.scala --- @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-09-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r40597512 --- Diff: core/src/main/scala/org/apache/spark/crypto/CryptoCodec.scala --- @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: [SPARK-10807][SPARKR] Added as.data.frame as a...

2015-09-28 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/8908#discussion_r40598461 --- Diff: R/pkg/R/DataFrame.R --- @@ -1848,3 +1848,28 @@ setMethod("crosstab", sct <- callJMethod(statFunctions, "crosstab", col1, col2)

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-09-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r40598481 --- Diff: core/src/main/scala/org/apache/spark/crypto/CryptoConf.scala --- @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-09-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r40598429 --- Diff: core/src/main/scala/org/apache/spark/crypto/CryptoCodec.scala --- @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-09-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r40598890 --- Diff: core/src/main/scala/org/apache/spark/crypto/CryptoConf.scala --- @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: [SPARK-8673] [launcher] API and infrastructure...

2015-09-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7052#issuecomment-143799326 [Test build #43066 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43066/consoleFull) for PR 7052 at commit

[GitHub] spark pull request: [SPARK-9384] [core] Easier setting of executor...

2015-09-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/7739#discussion_r40576297 --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala --- @@ -465,6 +466,10 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable with Logging

[GitHub] spark pull request: [SPARK-9384] [core] Easier setting of executor...

2015-09-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/7739#discussion_r40576243 --- Diff: bin/spark-shell --- @@ -35,7 +35,8 @@ export _SPARK_CMD_USAGE="Usage: ./bin/spark-shell [options]" # so we need to add the

[GitHub] spark pull request: [SPARK-10836] [SparkR] Added sort(x, decreasin...

2015-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8920#issuecomment-143813691 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10836] [SparkR] Added sort(x, decreasin...

2015-09-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8920#issuecomment-143813677 [Test build #43067 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43067/console) for PR 8920 at commit

[GitHub] spark pull request: [SPARK-10752][SPARKR] Implement corr() and cov...

2015-09-28 Thread NarineK
Github user NarineK commented on a diff in the pull request: https://github.com/apache/spark/pull/8869#discussion_r40581218 --- Diff: R/pkg/R/DataFrameStatFunctions.R --- @@ -0,0 +1,102 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] spark pull request: [SPARK-10101] [SQL] Add maxlength to JDBC fiel...

2015-09-28 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/8374#issuecomment-143832037 Just to let you know, we are busy wrapping up 1.5.1, but I have put reviewing this PR on our schedule for the next 2 week sprint. --- If your project is set up for

[GitHub] spark pull request: [SPARK-9384] [core] Easier setting of executor...

2015-09-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/7739#discussion_r40593517 --- Diff: core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala --- @@ -624,3 +639,15 @@ object UserClasspathFirstTest { } }

[GitHub] spark pull request: [SPARK-10807][SPARKR] Added as.data.frame as a...

2015-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8908#issuecomment-143849225 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10807][SPARKR] Added as.data.frame as a...

2015-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8908#issuecomment-143849259 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10807][SPARKR] Added as.data.frame as a...

2015-09-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8908#issuecomment-143849927 [Test build #43069 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43069/consoleFull) for PR 8908 at commit

[GitHub] spark pull request: [SPARK-10859] [SQL] fix stats of StringType in...

2015-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8929#issuecomment-143850517 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10859] [SQL] fix stats of StringType in...

2015-09-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8929#issuecomment-143852249 [Test build #43070 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43070/consoleFull) for PR 8929 at commit

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-09-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r40595862 --- Diff: core/src/main/scala/org/apache/spark/crypto/AesCtrCryptoCodec.scala --- @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-09-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r40595780 --- Diff: core/src/main/scala/org/apache/spark/crypto/AesCtrCryptoCodec.scala --- @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-09-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r40597016 --- Diff: core/src/main/scala/org/apache/spark/crypto/CryptoCodec.scala --- @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-09-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r40597034 --- Diff: core/src/main/scala/org/apache/spark/crypto/CryptoCodec.scala --- @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-09-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r40597121 --- Diff: core/src/main/scala/org/apache/spark/crypto/CryptoCodec.scala --- @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-09-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r40597474 --- Diff: core/src/main/scala/org/apache/spark/crypto/CryptoCodec.scala --- @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-09-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r40599555 --- Diff: core/src/main/scala/org/apache/spark/crypto/CryptoInputStream.scala --- @@ -0,0 +1,434 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-09-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r40599501 --- Diff: core/src/main/scala/org/apache/spark/crypto/CryptoInputStream.scala --- @@ -0,0 +1,434 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-09-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r40599619 --- Diff: core/src/main/scala/org/apache/spark/crypto/CryptoInputStream.scala --- @@ -0,0 +1,434 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-09-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r40599644 --- Diff: core/src/main/scala/org/apache/spark/crypto/CryptoInputStream.scala --- @@ -0,0 +1,434 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-8673] [launcher] API and infrastructure...

2015-09-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7052#issuecomment-143847626 [Test build #43066 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43066/console) for PR 7052 at commit

[GitHub] spark pull request: [SPARK-9384] [core] Easier setting of executor...

2015-09-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/7739#discussion_r40593175 --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala --- @@ -505,6 +510,23 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable with Logging

[GitHub] spark pull request: [SPARK-9384] [core] Easier setting of executor...

2015-09-28 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/7739#issuecomment-143849420 Looks sane but there's some room for cleanup; also, need to resolve conflicts. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-9384] [core] Easier setting of executor...

2015-09-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/7739#discussion_r40593778 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala --- @@ -143,6 +144,9 @@ private[deploy] class SparkSubmitArguments(args:

[GitHub] spark pull request: [SPARK-10859] [SQL] fix stats of StringType in...

2015-09-28 Thread davies
GitHub user davies opened a pull request: https://github.com/apache/spark/pull/8929 [SPARK-10859] [SQL] fix stats of StringType in columnar cache The UTF8String may come from UnsafeRow, then underline buffer of it is not copied, so we should clone it in order to hold it in Stats.

[GitHub] spark pull request: [SPARK-10859] [SQL] fix stats of StringType in...

2015-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8929#issuecomment-143850579 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-09-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r40596195 --- Diff: core/src/main/scala/org/apache/spark/crypto/CipherSuite.scala --- @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-09-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r40597245 --- Diff: core/src/main/scala/org/apache/spark/crypto/CryptoCodec.scala --- @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-09-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r40597300 --- Diff: core/src/main/scala/org/apache/spark/crypto/CryptoCodec.scala --- @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-09-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r40599017 --- Diff: core/src/main/scala/org/apache/spark/crypto/CryptoConf.scala --- @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-09-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r40598980 --- Diff: core/src/main/scala/org/apache/spark/crypto/CryptoConf.scala --- @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-09-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r40599106 --- Diff: core/src/main/scala/org/apache/spark/crypto/CryptoConf.scala --- @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-09-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r40599401 --- Diff: core/src/main/scala/org/apache/spark/crypto/CryptoInputStream.scala --- @@ -0,0 +1,434 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-09-28 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/8880#issuecomment-143862548 Hi @winningsix, I started to review this but the style violations are too distracting; I suggest fixing all those up front before going through a more complete

[GitHub] spark pull request: [SPARK-9384] [core] Easier setting of executor...

2015-09-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/7739#discussion_r40576075 --- Diff: bin/spark-shell --- @@ -35,7 +35,8 @@ export _SPARK_CMD_USAGE="Usage: ./bin/spark-shell [options]" # so we need to add the

[GitHub] spark pull request: Introduce config constants object

2015-09-28 Thread jaceklaskowski
Github user jaceklaskowski closed the pull request at: https://github.com/apache/spark/pull/8753 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request: [SPARK-10622] [core] Differentiate dead from "...

2015-09-28 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8887#issuecomment-143832319 can you add `[YARN]` to the title? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10101] [SQL] Add maxlength to JDBC fiel...

2015-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8374#issuecomment-143834967 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10833] [BUILD] Inline, organize BSD/MIT...

2015-09-28 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/8919#issuecomment-143837144 Hey Sean - looks good to me, but can't claim to be nearly as deep as you are on this stuff! --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-4449][Core]Specify port range in spark

2015-09-28 Thread WangTaoTheTonic
Github user WangTaoTheTonic commented on the pull request: https://github.com/apache/spark/pull/5722#issuecomment-143799075 I think we better keep backwards compatibility and treat [min, max] as a fine grained control on exact port while the "only 8080" with max retries as a coarse

[GitHub] spark pull request: [SPARK-10101] [SQL] Add maxlength to JDBC fiel...

2015-09-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8374#issuecomment-143843129 [Test build #43068 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43068/console) for PR 8374 at commit

[GitHub] spark pull request: [SPARK-10101] [SQL] Add maxlength to JDBC fiel...

2015-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8374#issuecomment-143843204 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10101] [SQL] Add maxlength to JDBC fiel...

2015-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8374#issuecomment-143843209 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10844] [SparkR] Added correlation of tw...

2015-09-28 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/8924#issuecomment-143812424 @NarineK As I commented on the JIRA, could we close this PR as we have https://github.com/apache/spark/pull/8869 in progress ? If there is something missing in #8869

[GitHub] spark pull request: [SPARK-10300] [BUILD] [TESTS] Add support for ...

2015-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8775#issuecomment-143804641 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10300] [BUILD] [TESTS] Add support for ...

2015-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8775#issuecomment-143804636 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10079][SPARKR] Make 'column' and 'col' ...

2015-09-28 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/8864#discussion_r40580851 --- Diff: R/pkg/R/DataFrame.R --- @@ -946,15 +946,36 @@ setMethod("foreachPartition", ## SELECT

[GitHub] spark pull request: [SPARK-10101] [SQL] Add maxlength to JDBC fiel...

2015-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8374#issuecomment-143834992 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-4122][STREAMING] Add a library that can...

2015-09-28 Thread WangTaoTheTonic
Github user WangTaoTheTonic commented on the pull request: https://github.com/apache/spark/pull/2994#issuecomment-143799798 Hi @harishreedharan, I think this is a nice feature which is very helpful for user who tries to write DStream back into Kafka. The implement is very neat too.

[GitHub] spark pull request: [SPARK-9384] [core] Easier setting of executor...

2015-09-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/7739#discussion_r40576432 --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala --- @@ -505,6 +510,23 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable with Logging

[GitHub] spark pull request: [SPARK-10836] [SparkR] Added sort(x, decreasin...

2015-09-28 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/8920#issuecomment-143810231 Jenkins, ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-10836] [SparkR] Added sort(x, decreasin...

2015-09-28 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/8920#issuecomment-143810259 cc @sun-rui --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-10807][SPARKR]

2015-09-28 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/8908#issuecomment-143835492 @olarayej Sorry I wasn't clear the last time around but the title should be `[SPARK-10807][SPARKR] Added as.data.frame as a synonym for collect` --- If your project

[GitHub] spark pull request: [SPARK-10622] [core] Differentiate dead from "...

2015-09-28 Thread mccheah
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/8887#discussion_r40588094 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala --- @@ -362,8 +395,8 @@ private[spark] class TaskSchedulerImpl( }

[GitHub] spark pull request: [SPARK-10101] [SQL] Add maxlength to JDBC fiel...

2015-09-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8374#issuecomment-143836713 [Test build #43068 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43068/consoleFull) for PR 8374 at commit

[GitHub] spark pull request: [SPARK-10622] [core] Differentiate dead from "...

2015-09-28 Thread mccheah
Github user mccheah commented on the pull request: https://github.com/apache/spark/pull/8887#issuecomment-143843978 The concept looks sound to me, however I'm actually less familiar with the logic of where tasks get allocated. Someone else should also review! --- If your project is

[GitHub] spark pull request: [SPARK-10300] [BUILD] [TESTS] Add support for ...

2015-09-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8775#issuecomment-143804474 [Test build #43062 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43062/console) for PR 8775 at commit

[GitHub] spark pull request: [SPARK-10836] [SparkR] Added sort(x, decreasin...

2015-09-28 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/8920#issuecomment-143810448 @NarineK Thanks for the PR. Could you also add a unit test for this ? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-10836] [SparkR] Added sort(x, decreasin...

2015-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8920#issuecomment-143810536 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10836] [SparkR] Added sort(x, decreasin...

2015-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8920#issuecomment-143810610 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10836] [SparkR] Added sort(x, decreasin...

2015-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8920#issuecomment-143813685 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10836] [SparkR] Added sort(x, decreasin...

2015-09-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8920#issuecomment-143813135 [Test build #43067 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43067/consoleFull) for PR 8920 at commit

[GitHub] spark pull request: SPARK-1537 publisher-side code and tests

2015-09-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8744#discussion_r40601188 --- Diff: yarn/history/src/main/scala/org/apache/spark/deploy/history/yarn/YarnHistoryService.scala --- @@ -0,0 +1,1048 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-10101] [SQL] Add maxlength to JDBC fiel...

2015-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8374#issuecomment-143865770 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

  1   2   3   4   >