[GitHub] spark pull request: [SPARK-11009] [SQL] fix wrong result of Window...

2015-10-10 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9050#issuecomment-147116624 @hvanhovell Yes, we will backport it to 1.5 branch. So it will be fixed in 1.5.2. Let me explain the cause. Every attribute reference has an `exprId`. If you do

[GitHub] spark pull request: [spark-11026][yarn]spark.yarn.user.classpath.f...

2015-10-10 Thread lianhuiwang
Github user lianhuiwang commented on the pull request: https://github.com/apache/spark/pull/9045#issuecomment-147094658 @vanzin @tgravescs when spark-submit --master yarn-cluster --jars /users/xxx.jar and spark.yarn.user.classpath.first=true, the jars of the command are not in

[GitHub] spark pull request: SPARK-11048 Use ForkJoinPool as executorServic...

2015-10-10 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9054#issuecomment-147104530 The cached thread pool does not create threads if threads are available:

[GitHub] spark pull request: [SPARK-10973][ML][PYTHON] Fix IndexError excep...

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9064#issuecomment-147109344 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10973][ML][PYTHON] Fix IndexError excep...

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9063#issuecomment-147109346 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10973][ML][PYTHON] __gettitem__ method ...

2015-10-10 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9009#issuecomment-147117437 @zero323 Good point, that's better for sure. Do you mind preparing a patch for 1.6 for that? (I don't think it's necessary to backport it everywhere.) --- If your

[GitHub] spark pull request: [spark-11026][yarn]spark.yarn.user.classpath.f...

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9045#issuecomment-147094723 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [spark-11026][yarn]spark.yarn.user.classpath.f...

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9045#issuecomment-147096063 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10913][SPARKR] attach() function suppor...

2015-10-10 Thread adrian555
Github user adrian555 commented on a diff in the pull request: https://github.com/apache/spark/pull/9031#discussion_r41698039 --- Diff: R/pkg/R/DataFrame.R --- @@ -1881,3 +1881,33 @@ setMethod("as.data.frame", } collect(x) }) +

[GitHub] spark pull request: [spark-11026][yarn]spark.yarn.user.classpath.f...

2015-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9045#issuecomment-147096650 [Test build #43530 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43530/console) for PR 9045 at commit

[GitHub] spark pull request: [spark-11026][yarn]spark.yarn.user.classpath.f...

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9045#issuecomment-147096659 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [spark-11026][yarn]spark.yarn.user.classpath.f...

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9045#issuecomment-147096660 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-10 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/9023#discussion_r41699681 --- Diff: R/pkg/R/stats.R --- @@ -100,3 +100,36 @@ setMethod("corr", statFunctions <- callJMethod(x@sdf, "stat")

[GitHub] spark pull request: [SPARK-11042] [SQL] Add a mechanism to ban cre...

2015-10-10 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9058#discussion_r41700341 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala --- @@ -1239,6 +1254,24 @@ object SQLContext {

[GitHub] spark pull request: [SPARK-10973][ML][PYTHON] Fix IndexError excep...

2015-10-10 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9062#issuecomment-147117151 This patch includes updates to a lot of pom files. Can you please remove those? (Thanks for sending all of these backports, btw!) --- If your project is

[GitHub] spark pull request: [spark-11026][yarn]spark.yarn.user.classpath.f...

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9045#issuecomment-147094732 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10973][ML][PYTHON] Fix IndexError excep...

2015-10-10 Thread zero323
GitHub user zero323 opened a pull request: https://github.com/apache/spark/pull/9064 [SPARK-10973][ML][PYTHON] Fix IndexError exception on SparseVector when asked for index after the last non-zero entry See https://github.com/apache/spark/pull/9009 for details. You can merge this

[GitHub] spark pull request: [SPARK-10973][ML][PYTHON] Fix IndexError excep...

2015-10-10 Thread zero323
GitHub user zero323 opened a pull request: https://github.com/apache/spark/pull/9062 [SPARK-10973][ML][PYTHON] Fix IndexError exception on SparseVector when asked for index after the last non-zero entry See https://github.com/apache/spark/pull/9009 for details. You can merge this

[GitHub] spark pull request: [SPARK-10973][ML][PYTHON] Fix IndexError excep...

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9062#issuecomment-147107757 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10973][ML][PYTHON] Fix IndexError excep...

2015-10-10 Thread zero323
GitHub user zero323 opened a pull request: https://github.com/apache/spark/pull/9063 [SPARK-10973][ML][PYTHON] Fix IndexError exception on SparseVector when asked for index after the last non-zero entry See https://github.com/apache/spark/pull/9009 for details. You can merge this

[GitHub] spark pull request: [SPARK-10913][SPARKR] attach() function suppor...

2015-10-10 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/9031#discussion_r41699843 --- Diff: R/pkg/R/DataFrame.R --- @@ -1881,3 +1881,33 @@ setMethod("as.data.frame", } collect(x) }) +

[GitHub] spark pull request: [SPARK-10973][ML][PYTHON] __gettitem__ method ...

2015-10-10 Thread zero323
Github user zero323 commented on the pull request: https://github.com/apache/spark/pull/9009#issuecomment-147114654 It should be possible to push this check before binary search: 8a695fe2c3344acd19279fcd539177426d436a02 --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-10973][ML][PYTHON] Fix IndexError excep...

2015-10-10 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9064#issuecomment-147116759 LGTM pending tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-10973][ML][PYTHON] Fix IndexError excep...

2015-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9064#issuecomment-147117889 [Test build #1872 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1872/console) for PR 9064 at commit

[GitHub] spark pull request: SPARK-11048 Use ForkJoinPool as executorServic...

2015-10-10 Thread tedyu
Github user tedyu commented on the pull request: https://github.com/apache/spark/pull/9054#issuecomment-147102012 The executorService in this case is used to initiate retry for fetching blocks. In a congested network environment, ForkJoinPool would serve better.

[GitHub] spark pull request: [SPARK-9478] [ml] Add class weights to Random ...

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9008#issuecomment-147102028 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9478] [ml] Add class weights to Random ...

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9008#issuecomment-147102033 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10973][ML][PYTHON] __gettitem__ method ...

2015-10-10 Thread zero323
Github user zero323 commented on the pull request: https://github.com/apache/spark/pull/9009#issuecomment-147108493 @jkbradley https://github.com/apache/spark/pull/9062, https://github.com/apache/spark/pull/9063, https://github.com/apache/spark/pull/9064 --- If your project is set

[GitHub] spark pull request: [SPARK-10913][SPARKR] attach() function suppor...

2015-10-10 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/9031#discussion_r41699442 --- Diff: R/pkg/R/DataFrame.R --- @@ -1881,3 +1881,33 @@ setMethod("as.data.frame", } collect(x) }) +

[GitHub] spark pull request: [SPARK-10973][ML][PYTHON] Fix IndexError excep...

2015-10-10 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9063#issuecomment-147117076 LGTM pending tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [spark-11026][yarn]spark.yarn.user.classpath.f...

2015-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9045#issuecomment-147095194 [Test build #43530 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43530/consoleFull) for PR 9045 at commit

[GitHub] spark pull request: [spark-11026][yarn]spark.yarn.user.classpath.f...

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9045#issuecomment-147096062 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9478] [ml] Add class weights to Random ...

2015-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9008#issuecomment-147102431 [Test build #43531 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43531/consoleFull) for PR 9008 at commit

[GitHub] spark pull request: [SPARK-10973][ML][PYTHON] Fix IndexError excep...

2015-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9062#issuecomment-147116668 [Test build #1874 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1874/consoleFull) for PR 9062 at commit

[GitHub] spark pull request: [SPARK-10973][ML][PYTHON] Fix IndexError excep...

2015-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9063#issuecomment-147116645 [Test build #1873 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1873/consoleFull) for PR 9063 at commit

[GitHub] spark pull request: [SPARK-10973][ML][PYTHON] Fix IndexError excep...

2015-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9064#issuecomment-147116649 [Test build #1872 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1872/consoleFull) for PR 9064 at commit

[GitHub] spark pull request: [SPARK-10478][ML] Performance, organization, a...

2015-10-10 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8648#discussion_r41700924 --- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala --- @@ -260,127 +263,126 @@ private[ann] trait ActivationFunction extends

[GitHub] spark pull request: [spark-11026][yarn]spark.yarn.user.classpath.f...

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9045#issuecomment-147095004 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [spark-11026][yarn]spark.yarn.user.classpath.f...

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9045#issuecomment-147095008 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10979] [SparkR] Sparkrmerge: Add merge ...

2015-10-10 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/9012#issuecomment-147113185 +1 on R-like signature, just want to call out we should be careful with breaking API changes --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-10913][SPARKR] attach() function suppor...

2015-10-10 Thread adrian555
Github user adrian555 commented on the pull request: https://github.com/apache/spark/pull/9031#issuecomment-147096207 @sun-rui First, the current subsetting function '$' of DataFrame ends up with a 'Column' class instead of a real column access of 'DataFrame'. So to operate on one

[GitHub] spark pull request: [SPARK-10888] [SparkR] Added as.DataFrame as a...

2015-10-10 Thread NarineK
Github user NarineK commented on the pull request: https://github.com/apache/spark/pull/8952#issuecomment-147119595 Thanks @sun-rui, with respect to export for as.DataFrame. I moved as.DataFrame up, because @felixcheung noted that we should pay attention to alphabetical

[GitHub] spark pull request: [SPARK-10973][ML][PYTHON] Fix IndexError excep...

2015-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9063#issuecomment-147122857 [Test build #1873 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1873/consoleFull) for PR 9063 at commit

[GitHub] spark pull request: [SPARK-11017] [SQL] Support ImperativeAggregat...

2015-10-10 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/9038#issuecomment-147125927 Okay, I have a theory as to what might be causing the test failure. The assertion failure is only occurring in the final aggregation, `finalAndCompleteAggregate`.

[GitHub] spark pull request: [SPARK-10888] [SparkR] Added as.DataFrame as a...

2015-10-10 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/8952#issuecomment-147146517 @NarineK, forget about my comment about export for as.DataFrame. I deleted it:) --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-11042] [SQL] Add a mechanism to ban cre...

2015-10-10 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9058#discussion_r41704241 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala --- @@ -1239,6 +1254,24 @@ object SQLContext {

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-10 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/9023#discussion_r41704334 --- Diff: R/pkg/R/stats.R --- @@ -100,3 +100,36 @@ setMethod("corr", statFunctions <- callJMethod(x@sdf, "stat")

[GitHub] spark pull request: [SPARK-9478] [ml] Add class weights to Random ...

2015-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9008#issuecomment-147122387 **[Test build #43531 timed out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43531/console)** for PR 9008 at commit

[GitHub] spark pull request: [SPARK-10913][SPARKR] attach() function suppor...

2015-10-10 Thread adrian555
Github user adrian555 commented on a diff in the pull request: https://github.com/apache/spark/pull/9031#discussion_r41701074 --- Diff: R/pkg/R/DataFrame.R --- @@ -1881,3 +1881,33 @@ setMethod("as.data.frame", } collect(x) }) +

[GitHub] spark pull request: [SPARK-10913][SPARKR] attach() function suppor...

2015-10-10 Thread adrian555
Github user adrian555 commented on the pull request: https://github.com/apache/spark/pull/9031#issuecomment-147146800 Hi admin, The failure is [error] (core/*:mimaPreviousClassfiles) sbt.ResolveException: download failed:

[GitHub] spark pull request: [SPARK-8514] LU factorization on BlockMatrix

2015-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8563#issuecomment-147149816 [Test build #43533 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43533/consoleFull) for PR 8563 at commit

[GitHub] spark pull request: [SPARK-11052] Spaces in the build dir causes f...

2015-10-10 Thread trystanleftwich
GitHub user trystanleftwich opened a pull request: https://github.com/apache/spark/pull/9065 [SPARK-11052] Spaces in the build dir causes failures in the build/mv… …n script You can merge this pull request into a Git repository by running: $ git pull

[GitHub] spark pull request: [SPARK-11017] [SQL] Support ImperativeAggregat...

2015-10-10 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9038#discussion_r41704981 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregationIterator.scala --- @@ -134,19 +137,74 @@ class

[GitHub] spark pull request: [SPARK-11053] Remove use of KVIterator in Sort...

2015-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9066#issuecomment-147155599 [Test build #43535 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43535/consoleFull) for PR 9066 at commit

[GitHub] spark pull request: [SPARK-8514] LU factorization on BlockMatrix

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8563#issuecomment-147158109 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11042] [SQL] Add a mechanism to ban cre...

2015-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9058#issuecomment-147157874 [Test build #43536 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43536/consoleFull) for PR 9058 at commit

[GitHub] spark pull request: [SPARK-9478] [ml] Add class weights to Random ...

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9008#issuecomment-147122395 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11017] [SQL] Support ImperativeAggregat...

2015-10-10 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/9038#discussion_r41701104 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/utils.scala --- @@ -154,143 +146,150 @@ object Utils { val

[GitHub] spark pull request: [SPARK-11017] [SQL] Support ImperativeAggregat...

2015-10-10 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9038#issuecomment-147141366 ah, `assert(initialInputBufferOffset > 0)` failed because when there is not grouping expression and the mode is not partial, initialInputBufferOffset will be 0. --- If

[GitHub] spark pull request: SPARK-11048 Use ForkJoinPool as executorServic...

2015-10-10 Thread tedyu
Github user tedyu commented on the pull request: https://github.com/apache/spark/pull/9054#issuecomment-147150006 Background: http://stackoverflow.com/questions/19528304/how-to-get-the-threadpoolexecutor-to-increase-threads-to-max-before-queueing/19528305#19528305 Toward

[GitHub] spark pull request: [SPARK-8514] LU factorization on BlockMatrix

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8563#issuecomment-147151970 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8514] LU factorization on BlockMatrix

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8563#issuecomment-147151971 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-8514] LU factorization on BlockMatrix

2015-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8563#issuecomment-147151956 [Test build #43533 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43533/console) for PR 8563 at commit

[GitHub] spark pull request: [SPARK-11053] Remove use of KVIterator in Sort...

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9066#issuecomment-147156068 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11053] Remove use of KVIterator in Sort...

2015-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9066#issuecomment-147156060 [Test build #43535 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43535/console) for PR 9066 at commit

[GitHub] spark pull request: [SPARK-8514] LU factorization on BlockMatrix

2015-10-10 Thread nilmeier
Github user nilmeier commented on a diff in the pull request: https://github.com/apache/spark/pull/8563#discussion_r41705354 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala --- @@ -402,4 +445,402 @@ class BlockMatrix @Since("1.3.0") (

[GitHub] spark pull request: [SPARK-11053] Remove use of KVIterator in Sort...

2015-10-10 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/9066#issuecomment-147158207 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8514] LU factorization on BlockMatrix

2015-10-10 Thread nilmeier
Github user nilmeier commented on a diff in the pull request: https://github.com/apache/spark/pull/8563#discussion_r41705352 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala --- @@ -402,4 +445,402 @@ class BlockMatrix @Since("1.3.0") (

[GitHub] spark pull request: [SPARK-8514] LU factorization on BlockMatrix

2015-10-10 Thread nilmeier
Github user nilmeier commented on a diff in the pull request: https://github.com/apache/spark/pull/8563#discussion_r41705505 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala --- @@ -402,4 +445,402 @@ class BlockMatrix @Since("1.3.0") (

[GitHub] spark pull request: [SPARK-8514] LU factorization on BlockMatrix

2015-10-10 Thread nilmeier
Github user nilmeier commented on a diff in the pull request: https://github.com/apache/spark/pull/8563#discussion_r41705389 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala --- @@ -402,4 +445,402 @@ class BlockMatrix @Since("1.3.0") (

[GitHub] spark pull request: [SPARK-8514] LU factorization on BlockMatrix

2015-10-10 Thread nilmeier
Github user nilmeier commented on a diff in the pull request: https://github.com/apache/spark/pull/8563#discussion_r41705434 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala --- @@ -402,4 +445,402 @@ class BlockMatrix @Since("1.3.0") (

[GitHub] spark pull request: [SPARK-9478] [ml] Add class weights to Random ...

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9008#issuecomment-147122396 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10913][SPARKR] attach() function suppor...

2015-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9031#issuecomment-147122953 [Test build #43532 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43532/consoleFull) for PR 9031 at commit

[GitHub] spark pull request: [SPARK-10996][SPARKR] Implement sampleBy() in ...

2015-10-10 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/9023#discussion_r41704114 --- Diff: R/pkg/R/stats.R --- @@ -100,3 +100,36 @@ setMethod("corr", statFunctions <- callJMethod(x@sdf, "stat")

[GitHub] spark pull request: [SPARK-8514] LU factorization on BlockMatrix

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8563#issuecomment-147149467 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8514] LU factorization on BlockMatrix

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8563#issuecomment-147149464 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11044][SQL] Parquet writer version fixe...

2015-10-10 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/9060#discussion_r41705069 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/CatalystWriteSupport.scala --- @@ -431,6 +431,7 @@ private[parquet]

[GitHub] spark pull request: [SPARK-11042] [SQL] Add a mechanism to ban cre...

2015-10-10 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9058#discussion_r41705075 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/MultiSQLContextSuite.scala --- @@ -0,0 +1,99 @@ +/* +* Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-11053] Remove use of KVIterator in Sort...

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9066#issuecomment-147156067 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11042] [SQL] Add a mechanism to ban cre...

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9058#issuecomment-147156665 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11042] [SQL] Add a mechanism to ban cre...

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9058#issuecomment-147156679 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10913][SPARKR] attach() function suppor...

2015-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9031#issuecomment-147124202 [Test build #43532 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43532/console) for PR 9031 at commit

[GitHub] spark pull request: [SPARK-10913][SPARKR] attach() function suppor...

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9031#issuecomment-147124210 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10913][SPARKR] attach() function suppor...

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9031#issuecomment-147124212 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11042] [SQL] Add a mechanism to ban cre...

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9058#issuecomment-147153030 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11042] [SQL] Add a mechanism to ban cre...

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9058#issuecomment-147153045 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10913][SPARKR] attach() function suppor...

2015-10-10 Thread adrian555
Github user adrian555 commented on a diff in the pull request: https://github.com/apache/spark/pull/9031#discussion_r41701060 --- Diff: R/pkg/R/DataFrame.R --- @@ -1881,3 +1881,33 @@ setMethod("as.data.frame", } collect(x) }) +

[GitHub] spark pull request: [SPARK-10913][SPARKR] attach() function suppor...

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9031#issuecomment-147122665 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10913][SPARKR] attach() function suppor...

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9031#issuecomment-147122669 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10973][ML][PYTHON] Fix IndexError excep...

2015-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9062#issuecomment-147123397 [Test build #1874 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1874/consoleFull) for PR 9062 at commit

[GitHub] spark pull request: [SPARK-11042] [SQL] Add a mechanism to ban cre...

2015-10-10 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/9058#discussion_r41703591 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala --- @@ -1239,6 +1254,24 @@ object SQLContext {

[GitHub] spark pull request: [SPARK-11053] Remove use of KVIterator in Sort...

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9066#issuecomment-147153492 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11053] Remove use of KVIterator in Sort...

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9066#issuecomment-147153450 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11053] Remove use of KVIterator in Sort...

2015-10-10 Thread JoshRosen
GitHub user JoshRosen opened a pull request: https://github.com/apache/spark/pull/9066 [SPARK-11053] Remove use of KVIterator in SortBasedAggregationIterator SortBasedAggregationIterator uses a KVIterator interface in order to process input rows as key-value pairs, but this use of

[GitHub] spark pull request: [SPARK-11042] [SQL] Add a mechanism to ban cre...

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9058#issuecomment-147155854 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11042] [SQL] Add a mechanism to ban cre...

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9058#issuecomment-147155853 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11042] [SQL] Add a mechanism to ban cre...

2015-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9058#issuecomment-147155850 [Test build #43534 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43534/console) for PR 9058 at commit

[GitHub] spark pull request: [SPARK-11053] Remove use of KVIterator in Sort...

2015-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9066#issuecomment-147158226 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8514] LU factorization on BlockMatrix

2015-10-10 Thread nilmeier
Github user nilmeier commented on a diff in the pull request: https://github.com/apache/spark/pull/8563#discussion_r41705594 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala --- @@ -402,4 +445,402 @@ class BlockMatrix @Since("1.3.0") (

[GitHub] spark pull request: [SPARK-8514] LU factorization on BlockMatrix

2015-10-10 Thread nilmeier
Github user nilmeier commented on a diff in the pull request: https://github.com/apache/spark/pull/8563#discussion_r41705597 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala --- @@ -402,4 +445,402 @@ class BlockMatrix @Since("1.3.0") (

  1   2   3   >