[GitHub] spark pull request: [SPARK-11632][Streaming] Filter out empty part...

2015-11-15 Thread jerryshao
Github user jerryshao commented on the pull request: https://github.com/apache/spark/pull/9597#issuecomment-156794866 Hi @koeninger , how about this change? Still keeping the mapping relations, so offset range can be retrieved through partitionId, just filter out empty partition.

[GitHub] spark pull request: [SPARK-11738] [SQL] Making ArrayType orderable

2015-11-15 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/9718#discussion_r44868778 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -267,6 +267,55 @@ class CodeGenContext {

[GitHub] spark pull request: [SPARK-11738] [SQL] Making ArrayType orderable

2015-11-15 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/9718#discussion_r44868784 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -267,6 +267,55 @@ class CodeGenContext {

[GitHub] spark pull request: [SPARK-11738] [SQL] Making ArrayType orderable

2015-11-15 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/9718#issuecomment-156789726 LGTM, and some minor comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11447][SQL] change NullType to StringTy...

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9720#issuecomment-156789931 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11447][SQL] change NullType to StringTy...

2015-11-15 Thread kevinyu98
GitHub user kevinyu98 opened a pull request: https://github.com/apache/spark/pull/9720 [SPARK-11447][SQL] change NullType to StringType during binaryComparison between NullType and StringType During executing PromoteStrings rule, if one side of binaryComparison is StringType and

[GitHub] spark pull request: [SPARK-11718][Yarn][Core]Fix explicitly killed...

2015-11-15 Thread jerryshao
Github user jerryshao commented on the pull request: https://github.com/apache/spark/pull/9684#issuecomment-156793955 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11743][SQL] Add UserDefinedType support...

2015-11-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9712#discussion_r44871929 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/RowEncoderSuite.scala --- @@ -68,7 +117,36 @@ class RowEncoderSuite extends

[GitHub] spark pull request: [SPARK-11689] [ML] Add user guide and example ...

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9722#issuecomment-156814081 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11086][SPARKR] Use dropFactors column-w...

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9099#issuecomment-156814877 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11086][SPARKR] Use dropFactors column-w...

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9099#issuecomment-156816289 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11086][SPARKR] Use dropFactors column-w...

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9099#issuecomment-156816290 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11743][SQL] Add UserDefinedType support...

2015-11-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/9712#discussion_r44872999 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/RowEncoderSuite.scala --- @@ -68,7 +117,36 @@ class RowEncoderSuite extends

[GitHub] spark pull request: [SPARK-11086][SPARKR] Use dropFactors column-w...

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9099#issuecomment-156816256 **[Test build #45953 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45953/consoleFull)** for PR 9099 at commit

[GitHub] spark pull request: [SPARK-11689] [ML] Add user guide and example ...

2015-11-15 Thread hhbyyh
GitHub user hhbyyh opened a pull request: https://github.com/apache/spark/pull/9722 [SPARK-11689] [ML] Add user guide and example code for LDA under spark.ml jira: https://issues.apache.org/jira/browse/SPARK-11689 Add simple user guide for LDA under spark.ml and example

[GitHub] spark pull request: [SPARK-11689] [ML] Add user guide and example ...

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9722#issuecomment-156812972 **[Test build #45951 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45951/consoleFull)** for PR 9722 at commit

[GitHub] spark pull request: [SPARK-11689] [ML] Add user guide and example ...

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9722#issuecomment-156814056 **[Test build #45951 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45951/consoleFull)** for PR 9722 at commit

[GitHub] spark pull request: [SPARK-11689] [ML] Add user guide and example ...

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9722#issuecomment-156814083 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11086][SPARKR] Use dropFactors column-w...

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9099#issuecomment-156814876 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11086][SPARKR] Use dropFactors column-w...

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9099#issuecomment-156814873 **[Test build #45952 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45952/consoleFull)** for PR 9099 at commit

[GitHub] spark pull request: [SPARK-11086][SPARKR] Use dropFactors column-w...

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9099#issuecomment-156815446 **[Test build #45953 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45953/consoleFull)** for PR 9099 at commit

[GitHub] spark pull request: [SPARK-11744][Launcher] Fix print version thro...

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9721#issuecomment-156815860 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11744][Launcher] Fix print version thro...

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9721#issuecomment-156815861 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11744][Launcher] Fix print version thro...

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9721#issuecomment-156815828 **[Test build #45950 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45950/consoleFull)** for PR 9721 at commit

[GitHub] spark pull request: [SPARK-11191] [SPARK-11311] [SQL] Backports #9...

2015-11-15 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/9671#issuecomment-156819436 cc @yhuai --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-11191] [SQL] Looks up temporary functio...

2015-11-15 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/9664#discussion_r44873198 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala --- @@ -454,7 +454,7 @@ class HiveContext private[hive]( // Note that

[GitHub] spark pull request: [SPARK-11632][Streaming] Filter out empty part...

2015-11-15 Thread koeninger
Github user koeninger commented on the pull request: https://github.com/apache/spark/pull/9597#issuecomment-156822484 Are you 100% sure that all uses of the partition array only use the index associated with the individual Partition, and not its position in the array? At

[GitHub] spark pull request: [SPARK-11593][SQL] Replace catalyst converter ...

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9565#issuecomment-156822427 **[Test build #45954 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45954/consoleFull)** for PR 9565 at commit

[GitHub] spark pull request: [SPARK-11517][SQL]Calc partitions in parallel ...

2015-11-15 Thread zhonghaihua
Github user zhonghaihua commented on the pull request: https://github.com/apache/spark/pull/9483#issuecomment-156810307 Hi @zhichao-li ,thanks for doing this.I got a problem of scanning partitions slowly,and I apply this patch to my spark version.In my case: * Before I apply this

[GitHub] spark pull request: [SPARK-11744][Launcher] Fix print version thro...

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9721#issuecomment-156810256 **[Test build #45950 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45950/consoleFull)** for PR 9721 at commit

[GitHub] spark pull request: [SPARK-11517][SQL]Calc partitions in parallel ...

2015-11-15 Thread zhonghaihua
Github user zhonghaihua commented on the pull request: https://github.com/apache/spark/pull/9483#issuecomment-156810714 Hi @zhichao-li ,thanks for doing this.I got a problem of scanning partitions slowly,and I apply this patch to my spark version.In my case: * Before I apply this

[GitHub] spark pull request: [SPARK-9026] Modifications to JobWaiter, Futur...

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9264#issuecomment-156810989 **[Test build #2060 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2060/consoleFull)** for PR 9264 at commit

[GitHub] spark pull request: [SPARK-9026] Modifications to JobWaiter, Futur...

2015-11-15 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9264#issuecomment-156801643 @reggert yeah, with thousands of tests, some of them integration-style tests, flakiness is a pretty regular occurrence. You can see a number of PRs to improve indivudal

[GitHub] spark pull request: [SPARK-9026] Modifications to JobWaiter, Futur...

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9264#issuecomment-156802784 **[Test build #2060 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2060/consoleFull)** for PR 9264 at commit

[GitHub] spark pull request: [SPARK-11718][Yarn][Core]Fix explicitly killed...

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9684#issuecomment-156802883 **[Test build #45948 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45948/consoleFull)** for PR 9684 at commit

[GitHub] spark pull request: [SPARK-11632][Streaming] Filter out empty part...

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9597#issuecomment-156806763 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11632][Streaming] Filter out empty part...

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9597#issuecomment-156806762 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11718][Yarn][Core]Fix explicitly killed...

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9684#issuecomment-15686 **[Test build #45948 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45948/consoleFull)** for PR 9684 at commit

[GitHub] spark pull request: [SPARK-11632][Streaming] Filter out empty part...

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9597#issuecomment-156803004 **[Test build #45949 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45949/consoleFull)** for PR 9597 at commit

[GitHub] spark pull request: [SPARK-11672] [ML] set active SQLContext in Ja...

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9719#issuecomment-156802990 **[Test build #45947 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45947/consoleFull)** for PR 9719 at commit

[GitHub] spark pull request: [SPARK-11632][Streaming] Filter out empty part...

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9597#issuecomment-156806725 **[Test build #45949 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45949/consoleFull)** for PR 9597 at commit

[GitHub] spark pull request: [SPARK-11672] [ML] set active SQLContext in Ja...

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9719#issuecomment-156807487 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11672] [ML] set active SQLContext in Ja...

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9719#issuecomment-156807488 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11672] [ML] set active SQLContext in Ja...

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9719#issuecomment-156807462 **[Test build #45947 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45947/consoleFull)** for PR 9719 at commit

[GitHub] spark pull request: [SPARK-11718][Yarn][Core]Fix explicitly killed...

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9684#issuecomment-156811167 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11744][Launcher] Fix print version thro...

2015-11-15 Thread jerryshao
GitHub user jerryshao opened a pull request: https://github.com/apache/spark/pull/9721 [SPARK-11744][Launcher] Fix print version throw exception when using pyspark shell Exception details can be seen here (https://issues.apache.org/jira/browse/SPARK-11744). You can merge this

[GitHub] spark pull request: [Spark-11522][SQL] input_file_name() returns "...

2015-11-15 Thread xwu0226
Github user xwu0226 commented on the pull request: https://github.com/apache/spark/pull/9542#issuecomment-156845293 Accidentially pushed another JIRA's code together. . I am backing it out --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: SPARK-6541 - Sort executors by ID (numeric)

2015-11-15 Thread jbonofre
Github user jbonofre commented on the pull request: https://github.com/apache/spark/pull/9165#issuecomment-156845898 PR rebased. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: SPARK-6541 - Sort executors by ID (numeric)

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9165#issuecomment-156846400 **[Test build #45957 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45957/consoleFull)** for PR 9165 at commit

[GitHub] spark pull request: [SPARK-10749][MESOS] Support multiple roles wi...

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8872#issuecomment-156846731 **[Test build #45958 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45958/consoleFull)** for PR 8872 at commit

[GitHub] spark pull request: [SPARK-11572] Exit AsynchronousListenerBus thr...

2015-11-15 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/9546#issuecomment-156846877 I think that this has caused the "org.apache.spark.scheduler.EventLoggingListenerSuite.End-to-end event logging" test to become flaky in Jenkins. I believe

[GitHub] spark pull request: [SPARK-11734][SQL] Rename TungstenProject -> P...

2015-11-15 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/9700#issuecomment-156841942 Going to merge this first. I will submit followup prs if there are any posthoc feedback. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [Spark-11522][SQL] input_file_name() returns "...

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9542#issuecomment-156842519 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9026] Modifications to JobWaiter, Futur...

2015-11-15 Thread reggert
Github user reggert commented on the pull request: https://github.com/apache/spark/pull/9264#issuecomment-156844499 @srowen Okay. I was just worried I was going to get blamed for breaking something. ;-) What's left to do here? --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-11572] Exit AsynchronousListenerBus thr...

2015-11-15 Thread ted-yu
Github user ted-yu commented on the pull request: https://github.com/apache/spark/pull/9546#issuecomment-156850070 I checked https://amplab.cs.berkeley.edu/jenkins/job/Spark-Master-Maven-with-YARN/HADOOP_PROFILE=hadoop-2.4,label=spark-test/4122/consoleFull back till:

[GitHub] spark pull request: [Spark-11522][SQL] input_file_name() returns "...

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9542#issuecomment-156850658 **[Test build #45959 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45959/consoleFull)** for PR 9542 at commit

[GitHub] spark pull request: [SPARK-11572] Exit AsynchronousListenerBus thr...

2015-11-15 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/9546#issuecomment-156851581 Look at the Master SBT build; there's definitely a regression:

[GitHub] spark pull request: [SPARK-8546] Add PMML export for Naive Bayes

2015-11-15 Thread selvinsource
Github user selvinsource commented on the pull request: https://github.com/apache/spark/pull/9057#issuecomment-156852089 @yinxusen https://github.com/selvinsource/spark-pmml-exporter-validator/tree/logistic_regression_multi_class I tested both multinomial and bernoulli.

[GitHub] spark pull request: [Spark-11522][SQL] input_file_name() returns "...

2015-11-15 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9542#issuecomment-156853749 LGTM pending jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11191] [SPARK-11311] [SQL] Backports #9...

2015-11-15 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9671#issuecomment-156854295 Merge to branch 1.5. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11191] [SPARK-11311] [SQL] Backports #9...

2015-11-15 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9671#issuecomment-156854870 Merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-11191] [SQL] Looks up temporary functio...

2015-11-15 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9664#discussion_r44877679 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala --- @@ -454,7 +454,7 @@ class HiveContext private[hive]( // Note that

[GitHub] spark pull request: [SPARK-11672] [ML] set active SQLContext in Ja...

2015-11-15 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9719#issuecomment-156855129 LGTM. Merge to branch 1.6 and master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-11672] [ML] set active SQLContext in Ja...

2015-11-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9719 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-15 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9272#issuecomment-156866902 Thanks! Merging to master and branch 1.6. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9026] Modifications to JobWaiter, Futur...

2015-11-15 Thread reggert
Github user reggert commented on the pull request: https://github.com/apache/spark/pull/9264#issuecomment-156868899 I'm not particularly happy about the (internal) API exposed by `ComplexFutureAction`. Having callers instantiate the action and then mutate it by calling the `run` and

[GitHub] spark pull request: [SPARK-11195][CORE] Use correct classloader fo...

2015-11-15 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9367#discussion_r44880055 --- Diff: core/src/test/scala/org/apache/spark/scheduler/TaskResultGetterSuite.scala --- @@ -119,5 +124,47 @@ class TaskResultGetterSuite extends SparkFunSuite

[GitHub] spark pull request: [SPARK-11195][CORE] Use correct classloader fo...

2015-11-15 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9367#discussion_r44880126 --- Diff: core/src/test/scala/org/apache/spark/scheduler/TaskResultGetterSuite.scala --- @@ -119,5 +124,47 @@ class TaskResultGetterSuite extends SparkFunSuite

[GitHub] spark pull request: [SPARK-11738] [SQL] Making ArrayType orderable

2015-11-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9718 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11572] Exit AsynchronousListenerBus thr...

2015-11-15 Thread ted-yu
Github user ted-yu commented on the pull request: https://github.com/apache/spark/pull/9546#issuecomment-156866484 Planning to send out a PR to fix the regression by keeping count of queued events first time seeing the stop flag. --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-11572] Process outstanding requests aft...

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9723#issuecomment-156870251 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11572] Process outstanding requests aft...

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9723#issuecomment-156877667 **[Test build #45962 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45962/consoleFull)** for PR 9723 at commit

[GitHub] spark pull request: [SPARK-11044][SQL] Parquet writer version fixe...

2015-11-15 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/9060#issuecomment-156879272 I saw accidently `TODO Adds test case for reading dictionary encoded decimals written as 'FIXED_LEN_BYTE_ARRAY'`. I will also add this test in the following

[GitHub] spark pull request: SPARK-6541 - Sort executors by ID (numeric)

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9165#issuecomment-156856529 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-6541 - Sort executors by ID (numeric)

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9165#issuecomment-156856532 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-6541 - Sort executors by ID (numeric)

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9165#issuecomment-156856492 **[Test build #45957 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45957/consoleFull)** for PR 9165 at commit

[GitHub] spark pull request: [SPARK-10749][MESOS] Support multiple roles wi...

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8872#issuecomment-156858796 **[Test build #45958 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45958/consoleFull)** for PR 8872 at commit

[GitHub] spark pull request: [SPARK-11572] Exit AsynchronousListenerBus thr...

2015-11-15 Thread ted-yu
Github user ted-yu commented on the pull request: https://github.com/apache/spark/pull/9546#issuecomment-156867526 Cloning git repo was extremely slow. Here is proposed fix: ``` diff --git a/core/src/main/scala/org/apache/spark/util/AsynchronousListenerBus.scala

[GitHub] spark pull request: [SPARK-9026] Modifications to JobWaiter, Futur...

2015-11-15 Thread reggert
Github user reggert commented on a diff in the pull request: https://github.com/apache/spark/pull/9264#discussion_r44879232 --- Diff: core/src/test/scala/org/apache/spark/rdd/AsyncRDDActionsSuite.scala --- @@ -27,7 +27,7 @@ import org.scalatest.BeforeAndAfterAll import

[GitHub] spark pull request: [Spark-11522][SQL] input_file_name() returns "...

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9542#issuecomment-156868010 **[Test build #45959 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45959/consoleFull)** for PR 9542 at commit

[GitHub] spark pull request: [Spark-11522][SQL] input_file_name() returns "...

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9542#issuecomment-156868048 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [Spark-11522][SQL] input_file_name() returns "...

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9542#issuecomment-156868046 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [Spark-11522][SQL] input_file_name() returns "...

2015-11-15 Thread xwu0226
Github user xwu0226 commented on the pull request: https://github.com/apache/spark/pull/9542#issuecomment-156869030 @yhuai I did not know that we should not update the resources/data directory.. I thought the test data files were added along the way by contributors. Thanks for

[GitHub] spark pull request: [SPARK-11390] [SQL] Query plan with/without fi...

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9679#issuecomment-156856575 **[Test build #45960 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45960/consoleFull)** for PR 9679 at commit

[GitHub] spark pull request: [SPARK-11195][CORE] Use correct classloader fo...

2015-11-15 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9367#discussion_r44880215 --- Diff: core/src/main/scala/org/apache/spark/TestUtils.scala --- @@ -78,15 +79,15 @@ private[spark] object TestUtils { } /** - *

[GitHub] spark pull request: [SPARK-11677][SQL] ORC filter tests all pass i...

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9687#issuecomment-156883379 **[Test build #45965 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45965/consoleFull)** for PR 9687 at commit

[GitHub] spark pull request: [SPARK-9928][SQL] Removal of LogicalLocalTable...

2015-11-15 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/9717#issuecomment-156888382 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11572] Process outstanding requests aft...

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9723#issuecomment-156889821 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11572] Process outstanding requests aft...

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9723#issuecomment-156889817 **[Test build #45968 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45968/consoleFull)** for PR 9723 at commit

[GitHub] spark pull request: [SPARK-11572] Process outstanding requests aft...

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9723#issuecomment-156889820 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11745][SQL] Enable more JSON parsing op...

2015-11-15 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/9724#discussion_r44883818 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonParsingOptionsSuite.scala --- @@ -0,0 +1,114 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-11745][SQL] Enable more JSON parsing op...

2015-11-15 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/9724#discussion_r44883828 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JSONOptions.scala --- @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-11044][SQL] Parquet writer version fixe...

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9060#issuecomment-156891545 **[Test build #45964 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45964/consoleFull)** for PR 9060 at commit

[GitHub] spark pull request: [SPARK-11572] Process outstanding requests aft...

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9723#issuecomment-156891548 **[Test build #45973 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45973/consoleFull)** for PR 9723 at commit

[GitHub] spark pull request: [SPARK-11044][SQL] Parquet writer version fixe...

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9060#issuecomment-156891628 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11044][SQL] Parquet writer version fixe...

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9060#issuecomment-156891627 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11745][SQL] Enable more JSON parsing op...

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9724#issuecomment-156891508 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11692][SQL] Support for Parquet logical...

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9658#issuecomment-156892687 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11745][SQL] Enable more JSON parsing op...

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9724#issuecomment-156892716 **[Test build #2061 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2061/consoleFull)** for PR 9724 at commit

[GitHub] spark pull request: [SPARK-11745][SQL] Enable more JSON parsing op...

2015-11-15 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9724#discussion_r44884636 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala --- @@ -227,6 +227,15 @@ class DataFrameReader private[sql](sqlContext:

  1   2   3   >