[GitHub] spark pull request: [SPARK-11544][SQL] sqlContext doesn't use Path...

2015-11-16 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/9652#discussion_r44942723 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -1393,4 +1401,58 @@ class JsonSuite extends

[GitHub] spark pull request: [SPARK-11544][SQL] sqlContext doesn't use Path...

2015-11-16 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/9652#discussion_r44942818 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -1393,4 +1401,58 @@ class JsonSuite extends

[GitHub] spark pull request: [SPARK-11652] [CORE] Remote code execution wit...

2015-11-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9731#issuecomment-157079364 **[Test build #2064 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2064/consoleFull)** for PR 9731 at commit

[GitHub] spark pull request: [SPARK-11191] [SQL] [FOLLOW-UP] Cleans up unne...

2015-11-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9737#issuecomment-157084858 **[Test build #45997 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45997/consoleFull)** for PR 9737 at commit

[GitHub] spark pull request: [SPARK-10852][PySpark][SQL] Override built-in ...

2015-11-16 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/8934#issuecomment-157095257 @viirya This PR only help a two corner cases, and they are not blocker (could be easily workaround), I'd like to not fix these (avoid the complexity). If we merge this

[GitHub] spark pull request: [Spark-11522][SQL] input_file_name() returns "...

2015-11-16 Thread xwu0226
Github user xwu0226 commented on the pull request: https://github.com/apache/spark/pull/9542#issuecomment-157075099 @yhuai The last test build passed. Do you know what might cause the previous errors? After resolving the conflicts, my own diff for this PR is still the same place,

[GitHub] spark pull request: [SPARK-11191] [SQL] [FOLLOW-UP] Cleans up unne...

2015-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9737#issuecomment-157085084 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11544][SQL] sqlContext doesn't use Path...

2015-11-16 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/9652#discussion_r44945464 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -1393,4 +1401,58 @@ class JsonSuite extends

[GitHub] spark pull request: [SPARK-11743][SQL] Add UserDefinedType support...

2015-11-16 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/9712#discussion_r44949708 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/RowEncoderSuite.scala --- @@ -68,7 +117,36 @@ class RowEncoderSuite extends

[GitHub] spark pull request: [SPARK-11743][SQL] Add UserDefinedType support...

2015-11-16 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/9712#issuecomment-157098726 LGTM, merging this into master and 1.6 branch, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-11743][SQL] Add UserDefinedType support...

2015-11-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9712#issuecomment-157009687 **[Test build #45992 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45992/consoleFull)** for PR 9712 at commit

[GitHub] spark pull request: [SPARK-11743][SQL] Add UserDefinedType support...

2015-11-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9712#issuecomment-157024019 **[Test build #45994 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45994/consoleFull)** for PR 9712 at commit

[GitHub] spark pull request: [SPARK-11652] [CORE] Remote code execution wit...

2015-11-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9731#issuecomment-157027215 **[Test build #2064 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2064/consoleFull)** for PR 9731 at commit

[GitHub] spark pull request: [SPARK-11044][SQL] Parquet writer version fixe...

2015-11-16 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/9060#issuecomment-157027289 @marmbrus Is this one OK for branch-1.6? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11743][SQL] Add UserDefinedType support...

2015-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9712#issuecomment-157062181 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11544][SQL] sqlContext doesn't use Path...

2015-11-16 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/9652#discussion_r44942380 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala --- @@ -814,8 +821,18 @@ private[sql] object HadoopFsRelation extends

[GitHub] spark pull request: SPARK-11760 - Fix getSeconds() to use the time...

2015-11-16 Thread jbonofre
GitHub user jbonofre opened a pull request: https://github.com/apache/spark/pull/9738 SPARK-11760 - Fix getSeconds() to use the timezone You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbonofre/spark SPARK-11760 Alternatively

[GitHub] spark pull request: [SPARK-11544][SQL] sqlContext doesn't use Path...

2015-11-16 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/9652#discussion_r44942050 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala --- @@ -440,9 +441,15 @@ abstract class HadoopFsRelation

[GitHub] spark pull request: [Spark-11522][SQL] input_file_name() returns "...

2015-11-16 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9542#issuecomment-157083196 @xwu0226 https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45977/consoleFull is good. I will merge it to master and branch 1.6. --- If your project is

[GitHub] spark pull request: [SPARK-11752][SQL] fix timezone problem for Da...

2015-11-16 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/9728#issuecomment-157097729 Merged into master, 1.6 and 1.5 branch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11191] [SQL] [FOLLOW-UP] Cleans up unne...

2015-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9737#issuecomment-157085080 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11044][SQL] Parquet writer version fixe...

2015-11-16 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/9060#issuecomment-157027571 @HyukjinKwon Thanks! I've merged this one to master. And yes, please feel free to add the decimal test case(s). --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-11530] [MLLIB] Return eigenvalues with ...

2015-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9736#issuecomment-157029811 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11191] [SQL] [FOLLOW-UP] Cleans up unne...

2015-11-16 Thread liancheng
GitHub user liancheng opened a pull request: https://github.com/apache/spark/pull/9737 [SPARK-11191] [SQL] [FOLLOW-UP] Cleans up unnecessary anonymous HiveFunctionRegistry According to discussion in PR #9664, the anonymous `HiveFunctionRegistry` in `HiveContext` can be removed

[GitHub] spark pull request: [SPARK-11530] [MLLIB] Return eigenvalues with ...

2015-11-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9736#issuecomment-157030529 **[Test build #2065 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2065/consoleFull)** for PR 9736 at commit

[GitHub] spark pull request: [SPARK-11057] [SQL] Add correlation and covari...

2015-11-16 Thread NarineK
Github user NarineK commented on the pull request: https://github.com/apache/spark/pull/9366#issuecomment-157034131 Hi @sun-rui, thank you for your comment. In general, I think that, it might be better to verify all columns types and make sure that we are dealing with numeric

[GitHub] spark pull request: [SPARK-11057] [SQL] Add correlation and covari...

2015-11-16 Thread NarineK
Github user NarineK commented on the pull request: https://github.com/apache/spark/pull/9366#issuecomment-157034350 what do you think ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11551][DOC][Example]Replace example cod...

2015-11-16 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/9735#discussion_r44926012 --- Diff: docs/ml-features.md --- @@ -53,7 +53,24 @@ Refer to the [HashingTF Java docs](api/java/org/apache/spark/ml/feature/HashingT Refer to the

[GitHub] spark pull request: [SPARK-11743][SQL] Add UserDefinedType support...

2015-11-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9712#issuecomment-157061992 **[Test build #45994 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45994/consoleFull)** for PR 9712 at commit

[GitHub] spark pull request: [SPARK-11743][SQL] Add UserDefinedType support...

2015-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9712#issuecomment-157062183 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11692][SQL] Support for Parquet logical...

2015-11-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9658 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-10946][SQL]JDBC - Use Statement.execute...

2015-11-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9733#issuecomment-157010778 **[Test build #2063 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2063/consoleFull)** for PR 9733 at commit

[GitHub] spark pull request: [SPARK-11692][SQL] Support for Parquet logical...

2015-11-16 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/9658#issuecomment-157034946 Thanks! Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11191] [SQL] [FOLLOW-UP] Cleans up unne...

2015-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9737#issuecomment-157037682 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11551][DOC][Example]Replace example cod...

2015-11-16 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/9735#issuecomment-157041394 Hi @somideshmukh, thanks for working on this. You can use the PR https://github.com/apache/spark/pull/9713 as an example. What we need to do is replacing all raw code

[GitHub] spark pull request: [SPARK-11523][SQL] Throw AnalysisException for...

2015-11-16 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/9496#issuecomment-157030249 ping @liancheng --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11743][SQL] Add UserDefinedType support...

2015-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9712#issuecomment-157009732 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11743][SQL] Add UserDefinedType support...

2015-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9712#issuecomment-157009731 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11743][SQL] Add UserDefinedType support...

2015-11-16 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/9712#issuecomment-157021799 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: SPARK-6541 - Sort executors by ID (numeric)

2015-11-16 Thread jbonofre
Github user jbonofre commented on the pull request: https://github.com/apache/spark/pull/9165#issuecomment-157026374 Thanks Sean ! Let me know if you need anything. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11530] [MLLIB] Return eigenvalues with ...

2015-11-16 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/9736 [SPARK-11530] [MLLIB] Return eigenvalues with PCA model Add `computePrincipalComponentsAndVariance` to also compute PCA's explained variance. CC @mengxr You can merge this pull request

[GitHub] spark pull request: [SPARK-11551][DOC][Example]Replace example cod...

2015-11-16 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/9735#discussion_r44925725 --- Diff: docs/ml-features.md --- @@ -37,7 +37,7 @@ In the following code segment, we start with a set of sentences. We split each Refer to the

[GitHub] spark pull request: [SPARK-11191] [SQL] [FOLLOW-UP] Cleans up unne...

2015-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9737#issuecomment-157037680 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11530] [MLLIB] Return eigenvalues with ...

2015-11-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9736#issuecomment-157037907 **[Test build #2065 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2065/consoleFull)** for PR 9736 at commit

[GitHub] spark pull request: [SPARK-11057] [SQL] Add correlation and covari...

2015-11-16 Thread NarineK
Github user NarineK commented on a diff in the pull request: https://github.com/apache/spark/pull/9366#discussion_r44926444 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/stat/StatFunctions.scala --- @@ -33,6 +34,31 @@ private[sql] object StatFunctions extends

[GitHub] spark pull request: [SPARK-11191] [SPARK-11311] [SQL] Backports #9...

2015-11-16 Thread liancheng
Github user liancheng closed the pull request at: https://github.com/apache/spark/pull/9671 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11679][SQL] Invoking method " apply(fie...

2015-11-16 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9649#discussion_r44918972 --- Diff: sql/core/src/test/java/test/org/apache/spark/sql/JavaDataFrameSuite.java --- @@ -209,6 +206,18 @@ public void testCreateDataFromFromList() {

[GitHub] spark pull request: [SPARK-11191] [SQL] Looks up temporary functio...

2015-11-16 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/9664#discussion_r44924301 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala --- @@ -454,7 +454,7 @@ class HiveContext private[hive]( // Note that

[GitHub] spark pull request: [SPARK-11460][Core] Increase locality level wh...

2015-11-16 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/9433#issuecomment-157031091 ping @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-11191] [SQL] [FOLLOW-UP] Cleans up unne...

2015-11-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9737#issuecomment-157037193 **[Test build #45997 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45997/consoleFull)** for PR 9737 at commit

[GitHub] spark pull request: [SPARK-11044][SQL] Parquet writer version fixe...

2015-11-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9060 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11530] [MLLIB] Return eigenvalues with ...

2015-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9736#issuecomment-157029810 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10852][PySpark][SQL] Override built-in ...

2015-11-16 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/8934#issuecomment-157030709 ping @davies Any more comments? Or should we close this pr? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: SPARK-7729:Executor which has been killed shou...

2015-11-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/6263#discussion_r44960862 --- Diff: core/src/main/scala/org/apache/spark/ui/exec/ExecutorsPage.scala --- @@ -25,6 +25,7 @@ import scala.xml.Node import

[GitHub] spark pull request: [SPARK-11089] [SQL] Adds option for disabling ...

2015-11-16 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/9740#discussion_r44960873 --- Diff: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala --- @@ -635,6 +683,7 @@ abstract class

[GitHub] spark pull request: SPARK-7729:Executor which has been killed shou...

2015-11-16 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/6263#issuecomment-157128907 @archit279thakur yeah don't worry about that test failure ... when you push updates & bring up to date w/ master the tests will re-run in any case --- If your project

[GitHub] spark pull request: [SPARK-10181][SQL] Do kerberos login for crede...

2015-11-16 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9272#issuecomment-157128630 Also merged to branch-1.5. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-7729:Executor which has been killed shou...

2015-11-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/6263#discussion_r44961686 --- Diff: core/src/main/scala/org/apache/spark/storage/StorageStatusListener.scala --- @@ -87,6 +113,8 @@ class StorageStatusListener extends SparkListener {

[GitHub] spark pull request: [SPARK-11089] [SQL] Adds option for disabling ...

2015-11-16 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/9740#discussion_r44964862 --- Diff: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala --- @@ -635,6 +683,7 @@ abstract class

[GitHub] spark pull request: [SPARK-11031][SPARKR] Method str() on a DataFr...

2015-11-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9613#issuecomment-157140688 **[Test build #46002 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46002/consoleFull)** for PR 9613 at commit

[GitHub] spark pull request: Prevent the call to StreamingContext#stop() in...

2015-11-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9741#issuecomment-157141605 **[Test build #46001 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46001/consoleFull)** for PR 9741 at commit

[GitHub] spark pull request: Prevent the call to StreamingContext#stop() in...

2015-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9741#issuecomment-157141612 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: Prevent the call to StreamingContext#stop() in...

2015-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9741#issuecomment-157141615 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [Spark-11522][SQL] input_file_name() returns "...

2015-11-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9542 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11743][SQL] Add UserDefinedType support...

2015-11-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9712 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11752][SQL] fix timezone problem for Da...

2015-11-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9728 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: SPARK-11760 - Fix getSeconds() to use the time...

2015-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9738#issuecomment-157100489 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11530] [MLLIB] Return eigenvalues with ...

2015-11-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9736#issuecomment-157099967 **[Test build #45998 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45998/consoleFull)** for PR 9736 at commit

[GitHub] spark pull request: [SPARK-11744][Launcher] Fix print version thro...

2015-11-16 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9721#issuecomment-157116639 LGTM (although you could probably have a single flag for both). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: SPARK-11716 - UDFRegistration just drops the i...

2015-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9739#issuecomment-157116741 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11583] [Core]MapStatus Using RoaringBit...

2015-11-16 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/9661#discussion_r44958298 --- Diff: core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala --- @@ -21,24 +21,24 @@ import java.io.{EOFException, IOException, InputStream,

[GitHub] spark pull request: [SPARK-11583] [Core]MapStatus Using RoaringBit...

2015-11-16 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/9661#issuecomment-157136868 SGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-11089] [SQL] Adds option for disabling ...

2015-11-16 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/9740#discussion_r44966303 --- Diff: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala --- @@ -635,6 +683,7 @@ abstract class

[GitHub] spark pull request: Prevent the call to StreamingContext#stop() in...

2015-11-16 Thread tedyu
GitHub user tedyu opened a pull request: https://github.com/apache/spark/pull/9741 Prevent the call to StreamingContext#stop() in the listener bus's thread See discussion toward the tail of https://github.com/apache/spark/pull/9723 You can merge this pull request into a Git

[GitHub] spark pull request: SPARK-11760 - Fix getSeconds() to use the time...

2015-11-16 Thread jbonofre
Github user jbonofre commented on the pull request: https://github.com/apache/spark/pull/9738#issuecomment-157102150 A fix has already been applied. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: SPARK-11760 - Fix getSeconds() to use the time...

2015-11-16 Thread jbonofre
Github user jbonofre closed the pull request at: https://github.com/apache/spark/pull/9738 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11089] [SQL] Adds option for disabling ...

2015-11-16 Thread liancheng
GitHub user liancheng opened a pull request: https://github.com/apache/spark/pull/9740 [SPARK-11089] [SQL] Adds option for disabling multi-session in Thrift server This PR adds a new option `spark.sql.hive.thriftServer.singleSession` for disabling multi-session support in the

[GitHub] spark pull request: [SPARK-11583] [Core]MapStatus Using RoaringBit...

2015-11-16 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/9661#discussion_r44958484 --- Diff: core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala --- @@ -173,18 +172,15 @@ private[spark] object HighlyCompressedMapStatus {

[GitHub] spark pull request: [SPARK-11089] [SQL] Adds option for disabling ...

2015-11-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9740#issuecomment-157122865 **[Test build #46000 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46000/consoleFull)** for PR 9740 at commit

[GitHub] spark pull request: [SPARK-11583] [Core]MapStatus Using RoaringBit...

2015-11-16 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/9661#issuecomment-157125514 @yaooqinn This PR looks good to me overall. Since your patch basically revert #9243, I'd like to revert that first, then rebase this pr, to make the history more clear.

[GitHub] spark pull request: [SPARK-11089] [SQL] Adds option for disabling ...

2015-11-16 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/9740#issuecomment-157128229 @liancheng This option is only for backward compatibility purpose, could we document it somewhere? We should also mention this change (isolated sessions) in release

[GitHub] spark pull request: [SPARK-11447][SQL] change NullType to StringTy...

2015-11-16 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/9720#discussion_r44963028 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala --- @@ -280,6 +280,12 @@ object HiveTypeCoercion {

[GitHub] spark pull request: [SPARK-11089] [SQL] Adds option for disabling ...

2015-11-16 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/9740#issuecomment-157134508 Yeah, I'll add it to the programming guide. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11617] [network] Fix leak in TransportF...

2015-11-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9619#issuecomment-157116469 **[Test build #45999 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45999/consoleFull)** for PR 9619 at commit

[GitHub] spark pull request: [SPARK-7799][Streaming]Add "streaming-akka" pr...

2015-11-16 Thread zsxwing
Github user zsxwing closed the pull request at: https://github.com/apache/spark/pull/6841 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-7799][Streaming]Add "streaming-akka" pr...

2015-11-16 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/6841#issuecomment-157124033 I'm closing this one. We can reopen it if we want to do it in 1.7. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-11089] [SQL] Adds option for disabling ...

2015-11-16 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/9740#issuecomment-157127825 @liancheng I like the this approach more, all global configurations should be placed in SparkConf (could be override in current session) --- If your project is set up

[GitHub] spark pull request: [SPARK-11195][CORE] Use correct classloader fo...

2015-11-16 Thread choochootrain
Github user choochootrain commented on a diff in the pull request: https://github.com/apache/spark/pull/9367#discussion_r44965129 --- Diff: core/src/main/scala/org/apache/spark/TestUtils.scala --- @@ -130,7 +131,7 @@ private[spark] object TestUtils { val fileName =

[GitHub] spark pull request: [SPARK-11195][CORE] Use correct classloader fo...

2015-11-16 Thread choochootrain
Github user choochootrain commented on a diff in the pull request: https://github.com/apache/spark/pull/9367#discussion_r44965069 --- Diff: core/src/test/scala/org/apache/spark/scheduler/TaskResultGetterSuite.scala --- @@ -17,8 +17,13 @@ package

[GitHub] spark pull request: [SPARK-11044][SQL] Parquet writer version fixe...

2015-11-16 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/9060#issuecomment-157138358 Merging to branch-1.6. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-11720] [SQL][ML] Return Double.NaN inst...

2015-11-16 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/9705#issuecomment-157140840 LGTM. cc @yhuai for another pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: Prevent the call to StreamingContext#stop() in...

2015-11-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9741#issuecomment-157140927 **[Test build #46001 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46001/consoleFull)** for PR 9741 at commit

[GitHub] spark pull request: [SPARK-11044][SQL] Parquet writer version fixe...

2015-11-16 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9060#issuecomment-157108064 Sure --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-11617] [network] Fix leak in TransportF...

2015-11-16 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9619#issuecomment-157111920 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11535][ML] handling empty string in Str...

2015-11-16 Thread pravingadakh
Github user pravingadakh commented on the pull request: https://github.com/apache/spark/pull/9522#issuecomment-157131275 @jkbradley Any updates on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [Spark-11522][SQL] input_file_name() returns "...

2015-11-16 Thread xwu0226
Github user xwu0226 commented on the pull request: https://github.com/apache/spark/pull/9542#issuecomment-157131325 @yhuai Many thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11195][CORE] Use correct classloader fo...

2015-11-16 Thread choochootrain
Github user choochootrain commented on a diff in the pull request: https://github.com/apache/spark/pull/9367#discussion_r44967313 --- Diff: core/src/test/scala/org/apache/spark/scheduler/TaskResultGetterSuite.scala --- @@ -119,5 +124,47 @@ class TaskResultGetterSuite extends

[GitHub] spark pull request: [SPARK-11755] [R] SparkR should export "predic...

2015-11-16 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/9732#discussion_r44952987 --- Diff: R/pkg/R/generics.R --- @@ -1054,6 +1054,10 @@ setGeneric("year", function(x) { standardGeneric("year") }) #' @export setGeneric("glm")

[GitHub] spark pull request: [SPARK-11692][SQL] Support for Parquet logical...

2015-11-16 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9658#issuecomment-157106033 We've added support for reading these types as strings, but we can't round trip data without losing the annotation which might be kind of confusing for users. Perhaps

[GitHub] spark pull request: [SPARK-11089] [SQL] Adds option for disabling ...

2015-11-16 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/9740#issuecomment-157121925 Another approach for this problem is to have "global" options. For example, `SET -g key=value` sets `key` to `value` for all sessions. This adds a new concept and

  1   2   3   4   5   6   7   >