[GitHub] spark pull request: [SPARK-11820] [ML] [PySpark] PySpark LiR & LoR...

2015-11-18 Thread yanboliang
GitHub user yanboliang opened a pull request: https://github.com/apache/spark/pull/9811 [SPARK-11820] [ML] [PySpark] PySpark LiR & LoR should support weightCol [SPARK-7685](https://issues.apache.org/jira/browse/SPARK-7685) and

[GitHub] spark pull request: [SPARK-11820] [ML] [PySpark] PySpark LiR & LoR...

2015-11-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9811#issuecomment-157749945 **[Test build #46218 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46218/consoleFull)** for PR 9811 at commit

[GitHub] spark pull request: [SPARK-11818][REPL] Fix ExecutorClassLoader to...

2015-11-18 Thread HeartSaVioR
GitHub user HeartSaVioR opened a pull request: https://github.com/apache/spark/pull/9812 [SPARK-11818][REPL] Fix ExecutorClassLoader to lookup resources from … …parent class loader Without patch, two additional tests of ExecutorClassLoaderSuite fails. -

[GitHub] spark pull request: [SPARK-11818][REPL] Fix ExecutorClassLoader to...

2015-11-18 Thread tedyu
Github user tedyu commented on the pull request: https://github.com/apache/spark/pull/9812#issuecomment-157758507 Jenkins, please test this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [WIP] [SPARK-11327] [MESOS] Dispatcher does no...

2015-11-18 Thread dragos
Github user dragos commented on a diff in the pull request: https://github.com/apache/spark/pull/9752#discussion_r45224067 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala --- @@ -422,6 +422,37 @@ private[spark] class

[GitHub] spark pull request: [SPARK-11791] Fix flaky test in BatchedWriteAh...

2015-11-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9790#issuecomment-157772007 **[Test build #46221 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46221/consoleFull)** for PR 9790 at commit

[GitHub] spark pull request: [SPARK-11773][SPARKR] Implement collection fun...

2015-11-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9764 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11195][CORE] Use correct classloader fo...

2015-11-18 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9779#issuecomment-157786997 LGTM. Merging to master and branch 1.6. I will try to cherry-pick it to 1.5. If there is no major conflict, we will not need a 1.5 specific pr. --- If your project is

[GitHub] spark pull request: [SPARK-11195][CORE] Use correct classloader fo...

2015-11-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9779 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11195][CORE] Use correct classloader fo...

2015-11-18 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9367#issuecomment-157793454 @choochootrain #9779 has been merged. Can you close this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-11791] Fix flaky test in BatchedWriteAh...

2015-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9790#issuecomment-157796265 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11314] [YARN] add service API and test ...

2015-11-18 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/9182#discussion_r45225663 --- Diff: yarn/src/main/scala/org/apache/spark/scheduler/cluster/SchedulerExtensionService.scala --- @@ -0,0 +1,160 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-11314] [YARN] add service API and test ...

2015-11-18 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/9182#discussion_r45226057 --- Diff: yarn/src/main/scala/org/apache/spark/scheduler/cluster/SchedulerExtensionService.scala --- @@ -0,0 +1,160 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-11314] [YARN] add service API and test ...

2015-11-18 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/9182#discussion_r45226337 --- Diff: yarn/src/main/scala/org/apache/spark/scheduler/cluster/SchedulerExtensionService.scala --- @@ -0,0 +1,160 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-11314] [YARN] add service API and test ...

2015-11-18 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/9182#discussion_r45226729 --- Diff: yarn/src/main/scala/org/apache/spark/scheduler/cluster/SchedulerExtensionService.scala --- @@ -0,0 +1,160 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-6790] [ML] Add linear regression model ...

2015-11-18 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9656#issuecomment-157778996 I'll go ahead and send an update. Thanks for your updates though! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-11339][SPARKR] Document the list of fun...

2015-11-18 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/9785#issuecomment-157787523 So my take on this is as follows: 1. If we have have the same name but different parameter types when compared to base R then we should make sure the base R command

[GitHub] spark pull request: [SPARK-11195][CORE] Use correct classloader fo...

2015-11-18 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9779#issuecomment-157787067 Thank you for the fix! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11314] [YARN] add service API and test ...

2015-11-18 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/9182#discussion_r45226180 --- Diff: yarn/src/main/scala/org/apache/spark/scheduler/cluster/SchedulerExtensionService.scala --- @@ -0,0 +1,160 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-11031][SPARKR] Method str() on a DataFr...

2015-11-18 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/9613#issuecomment-157786743 @felixcheung @shivaram Any more comments, folks? Otherwise, can we merge this? Thank you! --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-11818][REPL] Fix ExecutorClassLoader to...

2015-11-18 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/9812#discussion_r45225492 --- Diff: repl/src/main/scala/org/apache/spark/repl/ExecutorClassLoader.scala --- @@ -55,6 +57,14 @@ class ExecutorClassLoader(conf: SparkConf, classUri:

[GitHub] spark pull request: [SPARK-11818][REPL] Fix ExecutorClassLoader to...

2015-11-18 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/9812#discussion_r45225563 --- Diff: core/src/main/scala/org/apache/spark/TestUtils.scala --- @@ -159,6 +159,16 @@ private[spark] object TestUtils {

[GitHub] spark pull request: [SPARK-11636] [SQL] Support classes defined in...

2015-11-18 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9602#issuecomment-15378 Test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11633] [SQL] HiveContext's Case Insensi...

2015-11-18 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9762#issuecomment-157783851 @cloud-fan s suggestion sounds correct to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11633] [SQL] HiveContext's Case Insensi...

2015-11-18 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/9762#issuecomment-157786406 @cloud-fan @marmbrus Will follow your suggestions to update the fix. Thanks! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-11787] [SQL] Improve Parquet scan perfo...

2015-11-18 Thread nongli
Github user nongli closed the pull request at: https://github.com/apache/spark/pull/9801 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-10745][Core]Separate configs between sh...

2015-11-18 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/9481#issuecomment-157796036 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11810][SQL] Java-based encoder for opaq...

2015-11-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9802#issuecomment-157795321 **[Test build #2086 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2086/consoleFull)** for PR 9802 at commit

[GitHub] spark pull request: [SPARK-11791] Fix flaky test in BatchedWriteAh...

2015-11-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9790#issuecomment-157795846 **[Test build #46221 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46221/consoleFull)** for PR 9790 at commit

[GitHub] spark pull request: [SPARK-11791] Fix flaky test in BatchedWriteAh...

2015-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9790#issuecomment-157796262 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11530] [MLLIB] Return eigenvalues with ...

2015-11-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9736#issuecomment-157746373 **[Test build #46214 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46214/consoleFull)** for PR 9736 at commit

[GitHub] spark pull request: [SPARK-11820] [ML] [PySpark] PySpark LiR & LoR...

2015-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9811#issuecomment-157753815 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11638] [Mesos + Docker Bridge networkin...

2015-11-18 Thread skonto
Github user skonto commented on the pull request: https://github.com/apache/spark/pull/9608#issuecomment-157761772 guys...i tried to verify it check https://issues.apache.org/jira/browse/SPARK-11638 for the details. --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-11803][SQL] fix Dataset self-join

2015-11-18 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/9806#issuecomment-157749632 Your code looks pretty clean to me. Let me share my test cases this PR failed. ``` test("joinWith tuple - self join 1") { val ds = Seq(("a", 1),

[GitHub] spark pull request: [SPARK-11819][SQL] nice error message for miss...

2015-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9810#issuecomment-157751238 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11530] [MLLIB] Return eigenvalues with ...

2015-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9736#issuecomment-157746561 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11820] [ML] [PySpark] PySpark LiR & LoR...

2015-11-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9811#issuecomment-157753586 **[Test build #46218 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46218/consoleFull)** for PR 9811 at commit

[GitHub] spark pull request: [SPARK-11792] [SQL] [FOLLOW-UP] Change SizeEst...

2015-11-18 Thread yhuai
GitHub user yhuai opened a pull request: https://github.com/apache/spark/pull/9813 [SPARK-11792] [SQL] [FOLLOW-UP] Change SizeEstimation to KnownSizeEstimation and make estimatedSize return Long instead of Option[Long] https://issues.apache.org/jira/browse/SPARK-11792 The

[GitHub] spark pull request: [SPARK-11792] [SQL] [FOLLOW-UP] Change SizeEst...

2015-11-18 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9813#issuecomment-157754488 @davies how about this version? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11792] [SQL] [FOLLOW-UP] Change SizeEst...

2015-11-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9813#issuecomment-157758023 **[Test build #46219 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46219/consoleFull)** for PR 9813 at commit

[GitHub] spark pull request: [SPARK-11281][SPARKR] Add tests covering the i...

2015-11-18 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/9743#issuecomment-157769040 LGTM. Thanks @zero323 @sun-rui -- Merging this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11773][SPARKR] Implement collection fun...

2015-11-18 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/9764#issuecomment-157771427 Looks good. Good to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11819][SQL] nice error message for miss...

2015-11-18 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/9810 [SPARK-11819][SQL] nice error message for missing encoder before this PR, when users try to get an encoder for an un-supported class, they will only get a very simple error message like `Encoder

[GitHub] spark pull request: [SPARK-11819][SQL] nice error message for miss...

2015-11-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9810#issuecomment-157744727 **[Test build #46217 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46217/consoleFull)** for PR 9810 at commit

[GitHub] spark pull request: [SPARK-11820] [ML] [PySpark] PySpark LiR & LoR...

2015-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9811#issuecomment-157753792 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11530] [MLLIB] Return eigenvalues with ...

2015-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9736#issuecomment-157746563 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11804][PYSPARK] Exception raise when us...

2015-11-18 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/9791#issuecomment-157764846 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-11791] Fix flaky test in BatchedWriteAh...

2015-11-18 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/9790#issuecomment-157768764 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11819][SQL] nice error message for miss...

2015-11-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9810#issuecomment-157751175 **[Test build #46217 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46217/consoleFull)** for PR 9810 at commit

[GitHub] spark pull request: [SPARK-11819][SQL] nice error message for miss...

2015-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9810#issuecomment-157751232 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11818][REPL] Fix ExecutorClassLoader to...

2015-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9812#issuecomment-157752759 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11281][SPARKR] Add tests covering the i...

2015-11-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9743 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11773][SPARKR] Implement collection fun...

2015-11-18 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/9764#issuecomment-157770818 @felixcheung any other comments on this or is this good to merge ? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-11819][SQL] nice error message for miss...

2015-11-18 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/9810#issuecomment-157743926 cc @marmbrus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11804][PYSPARK] Exception raise when us...

2015-11-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9791 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-10745][Core]Separate configs between sh...

2015-11-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9481#issuecomment-157802030 **[Test build #46223 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46223/consoleFull)** for PR 9481 at commit

[GitHub] spark pull request: [WIP] [SPARK-11787] [SQL] Improve Parquet scan...

2015-11-18 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9774#discussion_r45235195 --- Diff: core/src/main/scala/org/apache/spark/rdd/SqlNewHadoopRDD.scala --- @@ -150,9 +155,30 @@ private[spark] class SqlNewHadoopRDD[V: ClassTag](

[GitHub] spark pull request: [SPARK-11810][SQL] Java-based encoder for opaq...

2015-11-18 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9802#discussion_r45235789 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/Encoder.scala --- @@ -43,28 +43,48 @@ trait Encoder[T] extends Serializable { */ object

[GitHub] spark pull request: [SPARK-11140] [core] Transfer files using netw...

2015-11-18 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9530#issuecomment-157804525 > Maybe you can just submit more prs basing on previous ones I don't know of any clean way of doing that in github; they'd end up including all the code in this

[GitHub] spark pull request: [SPARK-11819][SQL] nice error message for miss...

2015-11-18 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9810#discussion_r45236651 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ProductEncoder.scala --- @@ -61,7 +62,31 @@ object ProductEncoder {

[GitHub] spark pull request: [SPARK-11803][SQL] fix Dataset self-join

2015-11-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9806 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11803][SQL] fix Dataset self-join

2015-11-18 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/9806#issuecomment-157807682 Sure. Will do. Thanks! 2015-11-18 10:16 GMT-08:00 Michael Armbrust : > LGTM, merging to master and 1.6. > >

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-18 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/9796#discussion_r45237925 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala --- @@ -462,7 +463,8 @@ class

[GitHub] spark pull request: [SPARK-11725][SQL] correctly handle null input...

2015-11-18 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9770#discussion_r45238084 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1063,6 +1065,34 @@ class Analyzer(

[GitHub] spark pull request: [SPARK-11725][SQL] correctly handle null input...

2015-11-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9770 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11720] [SQL][ML] Handle edge cases when...

2015-11-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9705#issuecomment-157812732 **[Test build #46225 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46225/consoleFull)** for PR 9705 at commit

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-157813815 **[Test build #46224 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46224/consoleFull)** for PR 9796 at commit

[GitHub] spark pull request: [SPARK-11792] [SQL] [FOLLOW-UP] Change SizeEst...

2015-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9813#issuecomment-157815786 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11792] [SQL] [FOLLOW-UP] Change SizeEst...

2015-11-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9813#issuecomment-157815469 **[Test build #46219 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46219/consoleFull)** for PR 9813 at commit

[GitHub] spark pull request: [WIP] [SPARK-11327] [MESOS] Dispatcher does no...

2015-11-18 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9752#discussion_r45243548 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala --- @@ -422,6 +422,37 @@ private[spark] class

[GitHub] spark pull request: [SPARK-11799][CORE] Make it explicit in execut...

2015-11-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9809#issuecomment-157823280 **[Test build #46229 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46229/consoleFull)** for PR 9809 at commit

[GitHub] spark pull request: [SPARK-11812] [PySpark]

2015-11-18 Thread dtolpin
Github user dtolpin commented on the pull request: https://github.com/apache/spark/pull/9775#issuecomment-157806025 I don't see how I can make a meaningful unit test for this bug, unfortunately. That would require that I use a time-based window with reduceByKeyAndWindow, and fixture

[GitHub] spark pull request: [SPARK-11819][SQL] nice error message for miss...

2015-11-18 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9810#discussion_r45236348 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -719,6 +719,12 @@ trait ScalaReflection { }

[GitHub] spark pull request: [SPARK-11819][SQL] nice error message for miss...

2015-11-18 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9810#discussion_r45236560 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ProductEncoder.scala --- @@ -61,7 +62,31 @@ object ProductEncoder {

[GitHub] spark pull request: [SPARK-11803][SQL] fix Dataset self-join

2015-11-18 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9806#issuecomment-157806994 LGTM, merging to master and 1.6. @gatorsmile please open JIRAs targeted at 1.6.0 for the bugs you have found. (also use `checkAnswer` when writing test

[GitHub] spark pull request: [SPARK-11725][SQL] correctly handle null input...

2015-11-18 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9770#issuecomment-157810190 Looks great! Merging to master and 1.6. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11795][SQL] combine grouping attributes...

2015-11-18 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9792#issuecomment-157812686 LGTM, merging into master and 1.6. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-6790] [ML] Add linear regression model ...

2015-11-18 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9656#issuecomment-157814993 @fayeshine I had to merge with master to get some updates from a LogReg PR, so I couldn't create a clean PR to send you. I instead created a new PR:

[GitHub] spark pull request: [SPARK-6790] [ML] Add spark.ml LinearRegressio...

2015-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9814#issuecomment-157817423 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11195][CORE] Use correct classloader fo...

2015-11-18 Thread choochootrain
Github user choochootrain commented on the pull request: https://github.com/apache/spark/pull/9367#issuecomment-157817239 thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-6790] [ML] Add spark.ml LinearRegressio...

2015-11-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9814#issuecomment-157817411 **[Test build #46227 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46227/consoleFull)** for PR 9814 at commit

[GitHub] spark pull request: [SPARK-11809] Switch the default Mesos mode to...

2015-11-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9795#issuecomment-157823679 **[Test build #46230 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46230/consoleFull)** for PR 9795 at commit

[GitHub] spark pull request: [SPARK-4557] [Streaming] Spark Streaming forea...

2015-11-18 Thread BryanCutler
Github user BryanCutler commented on the pull request: https://github.com/apache/spark/pull/9488#issuecomment-157798989 I think this is good to go @tdas --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [WIP] [SPARK-11787] [SQL] Improve Parquet scan...

2015-11-18 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9774#discussion_r45234982 --- Diff: core/src/main/scala/org/apache/spark/rdd/SqlNewHadoopRDD.scala --- @@ -96,6 +96,11 @@ private[spark] class SqlNewHadoopRDD[V: ClassTag](

[GitHub] spark pull request: [SPARK-11787] [SQL] Improve Parquet scan perfo...

2015-11-18 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9801#discussion_r45234849 --- Diff: core/src/main/scala/org/apache/spark/rdd/SqlNewHadoopRDD.scala --- @@ -96,6 +96,11 @@ private[spark] class SqlNewHadoopRDD[V: ClassTag](

[GitHub] spark pull request: [SPARK-11819][SQL] nice error message for miss...

2015-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9810#issuecomment-157803956 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11819][SQL] nice error message for miss...

2015-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9810#issuecomment-157803953 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [WIP] [SPARK-11787] [SQL] Improve Parquet scan...

2015-11-18 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9774#discussion_r45235636 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/UnsafeRowParquetRecordReader.java --- @@ -0,0 +1,613 @@ +/* + *

[GitHub] spark pull request: [SPARK-11819][SQL] nice error message for miss...

2015-11-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9810#issuecomment-157803802 **[Test build #46220 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46220/consoleFull)** for PR 9810 at commit

[GitHub] spark pull request: [SPARK-11810][SQL] Java-based encoder for opaq...

2015-11-18 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9802#discussion_r45236071 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/FlatEncoderSuite.scala --- @@ -82,6 +82,16 @@ class FlatEncoderSuite extends

[GitHub] spark pull request: [SPARK-11814][Streaming]Add better default che...

2015-11-18 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/9805#discussion_r45236372 --- Diff: streaming/src/test/scala/org/apache/spark/streaming/TrackStateByKeySuite.scala --- @@ -436,6 +437,41 @@ class TrackStateByKeySuite extends

[GitHub] spark pull request: [SPARK-11810][SQL] Java-based encoder for opaq...

2015-11-18 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9802#discussion_r45236253 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala --- @@ -517,29 +517,39 @@ case class

[GitHub] spark pull request: [SPARK-11819][SQL] nice error message for miss...

2015-11-18 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9810#discussion_r45236758 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ProductEncoder.scala --- @@ -61,7 +62,31 @@ object ProductEncoder {

[GitHub] spark pull request: [SPARK-11819][SQL] nice error message for miss...

2015-11-18 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9810#issuecomment-157806550 This message looks great! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-11809] Switch the default Mesos mode to...

2015-11-18 Thread tnachen
Github user tnachen commented on the pull request: https://github.com/apache/spark/pull/9795#issuecomment-157807917 LGTM as well! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-18 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-157810833 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11795][SQL] combine grouping attributes...

2015-11-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9792 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11314] [YARN] add service API and test ...

2015-11-18 Thread steveloughran
Github user steveloughran commented on the pull request: https://github.com/apache/spark/pull/9182#issuecomment-157813169 OK, this is what I've done 1. AM doesn't propagate app/attempt IDs via system properties. It still sets them for other things to use, including

[GitHub] spark pull request: [SPARK-6790] [ML] Add spark.ml LinearRegressio...

2015-11-18 Thread jkbradley
GitHub user jkbradley opened a pull request: https://github.com/apache/spark/pull/9814 [SPARK-6790] [ML] Add spark.ml LinearRegression import/export This replaces [https://github.com/apache/spark/pull/9656] with updates. @fayeshine should be the main author when this PR is

[GitHub] spark pull request: [SPARK-11314] [YARN] add service API and test ...

2015-11-18 Thread steveloughran
Github user steveloughran commented on the pull request: https://github.com/apache/spark/pull/9182#issuecomment-157814298 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

  1   2   3   4   5   6   7   8   9   10   >