[GitHub] spark pull request: [SPARK-12234] [SparkR] Fix ```subset``` functi...

2015-12-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10217#issuecomment-163154351 **[Test build #47421 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47421/consoleFull)** for PR 10217 at commit

[GitHub] spark pull request: [SPARK-12181] Check Cached unaligned-access ca...

2015-12-09 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10181#issuecomment-163159930 I don't think simply adding a test for the field works. It is part of the jdk lib, not a jar we ship. Adding a test only tests our own Jenkins environment.

[GitHub] spark pull request: [SPARK-12236][SQL] JDBC filter tests all pass ...

2015-12-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10221#issuecomment-163159813 **[Test build #47418 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47418/consoleFull)** for PR 10221 at commit

[GitHub] spark pull request: [SPARK-11551][DOC] Replace example code in ml-...

2015-12-09 Thread BenFradet
Github user BenFradet commented on a diff in the pull request: https://github.com/apache/spark/pull/10219#discussion_r47068305 --- Diff: examples/src/main/scala/org/apache/spark/examples/ml/PolynomialExpansionExample.scala --- @@ -0,0 +1,53 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-11551][DOC] Replace example code in ml-...

2015-12-09 Thread BenFradet
Github user BenFradet commented on a diff in the pull request: https://github.com/apache/spark/pull/10219#discussion_r47068389 --- Diff: examples/src/main/scala/org/apache/spark/examples/ml/PCAExample.scala --- @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-11551][DOC] Replace example code in ml-...

2015-12-09 Thread BenFradet
Github user BenFradet commented on a diff in the pull request: https://github.com/apache/spark/pull/10219#discussion_r47068461 --- Diff: examples/src/main/scala/org/apache/spark/examples/ml/OneHotEncoderExample.scala --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-8641][SQL] Native Spark Window function...

2015-12-09 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/9819#discussion_r47071980 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala --- @@ -328,3 +281,222 @@ object

[GitHub] spark pull request: [SPARK-12227][SQL] Support drop multiple colum...

2015-12-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10218#issuecomment-163146790 **[Test build #47412 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47412/consoleFull)** for PR 10218 at commit

[GitHub] spark pull request: [SPARK-12227][SQL] Support drop multiple colum...

2015-12-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10218#issuecomment-163146896 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12227][SQL] Support drop multiple colum...

2015-12-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10218#issuecomment-163146900 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11965] [ML] [Doc] Update user guide for...

2015-12-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10222#issuecomment-163152437 **[Test build #47420 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47420/consoleFull)** for PR 10222 at commit

[GitHub] spark pull request: [SPARK-9104][SPARK-9105][SPARK-9106][SPARK-910...

2015-12-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7753#issuecomment-163157990 **[Test build #47415 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47415/consoleFull)** for PR 7753 at commit

[GitHub] spark pull request: [SPARK-5682][Core] Add encrypted shuffle in sp...

2015-12-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8880#issuecomment-163162054 **[Test build #47416 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47416/consoleFull)** for PR 8880 at commit

[GitHub] spark pull request: [SPARK-5682][Core] Add encrypted shuffle in sp...

2015-12-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8880#issuecomment-163162274 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12238][STREAMING][DOCS] s/Advanced Sour...

2015-12-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10223#issuecomment-163166615 **[Test build #47423 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47423/consoleFull)** for PR 10223 at commit

[GitHub] spark pull request: [SPARK-12238][STREAMING][DOCS] s/Advanced Sour...

2015-12-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10223#issuecomment-163166743 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12238][STREAMING][DOCS] s/Advanced Sour...

2015-12-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10223#issuecomment-163166744 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11944][PYSPARK][MLLIB] python mllib.clu...

2015-12-09 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/10150#discussion_r47070153 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/api/python/PythonMLLibAPI.scala --- @@ -121,6 +121,22 @@ private[python] class PythonMLLibAPI

[GitHub] spark pull request: [SPARK-7727] [SQL] Avoid inner classes in Rule...

2015-12-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10174#issuecomment-163179211 **[Test build #47425 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47425/consoleFull)** for PR 10174 at commit

[GitHub] spark pull request: [SPARK-8641][SQL] Native Spark Window function...

2015-12-09 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/9819#discussion_r47073846 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala --- @@ -328,3 +281,222 @@ object

[GitHub] spark pull request: [SPARK-8641][SQL] Native Spark Window function...

2015-12-09 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/9819#discussion_r47073901 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala --- @@ -328,3 +281,222 @@ object

[GitHub] spark pull request: [SPARK-12234] [SparkR] Fix ```subset``` functi...

2015-12-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10217#issuecomment-163144713 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12161][SQL] Ignore order of predicates ...

2015-12-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10163#issuecomment-163144747 **[Test build #47419 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47419/consoleFull)** for PR 10163 at commit

[GitHub] spark pull request: [SPARK-12234] [SparkR] Fix ```subset``` functi...

2015-12-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10217#issuecomment-163144711 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11965] [ML] [Doc] Update user guide for...

2015-12-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10222#issuecomment-163150264 **[Test build #47420 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47420/consoleFull)** for PR 10222 at commit

[GitHub] spark pull request: [SPARK-11551][DOC] Replace example code in ml-...

2015-12-09 Thread BenFradet
Github user BenFradet commented on a diff in the pull request: https://github.com/apache/spark/pull/10219#discussion_r47068203 --- Diff: examples/src/main/scala/org/apache/spark/examples/ml/StringIndexerExample.scala --- @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-11551][DOC] Replace example code in ml-...

2015-12-09 Thread BenFradet
Github user BenFradet commented on the pull request: https://github.com/apache/spark/pull/10219#issuecomment-163165116 I notice some formatting quirks, especially for scala examples, otherwise it looks good. However, shouldn't we take advantage of this pr to standardize the

[GitHub] spark pull request: [SPARK-7727] [SQL] Avoid inner classes in Rule...

2015-12-09 Thread stephankessler
Github user stephankessler commented on a diff in the pull request: https://github.com/apache/spark/pull/10174#discussion_r47071677 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -17,6 +17,8 @@ package

[GitHub] spark pull request: [SPARK-7727] [SQL] Avoid inner classes in Rule...

2015-12-09 Thread stephankessler
Github user stephankessler commented on a diff in the pull request: https://github.com/apache/spark/pull/10174#discussion_r47071770 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala --- @@ -56,12 +55,16 @@ abstract class

[GitHub] spark pull request: [SPARK-11551][DOC] Replace example code in ml-...

2015-12-09 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/10219#issuecomment-163173174 @BenFradet It's reasonable. I'll modify them now. Thanks for the review. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

2015-12-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10004#issuecomment-163178578 **[Test build #47422 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47422/consoleFull)** for PR 10004 at commit

[GitHub] spark pull request: [SPARK-9104][SPARK-9105][SPARK-9106][SPARK-910...

2015-12-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7753#issuecomment-163158139 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12234] [SparkR] Fix ```subset``` functi...

2015-12-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10217#issuecomment-163158401 **[Test build #47421 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47421/consoleFull)** for PR 10217 at commit

[GitHub] spark pull request: [SPARK-9104][SPARK-9105][SPARK-9106][SPARK-910...

2015-12-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7753#issuecomment-163158136 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-5682][Core] Add encrypted shuffle in sp...

2015-12-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8880#issuecomment-163162276 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12238][STREAMING][DOCS] s/Advanced Sour...

2015-12-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10223#issuecomment-163164284 **[Test build #47423 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47423/consoleFull)** for PR 10223 at commit

[GitHub] spark pull request: [SPARK-11922][PYSPARK][ML] Python api for ml.f...

2015-12-09 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/10085#issuecomment-163172333 @yanboliang I am OK to change `Bucketizer` to a `JavaModel`. At that time I just do not want to change that piece of code. That's also why I closed my PR because I

[GitHub] spark pull request: [SPARK-11923][ML] Python API for ml.feature.Ch...

2015-12-09 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/10186#discussion_r47074185 --- Diff: python/pyspark/ml/feature.py --- @@ -2093,6 +2093,95 @@ class RFormulaModel(JavaModel): """ +@inherit_doc +class

[GitHub] spark pull request: [SPARK-11923][ML] Python API for ml.feature.Ch...

2015-12-09 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/10186#discussion_r47074147 --- Diff: python/pyspark/ml/feature.py --- @@ -2093,6 +2093,95 @@ class RFormulaModel(JavaModel): """ +@inherit_doc +class

[GitHub] spark pull request: [SPARK-11832] [Core] Process arguments in spar...

2015-12-09 Thread jodersky
Github user jodersky commented on the pull request: https://github.com/apache/spark/pull/9824#issuecomment-163148987 +1 for treating the errors. How do you usually deal with overlapping pull requests? Should I just copy your error-handling code manually and mention it? --- If your

[GitHub] spark pull request: [SPARK-11965] [ML] [Doc] Update user guide for...

2015-12-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10222#issuecomment-163152543 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11965] [ML] [Doc] Update user guide for...

2015-12-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10222#issuecomment-163152536 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

2015-12-09 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/10004#issuecomment-163152700 @nongli Uploaded new screenshot and rebased to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-12161][SQL] Ignore order of predicates ...

2015-12-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10163#issuecomment-163157203 **[Test build #47419 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47419/consoleFull)** for PR 10163 at commit

[GitHub] spark pull request: [SPARK-12161][SQL] Ignore order of predicates ...

2015-12-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10163#issuecomment-163157250 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12161][SQL] Ignore order of predicates ...

2015-12-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10163#issuecomment-163157253 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12234] [SparkR] Fix ```subset``` functi...

2015-12-09 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/10217#issuecomment-163165902 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-11944][PYSPARK][MLLIB] python mllib.clu...

2015-12-09 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/10150#discussion_r47070681 --- Diff: python/pyspark/mllib/clustering.py --- @@ -38,13 +38,175 @@ from pyspark.mllib.util import Saveable, Loader, inherit_doc, JavaLoader,

[GitHub] spark pull request: [SPARK-11923][ML] Python API for ml.feature.Ch...

2015-12-09 Thread yanboliang
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/10186#issuecomment-163183655 Looks good except minor issues. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-11965] [ML] [Doc] Update user guide for...

2015-12-09 Thread yanboliang
GitHub user yanboliang opened a pull request: https://github.com/apache/spark/pull/10222 [SPARK-11965] [ML] [Doc] Update user guide for RFormula feature interactions Update user guide for RFormula feature interactions. You can merge this pull request into a Git repository by

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

2015-12-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10004#issuecomment-163153888 **[Test build #47422 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47422/consoleFull)** for PR 10004 at commit

[GitHub] spark pull request: [SPARK-12161][SQL] Ignore order of predicates ...

2015-12-09 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10163#discussion_r47064418 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala --- @@ -156,7 +156,18 @@ abstract class Expression

[GitHub] spark pull request: [SPARK-12238][STREAMING][DOCS] s/Advanced Sour...

2015-12-09 Thread ScrapCodes
GitHub user ScrapCodes opened a pull request: https://github.com/apache/spark/pull/10223 [SPARK-12238][STREAMING][DOCS] s/Advanced Sources/External Sources in docs. While reading the streaming docs, I felt reading as external sources(instead of Advanced sources) seemed more

[GitHub] spark pull request: [SPARK-11922][PYSPARK][ML] Python api for ml.f...

2015-12-09 Thread yanboliang
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/10085#issuecomment-163165252 I vote for make ```Bucketizer``` to a ```Model``` rather than ```Transformer``` which is consistent with Scala code. @yinxusen Could you explain the reason that you

[GitHub] spark pull request: [SPARK-11944][PYSPARK][MLLIB] python mllib.clu...

2015-12-09 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/10150#discussion_r47070564 --- Diff: python/pyspark/mllib/clustering.py --- @@ -38,13 +38,175 @@ from pyspark.mllib.util import Saveable, Loader, inherit_doc, JavaLoader,

[GitHub] spark pull request: [SPARK-8641][SQL] Native Spark Window function...

2015-12-09 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/9819#discussion_r47072914 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -592,11 +594,17 @@ class Analyzer( }

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

2015-12-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10004#issuecomment-163178822 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

2015-12-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10004#issuecomment-163178820 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11944][PYSPARK][MLLIB] python mllib.clu...

2015-12-09 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/10150#discussion_r47073596 --- Diff: python/pyspark/mllib/clustering.py --- @@ -38,13 +38,175 @@ from pyspark.mllib.util import Saveable, Loader, inherit_doc, JavaLoader,

[GitHub] spark pull request: [SPARK-12234] [SparkR] Fix ```subset``` functi...

2015-12-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10217#issuecomment-163158533 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12234] [SparkR] Fix ```subset``` functi...

2015-12-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10217#issuecomment-163158535 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12236][SQL] JDBC filter tests all pass ...

2015-12-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10221#issuecomment-163159981 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12236][SQL] JDBC filter tests all pass ...

2015-12-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10221#issuecomment-163159983 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11551][DOC] Replace example code in ml-...

2015-12-09 Thread BenFradet
Github user BenFradet commented on a diff in the pull request: https://github.com/apache/spark/pull/10219#discussion_r47068916 --- Diff: examples/src/main/scala/org/apache/spark/examples/ml/ElementWiseProductExample.scala --- @@ -0,0 +1,53 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-7889] [CORE] HistoryServer to refresh c...

2015-12-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6935#issuecomment-163168780 **[Test build #47424 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47424/consoleFull)** for PR 6935 at commit

[GitHub] spark pull request: [SPARK-12041] [ML] [PySpark] Add columnSimilar...

2015-12-09 Thread yanboliang
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/10158#issuecomment-163179848 LGTM @mengxr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11923][ML] Python API for ml.feature.Ch...

2015-12-09 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/10186#discussion_r47074421 --- Diff: python/pyspark/ml/feature.py --- @@ -2093,6 +2093,95 @@ class RFormulaModel(JavaModel): """ +@inherit_doc +class

[GitHub] spark pull request: [SPARK-12012] [SQL] Show more comprehensive Ph...

2015-12-09 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/10004#issuecomment-163187890 I know that the current visual effect of super long paths isn't perfect, but at least it doesn't introduce super wide plan nodes. And this is also how our current UI

[GitHub] spark pull request: [SPARK-7889] [CORE] HistoryServer to refresh c...

2015-12-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6935#issuecomment-163196873 **[Test build #47424 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47424/consoleFull)** for PR 6935 at commit

[GitHub] spark pull request: [SPARK-7889] [CORE] HistoryServer to refresh c...

2015-12-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6935#issuecomment-163196933 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12196][Core]Store blocks in storage dev...

2015-12-09 Thread yucai
Github user yucai closed the pull request at: https://github.com/apache/spark/pull/10192 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11551][DOC] Replace example code in ml-...

2015-12-09 Thread BenFradet
Github user BenFradet commented on the pull request: https://github.com/apache/spark/pull/10219#issuecomment-163213528 @yinxusen I'll have a look later today --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [WIP][SPARK-??][STREAMING] Renamed trackStateB...

2015-12-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10224#issuecomment-163220734 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-7889] [CORE] HistoryServer to refresh c...

2015-12-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6935#issuecomment-163196935 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [WIP][SPARK-??][STREAMING] Renamed trackStateB...

2015-12-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10224#issuecomment-163198867 **[Test build #47426 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47426/consoleFull)** for PR 10224 at commit

[GitHub] spark pull request: [SPARK-10780] [ML] Set initialModel in KMeans ...

2015-12-09 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/8972#issuecomment-163206656 @jayantshekhar 1. Agree with @dbtsai I prefer to use `KMeansModel` in ML package directly other than `MLlibKMeans` here. 2. I think it's better to

[GitHub] spark pull request: [SPARK-12196][Core] Store blocks in storage de...

2015-12-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10225#issuecomment-163224930 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12156] Make SPARK_EXECUTOR_INSTANCES be...

2015-12-09 Thread KaiXinXiaoLei
Github user KaiXinXiaoLei closed the pull request at: https://github.com/apache/spark/pull/10157 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request: [SPARK-10780] [ML] Set initialModel in KMeans ...

2015-12-09 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8972#discussion_r47078991 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -176,6 +176,21 @@ class KMeans @Since("1.5.0") ( @Since("1.5.0")

[GitHub] spark pull request: [WIP][SPARK-??][STREAMING] Renamed trackStateB...

2015-12-09 Thread tdas
GitHub user tdas opened a pull request: https://github.com/apache/spark/pull/10224 [WIP][SPARK-??][STREAMING] Renamed trackStateByKey to mapWithState You can merge this pull request into a Git repository by running: $ git pull https://github.com/tdas/spark rename

[GitHub] spark pull request: [WIP][SPARK-??][STREAMING] Renamed trackStateB...

2015-12-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10224#issuecomment-163220729 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [WIP][SPARK-??][STREAMING] Renamed trackStateB...

2015-12-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10224#issuecomment-163220578 **[Test build #47426 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47426/consoleFull)** for PR 10224 at commit

[GitHub] spark pull request: [SPARK-12221] add cpu time to metrics

2015-12-09 Thread steveloughran
Github user steveloughran commented on the pull request: https://github.com/apache/spark/pull/10212#issuecomment-163210092 (I may be trusted enough to start a run..let's see) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-11832] [Core] Process arguments in spar...

2015-12-09 Thread dragos
Github user dragos commented on the pull request: https://github.com/apache/spark/pull/9824#issuecomment-163234317 Copying is fine by me, it's a really small piece of code. I already closed my PR. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-11551][DOC] Replace example code in ml-...

2015-12-09 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/10219#issuecomment-163203243 @BenFradet Does the code look good for you? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12156] Make SPARK_EXECUTOR_INSTANCES be...

2015-12-09 Thread KaiXinXiaoLei
Github user KaiXinXiaoLei commented on the pull request: https://github.com/apache/spark/pull/10157#issuecomment-163186959 ok. thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-7727] [SQL] Avoid inner classes in Rule...

2015-12-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10174#issuecomment-163199890 **[Test build #47425 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47425/consoleFull)** for PR 10174 at commit

[GitHub] spark pull request: [SPARK-9926] [SPARK-10340] [SQL] Use S3 bulk l...

2015-12-09 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/8512#discussion_r47081031 --- Diff: core/pom.xml --- @@ -40,6 +40,16 @@ ${avro.mapred.classifier} + com.amazonaws +

[GitHub] spark pull request: [SPARK-9926] [SPARK-10340] [SQL] Use S3 bulk l...

2015-12-09 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/8512#discussion_r47081146 --- Diff: core/src/test/scala/org/apache/spark/deploy/SparkS3UtilSuite.scala --- @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-7727] [SQL] Avoid inner classes in Rule...

2015-12-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10174#issuecomment-163200019 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-7727] [SQL] Avoid inner classes in Rule...

2015-12-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10174#issuecomment-163200018 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9926] [SPARK-10340] [SQL] Use S3 bulk l...

2015-12-09 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/8512#discussion_r47081737 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkS3Util.scala --- @@ -0,0 +1,342 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-11353][IO] Update jets3t version to 0.9...

2015-12-09 Thread steveloughran
Github user steveloughran commented on the pull request: https://github.com/apache/spark/pull/9306#issuecomment-163222684 Moving to Hadoop 0.90 [HADOOP-9623](https://issues.apache.org/jira/browse/HADOOP-9623) was what could be described as "an accidental disaster"'; the patch

[GitHub] spark pull request: [SPARK-12196][Core] Store blocks in storage de...

2015-12-09 Thread yucai
GitHub user yucai opened a pull request: https://github.com/apache/spark/pull/10225 [SPARK-12196][Core] Store blocks in storage devices with hierarchy way https://issues.apache.org/jira/browse/SPARK-12196 You can merge this pull request into a Git repository by running: $ git

[GitHub] spark pull request: [SPARK-11938][ML] Expose numFeatures in all ML...

2015-12-09 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/9936#discussion_r47080514 --- Diff: python/pyspark/ml/tests.py --- @@ -371,6 +378,126 @@ def test_fit_maximize_metric(self): self.assertEqual(1.0, bestModelMetric,

[GitHub] spark pull request: [SPARK-7889] [CORE] HistoryServer to refresh c...

2015-12-09 Thread steveloughran
Github user steveloughran commented on the pull request: https://github.com/apache/spark/pull/6935#issuecomment-163203560 Failing test is pyspark —pretty unlikely to be related ``` == FAIL:

[GitHub] spark pull request: [SPARK-11551][DOC] Replace example code in ml-...

2015-12-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10219#issuecomment-163203400 **[Test build #47427 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47427/consoleFull)** for PR 10219 at commit

[GitHub] spark pull request: [SPARK-12221] add cpu time to metrics

2015-12-09 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/10212#discussion_r47083416 --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala --- @@ -718,6 +719,7 @@ private[spark] object JsonProtocol {

[GitHub] spark pull request: [SPARK-12221] add cpu time to metrics

2015-12-09 Thread steveloughran
Github user steveloughran commented on the pull request: https://github.com/apache/spark/pull/10212#issuecomment-163209990 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-11551][DOC] Replace example code in ml-...

2015-12-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10219#issuecomment-163211490 **[Test build #47427 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47427/consoleFull)** for PR 10219 at commit

  1   2   3   4   5   6   7   >