[GitHub] spark pull request: [SPARK-11701] dynamic allocation and speculati...

2016-01-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10951#issuecomment-175885311 **[Test build #50219 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50219/consoleFull)** for PR 10951 at commit

[GitHub] spark pull request: [SPARK-13031] [SQL] cleanup codegen and improv...

2016-01-27 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/10944#issuecomment-175885463 cc @nongli @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11701] dynamic allocation and speculati...

2016-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10951#issuecomment-175885501 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11701] dynamic allocation and speculati...

2016-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10951#issuecomment-175885503 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12230][ML] WeightedLeastSquares.fit() s...

2016-01-27 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/10274#discussion_r51059677 --- Diff: mllib/src/test/scala/org/apache/spark/ml/optim/WeightedLeastSquaresSuite.scala --- @@ -74,6 +89,35 @@ class WeightedLeastSquaresSuite extends

[GitHub] spark pull request: [SPARK-13049] Add First/last with ignore nulls...

2016-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10957#issuecomment-175889533 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13049] Add First/last with ignore nulls...

2016-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10957#issuecomment-175889530 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12895][SPARK-12896] Migrate TaskMetrics...

2016-01-27 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10835#discussion_r51061122 --- Diff: project/MimaExcludes.scala --- @@ -145,6 +145,15 @@ object MimaExcludes { // SPARK-12510 Refactor ActorReceiver to support Java

[GitHub] spark pull request: [SPARK-12895][SPARK-12896] Migrate TaskMetrics...

2016-01-27 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10835#issuecomment-175893531 I was able to verify that the changes in `Accumulable` and `Accumulator` do not break compatibility. --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-12895][SPARK-12896] Migrate TaskMetrics...

2016-01-27 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10835#discussion_r51062164 --- Diff: core/src/main/scala/org/apache/spark/InternalAccumulator.scala --- @@ -17,42 +17,193 @@ package org.apache.spark +import

[GitHub] spark pull request: [SPARK-10620] Minor addendum to #10835

2016-01-27 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10958#issuecomment-175897116 @JoshRosen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [Spark-12732][ML] bug fix in linear regression...

2016-01-27 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/10702#discussion_r51064724 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala --- @@ -558,6 +575,47 @@ class LinearRegressionSuite }

[GitHub] spark pull request: [Spark-12732][ML] bug fix in linear regression...

2016-01-27 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/10702#discussion_r51064615 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala --- @@ -558,6 +575,47 @@ class LinearRegressionSuite }

[GitHub] spark pull request: [SPARK-13049] Add First/last with ignore nulls...

2016-01-27 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10957#issuecomment-175904468 Why might this be a bug fix? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [Spark-12732][ML] bug fix in linear regression...

2016-01-27 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/10702#discussion_r51069962 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala --- @@ -219,33 +219,43 @@ class LinearRegression @Since("1.3.0")

[GitHub] spark pull request: [SPARK-13047][PYSPARK][ML] Pyspark Params.hasP...

2016-01-27 Thread sethah
GitHub user sethah opened a pull request: https://github.com/apache/spark/pull/10962 [SPARK-13047][PYSPARK][ML] Pyspark Params.hasParam should not throw an error Pyspark Params class has a method `hasParam(paramName)` which returns `True` if the class has a parameter by that name,

[GitHub] spark pull request: [SPARK-12177] [STREAMING] Update KafkaDStreams...

2016-01-27 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/10953#issuecomment-175891692 MiMA is a binary compatibility checker. It's complaining that some changes you made caused the public APIs exposed in the compiled classes to change - meaning existing

[GitHub] spark pull request: [SPARK-12656] [SQL] Implement Intersect with L...

2016-01-27 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10630#discussion_r51061765 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -388,57 +445,18 @@ class Analyzer(

[GitHub] spark pull request: [SPARK-13020][SQL][test] fix random generator ...

2016-01-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10930#issuecomment-175896474 **[Test build #50205 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50205/consoleFull)** for PR 10930 at commit

[GitHub] spark pull request: [SPARK-10620] Minor addendum to #10835

2016-01-27 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10958#issuecomment-175896506 @JoshRosen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [HOTFIX] Fix Scala 2.11 compilation

2016-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10955#issuecomment-175903354 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10620] [SPARK-13054] Minor addendum to ...

2016-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10958#issuecomment-175908428 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10620] [SPARK-13054] Minor addendum to ...

2016-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10958#issuecomment-175908426 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13045][SQL] Remove ColumnVector.Struct ...

2016-01-27 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/10952#issuecomment-175909805 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [WIP][SPARK-12957][SQL] Initial support for co...

2016-01-27 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/10844#discussion_r51068499 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala --- @@ -88,6 +88,12 @@ case class Generate(

[GitHub] spark pull request: [WIP][SPARK-12957][SQL] Initial support for co...

2016-01-27 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/10844#discussion_r51068376 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala --- @@ -17,16 +17,31 @@ package

[GitHub] spark pull request: [Spark-12732][ML] bug fix in linear regression...

2016-01-27 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/10702#discussion_r51070090 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala --- @@ -219,33 +219,43 @@ class LinearRegression @Since("1.3.0")

[GitHub] spark pull request: [SPARK-12895][SPARK-12896] Migrate TaskMetrics...

2016-01-27 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10835#issuecomment-175892453 I have compiled a list of breaking `@DeveloperAPI` changes: ExceptionFailure: - changed: `apply`, `unapply`, `copy` - removed: old constructor -

[GitHub] spark pull request: [SPARK-13031] [SQL] cleanup codegen and improv...

2016-01-27 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10944#issuecomment-175892206 Can you paste some generated code? (Actually I think that's useful for most of the code gen prs). --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-13020][SQL][test] fix random generator ...

2016-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10930#issuecomment-175892315 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13020][SQL][test] fix random generator ...

2016-01-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10930#issuecomment-175892138 **[Test build #50200 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50200/consoleFull)** for PR 10930 at commit

[GitHub] spark pull request: [SPARK-13029][ml] fix a logistic regression is...

2016-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10940#issuecomment-175898494 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13029][ml] fix a logistic regression is...

2016-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10940#issuecomment-175898492 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12988][SQL] Can't drop columns that con...

2016-01-27 Thread dilipbiswal
Github user dilipbiswal commented on the pull request: https://github.com/apache/spark/pull/10943#issuecomment-175899786 @cloud-fan Thank you Wenchen for your comments. In my understanding , users need to use back-tick to quote the column names if they wanted them to be treated as a

[GitHub] spark pull request: [Spark-12732][ML] bug fix in linear regression...

2016-01-27 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/10702#discussion_r51070105 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala --- @@ -219,33 +219,43 @@ class LinearRegression @Since("1.3.0")

[GitHub] spark pull request: [SPARK-12963] Improve performance of stddev/va...

2016-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10960#issuecomment-175915586 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12963] Improve performance of stddev/va...

2016-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10960#issuecomment-175915582 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13047][PYSPARK][ML] Pyspark Params.hasP...

2016-01-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10962#issuecomment-175920740 **[Test build #50242 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50242/consoleFull)** for PR 10962 at commit

[GitHub] spark pull request: [Spark-12732][ML] bug fix in linear regression...

2016-01-27 Thread iyounus
Github user iyounus commented on a diff in the pull request: https://github.com/apache/spark/pull/10702#discussion_r51071809 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala --- @@ -219,33 +219,43 @@ class LinearRegression @Since("1.3.0")

[GitHub] spark pull request: [SPARK-10620] Minor addendum to #10835

2016-01-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10958#issuecomment-175899434 **[Test build #50234 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50234/consoleFull)** for PR 10958 at commit

[GitHub] spark pull request: [Spark-12732][ML] bug fix in linear regression...

2016-01-27 Thread dbtsai
Github user dbtsai commented on the pull request: https://github.com/apache/spark/pull/10702#issuecomment-175901752 @iyounus `standardizeLabel = false/ture` with non-zero `regParam`, let's throw the exception. I explained the mismatch against the analytic normal equation in the other

[GitHub] spark pull request: [Spark-12732][ML] bug fix in linear regression...

2016-01-27 Thread iyounus
Github user iyounus commented on a diff in the pull request: https://github.com/apache/spark/pull/10702#discussion_r51071489 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala --- @@ -219,33 +219,43 @@ class LinearRegression @Since("1.3.0")

[GitHub] spark pull request: [SPARK-12656] [SQL] Implement Intersect with L...

2016-01-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/10630#discussion_r51059167 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -388,57 +445,18 @@ class Analyzer(

[GitHub] spark pull request: [SPARK-10620] Minor addendum to #10835

2016-01-27 Thread andrewor14
GitHub user andrewor14 opened a pull request: https://github.com/apache/spark/pull/10958 [SPARK-10620] Minor addendum to #10835 You can merge this pull request into a Git repository by running: $ git pull https://github.com/andrewor14/spark task-metrics-to-accums-followups

[GitHub] spark pull request: [SPARK-10620] [SPARK-13054] Minor addendum to ...

2016-01-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10958#issuecomment-175908753 **[Test build #50238 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50238/consoleFull)** for PR 10958 at commit

[GitHub] spark pull request: [SPARK-13050] [Build] Scalatest tags fail buil...

2016-01-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10954#issuecomment-175894464 **[Test build #50221 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50221/consoleFull)** for PR 10954 at commit

[GitHub] spark pull request: [SPARK-13020][SQL][test] fix random generator ...

2016-01-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10930#issuecomment-175900800 **[Test build #50233 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50233/consoleFull)** for PR 10930 at commit

[GitHub] spark pull request: [SPARK-10620] Minor addendum to #10835

2016-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10958#issuecomment-175903012 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10620] Minor addendum to #10835

2016-01-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10958#issuecomment-175902964 **[Test build #50234 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50234/consoleFull)** for PR 10958 at commit

[GitHub] spark pull request: [SPARK-10620] Minor addendum to #10835

2016-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10958#issuecomment-175903014 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13049] Add First/last with ignore nulls...

2016-01-27 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/10957#issuecomment-175908190 A user is trying to get this working on 1.6 using the dataframe api. That doesn't work directly because functions.scala misses the functions implemented in this

[GitHub] spark pull request: [SPARK-12963] Improve performance of stddev/va...

2016-01-27 Thread davies
GitHub user davies opened a pull request: https://github.com/apache/spark/pull/10960 [SPARK-12963] Improve performance of stddev/variance As benchmarked and discussed here: https://github.com/apache/spark/pull/10786/files#r50038294, benefits from codegen, the declarative aggregate

[GitHub] spark pull request: [WIP][SPARK-12957][SQL] Initial support for co...

2016-01-27 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/10844#discussion_r51068566 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala --- @@ -146,6 +172,26 @@ case class Union(children:

[GitHub] spark pull request: [SPARK-13029][ml] fix a logistic regression is...

2016-01-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10940#issuecomment-175911254 **[Test build #50227 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50227/consoleFull)** for PR 10940 at commit

[GitHub] spark pull request: [SPARK-13045][SQL] Remove ColumnVector.Struct ...

2016-01-27 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/10952#issuecomment-175911147 Merging this into master, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-10810] [SPARK-10902] [SQL] Improve sess...

2016-01-27 Thread Neuw84
Github user Neuw84 commented on the pull request: https://github.com/apache/spark/pull/8909#issuecomment-175916186 @deenar, I saw it after many hours reading the code in the web docs . Although, I think that the HiveSparkContext should implement the same logic as the SparkContext

[GitHub] spark pull request: [Spark-12732][ML] bug fix in linear regression...

2016-01-27 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/10702#discussion_r51070506 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala --- @@ -219,33 +219,43 @@ class LinearRegression @Since("1.3.0")

[GitHub] spark pull request: [SPARK-13049] Add First/last with ignore nulls...

2016-01-27 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/10957#issuecomment-175881244 @yhuai ```expr("last(r, true)")``` would return an ```UnresolvedFunction(UnresolvedAttribute(r), Literal(true))```. The problem is that the ```WindowSpec``` does

[GitHub] spark pull request: [SPARK-12177] [STREAMING] Update KafkaDStreams...

2016-01-27 Thread markgrover
Github user markgrover commented on the pull request: https://github.com/apache/spark/pull/10953#issuecomment-175887290 OK, I have no idea what Mima is but I will take a look and try to run them locally and fix the issues. --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-13020][SQL][test] fix random generator ...

2016-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10930#issuecomment-175892312 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13020][SQL][test] fix random generator ...

2016-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10930#issuecomment-175896643 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13020][SQL][test] fix random generator ...

2016-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10930#issuecomment-175896645 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13049] Add First/last with ignore nulls...

2016-01-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10957#issuecomment-175896538 **[Test build #50231 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50231/consoleFull)** for PR 10957 at commit

[GitHub] spark pull request: [SPARK-12895][SPARK-12896] Migrate TaskMetrics...

2016-01-27 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10835#discussion_r51062999 --- Diff: core/src/main/scala/org/apache/spark/Accumulator.scala --- @@ -75,43 +84,65 @@ private[spark] object Accumulators extends Logging { *

[GitHub] spark pull request: SPARK-13052 waitingApps metric doesn't show th...

2016-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10959#issuecomment-175904859 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13049] Add First/last with ignore nulls...

2016-01-27 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/10957#issuecomment-175881484 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13031] [SQL] cleanup codegen and improv...

2016-01-27 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/10944#issuecomment-175895315 Here is the generated code for `sqlContext.range(values).filter("(id & 1) = 1").count()` ``` /* 001 */ /* 002 */ public Object generate(Object[]

[GitHub] spark pull request: [SPARK-13020][SQL][test] fix random generator ...

2016-01-27 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/10930#issuecomment-175895328 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13029][ml] fix a logistic regression is...

2016-01-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10940#issuecomment-175898182 **[Test build #50229 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50229/consoleFull)** for PR 10940 at commit

[GitHub] spark pull request: [SPARK-6363][BUILD] Make Scala 2.11 the defaul...

2016-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10608#issuecomment-175907303 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-6363][BUILD] Make Scala 2.11 the defaul...

2016-01-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10608#issuecomment-175907259 **[Test build #50236 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50236/consoleFull)** for PR 10608 at commit

[GitHub] spark pull request: [SPARK-12926][SQL] SQLContext to disallow user...

2016-01-27 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10849#issuecomment-175907368 Please update the title and description (these become the commit message when merging). --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-6363][BUILD] Make Scala 2.11 the defaul...

2016-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10608#issuecomment-175907305 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13045][SQL] Remove ColumnVector.Struct ...

2016-01-27 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10952#issuecomment-175909089 cc @davies --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-13045][SQL] Remove ColumnVector.Struct ...

2016-01-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10952 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12963] Improve performance of stddev/va...

2016-01-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10960#issuecomment-175914531 **[Test build #50240 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50240/consoleFull)** for PR 10960 at commit

[GitHub] spark pull request: [SPARK-13043][SQL] Implement remaining catalys...

2016-01-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10961#issuecomment-175917592 **[Test build #50241 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50241/consoleFull)** for PR 10961 at commit

[GitHub] spark pull request: [SPARK-12988][SQL] Can't drop columns that con...

2016-01-27 Thread dilipbiswal
Github user dilipbiswal commented on the pull request: https://github.com/apache/spark/pull/10943#issuecomment-175917517 @cloud-fan Thank you Wenchen. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-11955][SQL] Mark optional fields in mer...

2016-01-27 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/9940#issuecomment-175927505 ping @liancheng Please see if latest updates are proper for you. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...

2016-01-27 Thread gliptak
Github user gliptak commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-175927249 Github is hiccuping ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-12567][SQL] Add aes_{encrypt,decrypt} U...

2016-01-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10527#issuecomment-175927638 **[Test build #50243 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50243/consoleFull)** for PR 10527 at commit

[GitHub] spark pull request: [SPARK-12968][SQL] Implement command to set cu...

2016-01-27 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/10916#discussion_r51073364 --- Diff: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/CliSuite.scala --- @@ -183,7 +183,7 @@ class CliSuite extends

[GitHub] spark pull request: [SPARK-12995][GraphX] Remove deprecate APIs fr...

2016-01-27 Thread maropu
Github user maropu commented on the pull request: https://github.com/apache/spark/pull/10918#issuecomment-175927636 @ankurdave @srowen ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-12966][SQL] Support ArrayType(DecimalTy...

2016-01-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10898#issuecomment-175978667 **[Test build #50251 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50251/consoleFull)** for PR 10898 at commit

[GitHub] spark pull request: [SPARK-12968][SQL] Implement command to set cu...

2016-01-27 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/10916#discussion_r51082907 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala --- @@ -1262,6 +1263,21 @@ class HiveQuerySuite extends

[GitHub] spark pull request: [SPARK-13057][SQL] Add benchmark codes and the...

2016-01-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10965#issuecomment-176000161 **[Test build #50254 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50254/consoleFull)** for PR 10965 at commit

[GitHub] spark pull request: [SPARK-11780][SQL] Add catalyst type aliases b...

2016-01-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10915#issuecomment-176007544 **[Test build #50256 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50256/consoleFull)** for PR 10915 at commit

[GitHub] spark pull request: [SPARK-12968][SQL] Implement command to set cu...

2016-01-27 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/10916#discussion_r51073555 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/ClientInterface.scala --- @@ -109,6 +109,9 @@ private[hive] trait ClientInterface {

[GitHub] spark pull request: [SPARK-12968][SQL] Implement command to set cu...

2016-01-27 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/10916#discussion_r51073506 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Catalog.scala --- @@ -46,6 +46,10 @@ trait Catalog { def

[GitHub] spark pull request: [SPARK-12567][SQL] Add aes_{encrypt,decrypt} U...

2016-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10527#issuecomment-175932469 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-12567][SQL] Add aes_{encrypt,decrypt} U...

2016-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10527#issuecomment-175932477 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12792][SPARKR] Refactor RRDD to support...

2016-01-27 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/10947#issuecomment-175946838 cc @davies. Thanks @sunrui for the PR. I'll review this later today --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-10521][SQL] Utilize Docker for test DB2...

2016-01-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9893#issuecomment-175955462 **[Test build #50247 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50247/consoleFull)** for PR 9893 at commit

[GitHub] spark pull request: [SPARK-10521][SQL] Utilize Docker for test DB2...

2016-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9893#issuecomment-175955469 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10521][SQL] Utilize Docker for test DB2...

2016-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9893#issuecomment-175955464 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10873] Support column sort and search f...

2016-01-27 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10648#issuecomment-176012531 @tgravescs @zhuoliu are you guys interested in more UI work? I have some ideas that I never found time / people to work on ... I think they will make the UI a lot more

[GitHub] spark pull request: [SPARK-13031] [SQL] cleanup codegen and improv...

2016-01-27 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/10944#issuecomment-176013043 @nongli Does this one looks good to you? this one blocks others. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...

2016-01-27 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/10723#discussion_r51074963 --- Diff: sql/catalyst/src/main/antlr3/org/apache/spark/sql/catalyst/parser/SparkSqlLexer.g --- @@ -465,7 +467,7 @@ Identifier fragment

[GitHub] spark pull request: [SPARK-10521][SQL] Utilize Docker for test DB2...

2016-01-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9893#issuecomment-175955168 **[Test build #50247 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50247/consoleFull)** for PR 9893 at commit

[GitHub] spark pull request: [SPARK-10873] Support column sort and search f...

2016-01-27 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/spark/pull/10648#issuecomment-175966503 Hi @tgravescs , finally fixed the paging stuff in RowsGrouping. :) --- If your project is set up for it, you can reply to this email and have your reply appear on

  1   2   3   4   5   6   7   >