Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10916#issuecomment-176601335
**[Test build #50350 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50350/consoleFull)**
for PR 10916 at commit
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/10977#issuecomment-176601291
When there is no aggregate functions, it did not generate the output using
resultExpression, which have only literals (I was mislead by the comment in
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10757#issuecomment-176604129
**[Test build #50353 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50353/consoleFull)**
for PR 10757 at commit
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10757#issuecomment-176607410
A few comments:
1. As discussed offline, let's be consistent and always quote in sql query
generation, and never allow backticks in aliases.
2. Rename
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10972#issuecomment-176607674
**[Test build #50354 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50354/consoleFull)**
for PR 10972 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10978#issuecomment-176609044
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10757#issuecomment-176609793
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10757#issuecomment-176609589
**[Test build #50353 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50353/consoleFull)**
for PR 10757 at commit
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10977#issuecomment-176609355
Thanks - can you add a test case that would catch this? In the long run, we
don't want to rely on HiveCompatibilitySuite.
---
If your project is set up for it, you
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10757#issuecomment-176609786
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-176619085
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-176619087
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-176618998
**[Test build #50349 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50349/consoleFull)**
for PR 10860 at commit
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10977#issuecomment-176619523
Sure it's a good idea to use that golden file infrastructure. Given we
don't have that yet, can you just add a test case?
---
If your project is set up for it, you
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/10961#discussion_r51232873
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java
---
@@ -282,6 +328,21 @@ public void reset() {
/**
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10977#issuecomment-176620545
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/9657#discussion_r51232882
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -155,6 +157,15 @@ final class DataFrameWriter private[sql](df:
DataFrame)
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/9657#discussion_r51232808
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -130,6 +131,16 @@ final class DataFrameWriter private[sql](df:
DataFrame)
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/9657#discussion_r51232826
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -155,6 +157,15 @@ final class DataFrameWriter private[sql](df:
DataFrame)
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/10630#issuecomment-176628957
LGTM. we can merge it first and @gatorsmile can address remaining comments
in a follow-up PR.
---
If your project is set up for it, you can reply to this email and
Github user zjffdu commented on a diff in the pull request:
https://github.com/apache/spark/pull/9657#discussion_r51233700
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ResolvedDataSource.scala
---
@@ -235,11 +236,18 @@ object ResolvedDataSource
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10930#issuecomment-176629169
**[Test build #50357 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50357/consoleFull)**
for PR 10930 at commit
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/10723#issuecomment-176279389
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10962#issuecomment-176278459
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user thomastechs commented on the pull request:
https://github.com/apache/spark/pull/10912#issuecomment-176237636
@yhuai working on the OracleIntgerationSuite (In the process of docker
build using Oracle linux)
---
If your project is set up for it, you can reply to this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10723#issuecomment-176257408
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10723#issuecomment-176257400
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10967#issuecomment-176239256
This is a separate issue. It happens when the alias defined in aggregation
expression is used in the group by. Thus, you do not need to merge my fix,
which is still
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10723#issuecomment-176256620
**[Test build #50276 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50276/consoleFull)**
for PR 10723 at commit
Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/10057#issuecomment-176599484
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/10757#discussion_r51230274
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -39,11 +39,11 @@ case class ScalaUDF(
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10973#issuecomment-176607805
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/10970#issuecomment-176607697
Sorry I thought the JIRA description tells it, will add it to PR
description next time.
---
If your project is set up for it, you can reply to this email and have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10973#issuecomment-176607734
**[Test build #50348 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50348/consoleFull)**
for PR 10973 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10973#issuecomment-176607807
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/10974#issuecomment-176613193
@rxin similar to https://github.com/apache/spark/pull/10333 , I only
observed about 5% speed up. I think branch prediction works very well for this
kind of case, the
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10972#issuecomment-176613206
@viirya do you want to submit a pull request to address your issue?
@liancheng is busy with something right now.
---
If your project is set up for it, you can reply to
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10977#issuecomment-176620367
**[Test build #50351 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50351/consoleFull)**
for PR 10977 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10977#issuecomment-176620544
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/10954#issuecomment-176620214
I'm merging this. Thanks for fixing this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10970#issuecomment-176605185
Existing tests were failing locally, but not on Jenkins. We are not sure
why.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10757#issuecomment-176629661
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10757#issuecomment-176629658
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10757#issuecomment-176629629
**[Test build #50356 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50356/consoleFull)**
for PR 10757 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10964#issuecomment-176599392
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10964#issuecomment-176599391
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-176599538
Looks like there are more rules to scala style now, it's finally passing!
@andrewor14 PTAL
---
If your project is set up for it, you can reply to this email and have
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/9940#discussion_r51232182
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructType.scala ---
@@ -359,6 +361,18 @@ object StructType extends AbstractDataType {
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/10757#issuecomment-176616783
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10977#issuecomment-176600324
What's the bug?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user flyjy opened a pull request:
https://github.com/apache/spark/pull/10978
[SPARK-13074][Core] Add JavaSparkContext. getPersistentRDDs method
The "getPersistentRDDs()" is a useful API of SparkContext to get cached
RDDs. However, the JavaSparkContext does not have this API.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10723#issuecomment-176612064
**[Test build #50355 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50355/consoleFull)**
for PR 10723 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10954
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user liancheng closed the pull request at:
https://github.com/apache/spark/pull/10972
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/10972#issuecomment-176622130
I'm closing this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/10961#discussion_r51232913
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java
---
@@ -354,6 +435,33 @@ public void reset() {
/**
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10630#issuecomment-176630203
This is not that big. Let's just do it together here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/10972#issuecomment-176629923
@rxin @liancheng yes, I would love to do it. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user seddonm1 opened a pull request:
https://github.com/apache/spark/pull/10976
[SPARK-5891][ML] Binarizer allowing Double AND Vector input types
This enhancement extends the existing SparkML Binarizer [SPARK-5891] to
allow Vector in addition to the existing Double input
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9657#issuecomment-176589845
**[Test build #50347 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50347/consoleFull)**
for PR 9657 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9657#issuecomment-176589925
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10976#issuecomment-176590073
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10916#issuecomment-176597875
**[Test build #50337 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50337/consoleFull)**
for PR 10916 at commit
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/10916#issuecomment-176598233
@rxin I've reverted last commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9893#issuecomment-176598247
**[Test build #50340 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50340/consoleFull)**
for PR 9893 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10977#issuecomment-176601896
**[Test build #50351 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50351/consoleFull)**
for PR 10977 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10057#issuecomment-176602007
**[Test build #50352 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50352/consoleFull)**
for PR 10057 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10630#discussion_r51233504
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ReplaceOperatorSuite.scala
---
@@ -0,0 +1,46 @@
+/*
+ * Licensed to
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10630#discussion_r51233589
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala
---
@@ -270,7 +270,8 @@ class AnalysisErrorSuite
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10677#issuecomment-176628618
@hvanhovell can you review this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9657#issuecomment-176589924
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10860#issuecomment-176591953
**[Test build #50349 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50349/consoleFull)**
for PR 10860 at commit
GitHub user davies opened a pull request:
https://github.com/apache/spark/pull/10977
[SPARK-13031] [SQL] cleanup codegen and improve test coverage
1. enable whole stage codegen during tests even there is only one operator
supports that.
2. split doProduce() into two APIs:
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10970#issuecomment-176603047
@cloud-fan is this fixing a bug? If yes, please add a test somewhere.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/10970#issuecomment-176602785
Tested it locally, test passed. I'm merging this into master, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/10972#issuecomment-176618727
@viirya It would be great if you can help since you are pretty familiar
with this part of code :)
---
If your project is set up for it, you can reply to this email
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/10977#issuecomment-176618967
The way we managed HiveCompatibilitySuite is actually better than our unit
tests (sql query and golden results in text format). Even if we don't want to
be compatible
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/10972#discussion_r51232373
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRelation.scala
---
@@ -799,9 +799,26 @@ private[sql] object
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10961#issuecomment-176618365
cc @davies for a more detailed review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10630#discussion_r51233135
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -214,12 +214,22 @@ trait CheckAnalysis {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10630#discussion_r51233162
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -214,12 +214,22 @@ trait CheckAnalysis {
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9893#issuecomment-176598833
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10916#issuecomment-176598683
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9893#issuecomment-176598841
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10916#issuecomment-176598666
Thanks - I've merged this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10974#issuecomment-176599074
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10964#issuecomment-176599145
**[Test build #50339 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50339/consoleFull)**
for PR 10964 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10974#issuecomment-176599067
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10974#issuecomment-176598205
**[Test build #50341 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50341/consoleFull)**
for PR 10974 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10916#issuecomment-176598689
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10970
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10916
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10757#discussion_r51231438
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -298,7 +299,14 @@ case class AttributeReference(
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10972#issuecomment-176617106
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10972#issuecomment-176617110
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10972#issuecomment-176616985
**[Test build #50354 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50354/consoleFull)**
for PR 10972 at commit
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/9657#discussion_r51233418
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/WriterContainer.scala
---
@@ -239,8 +249,10 @@ private[sql] abstract class
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/10860#discussion_r51229062
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -248,9 +248,7 @@ private[history] class
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10970#issuecomment-176605624
OK got it. @cloud-fan Please add that to the pull request description next
time.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10970#issuecomment-176608171
Yea the pull request description gets merged as commit description, and is
the only thing that sticks around forever.
---
If your project is set up for it, you can
1 - 100 of 627 matches
Mail list logo
