[GitHub] spark pull request: [SPARK-12153][SPARK-7617][MLlib]add support of...

2016-02-14 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/10152#discussion_r52867732 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala --- @@ -289,24 +301,20 @@ class Word2Vec extends Serializable with Logging {

[GitHub] spark pull request: [SPARK-13321][SQL] Support nested UNION in par...

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11204#issuecomment-184102321 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13321][SQL] Support nested UNION in par...

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11204#issuecomment-184102320 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13321][SQL] Support nested UNION in par...

2016-02-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11204#issuecomment-184102156 **[Test build #51295 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51295/consoleFull)** for PR 11204 at commit

[GitHub] spark pull request: [SPARK-12153][SPARK-7617][MLlib]add support of...

2016-02-14 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/10152#discussion_r52867596 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala --- @@ -289,24 +301,20 @@ class Word2Vec extends Serializable with Logging {

[GitHub] spark pull request: [SPARK-13308] ManagedBuffers passed to OneToOn...

2016-02-14 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/11193#issuecomment-184096704 After going through other codes, I think the previous codes are correct. However, the doc of `convertToNetty` is not clear about the ownership of the reference. It

[GitHub] spark pull request: [SPARK-13233][SQL][WIP] Python Dataset

2016-02-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7#issuecomment-184094105 **[Test build #51300 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51300/consoleFull)** for PR 7 at commit

[GitHub] spark pull request: [SPARK-13233][SQL][WIP] Python Dataset

2016-02-14 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/7#discussion_r52866283 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/objects.scala --- @@ -67,6 +74,72 @@ case class MapPartitions( } }

[GitHub] spark pull request: [SPARK-13233][SQL][WIP] Python Dataset

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7#issuecomment-184093584 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13233][SQL][WIP] Python Dataset

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7#issuecomment-184093588 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-184091762 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-184091767 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-184091233 **[Test build #51294 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51294/consoleFull)** for PR 11140 at commit

[GitHub] spark pull request: [SPARK-13033][ML][PySpark] Add import/export f...

2016-02-14 Thread Wenpei
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/11000#issuecomment-184090963 @yanboliang @mengxr Done for this PR. Please help review and launch test. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-11334][Core] Handle maximum task failur...

2016-02-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11205#issuecomment-184088639 **[Test build #51298 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51298/consoleFull)** for PR 11205 at commit

[GitHub] spark pull request: [SPARK-11334][Core] Handle maximum task failur...

2016-02-14 Thread jerryshao
GitHub user jerryshao opened a pull request: https://github.com/apache/spark/pull/11205 [SPARK-11334][Core] Handle maximum task failure situation in dynamic allocation Currently there're two problems in dynamic allocation when maximum task failure is met: 1. Number of

[GitHub] spark pull request: [SPARK-13308] ManagedBuffers passed to OneToOn...

2016-02-14 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/11193#discussion_r52864788 --- Diff: network/common/src/test/java/org/apache/spark/network/TestManagedBuffer.java --- @@ -44,7 +44,7 @@ public TestManagedBuffer(int len) {

[GitHub] spark pull request: [SPARK-13233][SQL][WIP] Python Dataset

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7#issuecomment-184083411 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13233][SQL][WIP] Python Dataset

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7#issuecomment-184083412 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13233][SQL][WIP] Python Dataset

2016-02-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7#issuecomment-184083409 **[Test build #51297 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51297/consoleFull)** for PR 7 at commit

[GitHub] spark pull request: [SPARK-13233][SQL][WIP] Python Dataset

2016-02-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7#issuecomment-184083196 **[Test build #51297 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51297/consoleFull)** for PR 7 at commit

[GitHub] spark pull request: [SPARK-12799] Simplify various string output f...

2016-02-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10757#issuecomment-184082236 **[Test build #51296 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51296/consoleFull)** for PR 10757 at commit

[GitHub] spark pull request: [SPARK-13139][SQL][WIP] Create native DDL comm...

2016-02-14 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/11048#discussion_r52864016 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/bucket.scala --- @@ -35,7 +36,8 @@ import org.apache.spark.sql.types.StructType

[GitHub] spark pull request: [SPARK-13321][SQL] Support nested UNION in par...

2016-02-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11204#issuecomment-184080252 **[Test build #51295 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51295/consoleFull)** for PR 11204 at commit

[GitHub] spark pull request: [SPARK-13321][SQL] Support nested UNION in par...

2016-02-14 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/11204#discussion_r52862728 --- Diff: sql/catalyst/src/main/antlr3/org/apache/spark/sql/catalyst/parser/SparkSqlParser.g --- @@ -2320,6 +2320,19 @@ regularBody[boolean topLevel]

[GitHub] spark pull request: [SPARK-13321][SQL] Support nested UNION in par...

2016-02-14 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/11204 [SPARK-13321][SQL] Support nested UNION in parser JIRA: https://issues.apache.org/jira/browse/SPARK-13321 The following SQL can not be parsed with current parser: SELECT

[GitHub] spark pull request: [SPARK-13236] SQL Generation for Set Operation...

2016-02-14 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/11195#discussion_r52862610 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/LogicalPlanToSQLSuite.scala --- @@ -105,6 +105,27 @@ class LogicalPlanToSQLSuite extends

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-14 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-184076992 Woohoo! Looks like the refactored version of this patch is finally passing all tests, so I'll do another pass to address a few minor debugability todos and then

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-184076652 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-184076651 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-184076622 **[Test build #51287 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51287/consoleFull)** for PR 10705 at commit

[GitHub] spark pull request: [SPARK-13310] [SQL] Resolve Missing Sorting Co...

2016-02-14 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/11198#discussion_r52861656 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -655,6 +655,8 @@ class Analyzer( resolved

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-184071981 **[Test build #51294 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51294/consoleFull)** for PR 11140 at commit

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-184067469 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-184067470 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-184067383 **[Test build #51291 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51291/consoleFull)** for PR 10705 at commit

[GitHub] spark pull request: [SPARK-13300][Documentation] Added pygments.rb...

2016-02-14 Thread amitdev
Github user amitdev commented on the pull request: https://github.com/apache/spark/pull/11180#issuecomment-184066189 @srowen, my JIRA handle is amitdev. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-184064541 **[Test build #51293 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51293/consoleFull)** for PR 11140 at commit

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-184064595 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-184064594 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7483] [MLlib] Upgrade Chill to 0.7.2 to...

2016-02-14 Thread mark800
Github user mark800 commented on the pull request: https://github.com/apache/spark/pull/11041#issuecomment-184060302 @srowen It passes all the test case with version 0.7.2 No transitive deps problem in checking chill's release notes. --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-12997][SQL] Use cast expression to perf...

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10980#issuecomment-184059786 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12997][SQL] Use cast expression to perf...

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10980#issuecomment-184059787 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12997][SQL] Use cast expression to perf...

2016-02-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10980#issuecomment-184059693 **[Test build #51292 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51292/consoleFull)** for PR 10980 at commit

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-184048372 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-184048371 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-184048345 **[Test build #51288 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51288/consoleFull)** for PR 10705 at commit

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-184043728 **[Test build #51293 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51293/consoleFull)** for PR 11140 at commit

[GitHub] spark pull request: [SPARK-12997][SQL] Use cast expression to perf...

2016-02-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10980#issuecomment-184037429 **[Test build #51292 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51292/consoleFull)** for PR 10980 at commit

[GitHub] spark pull request: [SPARK-12997][SQL] Use cast expression to perf...

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10980#issuecomment-184036335 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12997][SQL] Use cast expression to perf...

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10980#issuecomment-184036340 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-184035747 **[Test build #51291 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51291/consoleFull)** for PR 10705 at commit

[GitHub] spark pull request: [SPARK-7483] [MLlib] Upgrade Chill to 0.7.2 to...

2016-02-14 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/11041#issuecomment-184034549 @srowen 0.8.0 is the latest. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-12995][GraphX] Remove deprecate APIs fr...

2016-02-14 Thread maropu
Github user maropu commented on the pull request: https://github.com/apache/spark/pull/10918#issuecomment-184034314 @srowen okay, all the tests passed, so plz check this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-12997][SQL] Use cast expression to perf...

2016-02-14 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/10980#issuecomment-184033527 @rxin @falaki Could you please look through this and tell me if I understood this correctly and this approach is appropriate? --- If your project is set up for

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-184033065 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-184033063 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12997][SQL] Use cast expression to perf...

2016-02-14 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/10980#issuecomment-184032962 @rxin @falaki Could you please look through this and tell me if I understood this correctly and this approach is appropriate? --- If your project is set up for

[GitHub] spark pull request: [SPARK-12799] Simplify various string output f...

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10757#issuecomment-184032910 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12799] Simplify various string output f...

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10757#issuecomment-184032911 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12799] Simplify various string output f...

2016-02-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10757#issuecomment-184032838 **[Test build #51286 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51286/consoleFull)** for PR 10757 at commit

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-184027813 **[Test build #51288 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51288/consoleFull)** for PR 10705 at commit

[GitHub] spark pull request: [SPARK-8080][STREAMING] Receiver.store with It...

2016-02-14 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/6707#discussion_r52854361 --- Diff: streaming/src/test/scala/org/apache/spark/streaming/ReceivedBlockHandlerSuite.scala --- @@ -57,10 +56,12 @@ class ReceivedBlockHandlerSuite

[GitHub] spark pull request: [SPARK-8080][STREAMING] Receiver.store with It...

2016-02-14 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/6707#discussion_r52854321 --- Diff: streaming/src/test/scala/org/apache/spark/streaming/ReceivedBlockHandlerSuite.scala --- @@ -174,6 +176,130 @@ class ReceivedBlockHandlerSuite

[GitHub] spark pull request: [SPARK-8080][STREAMING] Receiver.store with It...

2016-02-14 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/6707#discussion_r52854308 --- Diff: streaming/src/test/scala/org/apache/spark/streaming/ReceivedBlockHandlerSuite.scala --- @@ -251,9 +377,21 @@ class ReceivedBlockHandlerSuite

[GitHub] spark pull request: [SPARK-8080][STREAMING] Receiver.store with It...

2016-02-14 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/6707#discussion_r52854271 --- Diff: streaming/src/test/scala/org/apache/spark/streaming/ReceivedBlockHandlerSuite.scala --- @@ -174,6 +176,130 @@ class ReceivedBlockHandlerSuite

[GitHub] spark pull request: [SPARK-8080][STREAMING] Receiver.store with It...

2016-02-14 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/6707#discussion_r52854252 --- Diff: streaming/src/test/scala/org/apache/spark/streaming/ReceivedBlockHandlerSuite.scala --- @@ -174,6 +176,130 @@ class ReceivedBlockHandlerSuite

[GitHub] spark pull request: [SPARK-12503][SPARK-12505] Limit pushdown in U...

2016-02-14 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11121#issuecomment-184025198 @liancheng I agree. : ) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8080][STREAMING] Receiver.store with It...

2016-02-14 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/6707#discussion_r52854187 --- Diff: streaming/src/test/scala/org/apache/spark/streaming/ReceivedBlockHandlerSuite.scala --- @@ -174,6 +176,130 @@ class ReceivedBlockHandlerSuite

[GitHub] spark pull request: [SPARK-8080][STREAMING] Receiver.store with It...

2016-02-14 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/6707#discussion_r52854163 --- Diff: streaming/src/test/scala/org/apache/spark/streaming/ReceivedBlockHandlerSuite.scala --- @@ -174,6 +176,130 @@ class ReceivedBlockHandlerSuite

[GitHub] spark pull request: [SPARK-7367] [Spark Submit] spark-submit CLI -...

2016-02-14 Thread BimalTandel
Github user BimalTandel closed the pull request at: https://github.com/apache/spark/pull/11191 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-8080][STREAMING] Receiver.store with It...

2016-02-14 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/6707#discussion_r52853940 --- Diff: streaming/src/test/scala/org/apache/spark/streaming/ReceivedBlockHandlerSuite.scala --- @@ -174,6 +176,130 @@ class ReceivedBlockHandlerSuite

[GitHub] spark pull request: [SPARK-8080][STREAMING] Receiver.store with It...

2016-02-14 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/6707#discussion_r52853898 --- Diff: streaming/src/test/scala/org/apache/spark/streaming/ReceivedBlockHandlerSuite.scala --- @@ -174,6 +176,130 @@ class ReceivedBlockHandlerSuite

[GitHub] spark pull request: [SPARK-8080][STREAMING] Receiver.store with It...

2016-02-14 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/6707#discussion_r52853882 --- Diff: streaming/src/test/scala/org/apache/spark/streaming/ReceivedBlockHandlerSuite.scala --- @@ -174,6 +176,130 @@ class ReceivedBlockHandlerSuite

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-184023107 **[Test build #51287 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51287/consoleFull)** for PR 10705 at commit

[GitHub] spark pull request: [SPARK-8080][STREAMING] Receiver.store with It...

2016-02-14 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/6707#issuecomment-184022738 I know it's about half a year too late to be complaining about this, but the formatting and control flow in this patch's tests make things really hard to debug and

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-184021971 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-184021972 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12503][SPARK-12505] Limit pushdown in U...

2016-02-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11121 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12503][SPARK-12505] Limit pushdown in U...

2016-02-14 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11121#issuecomment-184020008 I'm going to merge this in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-12503][SPARK-12505] Limit pushdown in U...

2016-02-14 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/11121#issuecomment-184019891 @cloud-fan I agree. For SQL generation, currently we can only focus on resolved plans parsed from HiveQL. @gatorsmile I think after finishing that part, we may gain

[GitHub] spark pull request: [SPARK-12503][SPARK-12505] Limit pushdown in U...

2016-02-14 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11121#issuecomment-184019730 Yea - I don't think we ever turn optimized plan into sql right now. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-12503][SPARK-12505] Limit pushdown in U...

2016-02-14 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/11121#issuecomment-184019306 I think this is good to go, we can defer the "converting optimized plans to SQL" in a followup patch. cc @liancheng --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-13314][SQL] Fixes malformed WholeStageC...

2016-02-14 Thread liancheng
Github user liancheng closed the pull request at: https://github.com/apache/spark/pull/11200 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13314][SQL] Fixes malformed WholeStageC...

2016-02-14 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/11200#issuecomment-184019253 Oh, I didn't realize that those extra vertical lines are used to indicate scopes of codegen'd stages, then the original tree string makes sense. I thought they were

[GitHub] spark pull request: [SPARK-12503][SPARK-12505] Limit pushdown in U...

2016-02-14 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/11121#issuecomment-184018655 To confirm: is merging this patch blocking on anything or can concerns related to converting optimized plans to SQL be addressed in a followup patch? Would

[GitHub] spark pull request: [SPARK-13036][SPARK-13318][SPARK-13319] Add sa...

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11203#issuecomment-184017408 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13036][SPARK-13318][SPARK-13319] Add sa...

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11203#issuecomment-184017410 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13036][SPARK-13318][SPARK-13319] Add sa...

2016-02-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11203#issuecomment-184017391 **[Test build #51285 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51285/consoleFull)** for PR 11203 at commit

[GitHub] spark pull request: [SPARK-13036][SPARK-13318][SPARK-13319] Add sa...

2016-02-14 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/11203#discussion_r52852895 --- Diff: python/pyspark/ml/feature.py --- @@ -53,6 +53,18 @@ class Binarizer(JavaTransformer, HasInputCol, HasOutputCol): >>> params =

[GitHub] spark pull request: [SPARK-13036][SPARK-13318][SPARK-13319] Add sa...

2016-02-14 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/11203#discussion_r52852811 --- Diff: python/pyspark/ml/feature.py --- @@ -53,6 +53,18 @@ class Binarizer(JavaTransformer, HasInputCol, HasOutputCol): >>> params =

[GitHub] spark pull request: [SPARK-12995][GraphX] Remove deprecate APIs fr...

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10918#issuecomment-184016930 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12799] Simplify various string output f...

2016-02-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10757#issuecomment-184016938 **[Test build #51286 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51286/consoleFull)** for PR 10757 at commit

[GitHub] spark pull request: [SPARK-12995][GraphX] Remove deprecate APIs fr...

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10918#issuecomment-184016929 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12995][GraphX] Remove deprecate APIs fr...

2016-02-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10918#issuecomment-184016850 **[Test build #51281 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51281/consoleFull)** for PR 10918 at commit

[GitHub] spark pull request: [SPARK-13314][SQL] Fixes malformed WholeStageC...

2016-02-14 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11200#issuecomment-184015792 I'm really confused. what were we doing before whole-stage codegen? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-13314][SQL] Fixes malformed WholeStageC...

2016-02-14 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/11200#issuecomment-184013932 At least there should be a vertical tree line connecting two `WholeStageCodegen` nodes to indicate that they are both children of `Union`? The `:` in plan tree

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-184012646 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-184012648 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13036][SPARK-13318][SPARK-13319] Add sa...

2016-02-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11203#issuecomment-184012477 **[Test build #51285 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51285/consoleFull)** for PR 11203 at commit

  1   2   3   >