[GitHub] spark pull request: [MINOR][SQL] Replace DataFrameWriter.stream() ...

2016-03-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11629 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [MINOR][SQL] Replace DataFrameWriter.stream() ...

2016-03-09 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11629#issuecomment-194720804 Merging in master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13732] [SPARK-13797] [SQL] Remove proje...

2016-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11565#issuecomment-194720152 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13732] [SPARK-13797] [SQL] Remove proje...

2016-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11565#issuecomment-194720154 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13732] [SPARK-13797] [SQL] Remove proje...

2016-03-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11565#issuecomment-194720120 **[Test build #52818 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52818/consoleFull)** for PR 11565 at commit

[GitHub] spark pull request: [SPARK-13432][SQL] add the source file name an...

2016-03-09 Thread kiszk
Github user kiszk commented on the pull request: https://github.com/apache/spark/pull/11301#issuecomment-194719424 @Sarutak, I think that join and sort may generate Java code by own routines. Can I address other operations in other future PRs incrementally? --- If your project is

[GitHub] spark pull request: [SPARK-13732] [SPARK-13797] [SQL] Remove proje...

2016-03-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11565#issuecomment-194718830 **[Test build #52820 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52820/consoleFull)** for PR 11565 at commit

[GitHub] spark pull request: [SPARK-13577] [yarn] Allow Spark jar to be mul...

2016-03-09 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11500#issuecomment-194718630 Mostly eyeballing it here, but it looks reasonable to me given its goal. You'll know a lot more about what needs to happen to make this work than I would. --- If your

[GitHub] spark pull request: [SPARK-13732] [SPARK-13797] [SQL] Remove proje...

2016-03-09 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/11565#discussion_r55643000 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -384,9 +374,25 @@ object ColumnPruning extends

[GitHub] spark pull request: [SPARK-13577] [yarn] Allow Spark jar to be mul...

2016-03-09 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/11500#discussion_r55643032 --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala --- @@ -653,7 +653,9 @@ private[spark] object SparkConf extends Logging {

[GitHub] spark pull request: [SPARK-13789] Infer additional constraints fro...

2016-03-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11618#issuecomment-194717639 **[Test build #52819 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52819/consoleFull)** for PR 11618 at commit

[GitHub] spark pull request: [SPARK-13732] [SPARK-13797] [SQL] Remove proje...

2016-03-09 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/11565#discussion_r55642840 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -384,9 +374,25 @@ object ColumnPruning extends

[GitHub] spark pull request: [SPARK-13578] [core] Modify launch scripts to ...

2016-03-09 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11591#issuecomment-194716774 Seems OK to me, fWIW --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13789] Infer additional constraints fro...

2016-03-09 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/11618#discussion_r55642742 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala --- @@ -62,6 +63,25 @@ abstract class QueryPlan[PlanType <:

[GitHub] spark pull request: [MINOR][SQL] Replace DataFrameWriter.stream() ...

2016-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11629#issuecomment-194715899 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [MINOR][SQL] Replace DataFrameWriter.stream() ...

2016-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11629#issuecomment-194715896 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Don't build full...

2016-03-09 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/11178#discussion_r55642612 --- Diff: launcher/src/main/java/org/apache/spark/launcher/AbstractCommandBuilder.java --- @@ -146,10 +146,38 @@ void addOptionString(List cmd, String

[GitHub] spark pull request: [SPARK-13244][SQL] Migrates DataFrame to Datas...

2016-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11443#issuecomment-194715480 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Don't build full...

2016-03-09 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/11178#discussion_r55642583 --- Diff: dev/mima --- @@ -24,24 +24,63 @@ set -e FWDIR="$(cd "`dirname "$0"`"/..; pwd)" cd "$FWDIR" -echo -e "q\n" | build/sbt

[GitHub] spark pull request: [MINOR][SQL] Replace DataFrameWriter.stream() ...

2016-03-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11629#issuecomment-194715507 **[Test build #52817 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52817/consoleFull)** for PR 11629 at commit

[GitHub] spark pull request: [SPARK-13244][SQL] Migrates DataFrame to Datas...

2016-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11443#issuecomment-194715479 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13244][SQL] Migrates DataFrame to Datas...

2016-03-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11443#issuecomment-194715305 **[Test build #52814 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52814/consoleFull)** for PR 11443 at commit

[GitHub] spark pull request: [SPARK-13732] [SPARK-13797] [SPARK-13798] [SQL...

2016-03-09 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/11565#discussion_r55642440 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -384,9 +374,25 @@ object ColumnPruning extends

[GitHub] spark pull request: [SPARK-13732] [SPARK-13797] [SPARK-13798] [SQL...

2016-03-09 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/11565#discussion_r55642460 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -384,9 +374,25 @@ object ColumnPruning extends

[GitHub] spark pull request: [SPARK-13732] [SPARK-13797] [SPARK-13798] [SQL...

2016-03-09 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/11565#discussion_r55642323 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -384,9 +374,25 @@ object ColumnPruning extends

[GitHub] spark pull request: [SPARK-13732] [SPARK-13797] [SPARK-13798] [SQL...

2016-03-09 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/11565#discussion_r55642338 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -384,9 +374,25 @@ object ColumnPruning extends

[GitHub] spark pull request: [SPARK-13776][WebUI]Add spark.ui.threads to se...

2016-03-09 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/11615#discussion_r55642314 --- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala --- @@ -270,9 +270,21 @@ private[spark] object JettyUtils extends Logging {

[GitHub] spark pull request: [SPARK-13788][MLLIB] Fix side effects in Chole...

2016-03-09 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11617#issuecomment-194713989 Certainly, the lapack methods modify their arguments in order to return a value. That's by design of course. And the javadoc for this method indicates that the

[GitHub] spark pull request: [SPARK-13732] [SPARK-13797] [SPARK-13798] [SQL...

2016-03-09 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/11565#discussion_r55642207 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -384,9 +374,25 @@ object ColumnPruning extends

[GitHub] spark pull request: [SPARK-13706] [ML] Add Python Example for Trai...

2016-03-09 Thread MLnick
Github user MLnick commented on the pull request: https://github.com/apache/spark/pull/11547#issuecomment-194713380 @JeremyNixon thanks! Merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-13732] [SPARK-13797] [SPARK-13798] [SQL...

2016-03-09 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11565#issuecomment-194713298 In the latest PR: we added two more cases/rules into the Optimizer. - After column pruning, if `Window` could contain an empty `windowExpressions` list, we

[GitHub] spark pull request: [SPARK-13706] [ML] Add Python Example for Trai...

2016-03-09 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/11547#discussion_r55642006 --- Diff: examples/src/main/python/ml/train_validation_split.py --- @@ -0,0 +1,69 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] spark pull request: [SPARK-13706] [ML] Add Python Example for Trai...

2016-03-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11547 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13746][Tests]stop using deprecated Sync...

2016-03-09 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11580#issuecomment-194709904 This needs a rebase anyway so I left a few more comments. Otherwise LGTM pending tests --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-13746][Tests]stop using deprecated Sync...

2016-03-09 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/11580#discussion_r55641453 --- Diff: core/src/test/scala/org/apache/spark/ContextCleanerSuite.scala --- @@ -579,17 +579,20 @@ class CleanerTester( private def

[GitHub] spark pull request: [SPARK-13790] Speed up ColumnVector's getDecim...

2016-03-09 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11624#issuecomment-194709645 cc @davies --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-13746][Tests]stop using deprecated Sync...

2016-03-09 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/11580#discussion_r55641420 --- Diff: core/src/test/scala/org/apache/spark/ContextCleanerSuite.scala --- @@ -442,25 +442,25 @@ class CleanerTester( checkpointIds: Seq[Long] =

[GitHub] spark pull request: [SPARK-13732] [SPARK-13797] [SPARK-13798] [SQL...

2016-03-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11565#issuecomment-194709320 **[Test build #52818 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52818/consoleFull)** for PR 11565 at commit

[GitHub] spark pull request: [SPARK-13793] [CORE] PipedRDD doesn't propagat...

2016-03-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11628#issuecomment-194703169 **[Test build #2626 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2626/consoleFull)** for PR 11628 at commit

[GitHub] spark pull request: [SPARK-13793] [CORE] PipedRDD doesn't propagat...

2016-03-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11628#issuecomment-194700395 **[Test build #2626 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2626/consoleFull)** for PR 11628 at commit

[GitHub] spark pull request: [SPARK-13793] [CORE] PipedRDD doesn't propagat...

2016-03-09 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11628#issuecomment-194700039 LGTM pending tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12343][YARN] Simplify Yarn client and c...

2016-03-09 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/11603#discussion_r55639455 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -454,10 +478,16 @@ private[spark] class Client( * (3) whether to

[GitHub] spark pull request: [SPARK-13793] [CORE] PipedRDD doesn't propagat...

2016-03-09 Thread tejasapatil
Github user tejasapatil commented on the pull request: https://github.com/apache/spark/pull/11628#issuecomment-194694929 @rxin : Thanks for the review. I have updated the PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-194694816 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13793] [CORE] PipedRDD doesn't propagat...

2016-03-09 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/11628#discussion_r55639115 --- Diff: core/src/main/scala/org/apache/spark/rdd/PipedRDD.scala --- @@ -133,23 +134,30 @@ private[spark] class PipedRDD[T: ClassTag]( // Start

[GitHub] spark pull request: [SPARK-13732] [SQL] Remove projectList from Wi...

2016-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11565#issuecomment-194694790 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-194694815 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13732] [SQL] Remove projectList from Wi...

2016-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11565#issuecomment-194694793 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-194694692 **[Test build #52816 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52816/consoleFull)** for PR 9 at commit

[GitHub] spark pull request: [SPARK-13793] [CORE] PipedRDD doesn't propagat...

2016-03-09 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/11628#discussion_r55639013 --- Diff: core/src/main/scala/org/apache/spark/rdd/PipedRDD.scala --- @@ -118,6 +118,7 @@ private[spark] class PipedRDD[T: ClassTag]( val

[GitHub] spark pull request: [SPARK-13732] [SQL] Remove projectList from Wi...

2016-03-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11565#issuecomment-194694601 **[Test build #52815 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52815/consoleFull)** for PR 11565 at commit

[GitHub] spark pull request: [SPARK-13432][SQL] add the source file name an...

2016-03-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11301#issuecomment-194693889 **[Test build #52805 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52805/consoleFull)** for PR 11301 at commit

[GitHub] spark pull request: [SPARK-13432][SQL] add the source file name an...

2016-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11301#issuecomment-194693946 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-13432][SQL] add the source file name an...

2016-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11301#issuecomment-194693948 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13742][Core] Add non-iterator interface...

2016-03-09 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/11578#issuecomment-194692523 I made a mistake in previous benchmark for `withReplacement = false`. Update benchmark here. Without generated code for sample(): Intel(R)

[GitHub] spark pull request: [SPARK-13244][SQL] Migrates DataFrame to Datas...

2016-03-09 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11443#issuecomment-194691377 I talked with Michael - we thought it's fine to throw an exception that contains the query plan. That enables the debugging case and we don't need the lazy analysis

[GitHub] spark pull request: [SPARK-13244][SQL] Migrates DataFrame to Datas...

2016-03-09 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/11443#issuecomment-194691016 @yhuai `HiveCompatibilitySuite` passed both locally and on Jenkins. @marmbrus @rxin OK, then I'll merge this one as soon as Jenkins passes. An update of the

[GitHub] spark pull request: [SPARK-13732] [SQL] Remove projectList from Wi...

2016-03-09 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/11565#discussion_r55637701 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -387,6 +381,14 @@ object ColumnPruning extends

[GitHub] spark pull request: [SPARK-13793] [CORE] PipedRDD doesn't propagat...

2016-03-09 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11628#issuecomment-194688064 Thanks - looking pretty good. Just some minor comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-13793] [CORE] PipedRDD doesn't propagat...

2016-03-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11628#discussion_r55637448 --- Diff: core/src/main/scala/org/apache/spark/rdd/PipedRDD.scala --- @@ -133,23 +134,30 @@ private[spark] class PipedRDD[T: ClassTag]( // Start a

[GitHub] spark pull request: [MINOR][SQL] Replace DataFrameWriter.stream() ...

2016-03-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11629#issuecomment-194687743 Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13793] [CORE] PipedRDD doesn't propagat...

2016-03-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11628#discussion_r55637430 --- Diff: core/src/main/scala/org/apache/spark/rdd/PipedRDD.scala --- @@ -118,6 +118,7 @@ private[spark] class PipedRDD[T: ClassTag]( val proc =

[GitHub] spark pull request: [SPARK-12555][SQL] Add provided test scenario

2016-03-09 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11623#issuecomment-194687095 Can you update the description to actually describe the problem? It'd be great if it is understandable without having to cross-reference the JIRA ticket. --- If your

[GitHub] spark pull request: [MINOR][SQL] Replace DataFrameWriter.stream() ...

2016-03-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11629#issuecomment-194686722 **[Test build #52817 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52817/consoleFull)** for PR 11629 at commit

[GitHub] spark pull request: [MINOR][SQL] Replace DataFrameWriter.stream() ...

2016-03-09 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11629#issuecomment-194686733 LGTM pending tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13742][Core] Add non-iterator interface...

2016-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11578#issuecomment-194686319 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13742][Core] Add non-iterator interface...

2016-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11578#issuecomment-194686321 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [MINOR][SQL] Replace DataFrameWriter.stream() ...

2016-03-09 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/11629 [MINOR][SQL] Replace DataFrameWriter.stream() with startStream() in comments. ## What changes were proposed in this pull request? According to #11627 , this PR replace

[GitHub] spark pull request: [SPARK-13742][Core] Add non-iterator interface...

2016-03-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11578#issuecomment-194686038 **[Test build #52812 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52812/consoleFull)** for PR 11578 at commit

[GitHub] spark pull request: [SPARK-13734][SPARKR] Added histogram function

2016-03-09 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/11569#issuecomment-194684792 I agree that SparkR should not "require" ggplot... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-09 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-194684818 test it please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-09 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r55636801 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -137,6 +138,17 @@ class KMeansModel private[ml] ( @Since("1.6.0")

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-194684711 **[Test build #52816 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52816/consoleFull)** for PR 9 at commit

[GitHub] spark pull request: [SPARK-13732] [SQL] Remove projectList from Wi...

2016-03-09 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/11565#discussion_r55636439 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -387,6 +381,14 @@ object ColumnPruning extends

[GitHub] spark pull request: [SPARK-12718][SPARK-13720][SQL] SQL generation...

2016-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11555#issuecomment-194683067 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12718][SPARK-13720][SQL] SQL generation...

2016-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11555#issuecomment-194683068 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12718][SPARK-13720][SQL] SQL generation...

2016-03-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11555#issuecomment-194682902 **[Test build #52813 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52813/consoleFull)** for PR 11555 at commit

[GitHub] spark pull request: [SPARK-13789] Infer additional constraints fro...

2016-03-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11618#discussion_r55636107 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala --- @@ -62,6 +63,25 @@ abstract class QueryPlan[PlanType <:

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-09 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r55636113 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -137,6 +138,18 @@ class KMeansModel private[ml] ( @Since("1.6.0")

[GitHub] spark pull request: [SPARK-13732] [SQL] Remove projectList from Wi...

2016-03-09 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/11565#discussion_r55636068 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -387,6 +381,14 @@ object ColumnPruning extends

[GitHub] spark pull request: [SPARK-11888] [ML] Decision tree persistence i...

2016-03-09 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/11581#issuecomment-194675931 @jkbradley Make a pass. LGTM except for the minor issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-12343][YARN] Simplify Yarn client and c...

2016-03-09 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/11603#discussion_r55635356 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/config.scala --- @@ -177,14 +177,26 @@ package object config { private[spark] val

[GitHub] spark pull request: [SPARK-7420][STREAMING][TESTS] Enable test: o....

2016-03-09 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/11626#issuecomment-194672903 @rxin thanks ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-7420][STREAMING][TESTS] Enable test: o....

2016-03-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11626 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13732] [SQL] Remove projectList from Wi...

2016-03-09 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/11565#discussion_r55634864 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -387,6 +381,14 @@ object ColumnPruning extends

[GitHub] spark pull request: [SPARK-7420][STREAMING][TESTS] Enable test: o....

2016-03-09 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11626#issuecomment-194671489 Thanks - merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13747][SQL] Fix concurrent query with f...

2016-03-09 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/11586#discussion_r55634802 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -613,7 +613,12 @@ class DAGScheduler( properties: Properties):

[GitHub] spark pull request: [SPARK-13732] [SQL] Remove projectList from Wi...

2016-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11565#issuecomment-194669064 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13732] [SQL] Remove projectList from Wi...

2016-03-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11565#issuecomment-194668856 **[Test build #52790 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52790/consoleFull)** for PR 11565 at commit

[GitHub] spark pull request: [SPARK-13732] [SQL] Remove projectList from Wi...

2016-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11565#issuecomment-194669060 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-13794][SQL] Rename DataFrameWriter.stre...

2016-03-09 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11627#issuecomment-194669186 Thanks - merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13794][SQL] Rename DataFrameWriter.stre...

2016-03-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11627 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13636][SQL] Directly consume UnsafeRow ...

2016-03-09 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/11484#issuecomment-194668304 @davies Comments are addressed. Please let me know if you have further comments. Thanks! --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-13746][Tests]stop using deprecated Sync...

2016-03-09 Thread wilson888888888
Github user wilson8 commented on a diff in the pull request: https://github.com/apache/spark/pull/11580#discussion_r55634450 --- Diff: core/src/test/scala/org/apache/spark/ContextCleanerSuite.scala --- @@ -586,10 +586,12 @@ class CleanerTester( } private

[GitHub] spark pull request: [SPARK-13742][Core] Add non-iterator interface...

2016-03-09 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/11578#issuecomment-194667443 @davies What do your think? Do we want to use generated codes for sample() in wholestage codegen Sample operator? --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-13794][SQL] Rename DataFrameWriter.stre...

2016-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11627#issuecomment-194667169 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13696] Remove BlockStore class & simpli...

2016-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11534#issuecomment-194667138 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13696] Remove BlockStore class & simpli...

2016-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11534#issuecomment-194667136 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13794][SQL] Rename DataFrameWriter.stre...

2016-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11627#issuecomment-194667168 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13696] Remove BlockStore class & simpli...

2016-03-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11534#issuecomment-19444 **[Test build #52787 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52787/consoleFull)** for PR 11534 at commit

  1   2   3   4   5   6   7   8   9   >