[GitHub] spark pull request: [SPARK-14620][SQL] Use/benchmark a better hash...

2016-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12379#issuecomment-210298511 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14620][SQL] Use/benchmark a better hash...

2016-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12379#issuecomment-210298508 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14620][SQL] Use/benchmark a better hash...

2016-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12379#issuecomment-210298083 **[Test build #55896 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55896/consoleFull)** for PR 12379 at commit

[GitHub] spark pull request: [SPARK-13484][SQL] Prevent illegal NULL propag...

2016-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11371#issuecomment-210297311 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13484][SQL] Prevent illegal NULL propag...

2016-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11371#issuecomment-210297313 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13484][SQL] Prevent illegal NULL propag...

2016-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11371#issuecomment-210297103 **[Test build #55899 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55899/consoleFull)** for PR 11371 at commit

[GitHub] spark pull request: [SPARK-13484][SQL] Prevent illegal NULL propag...

2016-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11371#issuecomment-210296251 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13484][SQL] Prevent illegal NULL propag...

2016-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11371#issuecomment-210296164 **[Test build #55897 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55897/consoleFull)** for PR 11371 at commit

[GitHub] spark pull request: [SPARK-13484][SQL] Prevent illegal NULL propag...

2016-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11371#issuecomment-210296253 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13904][Scheduler]Add support for plugga...

2016-04-14 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11723#issuecomment-210295660 Sorry for the delay. This looks pretty good. Just have some comments about the style to be more consistent with rest of the Spark codebase. --- If your project is set up

[GitHub] spark pull request: [SPARK-13904][Scheduler]Add support for plugga...

2016-04-14 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11723#discussion_r59829119 --- Diff: core/src/test/scala/org/apache/spark/scheduler/ExternalClusterManagerSuite.scala --- @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-13904][Scheduler]Add support for plugga...

2016-04-14 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11723#discussion_r59829110 --- Diff: core/src/test/scala/org/apache/spark/scheduler/ExternalClusterManagerSuite.scala --- @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-13904][Scheduler]Add support for plugga...

2016-04-14 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11723#discussion_r59829094 --- Diff: core/src/main/scala/org/apache/spark/scheduler/ExternalClusterManager.scala --- @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-13904][Scheduler]Add support for plugga...

2016-04-14 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11723#discussion_r59829070 --- Diff: core/src/main/scala/org/apache/spark/scheduler/ExternalClusterManager.scala --- @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-13904][Scheduler]Add support for plugga...

2016-04-14 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11723#discussion_r59829023 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -2443,8 +2443,34 @@ object SparkContext extends Logging { "in the form

[GitHub] spark pull request: [SPARK-13904][Scheduler]Add support for plugga...

2016-04-14 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11723#discussion_r59828906 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -2443,8 +2443,34 @@ object SparkContext extends Logging { "in the form

[GitHub] spark pull request: [SPARK-13904][Scheduler]Add support for plugga...

2016-04-14 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11723#discussion_r59828857 --- Diff: core/src/main/scala/org/apache/spark/scheduler/ExternalClusterManager.scala --- @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-13904][Scheduler]Add support for plugga...

2016-04-14 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11723#discussion_r59828785 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -150,6 +150,15 @@ private[spark] class Executor( } } +

[GitHub] spark pull request: [SPARK-14549][ML] Copy the Vector and Matrix c...

2016-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12317#issuecomment-210294593 **[Test build #55902 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55902/consoleFull)** for PR 12317 at commit

[GitHub] spark pull request: [SPARK-13904][Scheduler]Add support for plugga...

2016-04-14 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11723#discussion_r59828777 --- Diff: core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala --- @@ -135,6 +135,8 @@ private[spark] class

[GitHub] spark pull request: [SPARK-14445][SQL] Support native execution of...

2016-04-14 Thread dilipbiswal
Github user dilipbiswal commented on the pull request: https://github.com/apache/spark/pull/1#issuecomment-210294481 @andrewor14 Thank you for a detailed review. I have implemented your comments. A few points/questions. 1) Currently InMemoryCatalog does not make use of

[GitHub] spark pull request: [SPARK-14580][SQL] Hive IfCoercion should pres...

2016-04-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/12340#discussion_r59828732 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercionSuite.scala --- @@ -348,6 +350,20 @@ class

[GitHub] spark pull request: [SPARK-14580][SQL] Hive IfCoercion should pres...

2016-04-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/12340#discussion_r59828693 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercionSuite.scala --- @@ -348,6 +350,20 @@ class

[GitHub] spark pull request: [SPARK-14580][SQL] Hive IfCoercion should pres...

2016-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12340#issuecomment-210293749 **[Test build #55900 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55900/consoleFull)** for PR 12340 at commit

[GitHub] spark pull request: [SPARK-14580][SQL] Hive IfCoercion should pres...

2016-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12340#issuecomment-210293795 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14580][SQL] Hive IfCoercion should pres...

2016-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12340#issuecomment-210293788 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14647][SQL] Group SQLContext/HiveContex...

2016-04-14 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12405#issuecomment-210293019 either works -- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-14445][SQL] Support native execution of...

2016-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1#issuecomment-210292905 **[Test build #55901 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55901/consoleFull)** for PR 1 at commit

[GitHub] spark pull request: [SPARK-14580][SQL] Hive IfCoercion should pres...

2016-04-14 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12340#discussion_r59828445 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercionSuite.scala --- @@ -348,6 +350,20 @@ class HiveTypeCoercionSuite

[GitHub] spark pull request: [SPARK-14580][SQL] Hive IfCoercion should pres...

2016-04-14 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12340#discussion_r59828455 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercionSuite.scala --- @@ -348,6 +350,20 @@ class HiveTypeCoercionSuite

[GitHub] spark pull request: [SPARK-14580][SQL] Hive IfCoercion should pres...

2016-04-14 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12340#discussion_r59828440 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercionSuite.scala --- @@ -348,6 +350,20 @@ class HiveTypeCoercionSuite

[GitHub] spark pull request: [SPARK-14580][SQL] Hive IfCoercion should pres...

2016-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12340#issuecomment-210292283 **[Test build #55900 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55900/consoleFull)** for PR 12340 at commit

[GitHub] spark pull request: [SPARK-14580][SQL] Hive IfCoercion should pres...

2016-04-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12340#issuecomment-210291837 I added the test cases into `HiveTypeCoercionSuite.test("type coercion for If")`. Thank you, @rxin. It should be there. --- If your project is set up for

[GitHub] spark pull request: [WIP, DO-NOT-MERGE][SQL][Added support for par...

2016-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12409#issuecomment-210291259 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [WIP, DO-NOT-MERGE][SQL][Added support for par...

2016-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12409#issuecomment-210291264 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [WIP, DO-NOT-MERGE][SQL][Added support for par...

2016-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12409#issuecomment-210291102 **[Test build #55894 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55894/consoleFull)** for PR 12409 at commit

[GitHub] spark pull request: [SPARK-14549][ML] Copy the Vector and Matrix c...

2016-04-14 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/12317#discussion_r59828006 --- Diff: mllib-local/src/main/scala/org/apache/spark/mllib/util/NumericParser.scala --- @@ -21,16 +21,14 @@ import java.util.StringTokenizer

[GitHub] spark pull request: [SPARK-14620][SQL][WIP] Use/benchmark a better...

2016-04-14 Thread sameeragarwal
Github user sameeragarwal commented on the pull request: https://github.com/apache/spark/pull/12379#issuecomment-210289458 cc @nongli --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-14593][SQL] Make currentVars work with ...

2016-04-14 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/12351#issuecomment-210289062 ok. then let me close this now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-14593][SQL] Make currentVars work with ...

2016-04-14 Thread viirya
Github user viirya closed the pull request at: https://github.com/apache/spark/pull/12351 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...

2016-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-210288804 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14640] Add @DeveloperApi on PythonUserD...

2016-04-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12401 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...

2016-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-210288807 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14622] Retain lost executors status

2016-04-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12408 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: Branch 1.6

2016-04-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12407 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...

2016-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-210288710 **[Test build #55891 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55891/consoleFull)** for PR 12252 at commit

[GitHub] spark pull request: [SPARK-14541] [SQL] SQL function: IFNULL, NULL...

2016-04-14 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12373#issuecomment-210288398 Also can you remove the "JIRA related" section from the description? It is redundant with the title when makes into the commit message. --- If your project is set up

[GitHub] spark pull request: [SPARK-14580][SQL] Hive IfCoercion should pres...

2016-04-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/12340#discussion_r59826908 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HivePlanTest.scala --- @@ -49,4 +49,12 @@ class HivePlanTest extends QueryTest

[GitHub] spark pull request: [SPARK-14549][ML] Copy the Vector and Matrix c...

2016-04-14 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/12317#discussion_r59826886 --- Diff: mllib-local/pom.xml --- @@ -49,6 +49,10 @@ test + org.json4s +

[GitHub] spark pull request: [SPARK-14473][SQL] Define analysis rules to ca...

2016-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12246#issuecomment-210287120 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14473][SQL] Define analysis rules to ca...

2016-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12246#issuecomment-210287115 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14549][ML] Copy the Vector and Matrix c...

2016-04-14 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/12317#issuecomment-210287063 I'm making another pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14473][SQL] Define analysis rules to ca...

2016-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12246#issuecomment-210287017 **[Test build #55890 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55890/consoleFull)** for PR 12246 at commit

[GitHub] spark pull request: [SPARK-13925] [ML] [SparkR] Expose R-like summ...

2016-04-14 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/12393#issuecomment-210286974 LGTM except `relativeError` and a magic number in test. This PR looks great!! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-13925] [ML] [SparkR] Expose R-like summ...

2016-04-14 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/12393#discussion_r59826612 --- Diff: R/pkg/inst/tests/testthat/test_mllib.R --- @@ -77,6 +77,55 @@ test_that("glm and predict", { expect_equal(length(predict(lm(y ~ x))), 15)

[GitHub] spark pull request: [SPARK-14580][SQL] Hive IfCoercion should pres...

2016-04-14 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12340#discussion_r59826549 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HivePlanTest.scala --- @@ -49,4 +49,12 @@ class HivePlanTest extends QueryTest with

[GitHub] spark pull request: [SPARK-14593][SQL] Make currentVars work with ...

2016-04-14 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/12351#issuecomment-210286319 Since we can easily fallback, I'd like not to make it even complicated to support all the corner. Each column require two arguments, java method only support 255

[GitHub] spark pull request: [SPARK-14580][SQL] Hive IfCoercion should pres...

2016-04-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/12340#discussion_r59826449 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HivePlanTest.scala --- @@ -49,4 +49,12 @@ class HivePlanTest extends QueryTest

[GitHub] spark pull request: [SPARK-13484][SQL] Prevent illegal NULL propag...

2016-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11371#issuecomment-210285679 **[Test build #55899 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55899/consoleFull)** for PR 11371 at commit

[GitHub] spark pull request: [SPARK-13925] [ML] [SparkR] Expose R-like summ...

2016-04-14 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/12393#discussion_r59826370 --- Diff: mllib/src/main/scala/org/apache/spark/ml/r/GeneralizedLinearRegressionWrapper.scala --- @@ -30,19 +30,59 @@ private[r] class

[GitHub] spark pull request: [SPARK-13925] [ML] [SparkR] Expose R-like summ...

2016-04-14 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/12393#discussion_r59826301 --- Diff: R/pkg/R/mllib.R --- @@ -101,12 +101,54 @@ setMethod("summary", signature(object = "GeneralizedLinearRegressionModel"), jobj <-

[GitHub] spark pull request: [SPARK-14374] [ML] [PySpark] PySpark ml GBTCla...

2016-04-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12383 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14483][WEBUI] Display user name for eac...

2016-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12257#issuecomment-210283610 **[Test build #55898 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55898/consoleFull)** for PR 12257 at commit

[GitHub] spark pull request: [SPARK-14644][ML][PYSPARK] Turn Binary param i...

2016-04-14 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12404#discussion_r59826196 --- Diff: python/pyspark/ml/param/shared.py --- @@ -583,6 +583,31 @@ def getVarianceCol(self): return self.getOrDefault(self.varianceCol)

[GitHub] spark pull request: Branch 1.6

2016-04-14 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12407#issuecomment-210283001 @thinkborm can you please close the pull request? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-14374] [ML] [PySpark] PySpark ml GBTCla...

2016-04-14 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/12383#issuecomment-210283059 Merged into master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-14620][SQL][WIP] Use/benchmark a better...

2016-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12379#issuecomment-210282632 **[Test build #55896 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55896/consoleFull)** for PR 12379 at commit

[GitHub] spark pull request: [SPARK-13484][SQL] Prevent illegal NULL propag...

2016-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11371#issuecomment-210282634 **[Test build #55897 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55897/consoleFull)** for PR 11371 at commit

[GitHub] spark pull request: [SPARK-14580][SQL] Hive IfCoercion should pres...

2016-04-14 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12340#discussion_r59825935 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HivePlanTest.scala --- @@ -49,4 +49,12 @@ class HivePlanTest extends QueryTest with

[GitHub] spark pull request: [SPARK-14483][WEBUI] Display user name for eac...

2016-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12257#issuecomment-210282278 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14580][SQL] Hive IfCoercion should pres...

2016-04-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12340#issuecomment-210282267 Hmm. The following is

[GitHub] spark pull request: [SPARK-14483][WEBUI] Display user name for eac...

2016-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12257#issuecomment-210282276 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14483][WEBUI] Display user name for eac...

2016-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12257#issuecomment-210282274 **[Test build #55895 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55895/consoleFull)** for PR 12257 at commit

[GitHub] spark pull request: [SPARK-14593][SQL] Make currentVars work with ...

2016-04-14 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/12351#issuecomment-210282213 cc @davies have time to look at this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-14483][WEBUI] Display user name for eac...

2016-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12257#issuecomment-210282197 **[Test build #55895 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55895/consoleFull)** for PR 12257 at commit

[GitHub] spark pull request: [SPARK-13432][SQL] add the source file name an...

2016-04-14 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/11301#issuecomment-210282165 @kiszk Thanks for the update. I'll check it next Monday or Tuesday. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...

2016-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-210280296 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...

2016-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-210280292 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14580][SQL] Hive IfCoercion should pres...

2016-04-14 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12340#issuecomment-21028 It's Hive built-in function. The following is function description. ``` hive> desc function assert_true; OK assert_true(condition) - Throw an

[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...

2016-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-210279874 **[Test build #55889 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55889/consoleFull)** for PR 12252 at commit

[GitHub] spark pull request: [SPARK-14104][PYSPARK][ML] All Python param se...

2016-04-14 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/11939#discussion_r59825160 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -389,8 +391,8 @@ def copy(self, extra=None): if extra is None: extra =

[GitHub] spark pull request: [SPARK-14275][SQL] Reimplement TypedAggregateE...

2016-04-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12067 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14275][SQL] Reimplement TypedAggregateE...

2016-04-14 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12067#issuecomment-210276781 @davies thanks for your review! merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-14275][SQL] Reimplement TypedAggregateE...

2016-04-14 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12067#discussion_r59824988 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TypedAggregateExpression.scala --- @@ -19,133 +19,153 @@ package

[GitHub] spark pull request: [SPARK-14580][SQL] Hive IfCoercion should pres...

2016-04-14 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12340#issuecomment-210276359 What is assert_true? I didnt' find its documentation anywhere. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [WIP][SPARK-14629][SPARK-14630][Build] Add sup...

2016-04-14 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12396#issuecomment-210276124 we can push this into scalastyle and then upgrade the version. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-1267][PYSPARK] Adds pip installer for p...

2016-04-14 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/8318#issuecomment-210276089 I think it's a good thing to do if we enable "pip install spark" for local modes. As you said, minimizing overhead would be great. --- If your project is set up for it,

[GitHub] spark pull request: [WIP, DO-NOT-MERGE][SQL][Added support for par...

2016-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12409#issuecomment-210275749 **[Test build #55894 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55894/consoleFull)** for PR 12409 at commit

[GitHub] spark pull request: [SPARK-14647][SQL] Group SQLContext/HiveContex...

2016-04-14 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12405#issuecomment-210275697 `GlobalState` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-8171] [Web UI] Javascript based infinit...

2016-04-14 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/10910#issuecomment-210275571 @ajbozarth Thank you for the update. I'll check it next Sunday or Monday. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-14647][SQL] Group SQLContext/HiveContex...

2016-04-14 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12405#issuecomment-210275659 `SharedState` sounds better. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-14647][SQL] Group SQLContext/HiveContex...

2016-04-14 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12405#discussion_r59824674 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala --- @@ -114,25 +94,25 @@ class HiveContext private[hive](

[GitHub] spark pull request: [SPARK-14647][SQL] Group SQLContext/HiveContex...

2016-04-14 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12405#issuecomment-210275028 Hm, `SharedState`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [WIP, DO-NOT-MERGE][SQL][Added support for par...

2016-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12409#issuecomment-210274920 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14447][SQL] Speed up TungstenAggregate ...

2016-04-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12345 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [WIP, DO-NOT-MERGE][SQL][Added support for par...

2016-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12409#issuecomment-210274921 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [WIP, DO-NOT-MERGE][SQL][Added support for par...

2016-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12409#issuecomment-210274915 **[Test build #55893 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55893/consoleFull)** for PR 12409 at commit

[GitHub] spark pull request: [WIP, DO-NOT-MERGE][SQL][Added support for par...

2016-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12409#issuecomment-210274778 **[Test build #55893 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55893/consoleFull)** for PR 12409 at commit

[GitHub] spark pull request: [WIP, DO-NOT-MERGE][SQL][Added support for par...

2016-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12409#issuecomment-210274332 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [WIP, DO-NOT-MERGE][SQL][Added support for par...

2016-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12409#issuecomment-210274327 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

  1   2   3   4   5   6   7   8   9   >