[GitHub] spark pull request: [MINOR][PySpark] update _shared_params_code_ge...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12996#issuecomment-217781272 **[Test build #58122 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58122/consoleFull)** for PR 12996 at commit

[GitHub] spark pull request: [MINOR][PySpark] update _shared_params_code_ge...

2016-05-08 Thread zhengruifeng
GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/12996 [MINOR][PySpark] update _shared_params_code_gen.py ## What changes were proposed in this pull request? 1, add arg-checkings for `tol` and `stepSize` to keep in line with

[GitHub] spark pull request: [SPARK-14939][SQL] Add FoldablePropagation opt...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12719#issuecomment-217780844 **[Test build #58120 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58120/consoleFull)** for PR 12719 at commit

[GitHub] spark pull request: [SPARK-13902][SCHEDULER] Make DAGScheduler.get...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12655#issuecomment-217780852 **[Test build #58121 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58121/consoleFull)** for PR 12655 at commit

[GitHub] spark pull request: [SPARK-15064][ML] Locale support in StopWordsR...

2016-05-08 Thread hhbyyh
Github user hhbyyh commented on the pull request: https://github.com/apache/spark/pull/12968#issuecomment-217780806 Made a pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-13902][SCHEDULER] Make DAGScheduler.get...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12655#issuecomment-217780501 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13902][SCHEDULER] Make DAGScheduler.get...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12655#issuecomment-217780498 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15064][ML] Locale support in StopWordsR...

2016-05-08 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/12968#discussion_r62452057 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/StopWordsRemoverSuite.scala --- @@ -98,6 +98,7 @@ class StopWordsRemoverSuite

[GitHub] spark pull request: [SPARK-13902][SCHEDULER] Make DAGScheduler.get...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12655#issuecomment-217780496 **[Test build #58119 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58119/consoleFull)** for PR 12655 at commit

[GitHub] spark pull request: [SPARK-13902][SCHEDULER] Make DAGScheduler.get...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12655#issuecomment-217780312 **[Test build #58119 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58119/consoleFull)** for PR 12655 at commit

[GitHub] spark pull request: [SPARK-15199] [SQL] Disallow Dropping Build-in...

2016-05-08 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/12975#discussion_r62451961 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala --- @@ -157,6 +157,9 @@ case class DropFunction(

[GitHub] spark pull request: [SPARK-15199] [SQL] Disallow Dropping Build-in...

2016-05-08 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/12975#discussion_r62451866 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala --- @@ -157,6 +157,9 @@ case class DropFunction(

[GitHub] spark pull request: [SPARK-15064][ML] Locale support in StopWordsR...

2016-05-08 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/12968#discussion_r62451491 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala --- @@ -73,22 +75,37 @@ class StopWordsRemover(override val uid: String)

[GitHub] spark pull request: [SPARK-15209] Fix display of job descriptions ...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12995#issuecomment-217779134 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15209] Fix display of job descriptions ...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12995#issuecomment-217779133 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15064][ML] Locale support in StopWordsR...

2016-05-08 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/12968#discussion_r62451393 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala --- @@ -73,22 +75,37 @@ class StopWordsRemover(override val uid: String)

[GitHub] spark pull request: [SPARK-15209] Fix display of job descriptions ...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12995#issuecomment-217779047 **[Test build #58118 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58118/consoleFull)** for PR 12995 at commit

[GitHub] spark pull request: [SPARK-15064][ML] Locale support in StopWordsR...

2016-05-08 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/12968#discussion_r62451347 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala --- @@ -73,22 +75,37 @@ class StopWordsRemover(override val uid: String)

[GitHub] spark pull request: [SPARK-15160][SQL] support data source table i...

2016-05-08 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12935#issuecomment-21835 I'll update it after https://github.com/apache/spark/pull/12949 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-15217] [SQL] Always Case Insensitive in...

2016-05-08 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/12993#issuecomment-21713 Agree. We need to be careful for deciding the design. This PR is just to recover our previous behavior in `HiveContext`. Regarding case sensitivity, it is

[GitHub] spark pull request: [SPARK-15202][SPARKR] add dapplyCollect() meth...

2016-05-08 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/12989#issuecomment-21755 cc @shivaram, @felixcheung , @NarineK --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-14939][SQL] Add FoldablePropagation opt...

2016-05-08 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/12719#discussion_r62450948 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -90,6 +90,8 @@ abstract class

[GitHub] spark pull request: [SPARK-14939][SQL] Add FoldablePropagation opt...

2016-05-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12719#discussion_r62450837 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -90,6 +90,8 @@ abstract class

[GitHub] spark pull request: [SPARK-14495][SQL][1.6] fix resolution failure...

2016-05-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12974#discussion_r62450742 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DistinctAggregationRewriter.scala --- @@ -123,15 +119,7 @@ case class

[GitHub] spark pull request: [SPARK-15199] [SQL] Disallow Dropping Build-in...

2016-05-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12975#discussion_r62450713 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala --- @@ -157,6 +157,9 @@ case class DropFunction(

[GitHub] spark pull request: [SPARK-15184] [SQL] Fix Silent Removal of An E...

2016-05-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12959 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-15184] [SQL] Fix Silent Removal of An E...

2016-05-08 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12959#issuecomment-217776816 thanks, merging to master and 2.0! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-14098][SQL] Generate Java code that get...

2016-05-08 Thread kiszk
Github user kiszk commented on the pull request: https://github.com/apache/spark/pull/11956#issuecomment-217775281 @davies As you suggested, I moved most of the implmentation from ```WholeStageCodegenExec``` to ```InMemoryTableScanExec```. Now, the number of changed lines in

[GitHub] spark pull request: [SPARK-15217] [SQL] Always Case Insensitive in...

2016-05-08 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12993#issuecomment-217773874 I think we need to discuss it more: 1. should we allow the case sensitivity to be configurable? It's sometimes out of our control like hive catalog, which is

[GitHub] spark pull request: [SPARK-15199] [SQL] Disallow Dropping Build-in...

2016-05-08 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/12975#discussion_r62449958 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala --- @@ -157,6 +157,9 @@ case class DropFunction(

[GitHub] spark pull request: [SPARK-15185] [SQL] InMemoryCatalog: Silent Re...

2016-05-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12960 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-15185] [SQL] InMemoryCatalog: Silent Re...

2016-05-08 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12960#issuecomment-217774838 thanks, merging to master and 2.0! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-15199] [SQL] Disallow Dropping Build-in...

2016-05-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12975#discussion_r62449710 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala --- @@ -157,6 +157,9 @@ case class DropFunction(

[GitHub] spark pull request: [SPARK-15080][CORE] Break copyAndReset into co...

2016-05-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12936#discussion_r62449624 --- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala --- @@ -291,11 +291,20 @@ private[spark] object TaskMetrics extends Logging {

[GitHub] spark pull request: [SPARK-14098][SQL] Generate Java code that get...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11956#issuecomment-217773268 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14098][SQL] Generate Java code that get...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11956#issuecomment-217773265 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14098][SQL] Generate Java code that get...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11956#issuecomment-217773178 **[Test build #58117 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58117/consoleFull)** for PR 11956 at commit

[GitHub] spark pull request: [SPARK-15209] Fix display of job descriptions ...

2016-05-08 Thread JoshRosen
GitHub user JoshRosen opened a pull request: https://github.com/apache/spark/pull/12995 [SPARK-15209] Fix display of job descriptions with single quotes in web UI timeline ## What changes were proposed in this pull request? This patch fixes an escaping bug in the Web UI's

[GitHub] spark pull request: [SPARK-15209] Fix display of job descriptions ...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12995#issuecomment-217769812 **[Test build #58118 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58118/consoleFull)** for PR 12995 at commit

[GitHub] spark pull request: [SPARK-15217] [SQL] Always Case Insensitive in...

2016-05-08 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/12993#issuecomment-217770263 cc @cloud-fan @rxin @yhuai @andrewor14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15209] Fix display of job descriptions ...

2016-05-08 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/12995#issuecomment-217769825 /cc @andrewor14 as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-15187] [SQL] Disallow Dropping Default ...

2016-05-08 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/12962#issuecomment-217770405 @cloud-fan https://github.com/apache/spark/pull/12993 resolves the issue you mentioned above. Will change this PR too for resolving the issues of database names by

[GitHub] spark pull request: [SPARK-13232][YARN] Fix executor node label

2016-05-08 Thread jerryshao
Github user jerryshao commented on the pull request: https://github.com/apache/spark/pull/11129#issuecomment-217768853 >now, maximally devious would be to catch the exception and downgrade Maybe we could do this in Spark side, though a little complicated but doable.

[GitHub] spark pull request: [SPARK-15180][SQL] Support subexpression elimi...

2016-05-08 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/12956#issuecomment-217768690 cc @davies This is ready for review. Please take a look of this. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-15211][SQL] Select features column from...

2016-05-08 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/12986#issuecomment-217768128 ping @liancheng @yhuai Please take a look of this. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-13064] Make sure attemptId not none for...

2016-05-08 Thread jerryshao
Github user jerryshao commented on the pull request: https://github.com/apache/spark/pull/12075#issuecomment-217768123 @srowen , currently we assume attempt id is `None` when spark application is running on yarn client mode. This assumption is used not only in REST api, but also in

[GitHub] spark pull request: [SPARK-14098][SQL] Generate Java code that get...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11956#issuecomment-217766571 **[Test build #58117 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58117/consoleFull)** for PR 11956 at commit

[GitHub] spark pull request: [SPARK-15125][SQL] Changing CSV data source ma...

2016-05-08 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/12904#issuecomment-217765823 +1 for @sureshthalamati #12921 handles the inconsistent behaviour and this is why I think we should hold off this until that PR is merged. --- If your

[GitHub] spark pull request: [SPARK-15125][SQL] Changing CSV data source ma...

2016-05-08 Thread sureshthalamati
Github user sureshthalamati commented on the pull request: https://github.com/apache/spark/pull/12904#issuecomment-217765505 I am not sure what was the history behind returning empty String for null value. In my opinion it should be null be default. current behavior is also

[GitHub] spark pull request: [SPARK-14963][Yarn] Using recoveryPath if NM r...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12994#issuecomment-217764236 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14963][Yarn] Using recoveryPath if NM r...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12994#issuecomment-217764237 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14963][Yarn] Using recoveryPath if NM r...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12994#issuecomment-217764184 **[Test build #58116 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58116/consoleFull)** for PR 12994 at commit

[GitHub] spark pull request: [SPARK-14963][Yarn] Using recoveryPath if NM r...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12994#issuecomment-217763069 **[Test build #58116 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58116/consoleFull)** for PR 12994 at commit

[GitHub] spark pull request: [SPARK-14963][Yarn] Using recoveryPath if NM r...

2016-05-08 Thread jerryshao
GitHub user jerryshao opened a pull request: https://github.com/apache/spark/pull/12994 [SPARK-14963][Yarn] Using recoveryPath if NM recovery is enabled ## What changes were proposed in this pull request? From Hadoop 2.5+, Yarn NM supports NM recovery which using recovery

[GitHub] spark pull request: [SPARK-15217] [SQL] Always Case Insensitive in...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12993#issuecomment-217762674 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15217] [SQL] Always Case Insensitive in...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12993#issuecomment-217762675 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15217] [SQL] Always Case Insensitive in...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12993#issuecomment-217762595 **[Test build #58114 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58114/consoleFull)** for PR 12993 at commit

[GitHub] spark pull request: [SPARK-15125][SQL] Changing CSV data source ma...

2016-05-08 Thread sureshthalamati
Github user sureshthalamati commented on a diff in the pull request: https://github.com/apache/spark/pull/12904#discussion_r62444274 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala --- @@ -555,4 +558,37 @@ class CSVSuite extends

[GitHub] spark pull request: [SPARK-14098][SQL] Generate Java code that get...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11956#issuecomment-217760415 **[Test build #58115 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58115/consoleFull)** for PR 11956 at commit

[GitHub] spark pull request: [SPARK-14098][SQL] Generate Java code that get...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11956#issuecomment-217760423 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14098][SQL] Generate Java code that get...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11956#issuecomment-217760422 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14098][SQL] Generate Java code that get...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11956#issuecomment-217760139 **[Test build #58115 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58115/consoleFull)** for PR 11956 at commit

[GitHub] spark pull request: [SPARK-15217] [SQL] Always Case Insensitive in...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12993#issuecomment-217757584 **[Test build #58114 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58114/consoleFull)** for PR 12993 at commit

[GitHub] spark pull request: [SPARK-10216][SQL] Avoid creating empty files ...

2016-05-08 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/12855#issuecomment-217757354 Hi @marmbrus , Could you please take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-15217] [SQL] Always Case Insensitive in...

2016-05-08 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/12993 [SPARK-15217] [SQL] Always Case Insensitive in HiveSessionState What changes were proposed in this pull request? In a `HiveSessionState`, which is a given `SparkSession` backed by Hive,

[GitHub] spark pull request: [SPARK-13382][DOCS][PYSPARK] Update pyspark te...

2016-05-08 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/11278#issuecomment-217755544 ping @JoshRosen ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-15113][PySpark][ML] Add missing num fea...

2016-05-08 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/12889#issuecomment-217755535 Updated the classification models that do the mixing in based on the current inheritance in Scala side. I can follow up with more regression changes if no one takes

[GitHub] spark pull request: [SPARK-15130][PySpark][ML][DOCS] pyspark expos...

2016-05-08 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/12914#issuecomment-217755456 Any more ideas on if this is something we want (cc @davies ?)? This one only does shared params so I'd like to follow it up for the non-shared params as well. I think

[GitHub] spark pull request: [SPARK-15092][SPARK-15139][PYSPARK][ML] Pyspar...

2016-05-08 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/12919#discussion_r62441488 --- Diff: python/pyspark/ml/regression.py --- @@ -743,6 +743,18 @@ def treeWeights(self): """Return the weights for each tree"""

[GitHub] spark pull request: [spark-15212][SQL]CSV file reader when read fi...

2016-05-08 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/12987#issuecomment-217755229 I think this option should be associated with `ignoreLeadingWhiteSpace` and `ignoreTrailingWhiteSpace` options. --- If your project is set up for it, you can

[GitHub] spark pull request: [spark-15212][SQL]CSV file reader when read fi...

2016-05-08 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/12987#issuecomment-217754950 Also, the JIRA in the title, `spark-15212` might better be `SPARK-15212` (See https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark) --- If your

[GitHub] spark pull request: [spark-15212][SQL]CSV file reader when read fi...

2016-05-08 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/12987#discussion_r62441323 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/DefaultSource.scala --- @@ -61,7 +61,7 @@ class DefaultSource extends

[GitHub] spark pull request: [SPARK-15187] [SQL] Disallow Dropping Default ...

2016-05-08 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/12962#discussion_r62441163 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -118,6 +118,9 @@ class SessionCatalog( }

[GitHub] spark pull request: [SPARK-15076][SQL] Improve ConstantFolding opt...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12850#issuecomment-217751647 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15076][SQL] Improve ConstantFolding opt...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12850#issuecomment-217751648 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15076][SQL] Improve ConstantFolding opt...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12850#issuecomment-217751614 **[Test build #58113 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58113/consoleFull)** for PR 12850 at commit

[GitHub] spark pull request: [SPARK-15216] [SQL] Add a new Dataset API expl...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12992#issuecomment-217750373 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15216] [SQL] Add a new Dataset API expl...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12992#issuecomment-217750374 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15216] [SQL] Add a new Dataset API expl...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12992#issuecomment-217750329 **[Test build #58111 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58111/consoleFull)** for PR 12992 at commit

[GitHub] spark pull request: [SPARK-15207][BUILD] Use Travis CI for Java/Sc...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12980#issuecomment-217749784 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15207][BUILD] Use Travis CI for Java/Sc...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12980#issuecomment-217749785 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15058][MLLIB][TEST] Enable Java Decisio...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12840#issuecomment-217749775 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15058][MLLIB][TEST] Enable Java Decisio...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12840#issuecomment-217749756 **[Test build #58112 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58112/consoleFull)** for PR 12840 at commit

[GitHub] spark pull request: [SPARK-15058][MLLIB][TEST] Enable Java Decisio...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12840#issuecomment-217749777 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15207][BUILD] Use Travis CI for Java/Sc...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12980#issuecomment-217749731 **[Test build #58110 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58110/consoleFull)** for PR 12980 at commit

[GitHub] spark pull request: [SPARK-13432][SQL] add the source file name an...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11301#issuecomment-217748674 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13432][SQL] add the source file name an...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11301#issuecomment-217748675 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13432][SQL] add the source file name an...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11301#issuecomment-217748642 **[Test build #58109 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58109/consoleFull)** for PR 11301 at commit

[GitHub] spark pull request: [SPARK-15076][SQL] Improve ConstantFolding opt...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12850#issuecomment-217748244 **[Test build #58113 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58113/consoleFull)** for PR 12850 at commit

[GitHub] spark pull request: [SPARK-15058][MLLIB][TEST] Enable Java Decisio...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12840#issuecomment-217748005 **[Test build #58112 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58112/consoleFull)** for PR 12840 at commit

[GitHub] spark pull request: [SPARK-15216] [SQL] Add a new Dataset API expl...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12992#issuecomment-217746435 **[Test build #58111 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58111/consoleFull)** for PR 12992 at commit

[GitHub] spark pull request: [SPARK-15216] [SQL] Add a new Dataset API expl...

2016-05-08 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/12992#issuecomment-217746275 cc @rxin Let me know if this PR is valid. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-15216] [SQL] Add a new Dataset API expl...

2016-05-08 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/12992 [SPARK-15216] [SQL] Add a new Dataset API explainCodegen What changes were proposed in this pull request? Reading codegen output is important for developers to debug. So far,

[GitHub] spark pull request: [SPARK-15207][BUILD] Use Travis CI for Java/Sc...

2016-05-08 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12980#issuecomment-217744521 Hi, @srowen . I added `test-compile`, too. You can see the result here. https://travis-ci.org/dongjoon-hyun/spark/builds/128708372 For your

[GitHub] spark pull request: [SPARK-15207][BUILD] Use Travis CI for Java/Sc...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12980#issuecomment-217744182 **[Test build #58110 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58110/consoleFull)** for PR 12980 at commit

[GitHub] spark pull request: [SPARK-13432][SQL] add the source file name an...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11301#issuecomment-217742852 **[Test build #58109 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58109/consoleFull)** for PR 11301 at commit

[GitHub] spark pull request: [SPARK-15215] [SQL] Fix Explain Parsing and Ou...

2016-05-08 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/12991#discussion_r62437307 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -92,7 +92,7 @@ statement | CREATE TEMPORARY?

[GitHub] spark pull request: [SPARK-15215] [SQL] Fix Explain Parsing and Ou...

2016-05-08 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/12991#discussion_r62437296 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -92,7 +92,7 @@ statement | CREATE TEMPORARY?

[GitHub] spark pull request: [SPARK-15215] [SQL] Fix Explain Parsing and Ou...

2016-05-08 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/12991#discussion_r62437290 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -92,7 +92,7 @@ statement | CREATE TEMPORARY?

[GitHub] spark pull request: [SPARK-15215] [SQL] Fix Explain Parsing and Ou...

2016-05-08 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/12991#discussion_r62437280 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -92,7 +92,7 @@ statement | CREATE TEMPORARY?

  1   2   3   >