[GitHub] spark pull request: [SPARK-14603] [SQL] [WIP] Verification of Meta...

2016-05-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12385#issuecomment-218066012 **[Test build #58211 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58211/consoleFull)** for PR 12385 at commit

[GitHub] spark pull request: [SPARK-14963][Yarn] Using recoveryPath if NM r...

2016-05-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12994#issuecomment-218065383 **[Test build #58210 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58210/consoleFull)** for PR 12994 at commit

[GitHub] spark pull request: [SPARK-14963][Yarn] Using recoveryPath if NM r...

2016-05-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12994#issuecomment-218064524 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14963][Yarn] Using recoveryPath if NM r...

2016-05-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12994#issuecomment-218064520 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14963][Yarn] Using recoveryPath if NM r...

2016-05-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12994#issuecomment-218064500 **[Test build #58207 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58207/consoleFull)** for PR 12994 at commit

[GitHub] spark pull request: [SPARK-12837][CORE] reduce network IO for accu...

2016-05-09 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/12899#discussion_r62614867 --- Diff: core/src/main/scala/org/apache/spark/scheduler/Task.scala --- @@ -155,7 +155,13 @@ private[spark] abstract class Task[T]( */ def

[GitHub] spark pull request: [SPARK-15245][SQL] Stream API throws an except...

2016-05-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13021#issuecomment-218063538 **[Test build #58209 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58209/consoleFull)** for PR 13021 at commit

[GitHub] spark pull request: [SPARK-15245][SQL] Stream API throws an except...

2016-05-09 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/13021 [SPARK-15245][SQL] Stream API throws an exception for non-directory path with incorrect message. ## What changes were proposed in this pull request?

[GitHub] spark pull request: [SPARK-14963][Yarn] Using recoveryPath if NM r...

2016-05-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12994#issuecomment-218062949 **[Test build #58207 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58207/consoleFull)** for PR 12994 at commit

[GitHub] spark pull request: [SPARK-15207][BUILD] Use Travis CI for Java Li...

2016-05-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12980#issuecomment-218062958 **[Test build #58208 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58208/consoleFull)** for PR 12980 at commit

[GitHub] spark pull request: [SPARK-14963][Yarn] Using recoveryPath if NM r...

2016-05-09 Thread jerryshao
Github user jerryshao commented on the pull request: https://github.com/apache/spark/pull/12994#issuecomment-218062741 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-15207][BUILD] Use Travis CI for Java Li...

2016-05-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12980#issuecomment-218062547 @srowen I added comments, too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14914] Fix Resource not closed after us...

2016-05-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12693#issuecomment-218061787 **[Test build #58206 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58206/consoleFull)** for PR 12693 at commit

[GitHub] spark pull request: [SPARK-4452][Core][HOT-FIX] Fix code style and...

2016-05-09 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/13020#issuecomment-218061515 Is this really an hot fix (serious bug or breaking tests)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-15241][SPARK-15242][SQL] fix 2 decimal-...

2016-05-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13019#issuecomment-218061289 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15241][SPARK-15242][SQL] fix 2 decimal-...

2016-05-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13019#issuecomment-218061290 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15241][SPARK-15242][SQL] fix 2 decimal-...

2016-05-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13019#issuecomment-218061186 **[Test build #58202 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58202/consoleFull)** for PR 13019 at commit

[GitHub] spark pull request: [SPARK-14914] Fix Resource not closed after us...

2016-05-09 Thread taoli91
Github user taoli91 commented on the pull request: https://github.com/apache/spark/pull/12693#issuecomment-218061073 @andrewor14 I've fixed the failure. Could you please try it again? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-14963][Yarn] Using recoveryPath if NM r...

2016-05-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12994#issuecomment-218060958 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14963][Yarn] Using recoveryPath if NM r...

2016-05-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12994#issuecomment-218060959 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14963][Yarn] Using recoveryPath if NM r...

2016-05-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12994#issuecomment-218060952 **[Test build #58205 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58205/consoleFull)** for PR 12994 at commit

[GitHub] spark pull request: [SPARK-14963][Yarn] Using recoveryPath if NM r...

2016-05-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12994#issuecomment-218060219 **[Test build #58205 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58205/consoleFull)** for PR 12994 at commit

[GitHub] spark pull request: [WIP][SPARK-15207][BUILD] Use Travis CI for Ja...

2016-05-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12980#issuecomment-218056288 **[Test build #58204 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58204/consoleFull)** for PR 12980 at commit

[GitHub] spark pull request: [WIP][SPARK-15207][BUILD] Use Travis CI for Ja...

2016-05-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12980#issuecomment-218056112 Hi, @srowen . I removes `RAT` and `lint-python` in order to focus **lint-java**. Also, `lint-scala` is removed since it's already done by `mvn install`.

[GitHub] spark pull request: [SPARK-4452][Core][HOT-FIX] Fix code style and...

2016-05-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13020#discussion_r62610260 --- Diff: core/src/main/scala/org/apache/spark/util/collection/Spillable.scala --- @@ -41,7 +41,7 @@ private[spark] abstract class

[GitHub] spark pull request: [SPARK-4452][Core][HOT-FIX] Fix code style and...

2016-05-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13020#issuecomment-218055325 **[Test build #58203 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58203/consoleFull)** for PR 13020 at commit

[GitHub] spark pull request: [SPARK-4452][Core][HOT-FIX] Fix code style and...

2016-05-09 Thread lianhuiwang
Github user lianhuiwang commented on the pull request: https://github.com/apache/spark/pull/13020#issuecomment-218055343 cc @davies --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-4452][Core][HOT-FIX] Fix code style and...

2016-05-09 Thread lianhuiwang
Github user lianhuiwang commented on a diff in the pull request: https://github.com/apache/spark/pull/13020#discussion_r62610586 --- Diff: core/src/main/scala/org/apache/spark/util/collection/Spillable.scala --- @@ -112,7 +112,6 @@ private[spark] abstract class

[GitHub] spark pull request: [SPARK-15204][SQL] Nullable is not correct for...

2016-05-09 Thread sbcd90
Github user sbcd90 closed the pull request at: https://github.com/apache/spark/pull/13012 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-15204][SQL] Nullable is not correct for...

2016-05-09 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13012#issuecomment-218055835 @sbcd90 please just close this until you figure out the right fix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-15204][SQL] Nullable is not correct for...

2016-05-09 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13012#issuecomment-218055811 That's not the right fix, because the zero value can be non-null, and yet the result can still be null. The right fix probably requires looking at the encoder. --- If

[GitHub] spark pull request: [SPARK-4452][Core][HOT-FIX] Fix code style and...

2016-05-09 Thread lianhuiwang
Github user lianhuiwang commented on a diff in the pull request: https://github.com/apache/spark/pull/13020#discussion_r62610536 --- Diff: core/src/main/scala/org/apache/spark/util/collection/Spillable.scala --- @@ -41,7 +41,7 @@ private[spark] abstract class

[GitHub] spark pull request: [SPARK-15204][SQL] Nullable is not correct for...

2016-05-09 Thread sbcd90
Github user sbcd90 commented on the pull request: https://github.com/apache/spark/pull/13012#issuecomment-218054997 Hello @rxin , @koertkuipers , I have been following your conversation & feel that the right fix will be ``` override def nullable: Boolean =

[GitHub] spark pull request: [SPARK-4452][Core][HOT-FIX] Fix code style and...

2016-05-09 Thread lianhuiwang
GitHub user lianhuiwang opened a pull request: https://github.com/apache/spark/pull/13020 [SPARK-4452][Core][HOT-FIX] Fix code style and improve volatile ## What changes were proposed in this pull request? 1. Fix code style 2. remove volatile of elementsRead ##

[GitHub] spark pull request: [SPARK-15204][SQL] Nullable is not correct for...

2016-05-09 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13012#issuecomment-218054495 Your last sentence was what I was saying. It is not correct to just have nullable = false. Please close this pull request as it is not a proper fix. --- If

[GitHub] spark pull request: [SPARK-15240][SQL] Use buffer variables to imp...

2016-05-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13018#issuecomment-218054371 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15240][SQL] Use buffer variables to imp...

2016-05-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13018#issuecomment-218054372 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15240][SQL] Use buffer variables to imp...

2016-05-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13018#issuecomment-218054292 **[Test build #58200 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58200/consoleFull)** for PR 13018 at commit

[GitHub] spark pull request: [SPARK-15204][SQL] Nullable is not correct for...

2016-05-09 Thread koertkuipers
Github user koertkuipers commented on the pull request: https://github.com/apache/spark/pull/13012#issuecomment-218053856 blackbox transformations infer nullable=false when you return a primitive. for example: ``` scala> sc.parallelize(List(1,2,3)).toDS.map(i => i * 2).schema

[GitHub] spark pull request: [SPARK-15187] [SQL] Disallow Dropping Default ...

2016-05-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12962 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-15240][SQL] Use buffer variables to imp...

2016-05-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13018#issuecomment-218053501 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15240][SQL] Use buffer variables to imp...

2016-05-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13018#issuecomment-218053502 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15187] [SQL] Disallow Dropping Default ...

2016-05-09 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12962#issuecomment-218053442 LGTM , merging to master and 2.0, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15240][SQL] Use buffer variables to imp...

2016-05-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13018#issuecomment-218053422 **[Test build #58199 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58199/consoleFull)** for PR 13018 at commit

[GitHub] spark pull request: [SPARK-15241][SPARK-15242][SQL] fix 2 decimal-...

2016-05-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13019#issuecomment-218052794 **[Test build #58202 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58202/consoleFull)** for PR 13019 at commit

[GitHub] spark pull request: [SPARK-15241][SPARK-15242][SQL] fix 2 decimal-...

2016-05-09 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/13019#issuecomment-218052585 cc @yhuai @liancheng @viirya --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-15241][SPARK-15242][SQL] fix 2 decimal-...

2016-05-09 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/13019 [SPARK-15241][SPARK-15242][SQL] fix 2 decimal-related issues in RowEncoder ## What changes were proposed in this pull request? SPARK-15241: We now support java decimal and catalyst

[GitHub] spark pull request: [SPARK-12639] [SQL] Mark Filters Fully Handled...

2016-05-09 Thread RussellSpitzer
Github user RussellSpitzer commented on the pull request: https://github.com/apache/spark/pull/11317#issuecomment-218052162 I don't think this is because of me ``` # A fatal error has been detected by the Java Runtime Environment: # # Internal Error

[GitHub] spark pull request: [SPARK-14963][Yarn] Using recoveryPath if NM r...

2016-05-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12994#issuecomment-218051051 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14963][Yarn] Using recoveryPath if NM r...

2016-05-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12994#issuecomment-218051038 **[Test build #58201 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58201/consoleFull)** for PR 12994 at commit

[GitHub] spark pull request: [SPARK-14963][Yarn] Using recoveryPath if NM r...

2016-05-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12994#issuecomment-218051052 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15187] [SQL] Disallow Dropping Default ...

2016-05-09 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/12962#issuecomment-218050940 @andrewor14 @cloud-fan The PR is ready for review. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-14857] [SQL] Table/Database Name Valida...

2016-05-09 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/12618#issuecomment-218050854 This PR removes `CreateDataSourceTableUtils.validateName`. We move it to `SessionCatalog`. Let me know if we need to make any change here. Thanks! @yhuai

[GitHub] spark pull request: [SPARK-14963][Yarn] Using recoveryPath if NM r...

2016-05-09 Thread jerryshao
Github user jerryshao commented on the pull request: https://github.com/apache/spark/pull/12994#issuecomment-218050017 @tgravescs , I tested locally using Hadoop 2.4 and 2.6 with different scenarios: 1. Only Hadoop 2.4 2. Hadoop 2.4 upgrade to 2.6 with NM recovery

[GitHub] spark pull request: [SPARK-14476][SQL] Improve the physical plan v...

2016-05-09 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12947#issuecomment-218049881 "HadoopFiles" isn't very useful, and sometimes the files are not even in Hadoop (e.g. it is just using Hadoop APIs to read S3). Can we say "scan" instead, and say the

[GitHub] spark pull request: [SPARK-15240][SQL] Use buffer variables to imp...

2016-05-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13018#issuecomment-218049576 **[Test build #58200 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58200/consoleFull)** for PR 13018 at commit

[GitHub] spark pull request: [SPARK-15171][SQL][WIP]Deprecate registerTempT...

2016-05-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12945#discussion_r62607434 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -2306,8 +2306,37 @@ class Dataset[T] private[sql]( * @group basic *

[GitHub] spark pull request: [SPARK-14963][Yarn] Using recoveryPath if NM r...

2016-05-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12994#issuecomment-218049583 **[Test build #58201 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58201/consoleFull)** for PR 12994 at commit

[GitHub] spark pull request: [SPARK-15171][SQL][WIP]Deprecate registerTempT...

2016-05-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12945#discussion_r62607407 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -2306,8 +2306,37 @@ class Dataset[T] private[sql]( * @group basic *

[GitHub] spark pull request: [SPARK-15171][SQL][WIP]Deprecate registerTempT...

2016-05-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12945#discussion_r62607402 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -2306,8 +2306,37 @@ class Dataset[T] private[sql]( * @group basic *

[GitHub] spark pull request: [SPARK-14476][SQL] Improve the physical plan v...

2016-05-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12947#issuecomment-218049358 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14476][SQL] Improve the physical plan v...

2016-05-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12947#issuecomment-218049359 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [Spark-15154][SQL] Change key types to Long in...

2016-05-09 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13009#issuecomment-218049250 cc @davies --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-14476][SQL] Improve the physical plan v...

2016-05-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12947#issuecomment-218049248 **[Test build #58195 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58195/consoleFull)** for PR 12947 at commit

[GitHub] spark pull request: [SPARK-15204][SQL] Nullable is not correct for...

2016-05-09 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13012#issuecomment-218049147 Is this even correct? Certain aggregators might return nulls. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-14021][SQL] custom context support for ...

2016-05-09 Thread adrian-wang
Github user adrian-wang closed the pull request at: https://github.com/apache/spark/pull/11843 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-15240][SQL] Use buffer variables to imp...

2016-05-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13018#issuecomment-218049057 **[Test build #58199 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58199/consoleFull)** for PR 13018 at commit

[GitHub] spark pull request: [SPARK-15240][SQL] Use buffer variables for up...

2016-05-09 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/13018#issuecomment-21804 Benchmark: val N = 50L << 20 runBenchmark("typed aggregation", N) { sparkSession.range(N).map(x => (x & 65535,

[GitHub] spark pull request: [SPARK-15240][SQL] Use buffer variables for up...

2016-05-09 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/13018 [SPARK-15240][SQL] Use buffer variables for update/merge expressions instead duplicate serialization/deserialization in TungstenAggregate ## What changes were proposed in this pull request?

[GitHub] spark pull request: [SPARK-14857] [SQL] Table/Database Name Valida...

2016-05-09 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12618#issuecomment-218048161 Yea, let's be consistent on what we allow for table and db names. We have a utility function `CreateDataSourceTableUtils.validateName`, which does the same check as

[GitHub] spark pull request: [SPARK-14857] [SQL] Table/Database Name Valida...

2016-05-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12618#issuecomment-218047607 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15234][SQL] Fix spark.catalog.listDatab...

2016-05-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13015 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14857] [SQL] Table/Database Name Valida...

2016-05-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12618#issuecomment-218047605 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15229][SQL] Make case sensitivity setti...

2016-05-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13011 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14857] [SQL] Table/Database Name Valida...

2016-05-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12618#issuecomment-218047473 **[Test build #58194 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58194/consoleFull)** for PR 12618 at commit

[GitHub] spark pull request: [SPARK-15229][SQL] Make case sensitivity setti...

2016-05-09 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13011#issuecomment-218047419 Merging in master/branch-2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-15234][SQL] Fix spark.catalog.listDatab...

2016-05-09 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13015#issuecomment-218047335 Merging in master/branch-2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-14979] [ML] [PySpark] Add examples for ...

2016-05-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12754#issuecomment-218044958 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14979] [ML] [PySpark] Add examples for ...

2016-05-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12754#issuecomment-218044954 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14979] [ML] [PySpark] Add examples for ...

2016-05-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12754#issuecomment-218044896 **[Test build #58198 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58198/consoleFull)** for PR 12754 at commit

[GitHub] spark pull request: [WIP][SPARK-15207][BUILD] Use Travis CI for Ja...

2016-05-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12980#issuecomment-218044552 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [WIP][SPARK-15207][BUILD] Use Travis CI for Ja...

2016-05-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12980#issuecomment-218044554 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [WIP][SPARK-15207][BUILD] Use Travis CI for Ja...

2016-05-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12980#issuecomment-21808 **[Test build #58190 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58190/consoleFull)** for PR 12980 at commit

[GitHub] spark pull request: [SPARK-14979] [ML] [PySpark] Add examples for ...

2016-05-09 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/12754#discussion_r62604571 --- Diff: examples/src/main/scala/org/apache/spark/examples/ml/GeneralizedLinearRegressionExample.scala --- @@ -0,0 +1,69 @@ +/* + * Licensed to

[GitHub] spark pull request: [WIP][SPARK-15207][BUILD] Use Travis CI for Ja...

2016-05-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12980#issuecomment-218044302 I found that the previous similar discussion on maven checkstyle overhead with @zsxwing and @srowen here, https://github.com/apache/spark/pull/11438 --- If your

[GitHub] spark pull request: [SPARK-14979] [ML] [PySpark] Add examples for ...

2016-05-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12754#issuecomment-218043919 **[Test build #58198 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58198/consoleFull)** for PR 12754 at commit

[GitHub] spark pull request: [SPARK-14979] [ML] [PySpark] Add examples for ...

2016-05-09 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/12754#discussion_r62604290 --- Diff: examples/src/main/scala/org/apache/spark/examples/ml/GeneralizedLinearRegressionExample.scala --- @@ -0,0 +1,69 @@ +/* + * Licensed to

[GitHub] spark pull request: [SPARK-12922][SparkR][WIP] Implement gapply() ...

2016-05-09 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/12836#discussion_r62603831 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/r/MapPartitionsRWrapper.scala --- @@ -25,6 +25,21 @@ import org.apache.spark.sql.Row

[GitHub] spark pull request: [SPARK-13792][SQL] Limit logging of bad record...

2016-05-09 Thread maropu
Github user maropu commented on the pull request: https://github.com/apache/spark/pull/12173#issuecomment-218042338 @falaki ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-12837][CORE] reduce network IO for accu...

2016-05-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12899#issuecomment-218042313 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12837][CORE] reduce network IO for accu...

2016-05-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12899#issuecomment-218042312 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13792][SQL] Limit logging of bad record...

2016-05-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12173#issuecomment-218042235 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13792][SQL] Limit logging of bad record...

2016-05-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12173#issuecomment-218042236 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12837][CORE] reduce network IO for accu...

2016-05-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12899#issuecomment-218042198 **[Test build #58185 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58185/consoleFull)** for PR 12899 at commit

[GitHub] spark pull request: [SPARK-14495][SQL][1.6] fix resolution failure...

2016-05-09 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/12974#issuecomment-218042213 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13792][SQL] Limit logging of bad record...

2016-05-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12173#issuecomment-218042115 **[Test build #58193 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58193/consoleFull)** for PR 12173 at commit

[GitHub] spark pull request: [SPARK-15238] Clarify supported Python version...

2016-05-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13017#issuecomment-218041973 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15238] Clarify supported Python version...

2016-05-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13017#issuecomment-218041971 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15238] Clarify supported Python version...

2016-05-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13017#issuecomment-218041913 **[Test build #58197 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58197/consoleFull)** for PR 13017 at commit

[GitHub] spark pull request: [SPARK-12922][SparkR][WIP] Implement gapply() ...

2016-05-09 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/12836#discussion_r62603320 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/r/MapPartitionsRWrapper.scala --- @@ -25,6 +25,21 @@ import org.apache.spark.sql.Row

  1   2   3   4   5   6   7   8   >