Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/13219#issuecomment-221480232
@viirya I think we need a test for the picklers. See
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/12836#issuecomment-221478783
Lets keep it as `dapply` - The specific choice of applying on a partition
as a data frame is built into its semantics. If we do build a single row UDF
then we can
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13284#issuecomment-221478629
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12875#issuecomment-221478643
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13284#issuecomment-221478607
**[Test build #59256 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59256/consoleFull)**
for PR 13284 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13284#issuecomment-221478631
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12875#issuecomment-221478641
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12875#issuecomment-221478570
**[Test build #59257 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59257/consoleFull)**
for PR 12875 at commit
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/13284#issuecomment-221477942
as for subset - maybe tighter signature matching checks in R 3.3.0? I
couldn't find any reference on that though.
---
If your project is set up for it, you can
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/13284#issuecomment-221477791
so startsWith endsWith were definitely added in 3.3.0.
I think we should be able to change the generic to match the signature to
get it to work (have not tried
Github user sun-rui commented on the pull request:
https://github.com/apache/spark/pull/12836#issuecomment-221477758
@NarineK, mapply does not apply here, but we can later add something like
lapply, which applies a function to each row in a DataFrame. I suddenly
realized that it
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/13284#issuecomment-221477450
Ok - so that explains one of the problems. Does anybody know what the
problem in `subset` is ?
---
If your project is set up for it, you can reply to this email and
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12875#issuecomment-221477146
**[Test build #59257 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59257/consoleFull)**
for PR 12875 at commit
Github user wangmiao1981 commented on the pull request:
https://github.com/apache/spark/pull/13284#issuecomment-221477072
@shivaram I will make the change with R version check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/13284#issuecomment-221476748
Continuing from my previous message, we can't add or remove `endsWith` and
`startsWith` as we want to support all R versions from 3.1.0 onwards. We could
get the R
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13284#issuecomment-221476475
**[Test build #59256 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59256/consoleFull)**
for PR 13284 at commit
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/13107#issuecomment-221476424
TimSort require a temporary buffer to store the shorter part, which could
be half of the size of pointer array in worst case. This depends on the
original order of
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/13287#issuecomment-221476178
Thanks for the pull request. Can you format the description better?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/13284#issuecomment-221476116
Hmm looks like `startsWith` and `endsWith` were added in R 3.3.0 - See
http://www.r-statistics.com/2016/05/r-3-3-0-is-released/
---
If your project is set up
Github user wangmiao1981 commented on the pull request:
https://github.com/apache/spark/pull/13284#issuecomment-221476011
@shivaram The pipedRDD one seems working when using sudo in Linux. My mac
does not work though.
---
If your project is set up for it, you can reply to this email
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13268
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13199
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user wangmiao1981 commented on the pull request:
https://github.com/apache/spark/pull/13284#issuecomment-221475769
@felixcheung
> conflicts(detail = TRUE)
$.GlobalEnv
[1] "df"
$`package:SparkR`
[1] "alias" "cov" "filter"
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/13268#issuecomment-221475713
LGTM. Merging this to master and branch-2.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/13199#issuecomment-221475488
LGTM. Merging this to master and branch-2.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user wangmiao1981 commented on the pull request:
https://github.com/apache/spark/pull/13284#issuecomment-221475397
R version 3.3.0 (2016-05-03) -- "Supposedly Educational"
Copyright (C) 2016 The R Foundation for Statistical Computing
Platform: x86_64-apple-darwin13.4.0
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12875#issuecomment-221474796
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12875#issuecomment-221474798
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12875#issuecomment-221474776
**[Test build #59255 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59255/consoleFull)**
for PR 12875 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13281
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12875#issuecomment-221473671
**[Test build #59255 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59255/consoleFull)**
for PR 12875 at commit
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/13281#issuecomment-221473561
Thanks for reviewing. Merging to master / 2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13272#issuecomment-221473050
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13272#issuecomment-221473047
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13272#issuecomment-221472935
**[Test build #59252 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59252/consoleFull)**
for PR 13272 at commit
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/12772#issuecomment-221470057
Sorry, I am unable to reproduce it. Without the fix, the following test
case works well.
```scala
val data = Seq(("A\tB\tC\tD\t\t"),
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/13284#discussion_r64513464
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1445,7 +1445,11 @@ setMethod("[", signature(x = "SparkDataFrame"),
#' }
setMethod("subset", signature(x =
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13273
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/13284#discussion_r64513468
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1445,7 +1445,11 @@ setMethod("[", signature(x = "SparkDataFrame"),
#' }
setMethod("subset", signature(x =
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/13284#discussion_r64513429
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1445,7 +1445,11 @@ setMethod("[", signature(x = "SparkDataFrame"),
#' }
setMethod("subset", signature(x =
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13273#issuecomment-221469762
Merging to master and branch-2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/13284#issuecomment-221469622
I'm seeing the error with `subset` as well.
As for "endsWith", "startsWith" - could you check what you have in your
environment - you could run
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/13267#issuecomment-221469255
Yea I agree with escapeQuotes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/13267#issuecomment-221469276
@jurriaan want to do the change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user falaki commented on the pull request:
https://github.com/apache/spark/pull/13267#issuecomment-221468338
@rxin and @jurriaan I agree to keep it set by default. However, I think it
is better to leave it configurable. In two cases before, I assumed a reasonable
default value
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13150
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/13150#issuecomment-221467220
Merging in master/2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/13150#issuecomment-221467315
@Parth-Brahmbhatt you should add the email address you used in your commit
to your github profile, so the commit is associated with your account. Thanks.
---
If your
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13288
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/13288#issuecomment-221466892
Thanks - merging in master/2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-221466855
Thanks - look forward to it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13283#issuecomment-221466629
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13283#issuecomment-221466626
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13283#issuecomment-221466522
**[Test build #59249 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59249/consoleFull)**
for PR 13283 at commit
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/9192#issuecomment-221466080
@rxin
- [ ] fix failed tests (hiveContext related)
- [ ] check on roxygen2 generated doc
- [ ] update code examples in doc to remove sqlContext (I'd like
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13283#issuecomment-221466099
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13283#issuecomment-221466102
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13283#issuecomment-221466000
**[Test build #59254 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59254/consoleFull)**
for PR 13283 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13271#issuecomment-221465283
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13271#issuecomment-221465280
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13271#issuecomment-221465200
**[Test build #59250 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59250/consoleFull)**
for PR 13271 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13286#issuecomment-221464878
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13286#issuecomment-221464882
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13286#issuecomment-221464810
**[Test build #59253 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59253/consoleFull)**
for PR 13286 at commit
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/12943#discussion_r64510350
--- Diff: python/pyspark/ml/classification.py ---
@@ -1063,6 +1064,13 @@ class MultilayerPerceptronClassifier(JavaEstimator,
HasFeaturesCol, HasLabelCol,
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/13288#issuecomment-221463656
nit: [SQL] -> [Core]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13150#issuecomment-221463522
**[Test build #3017 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3017/consoleFull)**
for PR 13150 at commit
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/13284#issuecomment-221462859
@wangmiao1981 Thanks for investigating this. Do you know why these are not
failing in Jenkins though ? (the subset test and the pipedRDD one)
---
If your project is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13160#issuecomment-221462569
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13160#issuecomment-221462571
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13160#issuecomment-221462448
**[Test build #59243 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59243/consoleFull)**
for PR 13160 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13288#issuecomment-221462328
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13288#issuecomment-221462330
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13288#issuecomment-221462207
**[Test build #59245 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59245/consoleFull)**
for PR 13288 at commit
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/13282#issuecomment-221462008
Thank you, @rxin !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13271#issuecomment-221460289
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13271#issuecomment-221460288
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13271#issuecomment-221460191
**[Test build #59244 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59244/consoleFull)**
for PR 13271 at commit
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/11371#discussion_r64507505
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1443,6 +1445,32 @@ class Analyzer(
}
Github user wangyang1992 commented on the pull request:
https://github.com/apache/spark/pull/13177#issuecomment-221457800
Thanks @rxin . Added it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13280#issuecomment-221457588
I had once tried to upgrade Parquet to 1.8.1, and one more change needs to
be done for the upgrade:
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/13283#issuecomment-221457452
Just realized this PR is related to
https://github.com/apache/spark/pull/13201. Also tried to improve the exception
reporting in Python through hiding the long java
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13271#issuecomment-221457242
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13283#issuecomment-221457208
**[Test build #59254 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59254/consoleFull)**
for PR 13283 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13271#issuecomment-221457243
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13286#issuecomment-221457219
**[Test build #59253 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59253/consoleFull)**
for PR 13286 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13271#issuecomment-221457151
**[Test build #59241 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59241/consoleFull)**
for PR 13271 at commit
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/11371#discussion_r64506496
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1443,6 +1445,32 @@ class Analyzer(
}
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221456715
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221456714
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user Hydrotoast commented on a diff in the pull request:
https://github.com/apache/spark/pull/13265#discussion_r64506341
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/optimization/GradientDescent.scala
---
@@ -197,6 +197,11 @@ object GradientDescent extends Logging
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221456607
**[Test build #59246 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59246/consoleFull)**
for PR 13270 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13283#issuecomment-221456373
**[Test build #59251 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59251/consoleFull)**
for PR 13283 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13283#issuecomment-221456376
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13283#issuecomment-221456377
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13283#issuecomment-221455992
**[Test build #59251 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59251/consoleFull)**
for PR 13283 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13272#issuecomment-221455988
**[Test build #59252 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59252/consoleFull)**
for PR 13272 at commit
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/13257#issuecomment-221455213
@sbcd90 I currently can't think of other alternatives and it seems that's
why it has not been enabled again.
---
If your project is set up for it, you can reply
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13289#issuecomment-221454949
**[Test build #59248 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59248/consoleFull)**
for PR 13289 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13289#issuecomment-221455015
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
1 - 100 of 664 matches
Mail list logo