[GitHub] spark pull request: [SPARK-14343][SQL] Proper column pruning for text data s...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13431 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-15686][SQL] Move user-facing streaming classes in...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13429 **[Test build #3034 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3034/consoleFull)** for PR 13429 at commit

[GitHub] spark pull request: [SPARK-14343][SQL] Proper column pruning for text data s...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13431 **[Test build #59719 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59719/consoleFull)** for PR 13431 at commit

[GitHub] spark pull request: [SPARK-14343][SQL] Proper column pruning for text data s...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13431 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59719/ Test

[GitHub] spark pull request: [SPARK-15646] [SQL] When spark.sql.hive.convertCTAS is t...

2016-05-31 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/13386#discussion_r65306005 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -936,7 +936,39 @@ class SparkSqlAstBuilder(conf: SQLConf) extends

[GitHub] spark pull request: [SPARK-14343][SQL] Proper column pruning for text data s...

2016-05-31 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/13431 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark pull request: [SPARK-14343][SQL] Proper column pruning for text data s...

2016-05-31 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13431#discussion_r65305854 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/text/TextFileFormat.scala --- @@ -96,16 +96,23 @@ class TextFileFormat

[GitHub] spark pull request: [SPARK-14343][SQL] Proper column pruning for text data s...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13431 **[Test build #59719 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59719/consoleFull)** for PR 13431 at commit

[GitHub] spark pull request: [SPARK-14343][SQL] Proper column pruning for text data s...

2016-05-31 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/13431#discussion_r65305773 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/text/TextFileFormat.scala --- @@ -96,16 +96,23 @@ class TextFileFormat

[GitHub] spark pull request: [SPARK-15646] [SQL] When spark.sql.hive.convertCTAS is t...

2016-05-31 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/13386#discussion_r65305666 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -936,7 +936,39 @@ class SparkSqlAstBuilder(conf: SQLConf) extends

[GitHub] spark pull request: [SPARK-14343][SQL] Proper column pruning for text data s...

2016-05-31 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13431#discussion_r65305575 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/text/TextFileFormat.scala --- @@ -96,16 +96,23 @@ class TextFileFormat

[GitHub] spark pull request: [SPARK-14343][SQL] Proper column pruning for text data s...

2016-05-31 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13431#discussion_r65305387 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/text/TextFileFormat.scala --- @@ -96,16 +96,23 @@ class TextFileFormat

[GitHub] spark pull request: [SPARK-15646] [SQL] When spark.sql.hive.convertCTAS is t...

2016-05-31 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/13386#discussion_r65305383 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionState.scala --- @@ -139,22 +139,6 @@ private[hive] class HiveSessionState(sparkSession:

[GitHub] spark pull request: [SPARK-15646] [SQL] When spark.sql.hive.convertCTAS is t...

2016-05-31 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/13386#discussion_r65305344 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -447,52 +447,20 @@ private[hive] class

[GitHub] spark pull request: [SPARK-14343][SQL] Proper column pruning for text data s...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13431 **[Test build #59718 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59718/consoleFull)** for PR 13431 at commit

[GitHub] spark pull request: [SPARK-14343][SQL] Proper column pruning for text data s...

2016-05-31 Thread liancheng
GitHub user liancheng opened a pull request: https://github.com/apache/spark/pull/13431 [SPARK-14343][SQL] Proper column pruning for text data source ## What changes were proposed in this pull request? Text data source ignores requested schema, and may give wrong result

[GitHub] spark pull request: [SPARK-14949][SQL] Remove HiveConf dependency from Inser...

2016-05-31 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12728#discussion_r65304924 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala --- @@ -114,13 +110,15 @@ case class InsertIntoHiveTable(

[GitHub] spark pull request: [SPARK-14949][SQL] Remove HiveConf dependency from Inser...

2016-05-31 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/12728#discussion_r65304476 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala --- @@ -114,13 +110,15 @@ case class

[GitHub] spark pull request: [SPARK-13484] [SQL] Prevent illegal NULL propagation whe...

2016-05-31 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/13290 LGTM except for a few minor comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-15495][SQL]Improve the explain output for Aggrega...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13363 **[Test build #59716 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59716/consoleFull)** for PR 13363 at commit

[GitHub] spark pull request: [SPARK-12922][SparkR][WIP] Implement gapply() on DataFra...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12836 **[Test build #59717 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59717/consoleFull)** for PR 12836 at commit

[GitHub] spark pull request: [SPARK-15495][SQL]Improve the explain output for Aggrega...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13363 **[Test build #3035 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3035/consoleFull)** for PR 13363 at commit

[GitHub] spark pull request: [SPARK-15681][core] allow lowercase or mixed case log le...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13422 **[Test build #59714 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59714/consoleFull)** for PR 13422 at commit

[GitHub] spark pull request: [SPARK-15495][SQL]Improve the explain output for Aggrega...

2016-05-31 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13363 LGTM pending Jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request: [SPARK-15495][SQL]Improve the explain output for Aggrega...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13363 **[Test build #59715 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59715/consoleFull)** for PR 13363 at commit

[GitHub] spark pull request: [SPARK-15639][SQL] Try to push down filter at RowGroups ...

2016-05-31 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13371#discussion_r65303008 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala --- @@ -578,62 +583,6 @@ private[sql]

[GitHub] spark pull request: [SPARK-15639][SQL] Try to push down filter at RowGroups ...

2016-05-31 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/13371 It is a good idea to add it if parquet supports it (I have an impression that parquet does not support it. But maybe I am wrong). I think having benchmark results is a good practice, so we can

[GitHub] spark pull request: [SPARK-15639][SQL] Try to push down filter at RowGroups ...

2016-05-31 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/13371#discussion_r65302925 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala --- @@ -344,6 +344,11 @@ private[sql] class

[GitHub] spark pull request: [SPARK-15639][SQL] Try to push down filter at RowGroups ...

2016-05-31 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/13371#discussion_r65302899 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala --- @@ -344,6 +344,11 @@ private[sql] class

[GitHub] spark pull request: [SPARK-15495][SQL]Improve the explain output for Aggrega...

2016-05-31 Thread clockfly
Github user clockfly commented on the pull request: https://github.com/apache/spark/pull/13363 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request: [SPARK-14949][SQL] Remove HiveConf dependency from Inser...

2016-05-31 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12728#discussion_r65302512 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala --- @@ -114,13 +110,15 @@ case class InsertIntoHiveTable(

[GitHub] spark pull request: [SPARK-15593][SQL]Add DataFrameWriter.foreach to allow t...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13342 **[Test build #59713 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59713/consoleFull)** for PR 13342 at commit

[GitHub] spark pull request: [SPARK-15676] [SQL] Disallow Column Names as Partition C...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13415 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-15676] [SQL] Disallow Column Names as Partition C...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13415 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59712/ Test

[GitHub] spark pull request: [Minor] Slightly better error message when attempting to...

2016-05-31 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13427 @andrewor14 when you merge pull requests in the future, please have an explicit message that the pr's merged and include the branches. --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-15676] [SQL] Disallow Column Names as Partition C...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13415 **[Test build #59712 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59712/consoleFull)** for PR 13415 at commit

[GitHub] spark pull request: [SPARK-15677][SQL] Query with scalar sub-query in the SE...

2016-05-31 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13418#discussion_r65302021 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala --- @@ -84,6 +84,13 @@ object ScalarSubquery { case

[GitHub] spark pull request: [SPARK-15639][SQL] Try to push down filter at RowGroups ...

2016-05-31 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/13371 BTW, I can't see any reason not to add a row-group level filter for parquet. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-15639][SQL] Try to push down filter at RowGroups ...

2016-05-31 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/13371 @yhuai As you can see, this is not to fix a bug/problem. So I think it might be hard to provide a test case for it. I will try to do the benchmark. --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-15639][SQL] Try to push down filter at RowGroups ...

2016-05-31 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/13371#discussion_r65301812 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala --- @@ -578,62 +583,6 @@ private[sql] object

[GitHub] spark pull request: [SPARK-15639][SQL] Try to push down filter at RowGroups ...

2016-05-31 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/13371 Can you provide a test case that shows the problem? Also, can you provide benchmark results of the performance benefit? --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-15639][SQL] Try to push down filter at RowGroups ...

2016-05-31 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/13371#discussion_r65301654 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala --- @@ -344,6 +344,11 @@ private[sql] class

[GitHub] spark pull request: [SPARK-15639][SQL] Try to push down filter at RowGroups ...

2016-05-31 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/13371#discussion_r65301661 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala --- @@ -578,62 +583,6 @@ private[sql] object

[GitHub] spark pull request: [HOT-FIX] Fix the test case failures in DDLSuite

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13430 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [HOT-FIX] Fix the test case failures in DDLSuite

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13430 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59710/ Test

[GitHub] spark pull request: [HOT-FIX] Fix the test case failures in DDLSuite

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13430 **[Test build #59710 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59710/consoleFull)** for PR 13430 at commit

[GitHub] spark pull request: [SPARK-15686][SQL] Move user-facing streaming classes in...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13429 **[Test build #3034 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3034/consoleFull)** for PR 13429 at commit

[GitHub] spark pull request: [SPARK-15605] [ML] [Examples] Remove JavaDeveloperApiExa...

2016-05-31 Thread yanboliang
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/13353 I checked and found that this example is broken since Spark 1.4.0. Because before Spark 1.4.0, we don't use ```Params.shouldOwn``` method to validate that the input param belongs to the

[GitHub] spark pull request: [SPARK-15668] [ML] ml.feature: update check schema to av...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13411 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59711/ Test

[GitHub] spark pull request: [SPARK-15668] [ML] ml.feature: update check schema to av...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13411 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-15668] [ML] ml.feature: update check schema to av...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13411 **[Test build #59711 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59711/consoleFull)** for PR 13411 at commit

[GitHub] spark pull request: [SPARK-15686][SQL] Move user-facing streaming classes in...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13429 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59709/ Test

[GitHub] spark pull request: [SPARK-15686][SQL] Move user-facing streaming classes in...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13429 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-15686][SQL] Move user-facing streaming classes in...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13429 **[Test build #59709 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59709/consoleFull)** for PR 13429 at commit

[GitHub] spark pull request: [SPARK-15681][core] allow lowercase or mixed case log le...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13422 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-15681][core] allow lowercase or mixed case log le...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13422 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59707/ Test

[GitHub] spark pull request: [SPARK-15681][core] allow lowercase or mixed case log le...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13422 **[Test build #59707 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59707/consoleFull)** for PR 13422 at commit

[GitHub] spark pull request: [SPARK-15605] [ML] [Examples] Remove JavaDeveloperApiExa...

2016-05-31 Thread yanboliang
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/13353 @jkbradley Yes, we can fix it, but it may involves lots of changes which is not reasonable to be get in during QA. The main cause of this bug is that we only implement abstract class

[GitHub] spark pull request: [SPARK-15667][SQL]Throw exception if columns number of o...

2016-05-31 Thread WangTaoTheTonic
Github user WangTaoTheTonic commented on the pull request: https://github.com/apache/spark/pull/13409 cc @liancheng @andrewor14 Could you please review this? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-15676] [SQL] Disallow Column Names as Partition C...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13415 **[Test build #59712 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59712/consoleFull)** for PR 13415 at commit

[GitHub] spark pull request: [SPARK-15676] [SQL] Disallow Column Names as Partition C...

2016-05-31 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/13415 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request: [HOT-FIX] Fix the test case failures in DDLSuite

2016-05-31 Thread gatorsmile
Github user gatorsmile closed the pull request at: https://github.com/apache/spark/pull/13430 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [HOT-FIX] Fix the test case failures in DDLSuite

2016-05-31 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/13430 Since this has been resolved by @andrewor14 , let me close it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [HOT-FIX] Fix the test case failures in DDLSuite

2016-05-31 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/13430#discussion_r65296397 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -310,15 +310,13 @@ trait CheckAnalysis extends

[GitHub] spark pull request: [HOT-FIX] Fix the test case failures in DDLSuite

2016-05-31 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/13430#discussion_r65296315 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -310,15 +310,13 @@ trait CheckAnalysis extends

[GitHub] spark pull request: [SPARK-12988][SQL]Can't drop top level columns that cont...

2016-05-31 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/13306 This PR makes the behavior of drop and withColumn consistent. Let's decide what we do for backticks in a separate JIRA. --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-15668] [ML] ml.feature: update check schema to av...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13411 **[Test build #59711 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59711/consoleFull)** for PR 13411 at commit

[GitHub] spark pull request: [SPARK-15668] [ML] ml.feature: update check schema to av...

2016-05-31 Thread hhbyyh
Github user hhbyyh commented on the pull request: https://github.com/apache/spark/pull/13411 Thanks for helping review. @MLnick --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-15667][SQL]Throw exception if columns number of o...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13409 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59708/ Test

[GitHub] spark pull request: [SPARK-15667][SQL]Throw exception if columns number of o...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13409 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-15667][SQL]Throw exception if columns number of o...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13409 **[Test build #59708 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59708/consoleFull)** for PR 13409 at commit

[GitHub] spark pull request: [SPARK-15676] [SQL] Disallow Column Names as Partition C...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13415 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59705/ Test

[GitHub] spark pull request: [SPARK-15676] [SQL] Disallow Column Names as Partition C...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13415 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-15676] [SQL] Disallow Column Names as Partition C...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13415 **[Test build #59705 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59705/consoleFull)** for PR 13415 at commit

[GitHub] spark pull request: [SPARK-5581][Core] When writing sorted map output file, ...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13382 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12666][CORE] SparkSubmit packages fix for when 'd...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13428 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59701/ Test

[GitHub] spark pull request: [SPARK-5581][Core] When writing sorted map output file, ...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13382 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59704/ Test

[GitHub] spark pull request: [SPARK-12666][CORE] SparkSubmit packages fix for when 'd...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13428 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-5581][Core] When writing sorted map output file, ...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13382 **[Test build #59704 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59704/consoleFull)** for PR 13382 at commit

[GitHub] spark pull request: [SPARK-12666][CORE] SparkSubmit packages fix for when 'd...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13428 **[Test build #59701 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59701/consoleFull)** for PR 13428 at commit

[GitHub] spark pull request: [SPARK-15678][SQL] Not use cache on appends and overwrit...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13419 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-15678][SQL] Not use cache on appends and overwrit...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13419 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59706/ Test

[GitHub] spark pull request: [SPARK-15678][SQL] Not use cache on appends and overwrit...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13419 **[Test build #59706 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59706/consoleFull)** for PR 13419 at commit

[GitHub] spark pull request: [SPARK-15677][SQL] Query with scalar sub-query in the SE...

2016-05-31 Thread ioana-delaney
Github user ioana-delaney commented on a diff in the pull request: https://github.com/apache/spark/pull/13418#discussion_r65294821 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -1468,7 +1468,8 @@ object DecimalAggregates

[GitHub] spark pull request: [SPARK-15576] Add back hive tests blacklisted by SPARK-1...

2016-05-31 Thread techaddict
Github user techaddict closed the pull request at: https://github.com/apache/spark/pull/13334 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-15495][SQL]Improve the explain output for Aggrega...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13363 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59702/ Test

[GitHub] spark pull request: [SPARK-15495][SQL]Improve the explain output for Aggrega...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13363 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-15495][SQL]Improve the explain output for Aggrega...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13363 **[Test build #59702 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59702/consoleFull)** for PR 13363 at commit

[GitHub] spark pull request: [HOT-FIX] Fix the test case failures in DDLSuite

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13430 **[Test build #59710 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59710/consoleFull)** for PR 13430 at commit

[GitHub] spark pull request: [SPARK-15657][SQL] RowEncoder should validate the data t...

2016-05-31 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/13401#discussion_r65294127 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -721,8 +716,55 @@ case class

[GitHub] spark pull request: [HOT-FIX] Fix the test case failures in DDLSuite

2016-05-31 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/13430 @rxin @andrewor14 @srowen It causes a build break: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59698/consoleFull Please merge it ASAP. Thanks! --- If your

[GitHub] spark pull request: [HOT-FIX] Fix the test case failures in DDLSuite

2016-05-31 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/13430 [HOT-FIX] Fix the test case failures in DDLSuite What changes were proposed in this pull request? Test cases failure in `DDLSuite ` introduced in

[GitHub] spark pull request: [SPARK-15620][SQL] Fix transformed dataset attributes re...

2016-05-31 Thread jerryshao
Github user jerryshao commented on the pull request: https://github.com/apache/spark/pull/13399 @cloud-fan , would you please help to review this patch, not sure it is the right fix. Thanks a lot. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-15686][SQL] Move user-facing streaming classes in...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13429 **[Test build #59709 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59709/consoleFull)** for PR 13429 at commit

[GitHub] spark pull request: [SPARK-15686][SQL] Move user-facing streaming classes in...

2016-05-31 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13429 cc @marmbrus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark pull request: [SPARK-15686][SQL] Move user-facing streaming classes in...

2016-05-31 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13429#discussion_r65292690 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamTest.scala --- @@ -63,7 +65,7 @@ import org.apache.spark.util.{Clock, ManualClock,

[GitHub] spark pull request: [SPARK-15515] [SQL] Error Handling in Running SQL Direct...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13283 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-15515] [SQL] Error Handling in Running SQL Direct...

2016-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13283 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59699/ Test

[GitHub] spark pull request: [SPARK-15686][SQL] Move user-facing streaming classes in...

2016-05-31 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/13429 [SPARK-15686][SQL] Move user-facing streaming classes into sql.streaming ## What changes were proposed in this pull request? This patch moves all user-facing structured streaming classes into

[GitHub] spark pull request: [SPARK-15515] [SQL] Error Handling in Running SQL Direct...

2016-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13283 **[Test build #59699 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59699/consoleFull)** for PR 13283 at commit

  1   2   3   4   5   6   7   8   >