[GitHub] spark issue #13634: [SPARK-15913][CORE] Dispatcher.stopped should be enclose...

2016-06-12 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/13634 Hi, @vanzin . Could you review this when you have some time? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request #13634: [SPARK-15913][CORE] Dispatcher.stopped should be ...

2016-06-12 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/13634 [SPARK-15913][CORE] Dispatcher.stopped should be enclosed by synchronized block. ## What changes were proposed in this pull request? `Dispatcher.stopped` is guarded by `this`, but

[GitHub] spark issue #13623: [SPARK-15895][SQL] Filters out metadata files while doin...

2016-06-12 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/13623 In this file PartitioningAwareFileCatalog.scala, we have multiple places that we filter out files that start with underscore. Should we also filter dot in those places? --- If your project is set

[GitHub] spark pull request #13585: [SPARK-15859][SQL] Optimize the partition pruning...

2016-06-12 Thread yangw1234
Github user yangw1234 commented on a diff in the pull request: https://github.com/apache/spark/pull/13585#discussion_r66742485 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala --- @@ -92,6 +92,36 @@ object PhysicalOperation extends

[GitHub] spark issue #13633: [SPARK-15912] [SQL] Replace getPartitionsByFilter by get...

2016-06-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13633 **[Test build #60382 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60382/consoleFull)** for PR 13633 at commit

[GitHub] spark pull request #13633: [SPARK-15912] [SQL] Replace getPartitionsByFilter...

2016-06-12 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/13633 [SPARK-15912] [SQL] Replace getPartitionsByFilter by getPartitions in inputFiles of MetastoreRelation What changes were proposed in this pull request? Always returns the files of all

[GitHub] spark issue #13631: [SPARK-15911][SQL] Remove the additional Project to be c...

2016-06-12 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/13631 @cloud-fan There is a test ("Detect table partitioning with correct partition order") in `InsertIntoHiveTableSuite` which is dedicated to test `insertInto` with this column re-ordering. What you

[GitHub] spark pull request #13585: [SPARK-15859][SQL] Optimize the partition pruning...

2016-06-12 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/13585#discussion_r66741771 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala --- @@ -65,15 +65,20 @@ private[hive] trait HiveStrategies {

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-12 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r66741569 --- Diff: R/pkg/R/mllib.R --- @@ -218,9 +222,9 @@ setMethod("predict", signature(object = "GeneralizedLinearRegressionModel"),

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-12 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r66741577 --- Diff: R/pkg/R/mllib.R --- @@ -582,9 +586,9 @@ setMethod("summary", signature(object = "AFTSurvivalRegressionModel"),

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-12 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r66741575 --- Diff: R/pkg/R/mllib.R --- @@ -357,9 +361,9 @@ setMethod("summary", signature(object = "KMeansModel"), cluster = cluster,

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-12 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r66741568 --- Diff: R/pkg/R/mllib.R --- @@ -197,7 +201,7 @@ print.summary.GeneralizedLinearRegressionModel <- function(x, ...) { invisible(x) }

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-12 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r66741560 --- Diff: R/pkg/R/column.R --- @@ -170,6 +172,8 @@ setMethod("between", signature(x = "Column"), } }) +#' cast

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-12 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r66741566 --- Diff: R/pkg/R/functions.R --- @@ -249,10 +249,7 @@ col <- function(x) { #' #' Returns a Column based on the given column name. #'

[GitHub] spark issue #13413: [SPARK-15663][SQL] SparkSession.catalog.listFunctions sh...

2016-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13413 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13413: [SPARK-15663][SQL] SparkSession.catalog.listFunctions sh...

2016-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13413 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60379/ Test PASSed. ---

[GitHub] spark issue #13413: [SPARK-15663][SQL] SparkSession.catalog.listFunctions sh...

2016-06-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13413 **[Test build #60379 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60379/consoleFull)** for PR 13413 at commit

[GitHub] spark pull request #13585: [SPARK-15859][SQL] Optimize the partition pruning...

2016-06-12 Thread clockfly
Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/13585#discussion_r66741254 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala --- @@ -65,15 +65,20 @@ private[hive] trait HiveStrategies {

[GitHub] spark issue #13631: [SPARK-15911][SQL] Remove the additional Project to be c...

2016-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13631 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13631: [SPARK-15911][SQL] Remove the additional Project to be c...

2016-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13631 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60380/ Test FAILed. ---

[GitHub] spark issue #13631: [SPARK-15911][SQL] Remove the additional Project to be c...

2016-06-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13631 **[Test build #60380 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60380/consoleFull)** for PR 13631 at commit

[GitHub] spark issue #13623: [SPARK-15895][SQL] Filters out metadata files while doin...

2016-06-12 Thread clockfly
Github user clockfly commented on the issue: https://github.com/apache/spark/pull/13623 Looks good! +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark pull request #13604: [SPARK-15898][SQL] DataFrameReader.text should re...

2016-06-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13604 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #13604: [SPARK-15898][SQL] DataFrameReader.text should return Da...

2016-06-12 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/13604 Merging in master/2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #13629: [SPARK-15370][SQL] Fix count bug

2016-06-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13629 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #13629: [SPARK-15370][SQL] Fix count bug

2016-06-12 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/13629 Thanks - merging in master/2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #13632: [SPARK-15910][SQL] Check schema consistency when using K...

2016-06-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13632 **[Test build #60381 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60381/consoleFull)** for PR 13632 at commit

[GitHub] spark pull request #13632: [SPARK-15910][SQL] Check schema consistency when ...

2016-06-12 Thread clockfly
GitHub user clockfly opened a pull request: https://github.com/apache/spark/pull/13632 [SPARK-15910][SQL] Check schema consistency when using Kryo encoder to convert DataFrame to Dataset ## What changes were proposed in this pull request? This PR enforces schema check when

[GitHub] spark issue #13631: [SPARK-15911][SQL] Remove the additional Project to be c...

2016-06-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13631 **[Test build #60380 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60380/consoleFull)** for PR 13631 at commit

[GitHub] spark pull request #13631: [SPARK-15911][SQL] Remove the additional Project ...

2016-06-12 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/13631 [SPARK-15911][SQL] Remove the additional Project to be consistent with SQL ## What changes were proposed in this pull request? Currently In `DataFrameWriter`'s `insertInto` and

[GitHub] spark issue #13585: [SPARK-15859][SQL] Optimize the partition pruning within...

2016-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13585 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13585: [SPARK-15859][SQL] Optimize the partition pruning within...

2016-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13585 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60376/ Test PASSed. ---

[GitHub] spark issue #13585: [SPARK-15859][SQL] Optimize the partition pruning within...

2016-06-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13585 **[Test build #60376 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60376/consoleFull)** for PR 13585 at commit

[GitHub] spark issue #13413: [SPARK-15663][SQL] SparkSession.catalog.listFunctions sh...

2016-06-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13413 **[Test build #60379 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60379/consoleFull)** for PR 13413 at commit

[GitHub] spark issue #10706: [SPARK-12543] [SPARK-4226] [SQL] Subquery in expression

2016-06-12 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/10706 @kamalcoursera you could use a predicate scalar subquery here, i.e.: ```sql select runon as runon case when (select max(true) from sqltesttable b where b.key =

[GitHub] spark pull request #13630: [SPARK-15892][ML] Change spark to sqlContext in t...

2016-06-12 Thread HyukjinKwon
Github user HyukjinKwon closed the pull request at: https://github.com/apache/spark/pull/13630 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark issue #13630: [SPARK-15892][ML] Change spark to sqlContext in the test...

2016-06-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/13630 It seems this should be reverted first. Closing this (see https://github.com/apache/spark/pull/13619). --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #13619: [SPARK-15892][ML] Incorrectly merged AFTAggregator with ...

2016-06-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/13619 Yes, it seems it is still failing. I can change the PR to revert this if he is busy for now. Otherwise, I will close mine. --- If your project is set up for it, you can reply to this email and

[GitHub] spark issue #13619: [SPARK-15892][ML] Incorrectly merged AFTAggregator with ...

2016-06-12 Thread zzcclp
Github user zzcclp commented on the issue: https://github.com/apache/spark/pull/13619 @HyukjinKwon OK, but this pr should be reverted first. @jkbradley could you revert this pr for branch-1.6 ? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #13558: [SPARK-15820][PySpark][SQL]Add Catalog.refreshTable into...

2016-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13558 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60378/ Test FAILed. ---

[GitHub] spark issue #13558: [SPARK-15820][PySpark][SQL]Add Catalog.refreshTable into...

2016-06-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13558 **[Test build #60378 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60378/consoleFull)** for PR 13558 at commit

[GitHub] spark issue #13558: [SPARK-15820][PySpark][SQL]Add Catalog.refreshTable into...

2016-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13558 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13630: [SPARK-15892][ML] Change spark to sqlContext in the test...

2016-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13630 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13630: [SPARK-15892][ML] Change spark to sqlContext in the test...

2016-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13630 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60377/ Test FAILed. ---

[GitHub] spark issue #13630: [SPARK-15892][ML] Change spark to sqlContext in the test...

2016-06-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13630 **[Test build #60377 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60377/consoleFull)** for PR 13630 at commit

[GitHub] spark issue #13558: [SPARK-15820][PySpark][SQL]Add Catalog.refreshTable into...

2016-06-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13558 **[Test build #60378 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60378/consoleFull)** for PR 13558 at commit

[GitHub] spark issue #13558: [SPARK-15820][PySpark][SQL]Add Catalog.refreshTable into...

2016-06-12 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/13558 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #13619: [SPARK-15892][ML] Incorrectly merged AFTAggregator with ...

2016-06-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/13619 @zzcclp I made a PR against branch-1.6 here, https://github.com/apache/spark/pull/13630. Thank you for pointing this out quickly. --- If your project is set up for it, you can reply to this

[GitHub] spark issue #13630: [SPARK-15892][ML] Change spark to sqlContext in the test...

2016-06-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13630 **[Test build #60377 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60377/consoleFull)** for PR 13630 at commit

[GitHub] spark issue #13630: [SPARK-15892][ML] Change spark to sqlContext in the test...

2016-06-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/13630 cc @jkbradley and @zzcclp --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #13630: [SPARK-15892][ML] Change spark to sqlContext in t...

2016-06-12 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/13630 [SPARK-15892][ML] Change spark to sqlContext in the test in AFTSurvivalRegressionSuite for 1.6 ## What changes were proposed in this pull request?

[GitHub] spark issue #10706: [SPARK-12543] [SPARK-4226] [SQL] Subquery in expression

2016-06-12 Thread kamalcoursera
Github user kamalcoursera commented on the issue: https://github.com/apache/spark/pull/10706 Thank you ! Any alternative options to use instead of predicate subquery ? Is it in plan for amendment in 2.0? Select runon as runon, case when key in (Select key

[GitHub] spark pull request #13585: [SPARK-15859][SQL] Optimize the partition pruning...

2016-06-12 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/13585#discussion_r66733226 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala --- @@ -65,15 +65,20 @@ private[hive] trait HiveStrategies {

[GitHub] spark issue #13585: [SPARK-15859][SQL] Optimize the partition pruning within...

2016-06-12 Thread chenghao-intel
Github user chenghao-intel commented on the issue: https://github.com/apache/spark/pull/13585 Updated with more meaningful function name and add more unit test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #13585: [SPARK-15859][SQL] Optimize the partition pruning within...

2016-06-12 Thread chenghao-intel
Github user chenghao-intel commented on the issue: https://github.com/apache/spark/pull/13585 cc @liancheng --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #12836: [SPARK-12922][SparkR][WIP] Implement gapply() on ...

2016-06-12 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/12836#discussion_r66733080 --- Diff: core/src/main/scala/org/apache/spark/api/r/RRunner.scala --- @@ -40,7 +40,8 @@ private[spark] class RRunner[U]( broadcastVars:

[GitHub] spark pull request #13619: [SPARK-15892][ML] Incorrectly merged AFTAggregato...

2016-06-12 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13619#discussion_r66732958 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/AFTSurvivalRegressionSuite.scala --- @@ -390,6 +390,18 @@ class

[GitHub] spark issue #13585: [SPARK-15859][SQL] Optimize the partition pruning within...

2016-06-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13585 **[Test build #60376 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60376/consoleFull)** for PR 13585 at commit

[GitHub] spark pull request #13619: [SPARK-15892][ML] Incorrectly merged AFTAggregato...

2016-06-12 Thread zzcclp
Github user zzcclp commented on a diff in the pull request: https://github.com/apache/spark/pull/13619#discussion_r66732911 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/AFTSurvivalRegressionSuite.scala --- @@ -390,6 +390,18 @@ class AFTSurvivalRegressionSuite

[GitHub] spark pull request #13619: [SPARK-15892][ML] Incorrectly merged AFTAggregato...

2016-06-12 Thread zzcclp
Github user zzcclp commented on a diff in the pull request: https://github.com/apache/spark/pull/13619#discussion_r66732825 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/AFTSurvivalRegressionSuite.scala --- @@ -390,6 +390,18 @@ class AFTSurvivalRegressionSuite

[GitHub] spark issue #13629: [SPARK-15370][SQL] Fix count bug

2016-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13629 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13629: [SPARK-15370][SQL] Fix count bug

2016-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13629 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60375/ Test PASSed. ---

[GitHub] spark pull request #6983: [SPARK-6785][SQL] fix DateTimeUtils for dates befo...

2016-06-12 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/6983#discussion_r66732804 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala --- @@ -48,4 +49,41 @@ class DateTimeUtilsSuite extends

[GitHub] spark pull request #13619: [SPARK-15892][ML] Incorrectly merged AFTAggregato...

2016-06-12 Thread zzcclp
Github user zzcclp commented on a diff in the pull request: https://github.com/apache/spark/pull/13619#discussion_r66732808 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/AFTSurvivalRegressionSuite.scala --- @@ -390,6 +390,18 @@ class AFTSurvivalRegressionSuite

[GitHub] spark issue #13629: [SPARK-15370][SQL] Fix count bug

2016-06-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13629 **[Test build #60375 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60375/consoleFull)** for PR 13629 at commit

[GitHub] spark issue #13571: [SPARK-15369][WIP][RFC][PySpark][SQL] Expose potential t...

2016-06-12 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/13571 So this is a WIP of what this could look like, but I'd really like your thoughts on the draft @davies - do you think this is heading in the right direction given the performance #s from the

[GitHub] spark pull request #12836: [SPARK-12922][SparkR][WIP] Implement gapply() on ...

2016-06-12 Thread NarineK
Github user NarineK commented on a diff in the pull request: https://github.com/apache/spark/pull/12836#discussion_r66732763 --- Diff: R/pkg/R/group.R --- @@ -142,3 +142,58 @@ createMethods <- function() { } createMethods() + +#' gapply +#' +#'

[GitHub] spark issue #13604: [SPARK-15898][SQL] DataFrameReader.text should return Da...

2016-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13604 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60374/ Test PASSed. ---

[GitHub] spark issue #13604: [SPARK-15898][SQL] DataFrameReader.text should return Da...

2016-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13604 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13604: [SPARK-15898][SQL] DataFrameReader.text should return Da...

2016-06-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13604 **[Test build #60374 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60374/consoleFull)** for PR 13604 at commit

[GitHub] spark issue #13623: [SPARK-15895][SQL] Filters out metadata files while doin...

2016-06-12 Thread ssimeonov
Github user ssimeonov commented on the issue: https://github.com/apache/spark/pull/13623 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #13628: [SPARK-15907] [SQL] Issue Exceptions when Not Enough Inp...

2016-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13628 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60373/ Test PASSed. ---

[GitHub] spark issue #13628: [SPARK-15907] [SQL] Issue Exceptions when Not Enough Inp...

2016-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13628 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13628: [SPARK-15907] [SQL] Issue Exceptions when Not Enough Inp...

2016-06-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13628 **[Test build #60373 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60373/consoleFull)** for PR 13628 at commit

[GitHub] spark pull request #13496: [SPARK-15753][SQL] Move Analyzer stuff to Analyze...

2016-06-12 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/13496#discussion_r66731642 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -452,6 +452,17 @@ class Analyzer( def

[GitHub] spark pull request #13542: [SPARK-15730][SQL][WIP] Respect the --hiveconf in...

2016-06-12 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/13542#discussion_r66731077 --- Diff: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/CliSuite.scala --- @@ -91,6 +91,8 @@ class CliSuite extends

[GitHub] spark issue #13629: [SPARK-15370][SQL] Fix count bug

2016-06-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13629 **[Test build #60375 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60375/consoleFull)** for PR 13629 at commit

[GitHub] spark pull request #13629: [SPARK-15370][SQL] Fix count bug

2016-06-12 Thread hvanhovell
GitHub user hvanhovell opened a pull request: https://github.com/apache/spark/pull/13629 [SPARK-15370][SQL] Fix count bug # What changes were proposed in this pull request? This pull request fixes the COUNT bug in the `RewriteCorrelatedScalarSubquery` rule. After this

[GitHub] spark issue #12313: [SPARK-14543] [SQL] Improve InsertIntoTable column resol...

2016-06-12 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/12313 If this is too large for merging to 2.0, could @rdblue deliver a small fix for capturing the illegal user inputs? Thanks! --- If your project is set up for it, you can reply to this email and

[GitHub] spark issue #13628: [SPARK-15907] [SQL] Issue Exceptions when Not Enough Inp...

2016-06-12 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/13628 There is a better fix in https://github.com/apache/spark/pull/12313. Let me close it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request #13628: [SPARK-15907] [SQL] Issue Exceptions when Not Eno...

2016-06-12 Thread gatorsmile
Github user gatorsmile closed the pull request at: https://github.com/apache/spark/pull/13628 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request #13496: [SPARK-15753][SQL] Move Analyzer stuff to Analyze...

2016-06-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13496#discussion_r66730126 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -452,6 +452,17 @@ class Analyzer( def

[GitHub] spark issue #13626: [SPARK-15370][SQL] Revert PR "Update RewriteCorrelatedSu...

2016-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13626 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13626: [SPARK-15370][SQL] Revert PR "Update RewriteCorrelatedSu...

2016-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13626 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60372/ Test PASSed. ---

[GitHub] spark issue #13626: [SPARK-15370][SQL] Revert PR "Update RewriteCorrelatedSu...

2016-06-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13626 **[Test build #60372 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60372/consoleFull)** for PR 13626 at commit

[GitHub] spark issue #13604: [SPARK-15898][SQL] DataFrameReader.text should return Da...

2016-06-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13604 **[Test build #60374 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60374/consoleFull)** for PR 13604 at commit

[GitHub] spark issue #13628: [SPARK-15907] [SQL] Issue Exceptions when Not Enough Inp...

2016-06-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13628 **[Test build #60373 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60373/consoleFull)** for PR 13628 at commit

[GitHub] spark issue #13614: Support Stata-like tabulation of values in a single colu...

2016-06-12 Thread shafiquejamal
Github user shafiquejamal commented on the issue: https://github.com/apache/spark/pull/13614 Ok, I'll close this an open a new PR with the title done correctly. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request #13628: [SPARK-15907] [SQL] Issue Exceptions when Not Eno...

2016-06-12 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/13628 [SPARK-15907] [SQL] Issue Exceptions when Not Enough Input Columns for Dynamic Partitioning What changes were proposed in this pull request? ```SQL CREATE TABLE

[GitHub] spark issue #13596: [SPARK-15870][SQL] DataFrame can't execute after uncache...

2016-06-12 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13596 thanks, merging to master and 2.0! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #13596: [SPARK-15870][SQL] DataFrame can't execute after ...

2016-06-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13596 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #13496: [SPARK-15753][SQL] Move Analyzer stuff to Analyze...

2016-06-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/13496#discussion_r66729871 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -452,6 +452,17 @@ class Analyzer( def

[GitHub] spark pull request #13413: [SPARK-15663][SQL] SparkSession.catalog.listFunct...

2016-06-12 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/13413#discussion_r66729858 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala --- @@ -89,6 +89,10 @@ class SimpleFunctionRegistry

[GitHub] spark pull request #13496: [SPARK-15753][SQL] Move Analyzer stuff to Analyze...

2016-06-12 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/13496#discussion_r66729833 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -452,6 +452,17 @@ class Analyzer( def

[GitHub] spark issue #13627: [SPARK-15906][MLlib][WIP] Add complementary naive bayes ...

2016-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13627 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #13627: [SPARK-15906][MLlib][WIP] Add complementary naive...

2016-06-12 Thread tilumi
GitHub user tilumi opened a pull request: https://github.com/apache/spark/pull/13627 [SPARK-15906][MLlib][WIP] Add complementary naive bayes algorithm ## What changes were proposed in this pull request? Add `ComplementaryNaiveBayes.scala` in package

[GitHub] spark pull request #13496: [SPARK-15753][SQL] Move Analyzer stuff to Analyze...

2016-06-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/13496#discussion_r66729456 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -452,6 +452,17 @@ class Analyzer( def

[GitHub] spark pull request #13496: [SPARK-15753][SQL] Move Analyzer stuff to Analyze...

2016-06-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/13496#discussion_r66729419 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -452,6 +452,17 @@ class Analyzer( def

[GitHub] spark pull request #13496: [SPARK-15753][SQL] Move Analyzer stuff to Analyze...

2016-06-12 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/13496#discussion_r66729375 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -452,6 +452,17 @@ class Analyzer( def

[GitHub] spark issue #13570: [SPARK-15832][SQL] Embedded IN/EXISTS predicate subquery...

2016-06-12 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/13570 @hvanhovell @jkbradley Could you add @ioana-delaney to the whitelist? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

  1   2   3   >