[GitHub] spark pull request #13964: [SPARK-16274][SQL] Implement xpath_boolean

2016-06-28 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/13964#discussion_r68889173 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/xml/XPathExpressionSuite.scala --- @@ -0,0 +1,68 @@ +/* + *

[GitHub] spark issue #13930: [SPARK-16228][SQL] HiveSessionCatalog should return `dou...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13930 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13930: [SPARK-16228][SQL] HiveSessionCatalog should return `dou...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13930 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61446/ Test PASSed. ---

[GitHub] spark issue #13930: [SPARK-16228][SQL] HiveSessionCatalog should return `dou...

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13930 **[Test build #61446 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61446/consoleFull)** for PR 13930 at commit

[GitHub] spark pull request #13964: [SPARK-16274][SQL] Implement xpath_boolean

2016-06-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13964#discussion_r6729 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/xml/XPathExpressionSuite.scala --- @@ -0,0 +1,68 @@ +/* + *

[GitHub] spark issue #13860: [SPARK-16157] [SQL] Add New Methods for comments in Stru...

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13860 **[Test build #61451 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61451/consoleFull)** for PR 13860 at commit

[GitHub] spark issue #13886: [SPARK-16185] [SQL] Better Error Messages When Creating ...

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13886 **[Test build #61450 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61450/consoleFull)** for PR 13886 at commit

[GitHub] spark pull request #13860: [SPARK-16157] [SQL] Add New Methods for comments ...

2016-06-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/13860#discussion_r6152 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeSuite.scala --- @@ -52,6 +52,23 @@ class DataTypeSuite extends SparkFunSuite {

[GitHub] spark pull request #13966: [SPARK-16276][SQL] Implement elt SQL function

2016-06-28 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/13966#discussion_r6095 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -162,6 +162,42 @@ case class

[GitHub] spark pull request #13860: [SPARK-16157] [SQL] Add New Methods for comments ...

2016-06-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13860#discussion_r6077 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeSuite.scala --- @@ -52,6 +52,23 @@ class DataTypeSuite extends SparkFunSuite {

[GitHub] spark pull request #13964: [SPARK-16274][SQL] Implement xpath_boolean

2016-06-28 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13964#discussion_r6030 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala --- @@ -301,6 +302,7 @@ object FunctionRegistry {

[GitHub] spark pull request #13860: [SPARK-16157] [SQL] Add New Methods for comments ...

2016-06-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/13860#discussion_r6029 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala --- @@ -363,6 +363,31 @@ class DataFrameReaderWriterSuite

[GitHub] spark pull request #13964: [SPARK-16274][SQL] Implement xpath_boolean

2016-06-28 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/13964#discussion_r6009 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/xml/XPathExpressionSuite.scala --- @@ -0,0 +1,68 @@ +/* + *

[GitHub] spark pull request #13860: [SPARK-16157] [SQL] Add New Methods for comments ...

2016-06-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13860#discussion_r68887957 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeSuite.scala --- @@ -52,6 +52,23 @@ class DataTypeSuite extends SparkFunSuite {

[GitHub] spark issue #13886: [SPARK-16185] [SQL] Better Error Messages When Creating ...

2016-06-28 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/13886 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #13860: [SPARK-16157] [SQL] Add New Methods for comments ...

2016-06-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/13860#discussion_r68887844 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeSuite.scala --- @@ -52,6 +52,23 @@ class DataTypeSuite extends SparkFunSuite {

[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimizer

2016-06-28 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/13906 For 3, I respect your opinion. I just make another commit for 2. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request #13964: [SPARK-16274][SQL] Implement xpath_boolean

2016-06-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13964#discussion_r68887731 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala --- @@ -301,6 +302,7 @@ object FunctionRegistry {

[GitHub] spark pull request #13964: [SPARK-16274][SQL] Implement xpath_boolean

2016-06-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13964#discussion_r68887674 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/xml/XPathExpressionSuite.scala --- @@ -0,0 +1,68 @@ +/* + *

[GitHub] spark issue #13919: [SPARK-16222] [SQL] JDBC Sources - Handling illegal inpu...

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13919 **[Test build #61448 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61448/consoleFull)** for PR 13919 at commit

[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimizer

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13906 **[Test build #61449 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61449/consoleFull)** for PR 13906 at commit

[GitHub] spark pull request #13966: [SPARK-16276][SQL] Implement elt SQL function

2016-06-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13966#discussion_r68887526 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -162,6 +162,42 @@ case class

[GitHub] spark issue #13893: [SPARK-14172][SQL] Hive table partition predicate not pa...

2016-06-28 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13893 It's a good point, looks like we can also improve the `PushDownPredicate` rule according to this. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #13912: [SPARK-16216][SQL] CSV data source supports custom date ...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13912 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13912: [SPARK-16216][SQL] CSV data source supports custom date ...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13912 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61443/ Test PASSed. ---

[GitHub] spark issue #13912: [SPARK-16216][SQL] CSV data source supports custom date ...

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13912 **[Test build #61443 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61443/consoleFull)** for PR 13912 at commit

[GitHub] spark pull request #13964: [SPARK-16274][SQL] Implement xpath_boolean

2016-06-28 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/13964#discussion_r68887194 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala --- @@ -301,6 +302,7 @@ object FunctionRegistry {

[GitHub] spark issue #13912: [SPARK-16216][SQL] CSV data source supports custom date ...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13912 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13912: [SPARK-16216][SQL] CSV data source supports custom date ...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13912 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61444/ Test FAILed. ---

[GitHub] spark pull request #13860: [SPARK-16157] [SQL] Add New Methods for comments ...

2016-06-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13860#discussion_r68887161 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala --- @@ -363,6 +363,31 @@ class DataFrameReaderWriterSuite

[GitHub] spark pull request #13964: [SPARK-16274][SQL] Implement xpath_boolean

2016-06-28 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/13964#discussion_r68887178 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/xml/XPathBoolean.scala --- @@ -0,0 +1,56 @@ +/* + * Licensed to

[GitHub] spark issue #13912: [SPARK-16216][SQL] CSV data source supports custom date ...

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13912 **[Test build #61444 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61444/consoleFull)** for PR 13912 at commit

[GitHub] spark issue #13966: [SPARK-16276][SQL] Implement elt SQL function

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13966 **[Test build #3139 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3139/consoleFull)** for PR 13966 at commit

[GitHub] spark pull request #13860: [SPARK-16157] [SQL] Add New Methods for comments ...

2016-06-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13860#discussion_r68886986 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeSuite.scala --- @@ -52,6 +52,23 @@ class DataTypeSuite extends SparkFunSuite {

[GitHub] spark issue #13964: [SPARK-16274][SQL] Implement xpath_boolean

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13964 **[Test build #3140 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3140/consoleFull)** for PR 13964 at commit

[GitHub] spark issue #13966: [SPARK-16276][SQL] Implement elt SQL function

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13966 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #13966: [SPARK-16276][SQL] Implement elt SQL function

2016-06-28 Thread petermaxlee
Github user petermaxlee commented on the issue: https://github.com/apache/spark/pull/13966 cc @dongjoon-hyun @cloud-fan @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #13966: [SPARK-16276][SQL] Implement elt SQL function

2016-06-28 Thread petermaxlee
GitHub user petermaxlee opened a pull request: https://github.com/apache/spark/pull/13966 [SPARK-16276][SQL] Implement elt SQL function ## What changes were proposed in this pull request? This patch implements the elt function, as it is implemented in Hive. ## How was

[GitHub] spark issue #13893: [SPARK-14172][SQL] Hive table partition predicate not pa...

2016-06-28 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/13893 Predicates should not be reordered if a condition contains non-deterministic parts, for example, 'rand() < 0.1 AND a=1' should not be reordered to 'a=1 AND rand() < 0.1' as the number of calls

[GitHub] spark pull request #13950: [SPARK-15487] [Web UI] Spark Master UI to reverse...

2016-06-28 Thread gurvindersingh
Github user gurvindersingh commented on a diff in the pull request: https://github.com/apache/spark/pull/13950#discussion_r68886506 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -127,7 +128,14 @@ private[deploy] class Master(

[GitHub] spark pull request #13950: [SPARK-15487] [Web UI] Spark Master UI to reverse...

2016-06-28 Thread gurvindersingh
Github user gurvindersingh commented on a diff in the pull request: https://github.com/apache/spark/pull/13950#discussion_r68886448 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -127,7 +128,14 @@ private[deploy] class Master(

[GitHub] spark pull request #13964: [SPARK-16274][SQL] Implement xpath_boolean

2016-06-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13964#discussion_r68886429 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/NonFoldableLiteral.scala --- @@ -26,7 +26,7 @@ import

[GitHub] spark issue #13948: [SPARK-16259] [PYSPARK] cleanup options in DataFrame rea...

2016-06-28 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/13948 Feel free to do it - but please take another careful look before you cherry pick. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark issue #13933: [SPARK-16236] [SQL] Add Path Option back to Load API in ...

2016-06-28 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/13933 @gatorsmile parquet, json or other file formats support both `path` and `paths` options. So that's not a problem. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request #13964: [SPARK-16274][SQL] Implement xpath_boolean

2016-06-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13964#discussion_r68886317 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/xml/XPathBoolean.scala --- @@ -0,0 +1,56 @@ +/* + * Licensed to

[GitHub] spark pull request #13964: [SPARK-16274][SQL] Implement xpath_boolean

2016-06-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13964#discussion_r68886279 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/xml/XPathBoolean.scala --- @@ -0,0 +1,56 @@ +/* + * Licensed to

[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimizer

2016-06-28 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/13906 By the way, for complexity, it's 23 line optimizer without blank/comments. In fact, it's less than `NullPropagation`. --- If your project is set up for it, you can reply to this email and

[GitHub] spark issue #13948: [SPARK-16259] [PYSPARK] cleanup options in DataFrame rea...

2016-06-28 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/13948 @rxin why don't we merge this one to 2.0? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #13955: [SPARK-16266][SQL][STREAING] Moved DataStreamRead...

2016-06-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13955 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimizer

2016-06-28 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/13906 It sounds promising. Maybe, Spark 2.1? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #13955: [SPARK-16266][SQL][STREAING] Moved DataStreamReader/Writ...

2016-06-28 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/13955 LGTM. Merging to master and 2.0. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimizer

2016-06-28 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/13906 Sounds interesting. You mean `LocalNode` that computes all local node operators on `LocalRelation`, right? --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark issue #13893: [SPARK-14172][SQL] Hive table partition predicate not pa...

2016-06-28 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13893 no, the predicates order doesn't matter. Our optimizer can reorder the predicates to run them more efficient. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request #13704: [SPARK-15985][SQL] Reduce runtime overhead of a p...

2016-06-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13704#discussion_r68885567 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -837,8 +837,36 @@ case class Cast(child: Expression,

[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimizer

2016-06-28 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13906 I'm not sure if this optimization is useful 1. empty `LocalRelation` is a corner case and seems not worth to optimize. 2. the optimization rule in this PR is kind of complex. 3. if

[GitHub] spark issue #13893: [SPARK-14172][SQL] Hive table partition predicate not pa...

2016-06-28 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/13893 @cloud-fan I pushed a commit to apply predicate pushdown on deterministic parts placed before any non-deterministic predicates, should it be safe to do this optimization? --- If your

[GitHub] spark pull request #13964: [SPARK-16274][SQL] Implement xpath_boolean

2016-06-28 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/13964#discussion_r68884892 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala --- @@ -301,6 +302,7 @@ object FunctionRegistry {

[GitHub] spark issue #13965: [SPARK-16236] [SQL] [FOLLOWUP] Add Path Option back to L...

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13965 **[Test build #61447 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61447/consoleFull)** for PR 13965 at commit

[GitHub] spark pull request #13965: [SPARK-16236] [SQL] [FOLLOWUP] Add Path Option ba...

2016-06-28 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/13965 [SPARK-16236] [SQL] [FOLLOWUP] Add Path Option back to Load API in DataFrameReader What changes were proposed in this pull request? When users only specify one and only one path, we

[GitHub] spark pull request #13964: [SPARK-16274][SQL] Implement xpath_boolean

2016-06-28 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/13964#discussion_r68884564 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/XmlFunctionsSuite.scala --- @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #13964: [SPARK-16274][SQL] Implement xpath_boolean

2016-06-28 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/13964#discussion_r68884371 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/XmlFunctionsSuite.scala --- @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #13964: [SPARK-16274][SQL] Implement xpath_boolean

2016-06-28 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/13964#discussion_r68884363 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/NonFoldableLiteral.scala --- @@ -26,7 +26,7 @@ import

[GitHub] spark pull request #13964: [SPARK-16274][SQL] Implement xpath_boolean

2016-06-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13964#discussion_r68884303 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/XmlFunctionsSuite.scala --- @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #13964: [SPARK-16274][SQL] Implement xpath_boolean

2016-06-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13964#discussion_r68884274 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/XmlFunctionsSuite.scala --- @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #11863: [SPARK-12177][Streaming][Kafka] Update KafkaDStreams to ...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/11863 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #11863: [SPARK-12177][Streaming][Kafka] Update KafkaDStreams to ...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/11863 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61436/ Test PASSed. ---

[GitHub] spark issue #13961: [SPARK-16271][SQL] Implement Hive's UDFXPathUtil

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13961 **[Test build #3137 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3137/consoleFull)** for PR 13961 at commit

[GitHub] spark pull request #13964: [SPARK-16274][SQL] Implement xpath_boolean

2016-06-28 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/13964#discussion_r68884185 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/xml/XPathExpressionSuite.scala --- @@ -0,0 +1,68 @@ +/* + *

[GitHub] spark issue #11863: [SPARK-12177][Streaming][Kafka] Update KafkaDStreams to ...

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/11863 **[Test build #61436 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61436/consoleFull)** for PR 11863 at commit

[GitHub] spark pull request #13964: [SPARK-16274][SQL] Implement xpath_boolean

2016-06-28 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/13964#discussion_r68884156 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/xml/XPathBoolean.scala --- @@ -0,0 +1,56 @@ +/* + * Licensed to

[GitHub] spark issue #13778: [SPARK-16062][SPARK-15989][SQL] Fix two bugs of Python-o...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13778 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61441/ Test FAILed. ---

[GitHub] spark pull request #13964: [SPARK-16274][SQL] Implement xpath_boolean

2016-06-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13964#discussion_r68884143 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/NonFoldableLiteral.scala --- @@ -26,7 +26,7 @@ import

[GitHub] spark issue #13778: [SPARK-16062][SPARK-15989][SQL] Fix two bugs of Python-o...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13778 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13778: [SPARK-16062][SPARK-15989][SQL] Fix two bugs of Python-o...

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13778 **[Test build #61441 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61441/consoleFull)** for PR 13778 at commit

[GitHub] spark pull request #13964: [SPARK-16274][SQL] Implement xpath_boolean

2016-06-28 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/13964#discussion_r68884058 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/NonFoldableLiteral.scala --- @@ -26,7 +26,7 @@ import

[GitHub] spark issue #13963: [TRIVIAL][PYSPARK] Clean up orc compression option as we...

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13963 **[Test build #61445 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61445/consoleFull)** for PR 13963 at commit

[GitHub] spark issue #13963: [TRIVIAL][PYSPARK] Clean up orc compression option as we...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13963 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #13964: [SPARK-16274][SQL] Implement xpath_boolean

2016-06-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13964#discussion_r68884017 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/xml/XPathBoolean.scala --- @@ -0,0 +1,56 @@ +/* + * Licensed to

[GitHub] spark issue #13963: [TRIVIAL][PYSPARK] Clean up orc compression option as we...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13963 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61445/ Test PASSed. ---

[GitHub] spark pull request #13964: [SPARK-16274][SQL] Implement xpath_boolean

2016-06-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13964#discussion_r68883944 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/xml/XPathBoolean.scala --- @@ -0,0 +1,56 @@ +/* + * Licensed to

[GitHub] spark pull request #13964: [SPARK-16274][SQL] Implement xpath_boolean

2016-06-28 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/13964#discussion_r68883895 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/NonFoldableLiteral.scala --- @@ -26,7 +26,7 @@ import

[GitHub] spark issue #13778: [SPARK-16062][SPARK-15989][SQL] Fix two bugs of Python-o...

2016-06-28 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/13778 @cloud-fan @vlad17 Is this change good for your now? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request #13964: [SPARK-16274][SQL] Implement xpath_boolean

2016-06-28 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/13964#discussion_r68883797 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/NonFoldableLiteral.scala --- @@ -26,7 +26,7 @@ import

[GitHub] spark issue #13930: [SPARK-16228][SQL] HiveSessionCatalog should return `dou...

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13930 **[Test build #61446 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61446/consoleFull)** for PR 13930 at commit

[GitHub] spark issue #13930: [SPARK-16228][SQL] HiveSessionCatalog should return `dou...

2016-06-28 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/13930 Rebased to the master for https://github.com/apache/spark/pull/13939 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #13778: [SPARK-16062][SPARK-15989][SQL] Fix two bugs of Python-o...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13778 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61435/ Test PASSed. ---

[GitHub] spark issue #13778: [SPARK-16062][SPARK-15989][SQL] Fix two bugs of Python-o...

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13778 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13778: [SPARK-16062][SPARK-15989][SQL] Fix two bugs of Python-o...

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13778 **[Test build #61435 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61435/consoleFull)** for PR 13778 at commit

[GitHub] spark issue #13964: [SPARK-16274][SQL] Implement xpath_boolean

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13964 **[Test build #3138 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3138/consoleFull)** for PR 13964 at commit

[GitHub] spark issue #13964: [SPARK-16274][SQL] Implement xpath_boolean

2016-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13964 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #13964: [SPARK-16274][SQL] Implement xpath_boolean

2016-06-28 Thread petermaxlee
Github user petermaxlee commented on the issue: https://github.com/apache/spark/pull/13964 cc @srowen @cloud-fan @vanzin @squito If this one works, I can implement the other ones too. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #13964: [SPARK-16274][SQL] Implement xpath_boolean

2016-06-28 Thread petermaxlee
Github user petermaxlee commented on the issue: https://github.com/apache/spark/pull/13964 cc @srowen @cloud-fan @vanzin @squito --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #13964: [SPARK-16274][SQL] Implement xpath_boolean

2016-06-28 Thread petermaxlee
GitHub user petermaxlee opened a pull request: https://github.com/apache/spark/pull/13964 [SPARK-16274][SQL] Implement xpath_boolean ## What changes were proposed in this pull request? This patch implements xpath_boolean expression for Spark SQL, a xpath function that returns

[GitHub] spark pull request #13961: [SPARK-16271][SQL] Implement Hive's UDFXPathUtil

2016-06-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13961 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimizer

2016-06-28 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/13906 Thank you, @cloud-fan . It seems to be a good idea to handle operators on LocalRelations. But, if possible, may I dig that on another PR? :) --- If your project is set up for it, you

[GitHub] spark issue #13961: [SPARK-16271][SQL] Implement Hive's UDFXPathUtil

2016-06-28 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/13961 Merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark pull request #13494: [SPARK-15752] [SQL] support optimization for meta...

2016-06-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13494#discussion_r68882374 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/MetadataOnlyOptimizer.scala --- @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #13963: [TRIVIAL][PYSPARK] Clean up orc compression option as we...

2016-06-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13963 **[Test build #61445 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61445/consoleFull)** for PR 13963 at commit

[GitHub] spark pull request #13963: [TRIVIAL][PYSPARK] Clean up orc compression optio...

2016-06-28 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/13963 [TRIVIAL][PYSPARK] Clean up orc compression option as well ## What changes were proposed in this pull request? This PR corrects ORC compression option for PySpark as well. I think this

[GitHub] spark issue #13963: [TRIVIAL][PYSPARK] Clean up orc compression option as we...

2016-06-28 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/13963 cc @davies --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

  1   2   3   4   5   6   7   8   >