[GitHub] spark issue #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14132 Thank you so much always, @gatorsmile ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-16 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14132 I do not know the exact context why you need SQL generation. Tomorrow, I will review your PR (https://github.com/apache/spark/pull/14116) to understand your issues tomorrow. --- If your

[GitHub] spark issue #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14132 Or, now, I got it. It was the terminology problem I used. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14132 You know, Spark decide to use `createOrReplaceTempView` by deprecating `registerTempTable` in 2.0. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-16 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14132 That is right. TempView -> Temporary View. `Temporal views` are wrong. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark issue #14235: [SPARK-16590][SQL][TEST] Improve LogicalPlanToSQLSuite t...

2016-07-16 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14235 I can understand the advantage of comparing SQL statement strings, but the cost is higher than the benefit especially for a small group of key developers who are maintaining the Spark code

[GitHub] spark issue #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14132 What I mean is not making real view as you concern. I'm telling the one I need to make a view definition by SQL generation is the result of ```

[GitHub] spark issue #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14132 ? `createOrReplaceTempView` => `TempView` => Temporary View. I mean this, @gatorsmile . So, I called this Spark Native Temporary View. This does not exist in Hive or External catalog.

[GitHub] spark issue #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-16 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14132 Really? Can you show me the files? I think we should correct them --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14132 Yep. I know why you said like that. I also feel like that, but Spark 2.0 uses that term in API. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark issue #14235: [SPARK-16590][SQL][TEST] Improve LogicalPlanToSQLSuite t...

2016-07-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14235 :) Sorry, but I don't think so. * At every level, we need to prove correctness. The tolerance you want is the result of unpredictable removal of Optimizer. * Also, this is

[GitHub] spark issue #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-16 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14132 I see. That is a temporary table. Temporal Tables are a term for different purposes. The sizing is not small, if we want to support the temporary views created by any

[GitHub] spark issue #14235: [SPARK-16590][SQL][TEST] Improve LogicalPlanToSQLSuite t...

2016-07-16 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14235 Comparing the SQL statement strings is horrible to me. I have a different approach to verify the **correctness**. How about compare the optimized plans, which can tolerate more slight

[GitHub] spark issue #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14132 Yep. The above example, `spark.range(10).createOrReplaceTempView("t")`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #14235: [SPARK-16590][SQL][TEST] Improve LogicalPlanToSQLSuite t...

2016-07-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14235 First of all, you can update the whole query set by one flag. So, maintainability is no more difficult issue. I made this PR because `SQL generation` is currently fragile as [you said

[GitHub] spark issue #14194: [SPARK-16485][DOC][ML] Fixed several inline formatting i...

2016-07-16 Thread hhbyyh
Github user hhbyyh commented on the issue: https://github.com/apache/spark/pull/14194 Thanks for finding this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-16 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14132 What are Spark temporal views? Temporal tables? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #14235: [SPARK-16590][SQL][TEST] Improve LogicalPlanToSQL...

2016-07-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14235#discussion_r71076593 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala --- @@ -76,7 +79,29 @@ class LogicalPlanToSQLSuite

[GitHub] spark issue #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14132 Thank you for replying, @gatorsmile . Yes. Right. In fact, that limitation is important to me. To complete my `INFORMATION_SCHEMA` PR (https://github.com/apache/spark/pull/14116), I

[GitHub] spark issue #14235: [SPARK-16590][SQL][TEST] Improve LogicalPlanToSQLSuite t...

2016-07-16 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14235 It sounds like the latest changes are unable to resolve Reynold's concern: how to regenerate all the expected SQL queries in bulk? You know, for native view support, we are not

[GitHub] spark issue #14235: [SPARK-16590][SQL][TEST] Improve LogicalPlanToSQLSuite t...

2016-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14235 **[Test build #62423 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62423/consoleFull)** for PR 14235 at commit

[GitHub] spark issue #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-16 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14132 In the JIRA https://issues.apache.org/jira/browse/SPARK-11012, we documented the current limitation of SQL generation: >Note that not all resolved logical query plan can be converted back to

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14177 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14177 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62422/ Test PASSed. ---

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14177 **[Test build #62422 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62422/consoleFull)** for PR 14177 at commit

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14177 **[Test build #62422 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62422/consoleFull)** for PR 14177 at commit

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14177 Agreed - this could be a bug in SQL/Hive, I'd be interested in digging into it a bit more later next week. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...

2016-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14223 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62421/ Test FAILed. ---

[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...

2016-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14223 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...

2016-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14223 **[Test build #62421 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62421/consoleFull)** for PR 14223 at commit

[GitHub] spark pull request #14217: [SPARK-16562][SQL] Do not allow downcast in INT32...

2016-07-16 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/14217#discussion_r71076055 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetIOSuite.scala --- @@ -169,6 +169,19 @@ class ParquetIOSuite

[GitHub] spark issue #14235: [SPARK-16590][SQL][TEST] Improve LogicalPlanToSQLSuite t...

2016-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14235 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14235: [SPARK-16590][SQL][TEST] Improve LogicalPlanToSQLSuite t...

2016-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14235 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62420/ Test PASSed. ---

[GitHub] spark issue #14235: [SPARK-16590][SQL][TEST] Improve LogicalPlanToSQLSuite t...

2016-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14235 **[Test build #62420 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62420/consoleFull)** for PR 14235 at commit

[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...

2016-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14223 **[Test build #62421 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62421/consoleFull)** for PR 14223 at commit

[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...

2016-07-16 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/14223 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #14235: [SPARK-16590][SQL][TEST] Improve LogicalPlanToSQLSuite t...

2016-07-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14235 Oh, thank you for fast review! Yep. I will update like that. The purpose of this PR is having stronger `LogicalPlanToSQLSuite`. --- If your project is set up for it, you can reply to

[GitHub] spark issue #14235: [SPARK-16590][SQL][TEST] Improve LogicalPlanToSQLSuite t...

2016-07-16 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14235 hm the problem with this approach is that we'd need to spend a lot of time to update test cases whenever we change sql generation slightly. I think in order to do this, we should put the generated sql

[GitHub] spark issue #14235: [SPARK-16590][SQL][TEST] Improve LogicalPlanToSQLSuite t...

2016-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14235 **[Test build #62420 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62420/consoleFull)** for PR 14235 at commit

[GitHub] spark pull request #14235: [SPARK-16590][SQL][TEST] Improve LogicalPlanToSQL...

2016-07-16 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/14235 [SPARK-16590][SQL][TEST] Improve LogicalPlanToSQLSuite to check generated SQL directly ## What changes were proposed in this pull request? This issue improves

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14177 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14177 **[Test build #62419 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62419/consoleFull)** for PR 14177 at commit

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14177 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62419/ Test FAILed. ---

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14177 I just realized that my local build was not using the hive profile. If this fails on Jenkins let's just go back to the original PR. Also I wonder if this is something we should notify the SQL

[GitHub] spark pull request #14179: [SPARK-16055][SPARKR] warning added while using s...

2016-07-16 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14179#discussion_r71074245 --- Diff: R/pkg/R/sparkR.R --- @@ -155,6 +155,10 @@ sparkR.sparkContext <- function( existingPort <-

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14177 **[Test build #62419 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62419/consoleFull)** for PR 14177 at commit

[GitHub] spark pull request #13785: [SPARK-15613] set correct TimeZone in test cases ...

2016-07-16 Thread ckadner
Github user ckadner closed the pull request at: https://github.com/apache/spark/pull/13785 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #13785: [SPARK-15613] set correct TimeZone in test cases "to UTC...

2016-07-16 Thread ckadner
Github user ckadner commented on the issue: https://github.com/apache/spark/pull/13785 Closing this PR since another more comprehensive fix was committed from PR #13784 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14177 I didn't think that should be needed since SparkSession was created with enableHiveSupport = F. Let me try that too. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14177 Hmm ok - The only difference in the patch I tried out locally is that I had the `sleep` in the loop test case. Did you remove that for some other reason ? --- If your project is set up for it,

[GitHub] spark issue #13785: [SPARK-15613] set correct TimeZone in test cases "to UTC...

2016-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13785 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14177 Jenkins failed with: ``` 123456789a.bcdefghijklmnopqrstuvwxyzABCDS...EFGHIJKLMNOPQRSTUVW [Stage 61:> (0 + 0) / 2]

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14177 **[Test build #62418 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62418/consoleFull)** for PR 14177 at commit

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14177 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62418/ Test FAILed. ---

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14177 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14177 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62417/ Test FAILed. ---

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14177 **[Test build #62417 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62417/consoleFull)** for PR 14177 at commit

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14177 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14177 **[Test build #62418 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62418/consoleFull)** for PR 14177 at commit

[GitHub] spark pull request #14234: [MINOR][SQL][STREAMING][DOCS] Fix minor typos, pu...

2016-07-16 Thread ahmed-mahran
Github user ahmed-mahran commented on a diff in the pull request: https://github.com/apache/spark/pull/14234#discussion_r71073776 --- Diff: docs/structured-streaming-programming-guide.md --- @@ -1093,12 +1067,10 @@ spark.streams().awaitAnyTermination() # block until any one of

[GitHub] spark pull request #14234: [MINOR][SQL][STREAMING][DOCS] Fix minor typos, pu...

2016-07-16 Thread ahmed-mahran
Github user ahmed-mahran commented on a diff in the pull request: https://github.com/apache/spark/pull/14234#discussion_r71073767 --- Diff: docs/structured-streaming-programming-guide.md --- @@ -620,16 +603,14 @@ df.groupBy("type").count() ### Window Operations on Event Time

[GitHub] spark pull request #14234: [MINOR][SQL][STREAMING][DOCS] Fix minor typos, pu...

2016-07-16 Thread ahmed-mahran
Github user ahmed-mahran commented on a diff in the pull request: https://github.com/apache/spark/pull/14234#discussion_r71073763 --- Diff: docs/structured-streaming-programming-guide.md --- @@ -519,10 +502,10 @@ csvDF = spark \ -These examples generate

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14177 **[Test build #62417 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62417/consoleFull)** for PR 14177 at commit

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14177 No luck, but I push that change to see if it works better in Jenkins - is that what you are referring to? I'm consistently getting these errors: ``` Error in invokeJava(isStatic

[GitHub] spark pull request #14234: [MINOR][SQL][STREAMING][DOCS] Fix minor typos, pu...

2016-07-16 Thread ahmed-mahran
Github user ahmed-mahran commented on a diff in the pull request: https://github.com/apache/spark/pull/14234#discussion_r71073751 --- Diff: docs/structured-streaming-programming-guide.md --- @@ -439,7 +422,7 @@ Here are some examples. {% highlight scala %} -val

[GitHub] spark pull request #14234: [MINOR][SQL][STREAMING][DOCS] Fix minor typos, pu...

2016-07-16 Thread ahmed-mahran
Github user ahmed-mahran commented on a diff in the pull request: https://github.com/apache/spark/pull/14234#discussion_r71073746 --- Diff: docs/structured-streaming-programming-guide.md --- @@ -410,26 +398,21 @@ see how this model handles event-time based processing and late

[GitHub] spark pull request #14234: [MINOR][SQL][STREAMING][DOCS] Fix minor typos, pu...

2016-07-16 Thread ahmed-mahran
Github user ahmed-mahran commented on a diff in the pull request: https://github.com/apache/spark/pull/14234#discussion_r71073739 --- Diff: docs/structured-streaming-programming-guide.md --- @@ -410,26 +398,21 @@ see how this model handles event-time based processing and late

[GitHub] spark pull request #14234: [MINOR][SQL][STREAMING][DOCS] Fix minor typos, pu...

2016-07-16 Thread ahmed-mahran
Github user ahmed-mahran commented on a diff in the pull request: https://github.com/apache/spark/pull/14234#discussion_r71073736 --- Diff: docs/structured-streaming-programming-guide.md --- @@ -410,26 +398,21 @@ see how this model handles event-time based processing and late

[GitHub] spark pull request #14234: [MINOR][SQL][STREAMING][DOCS] Fix minor typos, pu...

2016-07-16 Thread ahmed-mahran
Github user ahmed-mahran commented on a diff in the pull request: https://github.com/apache/spark/pull/14234#discussion_r71073721 --- Diff: docs/structured-streaming-programming-guide.md --- @@ -223,7 +211,7 @@ $ ./bin/run-example

[GitHub] spark pull request #14234: [MINOR][SQL][STREAMING][DOCS] Fix minor typos, pu...

2016-07-16 Thread ahmed-mahran
Github user ahmed-mahran commented on a diff in the pull request: https://github.com/apache/spark/pull/14234#discussion_r71073714 --- Diff: docs/structured-streaming-programming-guide.md --- @@ -65,11 +51,13 @@ val words = lines.as[String].flatMap(_.split(" ")) val wordCounts

[GitHub] spark pull request #14234: [MINOR][SQL][STREAMING][DOCS] Fix minor typos, pu...

2016-07-16 Thread ahmed-mahran
Github user ahmed-mahran commented on a diff in the pull request: https://github.com/apache/spark/pull/14234#discussion_r71073700 --- Diff: docs/structured-streaming-programming-guide.md --- @@ -82,8 +70,6 @@ SparkSession spark = SparkSession .builder()

[GitHub] spark pull request #14173: [SPARKR][SPARK-16507] Add a CRAN checker, fix Rd ...

2016-07-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14173 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #14234: [MINOR][SQL][STREAMING][DOCS] Fix minor typos, pu...

2016-07-16 Thread ahmed-mahran
Github user ahmed-mahran commented on a diff in the pull request: https://github.com/apache/spark/pull/14234#discussion_r71073691 --- Diff: docs/structured-streaming-programming-guide.md --- @@ -14,29 +14,13 @@ Structured Streaming is a scalable and fault-tolerant stream

[GitHub] spark issue #14234: [MINOR][SQL][STREAMING][DOCS] Fix minor typos, punctuati...

2016-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14234 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #14234: [MINOR][SQL][STREAMING][DOCS] Fix minor typos, pu...

2016-07-16 Thread ahmed-mahran
GitHub user ahmed-mahran opened a pull request: https://github.com/apache/spark/pull/14234 [MINOR][SQL][STREAMING][DOCS] Fix minor typos, punctuations and grammar ## What changes were proposed in this pull request? Minor fixes correcting some typos, punctuations, grammar.

[GitHub] spark issue #14173: [SPARKR][SPARK-16507] Add a CRAN checker, fix Rd aliases

2016-07-16 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14173 Cool. Merging this to master, branch-2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #14179: [SPARK-16055][SPARKR] warning added while using s...

2016-07-16 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/14179#discussion_r71073655 --- Diff: R/pkg/R/sparkR.R --- @@ -155,6 +155,10 @@ sparkR.sparkContext <- function( existingPort <- Sys.getenv("EXISTING_SPARKR_BACKEND_PORT",

[GitHub] spark pull request #14090: [SPARK-16112][SparkR] Programming guide for gappl...

2016-07-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14090 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #14090: [SPARK-16112][SparkR] Programming guide for gapply/gappl...

2016-07-16 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14090 Merging this to master, branch-2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14090: [SPARK-16112][SparkR] Programming guide for gapply/gappl...

2016-07-16 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14090 LGTM. thanks for putting this together! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #14179: [SPARK-16055][SPARKR] warning added while using sparkPac...

2016-07-16 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14179 A couple of test files are reusing an existing SparkSession/SparkContext by calling `sparkR.sparkContext` I think they are now hitting the warning statement that is added in this PR, somehow.

[GitHub] spark issue #14173: [SPARKR][SPARK-16507] Add a CRAN checker, fix Rd aliases

2016-07-16 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14173 Yap - I'll check if there's anything left as per SPARK-16508 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request #14210: [SPARK-16556] [SPARK-16559] [SQL] Fix Two Bugs in...

2016-07-16 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/14210#discussion_r71072892 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -1264,6 +1265,29 @@ class DDLSuite extends QueryTest

[GitHub] spark pull request #14210: [SPARK-16556] [SPARK-16559] [SQL] Fix Two Bugs in...

2016-07-16 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/14210#discussion_r71072862 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/sources/CreateTableAsSelectSuite.scala --- @@ -199,7 +200,7 @@ class CreateTableAsSelectSuite

[GitHub] spark pull request #14210: [SPARK-16556] [SPARK-16559] [SQL] Fix Two Bugs in...

2016-07-16 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/14210#discussion_r71072854 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/sources/CreateTableAsSelectSuite.scala --- @@ -212,7 +213,23 @@ class

[GitHub] spark pull request #14210: [SPARK-16556] [SPARK-16559] [SQL] Fix Two Bugs in...

2016-07-16 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/14210#discussion_r71072842 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -1264,6 +1265,29 @@ class DDLSuite extends QueryTest

[GitHub] spark pull request #14217: [SPARK-16562][SQL] Do not allow downcast in INT32...

2016-07-16 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/14217#discussion_r71072773 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetIOSuite.scala --- @@ -169,6 +169,19 @@ class

[GitHub] spark issue #14090: [SPARK-16112][SparkR] Programming guide for gapply/gappl...

2016-07-16 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14090 Thanks @NarineK - I tried it on a fresh Ubuntu VM and it rendered fine. I think it has something to do with ruby / jekyll versions. The rendered docs looked fine on the Ubuntu VM LGTM.

[GitHub] spark issue #14098: [SPARK-16380][SQL][Example]:Update SQL examples and prog...

2016-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14098 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14098: [SPARK-16380][SQL][Example]:Update SQL examples and prog...

2016-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14098 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62416/ Test PASSed. ---

[GitHub] spark issue #14098: [SPARK-16380][SQL][Example]:Update SQL examples and prog...

2016-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14098 **[Test build #62416 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62416/consoleFull)** for PR 14098 at commit

[GitHub] spark issue #14098: [SPARK-16380][SQL][Example]:Update SQL examples and prog...

2016-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14098 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62415/ Test PASSed. ---

[GitHub] spark issue #14098: [SPARK-16380][SQL][Example]:Update SQL examples and prog...

2016-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14098 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14098: [SPARK-16380][SQL][Example]:Update SQL examples and prog...

2016-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14098 **[Test build #62415 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62415/consoleFull)** for PR 14098 at commit

[GitHub] spark issue #14179: [SPARK-16055][SPARKR] warning added while using sparkPac...

2016-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14179 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62414/ Test FAILed. ---

[GitHub] spark issue #14179: [SPARK-16055][SPARKR] warning added while using sparkPac...

2016-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14179 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14179: [SPARK-16055][SPARKR] warning added while using sparkPac...

2016-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14179 **[Test build #62414 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62414/consoleFull)** for PR 14179 at commit

[GitHub] spark issue #14098: [SPARK-16380][SQL][Example]:Update SQL examples and prog...

2016-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14098 **[Test build #62416 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62416/consoleFull)** for PR 14098 at commit

[GitHub] spark issue #14098: [SPARK-16380][SQL][Example]:Update SQL examples and prog...

2016-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14098 **[Test build #62415 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62415/consoleFull)** for PR 14098 at commit

[GitHub] spark issue #14179: [SPARK-16055][SPARKR] warning added while using sparkPac...

2016-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14179 **[Test build #62414 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62414/consoleFull)** for PR 14179 at commit

  1   2   >