[GitHub] spark pull request #14335: [SPARK-16697][ML][MLLib] improve LDA submitMiniBa...

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14335#discussion_r72011858 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala --- @@ -472,12 +473,13 @@ final class OnlineLDAOptimizer extends

[GitHub] spark pull request #14335: [SPARK-16697][ML][MLLib] improve LDA submitMiniBa...

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14335#discussion_r72011821 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala --- @@ -472,12 +473,13 @@ final class OnlineLDAOptimizer extends

[GitHub] spark pull request #14336: Don't run over all numFeatures if debug log disab...

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14336#discussion_r72011689 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala --- @@ -118,9 +118,11 @@ private[spark] object RandomForest extends Logging {

[GitHub] spark pull request #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14132#discussion_r72011582 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1774,6 +1775,49 @@ class Analyzer( }

[GitHub] spark pull request #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14132#discussion_r72011413 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1774,6 +1775,49 @@ class Analyzer( }

[GitHub] spark pull request #14336: Don't run over all numFeatures if debug log disab...

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14336#discussion_r72011376 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala --- @@ -118,9 +118,11 @@ private[spark] object RandomForest extends Logging {

[GitHub] spark pull request #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14132#discussion_r72011394 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1774,6 +1775,49 @@ class Analyzer( }

[GitHub] spark issue #14333: [SPARK-16696][ML][MLLib] destroy KMeans bcNewCenters whe...

Github user srowen commented on the issue: https://github.com/apache/spark/pull/14333 I don't understand the last change. As far as I can see it can be destroyed inside the loop iteration. It's also possible to reuse the broadcast (declare outside the loop), and unpersist each

[GitHub] spark pull request #14296: [SPARK-16639][SQL] The query with having conditio...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14296#discussion_r72011203 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1207,6 +1207,12 @@ class Analyzer(

[GitHub] spark pull request #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14132#discussion_r72011145 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1774,6 +1775,49 @@ class Analyzer( }

[GitHub] spark issue #14331: [SPARK-16691][SQL] move BucketSpec to catalyst module an...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14331 **[Test build #62798 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62798/consoleFull)** for PR 14331 at commit

[GitHub] spark issue #14334: [SPARK-16703][SQL] Fixes window specification SQL format

Github user rxin commented on the issue: https://github.com/apache/spark/pull/14334 BTW can you change the title to say "Remove extra whitespace in SQL generation for window functions"? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #14297: [SPARK-16660][SQL] CreateViewCommand should not take Cat...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14297 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14297: [SPARK-16660][SQL] CreateViewCommand should not take Cat...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14297 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62786/ Test PASSed. ---

[GitHub] spark issue #14297: [SPARK-16660][SQL] CreateViewCommand should not take Cat...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14297 **[Test build #62786 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62786/consoleFull)** for PR 14297 at commit

[GitHub] spark issue #14334: [SPARK-16703][SQL] Fixes window specification SQL format

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14334 **[Test build #62797 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62797/consoleFull)** for PR 14334 at commit

[GitHub] spark pull request #14331: [SPARK-16691][SQL] move BucketSpec to catalyst mo...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14331#discussion_r72010784 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -173,8 +190,18 @@ case class CatalogTable(

[GitHub] spark pull request #13077: [SPARK-10748] [Mesos] Log error instead of crashi...

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/13077#discussion_r72010691 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala --- @@ -502,41 +502,53 @@ private[spark] class

[GitHub] spark issue #14339: [SPARK-16698][SQL] Field names having dots should be all...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14339 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14339: [SPARK-16698][SQL] Field names having dots should be all...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14339 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62787/ Test PASSed. ---

[GitHub] spark issue #14339: [SPARK-16698][SQL] Field names having dots should be all...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14339 **[Test build #62787 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62787/consoleFull)** for PR 14339 at commit

[GitHub] spark issue #14334: [SPARK-16703][SQL] Fixes window specification SQL format

Github user liancheng commented on the issue: https://github.com/apache/spark/pull/14334 @rxin @dongjoon-hyun Thanks! JIRA ticket added and updated the golden files. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14132#discussion_r72010521 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1774,6 +1775,49 @@ class Analyzer( }

[GitHub] spark issue #14257: [SPARK-16621][SQL][WIP] Use a stable ID generation metho...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14257 **[Test build #62796 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62796/consoleFull)** for PR 14257 at commit

[GitHub] spark pull request #14296: [SPARK-16639][SQL] The query with having conditio...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/14296#discussion_r72009959 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1207,6 +1207,12 @@ class Analyzer(

[GitHub] spark pull request #14332: [SPARK-16694] [CORE] Use for/foreach rather than ...

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14332#discussion_r72009839 --- Diff: examples/src/main/scala/org/apache/spark/examples/ml/DataFrameExample.scala --- @@ -54,14 +54,13 @@ object DataFrameExample { }

[GitHub] spark issue #14331: [SPARK-16691][SQL] move BucketSpec to catalyst module an...

Github user liancheng commented on the issue: https://github.com/apache/spark/pull/14331 Overall LGTM, a few minor comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #14331: [SPARK-16691][SQL] move BucketSpec to catalyst mo...

Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/14331#discussion_r72009811 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala --- @@ -20,10 +20,11 @@ package org.apache.spark.sql.sources

[GitHub] spark pull request #14331: [SPARK-16691][SQL] move BucketSpec to catalyst mo...

Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/14331#discussion_r72009802 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -110,6 +110,25 @@ case class CatalogTablePartition(

[GitHub] spark pull request #14331: [SPARK-16691][SQL] move BucketSpec to catalyst mo...

Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/14331#discussion_r72009804 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -173,8 +190,18 @@ case class CatalogTable(

[GitHub] spark issue #14340: [SPARK-16534][Streaming][Kafka] Add Python API support f...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14340 **[Test build #62795 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62795/consoleFull)** for PR 14340 at commit

[GitHub] spark issue #14342: [SPARK-16685] Remove audit-release scripts.

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14342 **[Test build #62794 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62794/consoleFull)** for PR 14342 at commit

[GitHub] spark pull request #14296: [SPARK-16639][SQL] The query with having conditio...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14296#discussion_r72009643 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1207,6 +1207,12 @@ class Analyzer(

[GitHub] spark pull request #14296: [SPARK-16639][SQL] The query with having conditio...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14296#discussion_r72009599 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -46,6 +46,14 @@ class SQLQuerySuite extends QueryTest with

[GitHub] spark pull request #14296: [SPARK-16639][SQL] The query with having conditio...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14296#discussion_r72009571 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1207,6 +1207,12 @@ class Analyzer(

[GitHub] spark pull request #14342: [SPARK-16685] Remove audit-release scripts.

GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/14342 [SPARK-16685] Remove audit-release scripts. ## What changes were proposed in this pull request? This patch removes dev/audit-release. It was initially created to do basic release auditing, but we

[GitHub] spark issue #14333: [SPARK-16696][ML][MLLib] destroy KMeans bcNewCenters whe...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14333 **[Test build #62793 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62793/consoleFull)** for PR 14333 at commit

[GitHub] spark pull request #14327: [SPARK-16686][SQL] Project shouldn't be pushed do...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/14327#discussion_r72009385 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -150,11 +150,13 @@ class SimpleTestOptimizer extends

[GitHub] spark issue #14339: [SPARK-16698][SQL] Field names having dots should be all...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14339 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14339: [SPARK-16698][SQL] Field names having dots should be all...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14339 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62785/ Test PASSed. ---

[GitHub] spark issue #14339: [SPARK-16698][SQL] Field names having dots should be all...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14339 **[Test build #62785 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62785/consoleFull)** for PR 14339 at commit

[GitHub] spark issue #14313: [SPARK-16674][SQL] Avoid per-record type dispatch in JDB...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14313 **[Test build #62792 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62792/consoleFull)** for PR 14313 at commit

[GitHub] spark issue #13077: [SPARK-10748] [Mesos] Log error instead of crashing Spar...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13077 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62783/ Test PASSed. ---

[GitHub] spark pull request #14337: [SPARK-16699][SQL] Fix performance bug in hash ag...

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14337 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #13077: [SPARK-10748] [Mesos] Log error instead of crashing Spar...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13077 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14337: [SPARK-16699][SQL] Fix performance bug in hash aggregate...

Github user rxin commented on the issue: https://github.com/apache/spark/pull/14337 @ooq next time please open a pull request against master branch rather than 2.0. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #13077: [SPARK-10748] [Mesos] Log error instead of crashing Spar...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13077 **[Test build #62783 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62783/consoleFull)** for PR 13077 at commit

[GitHub] spark issue #14341: [Minor][Doc][SQL] Fix two documents regarding size in by...

Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14341 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #14337: [SPARK-16699][SQL] Fix performance bug in hash aggregate...

Github user rxin commented on the issue: https://github.com/apache/spark/pull/14337 Merging in master/2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #14339: [SPARK-16698][SQL] Field names having dots should be all...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14339 **[Test build #62791 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62791/consoleFull)** for PR 14339 at commit

[GitHub] spark pull request #14327: [SPARK-16686][SQL] Project shouldn't be pushed do...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14327#discussion_r72008673 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -150,11 +150,13 @@ class SimpleTestOptimizer extends

[GitHub] spark issue #14341: [Minor][Doc][SQL] Fix two documents regarding size in by...

Github user viirya commented on the issue: https://github.com/apache/spark/pull/14341 cc @cloud-fan @liancheng Just minor document changes. Please review if this change is proper. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #14339: [SPARK-16698][SQL] Field names having dots should be all...

Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14339 LGTM, cc @liancheng to take another look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #14327: [SPARK-16686][SQL] Project shouldn't be pushed do...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/14327#discussion_r72008576 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -150,11 +150,13 @@ class SimpleTestOptimizer extends

[GitHub] spark pull request #14339: [SPARK-16698][SQL] Field names having dots should...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14339#discussion_r72008560 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -2982,4 +2982,19 @@ class SQLQuerySuite extends QueryTest with

[GitHub] spark issue #14341: [Minor][Doc][SQL] Fix two documents regarding size in by...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14341 **[Test build #62790 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62790/consoleFull)** for PR 14341 at commit

[GitHub] spark issue #14313: [SPARK-16674][SQL] Avoid per-record type dispatch in JDB...

Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14313 LGTM except some style comments, thanks for working on it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request #14313: [SPARK-16674][SQL] Avoid per-record type dispatch...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14313#discussion_r72008447 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -322,46 +322,133 @@ private[sql] class JDBCRDD(

[GitHub] spark pull request #14341: [Minor][Doc][SQL] Fix two documents regarding siz...

GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/14341 [Minor][Doc][SQL] Fix two documents regarding size in bytes ## What changes were proposed in this pull request? Fix two places in SQLConf documents regarding size in bytes and statistics.

[GitHub] spark pull request #14313: [SPARK-16674][SQL] Avoid per-record type dispatch...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14313#discussion_r72008403 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -322,46 +322,133 @@ private[sql] class JDBCRDD(

[GitHub] spark pull request #14327: [SPARK-16686][SQL] Project shouldn't be pushed do...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14327#discussion_r72008303 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -150,11 +150,13 @@ class SimpleTestOptimizer extends

[GitHub] spark pull request #14327: [SPARK-16686][SQL] Project shouldn't be pushed do...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14327#discussion_r72008210 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -150,11 +150,13 @@ class SimpleTestOptimizer extends

[GitHub] spark issue #14340: [SPARK-16534][Streaming][Kafka] Add Python API support f...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14340 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14340: [SPARK-16534][Streaming][Kafka] Add Python API support f...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14340 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62784/ Test FAILed. ---

[GitHub] spark issue #14340: [SPARK-16534][Streaming][Kafka] Add Python API support f...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14340 **[Test build #62784 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62784/consoleFull)** for PR 14340 at commit

[GitHub] spark pull request #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14132#discussion_r72008134 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1774,6 +1775,49 @@ class Analyzer( }

[GitHub] spark issue #14327: [SPARK-16686][SQL] Project shouldn't be pushed down thro...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14327 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62782/ Test PASSed. ---

[GitHub] spark issue #14327: [SPARK-16686][SQL] Project shouldn't be pushed down thro...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14327 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14327: [SPARK-16686][SQL] Project shouldn't be pushed down thro...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14327 **[Test build #62782 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62782/consoleFull)** for PR 14327 at commit

[GitHub] spark issue #14313: [SPARK-16674][SQL] Avoid per-record type dispatch in JDB...

Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14313 @cloud-fan I just addressed your comments. I added another argument in `JDBCConversion` for `MutableRow` so that we can avoid type-boxing. --- If your project is set up for it, you can reply

[GitHub] spark issue #14313: [SPARK-16674][SQL] Avoid per-record type dispatch in JDB...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14313 **[Test build #62789 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62789/consoleFull)** for PR 14313 at commit

[GitHub] spark pull request #14313: [SPARK-16674][SQL] Avoid per-record type dispatch...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/14313#discussion_r72007301 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -407,84 +496,8 @@ private[sql] class JDBCRDD(

[GitHub] spark issue #14327: [SPARK-16686][SQL] Project shouldn't be pushed down thro...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14327 **[Test build #62788 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62788/consoleFull)** for PR 14327 at commit

[GitHub] spark issue #14327: [SPARK-16686][SQL] Project shouldn't be pushed down thro...

Github user viirya commented on the issue: https://github.com/apache/spark/pull/14327 Besides, according to the JIRA, this may need to be backported to 1.6. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #14327: [SPARK-16686][SQL] Project shouldn't be pushed down thro...

Github user viirya commented on the issue: https://github.com/apache/spark/pull/14327 cc @cloud-fan @liancheng @yhuai Please review this change. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #14339: [SPARK-16698][SQL] Field names having dots should be all...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14339 **[Test build #62787 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62787/consoleFull)** for PR 14339 at commit

[GitHub] spark issue #14331: [SPARK-16691][SQL] move BucketSpec to catalyst module an...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14331 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62777/ Test PASSed. ---

[GitHub] spark issue #14331: [SPARK-16691][SQL] move BucketSpec to catalyst module an...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14331 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14331: [SPARK-16691][SQL] move BucketSpec to catalyst module an...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14331 **[Test build #62777 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62777/consoleFull)** for PR 14331 at commit

[GitHub] spark issue #14331: [SPARK-16691][SQL] move BucketSpec to catalyst module an...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14331 **[Test build #62776 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62776/consoleFull)** for PR 14331 at commit

[GitHub] spark issue #14297: [SPARK-16660][SQL] CreateViewCommand should not take Cat...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14297 **[Test build #62786 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62786/consoleFull)** for PR 14297 at commit

[GitHub] spark issue #14331: [SPARK-16691][SQL] move BucketSpec to catalyst module an...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14331 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14331: [SPARK-16691][SQL] move BucketSpec to catalyst module an...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14331 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62776/ Test PASSed. ---

[GitHub] spark issue #14204: [SPARK-16520] [WEBUI] Link executors to corresponding wo...

Github user yhuai commented on the issue: https://github.com/apache/spark/pull/14204 In my test, the column does not exist. On Sun, Jul 24, 2016 at 6:41 PM -0700, "Tao Lin" wrote:

[GitHub] spark issue #14339: [SPARK-16698][SQL] Field names having dots should be all...

Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14339 Sure! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #14297: [SPARK-16660][SQL] CreateViewCommand should not take Cat...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14297 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62775/ Test PASSed. ---

[GitHub] spark pull request #14313: [SPARK-16674][SQL] Avoid per-record type dispatch...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14313#discussion_r72005471 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -407,84 +496,8 @@ private[sql] class JDBCRDD(

[GitHub] spark pull request #14313: [SPARK-16674][SQL] Avoid per-record type dispatch...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14313#discussion_r72005487 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -322,46 +322,135 @@ private[sql] class JDBCRDD(

[GitHub] spark issue #14297: [SPARK-16660][SQL] CreateViewCommand should not take Cat...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14297 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14297: [SPARK-16660][SQL] CreateViewCommand should not take Cat...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14297 **[Test build #62775 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62775/consoleFull)** for PR 14297 at commit

[GitHub] spark pull request #14313: [SPARK-16674][SQL] Avoid per-record type dispatch...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14313#discussion_r72005398 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -322,46 +322,135 @@ private[sql] class JDBCRDD(

[GitHub] spark pull request #14313: [SPARK-16674][SQL] Avoid per-record type dispatch...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14313#discussion_r72005309 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -322,46 +322,135 @@ private[sql] class JDBCRDD(

[GitHub] spark pull request #14313: [SPARK-16674][SQL] Avoid per-record type dispatch...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/14313#discussion_r72005232 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -407,84 +496,8 @@ private[sql] class JDBCRDD(

[GitHub] spark issue #14333: [SPARK-16696][ML][MLLib] fix KMeans bcNewCenters unpersi...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14333 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14333: [SPARK-16696][ML][MLLib] fix KMeans bcNewCenters unpersi...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14333 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62779/ Test PASSed. ---

[GitHub] spark issue #14333: [SPARK-16696][ML][MLLib] fix KMeans bcNewCenters unpersi...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14333 **[Test build #62779 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62779/consoleFull)** for PR 14333 at commit

[GitHub] spark pull request #14313: [SPARK-16674][SQL] Avoid per-record type dispatch...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14313#discussion_r72005172 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -407,84 +496,8 @@ private[sql] class JDBCRDD(

[GitHub] spark pull request #14313: [SPARK-16674][SQL] Avoid per-record type dispatch...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14313#discussion_r72005085 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -322,46 +322,135 @@ private[sql] class JDBCRDD(

[GitHub] spark issue #14339: [SPARK-16698][SQL] Field names having dots should be all...

Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14339 can we test it in `SQLQuerySuite` or something? I think `FileSourceStrategySuite` should be used to test the strategy. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark issue #14339: [SPARK-16698][SQL] Field names having dots should be all...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14339 **[Test build #62785 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62785/consoleFull)** for PR 14339 at commit

  1   2   3   >