[GitHub] spark issue #14433: [SPARK-16829][SparkR]:sparkR sc.setLogLevel doesn't work

2016-08-02 Thread wangmiao1981
Github user wangmiao1981 commented on the issue: https://github.com/apache/spark/pull/14433 @felixcheung Checking whether it is running from shell is not exactly the same as checking which shell is calling it. My approach is depends on the fact that the Logging trait is used in three

[GitHub] spark issue #14471: [SPARK-14387][SQL] Exceptions thrown when querying ORC t...

2016-08-02 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14471 Can you add a test case? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #14433: [SPARK-16829][SparkR]:sparkR sc.setLogLevel doesn't work

2016-08-02 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14433 I think both checks are a bit fragile and would be great to a single way to check if running as shell that is shared, and that could be what SparkSubmit.scala call as well. Would be

[GitHub] spark pull request #14390: [SPARK-15541] Casting ConcurrentHashMap to Concur...

2016-08-02 Thread maver1ck
Github user maver1ck closed the pull request at: https://github.com/apache/spark/pull/14390 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #14390: [SPARK-15541] Casting ConcurrentHashMap to ConcurrentMap...

2016-08-02 Thread maver1ck
Github user maver1ck commented on the issue: https://github.com/apache/spark/pull/14390 Done. Thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #14472: [SPARK-16866][SQL] Infrastructure for file-based SQL end...

2016-08-02 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14472 yea, it looks much better. Although golden files are always generated, we should make it easy to read and verify its correctness. --- If your project is set up for it, you can reply to this

[GitHub] spark issue #14475: [SPARK-16862] Configurable buffer size in `UnsafeSorterS...

2016-08-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14475 **[Test build #63156 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63156/consoleFull)** for PR 14475 at commit

[GitHub] spark pull request #14475: [SPARK-16862] Configurable buffer size in `Unsafe...

2016-08-02 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/14475#discussion_r73283038 --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillReader.java --- @@ -50,7 +55,19 @@ public

[GitHub] spark pull request #14475: [SPARK-16862] Configurable buffer size in `Unsafe...

2016-08-02 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/14475#discussion_r73283047 --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillReader.java --- @@ -31,6 +34,8 @@ * of the file

[GitHub] spark issue #14472: [SPARK-16866][SQL] Infrastructure for file-based SQL end...

2016-08-02 Thread petermaxlee
Github user petermaxlee commented on the issue: https://github.com/apache/spark/pull/14472 I don't think these golden files should be manually created. They should always be generated. I tried JSON earlier and it was not very friendly either (worse than XML in this case). Do

[GitHub] spark issue #14447: [SPARK-16445][MLlib][SparkR] Multilayer Perceptron Class...

2016-08-02 Thread keypointt
Github user keypointt commented on the issue: https://github.com/apache/spark/pull/14447 Actually I've already tried to change the classes to be public, and open them to not only `[r]` but every module which still does not work. And exactly, above comment msg is the only

[GitHub] spark issue #14472: [SPARK-16866][SQL] Infrastructure for file-based SQL end...

2016-08-02 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14472 Is there any case that people need to write a golden file themselves? If we wanna use some standard formats, I prefer json over xml. --- If your project is set up for it, you can reply to this

[GitHub] spark issue #12983: [SPARK-15213][PySpark] Unify 'range' usages

2016-08-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/12983 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #12983: [SPARK-15213][PySpark] Unify 'range' usages

2016-08-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12983 **[Test build #63155 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63155/consoleFull)** for PR 12983 at commit

[GitHub] spark issue #12983: [SPARK-15213][PySpark] Unify 'range' usages

2016-08-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/12983 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63155/ Test FAILed. ---

[GitHub] spark issue #14447: [SPARK-16445][MLlib][SparkR] Multilayer Perceptron Class...

2016-08-02 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/14447 Actually I don't have an excellent debug way for SparkR wrappers. Usually you can create a ```RWrapperSuite``` and test whether it works well in the Scala side (If you encounter some issues

[GitHub] spark issue #14433: [SPARK-16829][SparkR]:sparkR sc.setLogLevel doesn't work

2016-08-02 Thread wangmiao1981
Github user wangmiao1981 commented on the issue: https://github.com/apache/spark/pull/14433 @felixcheung "I think we might have a need to create a helper for "am I running in the SparkR shell" function?" Do you mean for #14258 ? Not for this PR, right? --- If your project is set up

[GitHub] spark issue #12983: [SPARK-15213][PySpark] Unify 'range' usages

2016-08-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12983 **[Test build #63155 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63155/consoleFull)** for PR 12983 at commit

[GitHub] spark issue #14475: [SPARK-16862] Configurable buffer size in `UnsafeSorterS...

2016-08-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14475 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63153/ Test FAILed. ---

[GitHub] spark issue #14475: [SPARK-16862] Configurable buffer size in `UnsafeSorterS...

2016-08-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14475 **[Test build #63153 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63153/consoleFull)** for PR 14475 at commit

[GitHub] spark issue #14475: [SPARK-16862] Configurable buffer size in `UnsafeSorterS...

2016-08-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14475 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14472: [SPARK-16866][SQL] Infrastructure for file-based SQL end...

2016-08-02 Thread petermaxlee
Github user petermaxlee commented on the issue: https://github.com/apache/spark/pull/14472 For output file -- one other way I thought about was to use ``` -- query 1 query -- query 1: schema schema -- query 1: result result -- query 2 query

[GitHub] spark issue #14136: [SPARK-16282][SQL] Implement percentile SQL function.

2016-08-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14136 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14136: [SPARK-16282][SQL] Implement percentile SQL function.

2016-08-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14136 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63152/ Test PASSed. ---

[GitHub] spark issue #14136: [SPARK-16282][SQL] Implement percentile SQL function.

2016-08-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14136 **[Test build #63152 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63152/consoleFull)** for PR 14136 at commit

[GitHub] spark pull request #14472: [SPARK-16866][SQL] Infrastructure for file-based ...

2016-08-02 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/14472#discussion_r73281256 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala --- @@ -0,0 +1,186 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #14472: [SPARK-16866][SQL] Infrastructure for file-based ...

2016-08-02 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/14472#discussion_r73281270 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala --- @@ -0,0 +1,186 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #14472: [SPARK-16866][SQL] Infrastructure for file-based ...

2016-08-02 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/14472#discussion_r73281221 --- Diff: sql/core/src/test/resources/sql-tests/inputs/number-format.sql --- @@ -0,0 +1,13 @@ +-- Verifies how we parse numbers + +-- parse

[GitHub] spark issue #14446: [SPARK-16841][SQL] Improves the row level metrics perfor...

2016-08-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14446 **[Test build #63154 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63154/consoleFull)** for PR 14446 at commit

[GitHub] spark pull request #14472: [SPARK-16866][SQL] Infrastructure for file-based ...

2016-08-02 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14472#discussion_r73280922 --- Diff: sql/core/src/test/resources/sql-tests/inputs/number-format.sql --- @@ -0,0 +1,13 @@ +-- Verifies how we parse numbers + +-- parse as

[GitHub] spark pull request #14472: [SPARK-16866][SQL] Infrastructure for file-based ...

2016-08-02 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14472#discussion_r73280876 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala --- @@ -0,0 +1,186 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #14472: [SPARK-16866][SQL] Infrastructure for file-based ...

2016-08-02 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14472#discussion_r73280720 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala --- @@ -0,0 +1,186 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #14474: [SPARK-16853][SQL] fixes encoder error in DataSet typed ...

2016-08-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14474 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63151/ Test PASSed. ---

[GitHub] spark issue #14474: [SPARK-16853][SQL] fixes encoder error in DataSet typed ...

2016-08-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14474 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14474: [SPARK-16853][SQL] fixes encoder error in DataSet typed ...

2016-08-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14474 **[Test build #63151 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63151/consoleFull)** for PR 14474 at commit

[GitHub] spark issue #14472: [SPARK-16866][SQL] Infrastructure for file-based SQL end...

2016-08-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14472 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63149/ Test PASSed. ---

[GitHub] spark issue #14472: [SPARK-16866][SQL] Infrastructure for file-based SQL end...

2016-08-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14472 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14472: [SPARK-16866][SQL] Infrastructure for file-based SQL end...

2016-08-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14472 **[Test build #63149 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63149/consoleFull)** for PR 14472 at commit

[GitHub] spark issue #14471: [SPARK-14387][SQL] Exceptions thrown when querying ORC t...

2016-08-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14471 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63150/ Test PASSed. ---

[GitHub] spark issue #14471: [SPARK-14387][SQL] Exceptions thrown when querying ORC t...

2016-08-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14471 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14471: [SPARK-14387][SQL] Exceptions thrown when querying ORC t...

2016-08-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14471 **[Test build #63150 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63150/consoleFull)** for PR 14471 at commit

[GitHub] spark pull request #14475: [SPARK-16862] Configurable buffer size in `Unsafe...

2016-08-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14475#discussion_r73278229 --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillReader.java --- @@ -50,7 +55,19 @@ public

[GitHub] spark issue #13950: [SPARK-15487] [Web UI] Spark Master UI to reverse proxy ...

2016-08-02 Thread gurvindersingh
Github user gurvindersingh commented on the issue: https://github.com/apache/spark/pull/13950 @ajbozarth it seems @tgravescs is busy, is anybody else then who you think could help us in merging this. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request #14475: [SPARK-16862] Configurable buffer size in `Unsafe...

2016-08-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14475#discussion_r73278175 --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillReader.java --- @@ -31,6 +34,8 @@ * of the file format).

[GitHub] spark issue #14444: [SPARK-16839] [SQL] redundant aliases after cleanupAlias...

2016-08-02 Thread eyalfa
Github user eyalfa commented on the issue: https://github.com/apache/spark/pull/1 As a separate till running before CleanupAliases? I'll sketch something later today. On Aug 3, 2016 04:07, "Wenchen Fan" wrote: > I'd like to make

[GitHub] spark issue #14472: [SPARK-16866][SQL] Infrastructure for file-based SQL end...

2016-08-02 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14472 Seems like a good idea. @cloud-fan can you review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #14110: [SPARK-16455] Add a new hook in CoarseGrainedSchedulerBa...

2016-08-02 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14110 cc @kayousterhout --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #14475: [SPARK-16862] Configurable buffer size in `UnsafeSorterS...

2016-08-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14475 **[Test build #63153 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63153/consoleFull)** for PR 14475 at commit

[GitHub] spark pull request #14475: [SPARK-16862] Configurable buffer size in `Unsafe...

2016-08-02 Thread tejasapatil
GitHub user tejasapatil opened a pull request: https://github.com/apache/spark/pull/14475 [SPARK-16862] Configurable buffer size in `UnsafeSorterSpillReader` ## What changes were proposed in this pull request? Jira: https://issues.apache.org/jira/browse/SPARK-16862

[GitHub] spark issue #14475: [SPARK-16862] Configurable buffer size in `UnsafeSorterS...

2016-08-02 Thread tejasapatil
Github user tejasapatil commented on the issue: https://github.com/apache/spark/pull/14475 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #14110: [SPARK-16455] Add a new hook in CoarseGrainedSchedulerBa...

2016-08-02 Thread lovexi
Github user lovexi commented on the issue: https://github.com/apache/spark/pull/14110 Ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #14136: [SPARK-16282][SQL] Implement percentile SQL function.

2016-08-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14136 **[Test build #63152 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63152/consoleFull)** for PR 14136 at commit

[GitHub] spark issue #14474: [SPARK-16853][SQL] fixes encoder error in DataSet typed ...

2016-08-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14474 **[Test build #63151 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63151/consoleFull)** for PR 14474 at commit

[GitHub] spark issue #14470: [SPARK-16863][ML] ProbabilisticClassifier.fit check thre...

2016-08-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14470 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14470: [SPARK-16863][ML] ProbabilisticClassifier.fit check thre...

2016-08-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14470 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63146/ Test PASSed. ---

[GitHub] spark issue #14470: [SPARK-16863][ML] ProbabilisticClassifier.fit check thre...

2016-08-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14470 **[Test build #63146 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63146/consoleFull)** for PR 14470 at commit

[GitHub] spark pull request #14474: [SPARK-16853][SQL] fixes encoder error in DataSet...

2016-08-02 Thread clockfly
GitHub user clockfly opened a pull request: https://github.com/apache/spark/pull/14474 [SPARK-16853][SQL] fixes encoder error in DataSet typed select ## What changes were proposed in this pull request? For DataSet typed select: ``` def select[U1: Encoder](c1:

[GitHub] spark issue #14473: [SPARK-16495] Add ADMM optimizer in mllib package

2016-08-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14473 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #14473: [SPARK-16495] Add ADMM optimizer in mllib package

2016-08-02 Thread ZunwenYou
GitHub user ZunwenYou opened a pull request: https://github.com/apache/spark/pull/14473 [SPARK-16495] Add ADMM optimizer in mllib package Alternating Direction Method of Multipliers (ADMM) is well suited to distributed convex optimization, and in particular to large-scale problems

[GitHub] spark issue #14471: [SPARK-14387][SQL] Exceptions thrown when querying ORC t...

2016-08-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14471 **[Test build #63150 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63150/consoleFull)** for PR 14471 at commit

[GitHub] spark issue #14471: [SPARK-14387][SQL] Exceptions thrown when querying ORC t...

2016-08-02 Thread rajeshbalamohan
Github user rajeshbalamohan commented on the issue: https://github.com/apache/spark/pull/14471 Fixed scalastyle issues --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #14065: [SPARK-14743][YARN] Add a configurable credential manage...

2016-08-02 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/14065 @vanzin , I did refactoring on some interfaces, especially for `obtainCredentials` method, and the implementation of `HDFSCredentialProvider` and `HiveCredential`, would you please help to

[GitHub] spark issue #14472: [SPARK-16866][SQL] Infrastructure for file-based SQL end...

2016-08-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14472 **[Test build #63149 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63149/consoleFull)** for PR 14472 at commit

[GitHub] spark pull request #14472: [SPARK-16866][SQL] Infrastructure for file-based ...

2016-08-02 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/14472#discussion_r73272864 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala --- @@ -0,0 +1,186 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #14472: [SPARK-16866][SQL] Infrastructure for file-based ...

2016-08-02 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/14472#discussion_r73272873 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala --- @@ -0,0 +1,186 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #14472: [SPARK-16866][SQL] Infrastructure for file-based SQL end...

2016-08-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14472 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63148/ Test FAILed. ---

[GitHub] spark issue #14472: [SPARK-16866][SQL] Infrastructure for file-based SQL end...

2016-08-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14472 **[Test build #63148 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63148/consoleFull)** for PR 14472 at commit

[GitHub] spark issue #14472: [SPARK-16866][SQL] Infrastructure for file-based SQL end...

2016-08-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14472 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14472: [SPARK-16866][SQL] Infrastructure for file-based SQL end...

2016-08-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14472 **[Test build #63148 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63148/consoleFull)** for PR 14472 at commit

[GitHub] spark issue #14472: [SPARK-16866][SQL] Infrastructure for file-based SQL end...

2016-08-02 Thread petermaxlee
Github user petermaxlee commented on the issue: https://github.com/apache/spark/pull/14472 cc @cloud-fan and @rxin for feedback. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #14472: [SPARK-16866][SQL] Infrastructure for file-based ...

2016-08-02 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/14472#discussion_r73272687 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala --- @@ -0,0 +1,186 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #14472: [SPARK-16866][SQL] Infrastructure for file-based ...

2016-08-02 Thread petermaxlee
GitHub user petermaxlee opened a pull request: https://github.com/apache/spark/pull/14472 [SPARK-16866][SQL] Infrastructure for file-based SQL end-to-end tests ## What changes were proposed in this pull request? This patch introduces SQLQueryTestSuite, which is a basic framework

[GitHub] spark issue #14471: [SPARK-14387][SQL] Exceptions thrown when querying ORC t...

2016-08-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14471 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63147/ Test FAILed. ---

[GitHub] spark issue #14471: [SPARK-14387][SQL] Exceptions thrown when querying ORC t...

2016-08-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14471 **[Test build #63147 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63147/consoleFull)** for PR 14471 at commit

[GitHub] spark issue #14471: [SPARK-14387][SQL] Exceptions thrown when querying ORC t...

2016-08-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14471 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14450: [SPARK-16847][SQL] Prevent to potentially read corrupt s...

2016-08-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14450 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63145/ Test PASSed. ---

[GitHub] spark issue #14450: [SPARK-16847][SQL] Prevent to potentially read corrupt s...

2016-08-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14450 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14471: [SPARK-14387][SQL] Exceptions thrown when querying ORC t...

2016-08-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14471 **[Test build #63147 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63147/consoleFull)** for PR 14471 at commit

[GitHub] spark issue #14450: [SPARK-16847][SQL] Prevent to potentially read corrupt s...

2016-08-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14450 **[Test build #63145 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63145/consoleFull)** for PR 14450 at commit

[GitHub] spark pull request #12293: [SPARK-14387][SQL] Exceptions thrown when queryin...

2016-08-02 Thread rajeshbalamohan
Github user rajeshbalamohan closed the pull request at: https://github.com/apache/spark/pull/12293 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #12293: [SPARK-14387][SQL] Exceptions thrown when querying ORC t...

2016-08-02 Thread rajeshbalamohan
Github user rajeshbalamohan commented on the issue: https://github.com/apache/spark/pull/12293 @yuananf Thanks for trying it out. I have rebased it and created https://github.com/apache/spark/pull/14471. Closing this one. --- If your project is set up for it, you can reply to this

[GitHub] spark pull request #14471: [SPARK-14387][SQL] Exceptions thrown when queryin...

2016-08-02 Thread rajeshbalamohan
GitHub user rajeshbalamohan opened a pull request: https://github.com/apache/spark/pull/14471 [SPARK-14387][SQL] Exceptions thrown when querying ORC tables ## What changes were proposed in this pull request? This PR improves ORCFileFormat to handle cases when schema stored in

[GitHub] spark issue #14449: [SPARK-16843][MLLIB] add the percentage ChiSquareSelecto...

2016-08-02 Thread mpjlu
Github user mpjlu commented on the issue: https://github.com/apache/spark/pull/14449 Hi @srowen, thanks for your comment. I agree for your comment, user can get the number of features without percentage method. For the user experience, sometimes the percentage method seems

[GitHub] spark issue #13680: [SPARK-15962][SQL] Introduce implementation with a dense...

2016-08-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13680 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13680: [SPARK-15962][SQL] Introduce implementation with a dense...

2016-08-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13680 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63144/ Test PASSed. ---

[GitHub] spark issue #13680: [SPARK-15962][SQL] Introduce implementation with a dense...

2016-08-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13680 **[Test build #63144 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63144/consoleFull)** for PR 13680 at commit

[GitHub] spark issue #14433: [SPARK-16829][SparkR]:sparkR sc.setLogLevel doesn't work

2016-08-02 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14433 awesome! I think we might have a need to create a helper for "am I running in the SparkR shell" function? https://github.com/apache/spark/pull/14258#issuecomment-236336042 --- If

[GitHub] spark issue #14470: [SPARK-16863][ML] ProbabilisticClassifier.fit check thre...

2016-08-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14470 **[Test build #63146 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63146/consoleFull)** for PR 14470 at commit

[GitHub] spark pull request #14470: [SPARK-16863][ML] ProbabilisticClassifier.fit che...

2016-08-02 Thread zhengruifeng
GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/14470 [SPARK-16863][ML] ProbabilisticClassifier.fit check threshoulds' length ## What changes were proposed in this pull request? Add threshoulds' length checking for Classifiers which

[GitHub] spark issue #14468: [SPARK-16671][core][sql] Consolidate code to do variable...

2016-08-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14468 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14468: [SPARK-16671][core][sql] Consolidate code to do variable...

2016-08-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14468 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63142/ Test PASSed. ---

[GitHub] spark issue #14468: [SPARK-16671][core][sql] Consolidate code to do variable...

2016-08-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14468 **[Test build #63142 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63142/consoleFull)** for PR 14468 at commit

[GitHub] spark issue #13624: [SPARK-15858][ML]: Fix calculating error by tree stack o...

2016-08-02 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/13624 @mhmoudr There were a few follow-up comments on your PR commit, visible here: [https://github.com/apache/spark/commit/393db655c3c43155305fbba1b2f8c48a95f18d93] Could you please send a quick

[GitHub] spark issue #14444: [SPARK-16839] [SQL] redundant aliases after cleanupAlias...

2016-08-02 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/1 I'd like to make `CreateStruct` just a place holder, and create a new rule in `Analyzer` to always convert `CreateStruct` to `CreateNamedStruct` --- If your project is set up for it, you can

[GitHub] spark issue #14450: [SPARK-16847][SQL] Prevent to potentially read corrupt s...

2016-08-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14450 **[Test build #63145 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63145/consoleFull)** for PR 14450 at commit

[GitHub] spark pull request #14458: [SQL][minor] use stricter type parameter to make ...

2016-08-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14458 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #14458: [SQL][minor] use stricter type parameter to make it clea...

2016-08-02 Thread liancheng
Github user liancheng commented on the issue: https://github.com/apache/spark/pull/14458 LGTM, merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #14469: [SPARK-16700] [PYSPARK] [SQL] create DataFrame from dict...

2016-08-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14469 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63143/ Test FAILed. ---

[GitHub] spark issue #14469: [SPARK-16700] [PYSPARK] [SQL] create DataFrame from dict...

2016-08-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14469 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13680: [SPARK-15962][SQL] Introduce implementation with a dense...

2016-08-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13680 **[Test build #63144 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63144/consoleFull)** for PR 13680 at commit

  1   2   3   4   5   >