[GitHub] spark issue #12819: [SPARK-14077][ML] Refactor NaiveBayes to support weighte...

2016-08-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/12819 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63341/ Test PASSed. ---

[GitHub] spark issue #12819: [SPARK-14077][ML] Refactor NaiveBayes to support weighte...

2016-08-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/12819 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #12819: [SPARK-14077][ML] Refactor NaiveBayes to support weighte...

2016-08-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12819 **[Test build #63341 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63341/consoleFull)** for PR 12819 at commit

[GitHub] spark pull request #13704: [SPARK-15985][SQL] Eliminate redundant cast from ...

2016-08-07 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/13704#discussion_r73824598 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -1441,6 +1441,12 @@ object PushPredicateThroughJoin

[GitHub] spark pull request #14522: [Spark-16508][SparkR] Split docs for arrange and ...

2016-08-07 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14522#discussion_r73824558 --- Diff: R/pkg/R/generics.R --- @@ -551,7 +551,7 @@ setGeneric("merge") #' @export setGeneric("mutate", function(.data, ...)

[GitHub] spark issue #13758: [SPARK-16043][SQL] Prepare GenericArrayData implementati...

2016-08-07 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/13758 @hvanhovell , @cloud-fan , @davies would it be possible to review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #11956: [SPARK-14098][SQL] Generate Java code that gets a float/...

2016-08-07 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/11956 @davies, I hope that you have some bandwidth to review PRs. Could you please review this, too? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request #14522: [Spark-16508][SparkR] Split docs for arrange and ...

2016-08-07 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14522#discussion_r73824520 --- Diff: R/pkg/R/WindowSpec.R --- @@ -82,16 +82,18 @@ setMethod("partitionBy", } }) -#' orderBy +#'

[GitHub] spark pull request #14522: [Spark-16508][SparkR] Split docs for arrange and ...

2016-08-07 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14522#discussion_r73824487 --- Diff: R/pkg/R/DataFrame.R --- @@ -2121,7 +2121,7 @@ setMethod("arrange", }) #' @rdname arrange -#' @name orderBy

[GitHub] spark issue #14113: [SPARK-16457] [SQL] Fix Wrong Messages when CTAS with a ...

2016-08-07 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14113 LGTM, pending jenkins --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #14533: [SPARK-16606] [CORE] isleading warning for SparkContext....

2016-08-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14533 **[Test build #63344 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63344/consoleFull)** for PR 14533 at commit

[GitHub] spark pull request #14522: [Spark-16508][SparkR] Split docs for arrange and ...

2016-08-07 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14522#discussion_r73824170 --- Diff: R/pkg/R/WindowSpec.R --- @@ -82,10 +82,18 @@ setMethod("partitionBy", } }) -#' @rdname orderBy

[GitHub] spark pull request #14533: [SPARK-16606] [CORE] isleading warning for SparkC...

2016-08-07 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/14533 [SPARK-16606] [CORE] isleading warning for SparkContext.getOrCreate "WARN SparkContext: Use an existing SparkContext, some configuration may not take effect." ## What changes were proposed in this

[GitHub] spark pull request #14489: [MINOR][SparkR] R API documentation for "coltypes...

2016-08-07 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14489#discussion_r73823955 --- Diff: R/pkg/R/DataFrame.R --- @@ -411,7 +411,7 @@ setMethod("coltypes", #' #' Set the column types of a SparkDataFrame. #' -#'

[GitHub] spark issue #14113: [SPARK-16457] [SQL] Fix Wrong Messages when CTAS with a ...

2016-08-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14113 **[Test build #63343 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63343/consoleFull)** for PR 14113 at commit

[GitHub] spark pull request #14507: [SPARK-16919] Configurable update interval for co...

2016-08-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14507 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #14532: SPARK-16945: Fix Java Lint errors

2016-08-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14532 **[Test build #63342 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63342/consoleFull)** for PR 14532 at commit

[GitHub] spark pull request #14175: [SPARK-16522][MESOS] Spark application throws exc...

2016-08-07 Thread mgummelt
Github user mgummelt commented on a diff in the pull request: https://github.com/apache/spark/pull/14175#discussion_r73823481 --- Diff: core/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackendSuite.scala --- @@ -396,6 +425,10 @@ class

[GitHub] spark issue #14507: [SPARK-16919] Configurable update interval for console p...

2016-08-07 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14507 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #14175: [SPARK-16522][MESOS] Spark application throws exception ...

2016-08-07 Thread mgummelt
Github user mgummelt commented on the issue: https://github.com/apache/spark/pull/14175 A couple minor style issues then LGTM. Will ping the committer when style issues are resolved. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request #14175: [SPARK-16522][MESOS] Spark application throws exc...

2016-08-07 Thread mgummelt
Github user mgummelt commented on a diff in the pull request: https://github.com/apache/spark/pull/14175#discussion_r73823297 --- Diff: core/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackendSuite.scala --- @@ -341,6 +344,32 @@ class

[GitHub] spark issue #14422: Add rand(numRows: Int, numCols: Int) functions

2016-08-07 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14422 @xubo245 you need to close the issues, we can't do so directly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request #14175: [SPARK-16522][MESOS] Spark application throws exc...

2016-08-07 Thread mgummelt
Github user mgummelt commented on a diff in the pull request: https://github.com/apache/spark/pull/14175#discussion_r73823241 --- Diff: core/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackendSuite.scala --- @@ -341,6 +344,32 @@ class

[GitHub] spark pull request #14175: [SPARK-16522][MESOS] Spark application throws exc...

2016-08-07 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/14175#discussion_r73823225 --- Diff: core/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackendSuite.scala --- @@ -396,6 +425,10 @@ class

[GitHub] spark issue #14532: SPARK-16945: Fix Java Lint errors

2016-08-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14532 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #14532: SPARK-16945: Fix Java Lint errors

2016-08-07 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14532 Jenkins test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #14532: SPARK-16945: Fix Java Lint errors

2016-08-07 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14532 Thank you, yeah was going to fix those. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #14532: SPARK-16945: Fix Java Lint errors

2016-08-07 Thread Sherry302
GitHub user Sherry302 opened a pull request: https://github.com/apache/spark/pull/14532 SPARK-16945: Fix Java Lint errors ## What changes were proposed in this pull request? This PR is to fix the minor Java linter errors as following: [ERROR]

[GitHub] spark pull request #14530: [SPARK-16868][Web Ui] Fix executor be both dead a...

2016-08-07 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14530#discussion_r73823171 --- Diff: core/src/main/scala/org/apache/spark/storage/StorageStatusListener.scala --- @@ -77,6 +77,18 @@ class StorageStatusListener(conf: SparkConf)

[GitHub] spark pull request #14175: [SPARK-16522][MESOS] Spark application throws exc...

2016-08-07 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/14175#discussion_r73823074 --- Diff: core/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackendSuite.scala --- @@ -341,6 +344,32 @@ class

[GitHub] spark pull request #14175: [SPARK-16522][MESOS] Spark application throws exc...

2016-08-07 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/14175#discussion_r73823040 --- Diff: core/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackendSuite.scala --- @@ -341,6 +344,32 @@ class

[GitHub] spark issue #10212: [SPARK-12221] add cpu time to metrics

2016-08-07 Thread jisookim0513
Github user jisookim0513 commented on the issue: https://github.com/apache/spark/pull/10212 @vanzin sure will do --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #14175: [SPARK-16522][MESOS] Spark application throws exc...

2016-08-07 Thread mgummelt
Github user mgummelt commented on a diff in the pull request: https://github.com/apache/spark/pull/14175#discussion_r73822922 --- Diff: core/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackendSuite.scala --- @@ -341,6 +344,32 @@ class

[GitHub] spark issue #12819: [SPARK-14077][ML] Refactor NaiveBayes to support weighte...

2016-08-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12819 **[Test build #63341 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63341/consoleFull)** for PR 12819 at commit

[GitHub] spark issue #14411: [SPARK-16804][SQL] Correlated subqueries containing non-...

2016-08-07 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14411 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #14523: [SPARK-16936] [SQL] Case Sensitivity Support for Refresh...

2016-08-07 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14523 This is not a regression, but Spark 2.0 has the issue. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #14523: [SPARK-16936] [SQL] Case Sensitivity Support for Refresh...

2016-08-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14523 **[Test build #63340 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63340/consoleFull)** for PR 14523 at commit

[GitHub] spark pull request #14175: [SPARK-16522][MESOS] Spark application throws exc...

2016-08-07 Thread mgummelt
Github user mgummelt commented on a diff in the pull request: https://github.com/apache/spark/pull/14175#discussion_r73822562 --- Diff: core/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackendSuite.scala --- @@ -341,6 +344,32 @@ class

[GitHub] spark pull request #14175: [SPARK-16522][MESOS] Spark application throws exc...

2016-08-07 Thread mgummelt
Github user mgummelt commented on a diff in the pull request: https://github.com/apache/spark/pull/14175#discussion_r73822546 --- Diff: core/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackendSuite.scala --- @@ -396,6 +425,10 @@ class

[GitHub] spark issue #13701: [SPARK-15639][SPARK-16321][SQL] Push down filter at RowG...

2016-08-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13701 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63337/ Test PASSed. ---

[GitHub] spark issue #13701: [SPARK-15639][SPARK-16321][SQL] Push down filter at RowG...

2016-08-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13701 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13701: [SPARK-15639][SPARK-16321][SQL] Push down filter at RowG...

2016-08-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13701 **[Test build #63337 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63337/consoleFull)** for PR 13701 at commit

[GitHub] spark issue #14511: [SPARK-16927] [SPARK-16923] Override task properties at ...

2016-08-07 Thread mgummelt
Github user mgummelt commented on the issue: https://github.com/apache/spark/pull/14511 retest please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark pull request #13893: [SPARK-14172][SQL] Hive table partition predicate...

2016-08-07 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/13893#discussion_r73821493 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala --- @@ -64,10 +64,17 @@ object PhysicalOperation extends

[GitHub] spark issue #14531: [SPARK-16943] [SPARK-16942] [SQL] Fix multiple bugs in C...

2016-08-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14531 **[Test build #63339 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63339/consoleFull)** for PR 14531 at commit

[GitHub] spark pull request #14531: [SPARK-16943] [SPAR] [SQL] Fix multiple bugs in C...

2016-08-07 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/14531 [SPARK-16943] [SPAR] [SQL] Fix multiple bugs in CREATE TABLE LIKE command ### What changes were proposed in this pull request? ### How was this patch tested? Added a few test

[GitHub] spark issue #12819: [SPARK-14077][ML] Refactor NaiveBayes to support weighte...

2016-08-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/12819 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63338/ Test FAILed. ---

[GitHub] spark issue #12819: [SPARK-14077][ML] Refactor NaiveBayes to support weighte...

2016-08-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/12819 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #12819: [SPARK-14077][ML] Refactor NaiveBayes to support weighte...

2016-08-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12819 **[Test build #63338 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63338/consoleFull)** for PR 12819 at commit

[GitHub] spark pull request #13886: [SPARK-16185] [SQL] Better Error Messages When Cr...

2016-08-07 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/13886#discussion_r73820673 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -357,6 +357,10 @@ trait CheckAnalysis extends

[GitHub] spark issue #14410: [SPARK-16803] [SQL] SaveAsTable does not work when sourc...

2016-08-07 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14410 @cloud-fan Sure, will do it soon. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #14113: [SPARK-16457] [SQL] Fix Wrong Messages when CTAS with a ...

2016-08-07 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14113 Will update it tonight. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #14530: [SPARK-16868][Web Ui] Fix executor be both dead and aliv...

2016-08-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14530 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63335/ Test PASSed. ---

[GitHub] spark issue #14530: [SPARK-16868][Web Ui] Fix executor be both dead and aliv...

2016-08-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14530 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14530: [SPARK-16868][Web Ui] Fix executor be both dead and aliv...

2016-08-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14530 **[Test build #63335 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63335/consoleFull)** for PR 14530 at commit

[GitHub] spark issue #14518: [SPARK-16610][SQL] Add `orc.compress` as an alias for `c...

2016-08-07 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14518 IMHO, I would prefer `compression` over `orc.compress` because I believe we should promote to use `compression` rather than `orc.compress` for consistency with other datasources. As

[GitHub] spark issue #14155: [SPARK-16498][SQL] move hive hack for data source table ...

2016-08-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14155 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63336/ Test PASSed. ---

[GitHub] spark issue #14155: [SPARK-16498][SQL] move hive hack for data source table ...

2016-08-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14155 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14155: [SPARK-16498][SQL] move hive hack for data source table ...

2016-08-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14155 **[Test build #63336 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63336/consoleFull)** for PR 14155 at commit

[GitHub] spark issue #12819: [SPARK-14077][ML] Refactor NaiveBayes to support weighte...

2016-08-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12819 **[Test build #63338 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63338/consoleFull)** for PR 12819 at commit

[GitHub] spark issue #14518: [SPARK-16610][SQL] Add `orc.compress` as an alias for `c...

2016-08-07 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14518 What if users set both `compression` and `orc.compress`? It looks to me that `orc.compress` is for ORC only and should have higher priority over `compression` in ORC data source. cc

[GitHub] spark issue #13867: [SPARK-16161][SQL] Ambiguous error message for unsupport...

2016-08-07 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13867 cc @hvanhovell --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #14113: [SPARK-16457] [SQL] Fix Wrong Messages when CTAS with a ...

2016-08-07 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14113 can you update it? thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #13886: [SPARK-16185] [SQL] Better Error Messages When Cr...

2016-08-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13886#discussion_r73817954 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -357,6 +357,10 @@ trait CheckAnalysis extends

[GitHub] spark pull request #14472: [SPARK-16866][SQL] Infrastructure for file-based ...

2016-08-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14472#discussion_r73817418 --- Diff: sql/core/src/test/resources/sql-tests/results/number-format.sql.out --- @@ -0,0 +1,50 @@ +-- Automatically generated by

[GitHub] spark issue #14529: [TRIVIAL][SQL] Match the name of OrcRelation companion o...

2016-08-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14529 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63334/ Test PASSed. ---

[GitHub] spark issue #13701: [SPARK-15639][SPARK-16321][SQL] Push down filter at RowG...

2016-08-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13701 **[Test build #63337 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63337/consoleFull)** for PR 13701 at commit

[GitHub] spark issue #14529: [TRIVIAL][SQL] Match the name of OrcRelation companion o...

2016-08-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14529 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14529: [TRIVIAL][SQL] Match the name of OrcRelation companion o...

2016-08-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14529 **[Test build #63334 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63334/consoleFull)** for PR 14529 at commit

[GitHub] spark issue #14218: [SPARK-16563][SQL] fix spark sql thrift server FetchResu...

2016-08-07 Thread ericl
Github user ericl commented on the issue: https://github.com/apache/spark/pull/14218 Lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #14411: [SPARK-16804][SQL] Correlated subqueries containing non-...

2016-08-07 Thread nsyca
Github user nsyca commented on the issue: https://github.com/apache/spark/pull/14411 Thanks, @gatorsmile. This time I ran `dev/lint-scala`. Hope it's my last attempt to get this work thru. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request #14472: [SPARK-16866][SQL] Infrastructure for file-based ...

2016-08-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14472#discussion_r73816313 --- Diff: dev/.rat-excludes --- @@ -99,4 +99,5 @@ spark-deps-.* .*tsv org.apache.spark.scheduler.ExternalClusterManager .*\.sql

[GitHub] spark issue #14528: [SPARK-16940][SQL] `checkAnswer` should raise `TestFaile...

2016-08-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14528 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63332/ Test PASSed. ---

[GitHub] spark issue #14528: [SPARK-16940][SQL] `checkAnswer` should raise `TestFaile...

2016-08-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14528 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14528: [SPARK-16940][SQL] `checkAnswer` should raise `TestFaile...

2016-08-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14528 **[Test build #63332 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63332/consoleFull)** for PR 14528 at commit

[GitHub] spark issue #14518: [SPARK-16610][SQL] Add `orc.compress` as an alias for `c...

2016-08-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14518 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/6/ Test PASSed. ---

[GitHub] spark issue #14518: [SPARK-16610][SQL] Add `orc.compress` as an alias for `c...

2016-08-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14518 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14518: [SPARK-16610][SQL] Add `orc.compress` as an alias for `c...

2016-08-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14518 **[Test build #6 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/6/consoleFull)** for PR 14518 at commit

[GitHub] spark issue #14065: [SPARK-14743][YARN] Add a configurable credential manage...

2016-08-07 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/14065 @vazin, looks like I missed that comment, I will address that today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #14518: [SPARK-16610][SQL] Add `orc.compress` as an alias for `c...

2016-08-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14518 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14518: [SPARK-16610][SQL] Add `orc.compress` as an alias for `c...

2016-08-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14518 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63331/ Test PASSed. ---

[GitHub] spark issue #14518: [SPARK-16610][SQL] Add `orc.compress` as an alias for `c...

2016-08-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14518 **[Test build #63331 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63331/consoleFull)** for PR 14518 at commit

[GitHub] spark issue #14155: [SPARK-16498][SQL] move hive hack for data source table ...

2016-08-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14155 **[Test build #63336 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63336/consoleFull)** for PR 14155 at commit

[GitHub] spark issue #14530: [SPARK-16868][Web Ui] Fix executor be both dead and aliv...

2016-08-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14530 **[Test build #63335 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63335/consoleFull)** for PR 14530 at commit

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r73815242 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -1218,11 +1151,6 @@ class DDLSuite extends QueryTest with

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r73815246 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -1523,12 +1451,6 @@ class DDLSuite extends QueryTest with

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r73815233 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -1109,11 +1047,6 @@ class DDLSuite extends QueryTest with

[GitHub] spark pull request #14530: [SPARK-16868][Web Ui] Fix executor be both dead a...

2016-08-07 Thread SaintBacchus
GitHub user SaintBacchus opened a pull request: https://github.com/apache/spark/pull/14530 [SPARK-16868][Web Ui] Fix executor be both dead and alive on executor ui. ## What changes were proposed in this pull request? In a heavy pressure of the spark application, since the

[GitHub] spark issue #14523: [SPARK-16936] [SQL] Case Sensitivity Support for Refresh...

2016-08-07 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14523 LGTM, is it a regression for 2.0? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #14523: [SPARK-16936] [SQL] Case Sensitivity Support for ...

2016-08-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14523#discussion_r73814553 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/MetadataCacheSuite.scala --- @@ -85,4 +86,28 @@ class MetadataCacheSuite extends QueryTest with

[GitHub] spark issue #14410: [SPARK-16803] [SQL] SaveAsTable does not work when sourc...

2016-08-07 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14410 Hi @gatorsmile can you send out a PR first? We definitely need it for 2.1, and we can decide if we should backport it to 2.0 later. --- If your project is set up for it, you can reply to this

[GitHub] spark issue #14410: [SPARK-16803] [SQL] SaveAsTable does not work when sourc...

2016-08-07 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14410 now I think it's easy to catch `saveAsTable` for hive tables: `case CreateTable(tableDesc, SaveMode.APPEND, Some(query)) if tableDesc.provider.get != "hive" =>` We can add a new rule

[GitHub] spark pull request #13818: [SPARK-15968][SQL] Nonempty partitioned metastore...

2016-08-07 Thread erfangc
Github user erfangc commented on a diff in the pull request: https://github.com/apache/spark/pull/13818#discussion_r73814190 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala --- @@ -298,6 +298,7 @@ case class InsertIntoHiveTable(

[GitHub] spark issue #14389: [SPARK-16714][SQL] Refactor type widening for consistenc...

2016-08-07 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14389 to refactor the type widen rules, i.e. we only need 2 rules: `findWiderType` and `findWiderTypeAndPromoteToString`. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark issue #14523: [SPARK-16936] [SQL] Case Sensitivity Support for Refresh...

2016-08-07 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14523 cc @rxin @cloud-fan This is a simple fix. Could you review the fix? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request #13680: [SPARK-15962][SQL] Introduce implementation with ...

2016-08-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13680#discussion_r73814104 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java --- @@ -25,55 +25,57 @@ import

[GitHub] spark issue #14218: [SPARK-16563][SQL] fix spark sql thrift server FetchResu...

2016-08-07 Thread alicegugu
Github user alicegugu commented on the issue: https://github.com/apache/spark/pull/14218 @ericl thanks for the comments, comments incorporated in new commit --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #14529: [TRIVIAL][SQL] Match the name of OrcRelation companion o...

2016-08-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14529 **[Test build #63334 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63334/consoleFull)** for PR 14529 at commit

[GitHub] spark issue #14529: [TRIVIAL][SQL] Match the name of OrcRelation companion o...

2016-08-07 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14529 BTW, `CSVRelation` also exists in a separate file but https://github.com/apache/spark/pull/13988 includes this change. --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request #13818: [SPARK-15968][SQL] Nonempty partitioned metastore...

2016-08-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13818#discussion_r73813847 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala --- @@ -298,6 +298,7 @@ case class InsertIntoHiveTable(

  1   2   3   >