[GitHub] spark issue #14850: [SPARK-17279][SQL] better error message for exceptions d...

2016-09-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14850 **[Test build #64833 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64833/consoleFull)** for PR 14850 at commit

[GitHub] spark pull request #14079: [SPARK-8425][CORE] New Blacklist Mechanism

2016-09-01 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/14079#discussion_r77296679 --- Diff: core/src/test/scala/org/apache/spark/scheduler/BlacklistTrackerSuite.scala --- @@ -0,0 +1,503 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #12601: [SPARK-14525][SQL] Make DataFrameWrite.save work for jdb...

2016-09-01 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/12601 It sounds like you understand my points. Then, please update your PR based on my latest changes and we can review your PR. Thanks! --- If your project is set up for it, you can reply to this

[GitHub] spark pull request #14079: [SPARK-8425][CORE] New Blacklist Mechanism

2016-09-01 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/14079#discussion_r77296487 --- Diff: core/src/test/scala/org/apache/spark/scheduler/BlacklistTrackerSuite.scala --- @@ -0,0 +1,503 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #14079: [SPARK-8425][CORE] New Blacklist Mechanism

2016-09-01 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/14079#discussion_r77296415 --- Diff: core/src/test/scala/org/apache/spark/scheduler/BlacklistTrackerSuite.scala --- @@ -0,0 +1,503 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #14079: [SPARK-8425][CORE] New Blacklist Mechanism

2016-09-01 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/14079#discussion_r77296312 --- Diff: core/src/test/scala/org/apache/spark/scheduler/BlacklistTrackerSuite.scala --- @@ -0,0 +1,503 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #14079: [SPARK-8425][CORE] New Blacklist Mechanism

2016-09-01 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/14079#discussion_r77296176 --- Diff: core/src/test/scala/org/apache/spark/scheduler/BlacklistTrackerSuite.scala --- @@ -0,0 +1,503 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #14079: [SPARK-8425][CORE] New Blacklist Mechanism

2016-09-01 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/14079#discussion_r77296120 --- Diff: core/src/test/scala/org/apache/spark/scheduler/BlacklistTrackerSuite.scala --- @@ -0,0 +1,503 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #14079: [SPARK-8425][CORE] New Blacklist Mechanism

2016-09-01 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/14079#discussion_r77296072 --- Diff: core/src/test/scala/org/apache/spark/scheduler/BlacklistTrackerSuite.scala --- @@ -0,0 +1,503 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #14079: [SPARK-8425][CORE] New Blacklist Mechanism

2016-09-01 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/14079#discussion_r77295971 --- Diff: core/src/test/scala/org/apache/spark/scheduler/BlacklistTrackerSuite.scala --- @@ -0,0 +1,503 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #14079: [SPARK-8425][CORE] New Blacklist Mechanism

2016-09-01 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/14079#discussion_r77296004 --- Diff: core/src/test/scala/org/apache/spark/scheduler/BlacklistTrackerSuite.scala --- @@ -0,0 +1,503 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #14921: [SPARK-17361][SQL] file-based external table with...

2016-09-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14921#discussion_r77295817 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -314,12 +314,8 @@ case class DataSource( /**

[GitHub] spark pull request #14809: [SPARK-17238][SQL] simplify the logic for convert...

2016-09-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14809#discussion_r77295778 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -241,10 +241,21 @@ private[spark] class

[GitHub] spark issue #14921: [SPARK-17361][SQL] file-based external table without pat...

2016-09-01 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14921 @clockfly updated, the only external behavior change is what I fixed in this PR: creating file-based external table without path will fail. --- If your project is set up for it, you can reply to

[GitHub] spark pull request #14079: [SPARK-8425][CORE] New Blacklist Mechanism

2016-09-01 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/14079#discussion_r77295487 --- Diff: core/src/test/scala/org/apache/spark/scheduler/BlacklistTrackerSuite.scala --- @@ -0,0 +1,503 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #14773: [SPARK-17203][SQL] data source options should alw...

2016-09-01 Thread clockfly
Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/14773#discussion_r77295324 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ddl.scala --- @@ -90,17 +90,31 @@ case class RefreshResource(path: String)

[GitHub] spark pull request #14931: [SPARK-17370] Shuffle service files not invalidat...

2016-09-01 Thread mateiz
Github user mateiz commented on a diff in the pull request: https://github.com/apache/spark/pull/14931#discussion_r77294974 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala --- @@ -346,15 +346,16 @@ private[spark] class TaskSchedulerImpl(

[GitHub] spark issue #14915: [SPARK-17356][SQL] Fix out of memory issue when generati...

2016-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14915 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64828/ Test PASSed. ---

[GitHub] spark issue #14915: [SPARK-17356][SQL] Fix out of memory issue when generati...

2016-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14915 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #14773: [SPARK-17203][SQL] data source options should alw...

2016-09-01 Thread clockfly
Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/14773#discussion_r77294893 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ddl.scala --- @@ -90,17 +90,31 @@ case class RefreshResource(path: String)

[GitHub] spark issue #14915: [SPARK-17356][SQL] Fix out of memory issue when generati...

2016-09-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14915 **[Test build #64828 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64828/consoleFull)** for PR 14915 at commit

[GitHub] spark pull request #14809: [SPARK-17238][SQL] simplify the logic for convert...

2016-09-01 Thread clockfly
Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/14809#discussion_r77294000 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -272,17 +282,11 @@ private[spark] class

[GitHub] spark issue #12601: [SPARK-14525][SQL] Make DataFrameWrite.save work for jdb...

2016-09-01 Thread JustinPihony
Github user JustinPihony commented on the issue: https://github.com/apache/spark/pull/12601 Yes I realize that `SchemaRelationProvider` is not necessary, but the legwork has already been done, so why not take advantage of it. Even still, this original PR is actually not that far from

[GitHub] spark pull request #14809: [SPARK-17238][SQL] simplify the logic for convert...

2016-09-01 Thread clockfly
Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/14809#discussion_r77293800 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -241,10 +241,21 @@ private[spark] class

[GitHub] spark issue #14850: [SPARK-17279][SQL] better error message for exceptions d...

2016-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14850 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14850: [SPARK-17279][SQL] better error message for exceptions d...

2016-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14850 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64829/ Test FAILed. ---

[GitHub] spark issue #14850: [SPARK-17279][SQL] better error message for exceptions d...

2016-09-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14850 **[Test build #64829 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64829/consoleFull)** for PR 14850 at commit

[GitHub] spark issue #14924: [SPARK-17299] TRIM/LTRIM/RTRIM should not strips charact...

2016-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14924 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14924: [SPARK-17299] TRIM/LTRIM/RTRIM should not strips charact...

2016-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14924 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64827/ Test PASSed. ---

[GitHub] spark issue #14834: [SPARK-17163][ML][WIP] Unified LogisticRegression interf...

2016-09-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14834 **[Test build #64832 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64832/consoleFull)** for PR 14834 at commit

[GitHub] spark issue #14924: [SPARK-17299] TRIM/LTRIM/RTRIM should not strips charact...

2016-09-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14924 **[Test build #64827 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64827/consoleFull)** for PR 14924 at commit

[GitHub] spark pull request #14850: [SPARK-17279][SQL] better error message for excep...

2016-09-01 Thread clockfly
Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/14850#discussion_r77292898 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala --- @@ -1039,9 +1033,18 @@ case class ScalaUDF(

[GitHub] spark issue #14834: [SPARK-17163][ML][WIP] Unified LogisticRegression interf...

2016-09-01 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/14834 @yanboliang Thanks for the tip. Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #14921: [SPARK-17361][SQL] file-based external table with...

2016-09-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14921#discussion_r77292804 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -314,12 +314,8 @@ case class DataSource( /**

[GitHub] spark issue #14921: [SPARK-17361][SQL] createExternalTable should fail if pa...

2016-09-01 Thread clockfly
Github user clockfly commented on the issue: https://github.com/apache/spark/pull/14921 @cloud-fan Can you update the PR tile and PR description to be more user-facing. For example, it is better to use "CREATE TABLE ..USING.." in the PR title. It is also better to list

[GitHub] spark issue #14834: [SPARK-17163][ML][WIP] Unified LogisticRegression interf...

2016-09-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14834 **[Test build #64831 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64831/consoleFull)** for PR 14834 at commit

[GitHub] spark pull request #14921: [SPARK-17361][SQL] createExternalTable should fai...

2016-09-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14921#discussion_r77292635 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -314,12 +314,8 @@ case class DataSource( /**

[GitHub] spark pull request #14921: [SPARK-17361][SQL] createExternalTable should fai...

2016-09-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14921#discussion_r77292575 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -314,12 +314,8 @@ case class DataSource( /**

[GitHub] spark pull request #14921: [SPARK-17361][SQL] createExternalTable should fai...

2016-09-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14921#discussion_r77292542 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -314,12 +314,8 @@ case class DataSource( /**

[GitHub] spark pull request #14921: [SPARK-17361][SQL] createExternalTable should fai...

2016-09-01 Thread clockfly
Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/14921#discussion_r77292448 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -314,12 +314,8 @@ case class DataSource( /**

[GitHub] spark pull request #14921: [SPARK-17361][SQL] createExternalTable should fai...

2016-09-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14921#discussion_r77292357 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -314,12 +314,8 @@ case class DataSource( /**

[GitHub] spark issue #14921: [SPARK-17361][SQL] createExternalTable should fail if pa...

2016-09-01 Thread clockfly
Github user clockfly commented on the issue: https://github.com/apache/spark/pull/14921 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request #14883: [SPARK-17319] [SQL] Move addJar from HiveSessionS...

2016-09-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14883#discussion_r77292196 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala --- @@ -184,4 +184,17 @@ abstract class

[GitHub] spark pull request #14921: [SPARK-17361][SQL] createExternalTable should fai...

2016-09-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14921#discussion_r77291908 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -314,12 +314,8 @@ case class DataSource( /**

[GitHub] spark issue #14933: [SPARK-16533][CORE] - backport driver deadlock fix to 2....

2016-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14933 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #14933: [SPARK-16533][CORE] - backport driver deadlock fi...

2016-09-01 Thread angolon
GitHub user angolon opened a pull request: https://github.com/apache/spark/pull/14933 [SPARK-16533][CORE] - backport driver deadlock fix to 2.0 ## What changes were proposed in this pull request? Backport changes from #14710 and #14925 to 2.0 You can merge this pull request

[GitHub] spark pull request #14883: [SPARK-17319] [SQL] Move addJar from HiveSessionS...

2016-09-01 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/14883#discussion_r77291638 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala --- @@ -184,4 +184,17 @@ abstract class ExternalCatalog {

[GitHub] spark issue #14921: [SPARK-17361][SQL] createExternalTable should fail if pa...

2016-09-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14921 **[Test build #64830 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64830/consoleFull)** for PR 14921 at commit

[GitHub] spark issue #13584: [SPARK-15509][ML][SparkR] R MLlib algorithms should supp...

2016-09-01 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/13584 LGTM - @felixcheung Feel free to merge when its ready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #14850: [SPARK-17279][SQL] better error message for exceptions d...

2016-09-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14850 **[Test build #64829 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64829/consoleFull)** for PR 14850 at commit

[GitHub] spark issue #14854: [SPARK-17283][Core] Cancel job in RDD.take() as soon as ...

2016-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14854 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64826/ Test FAILed. ---

[GitHub] spark issue #14854: [SPARK-17283][Core] Cancel job in RDD.take() as soon as ...

2016-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14854 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14854: [SPARK-17283][Core] Cancel job in RDD.take() as soon as ...

2016-09-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14854 **[Test build #64826 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64826/consoleFull)** for PR 14854 at commit

[GitHub] spark issue #13584: [SPARK-15509][ML][SparkR] R MLlib algorithms should supp...

2016-09-01 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/13584 LGTM. @shivaram do you have any other comment? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #13584: [SPARK-15509][ML][SparkR] R MLlib algorithms shou...

2016-09-01 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/13584#discussion_r77290933 --- Diff: mllib/src/main/scala/org/apache/spark/ml/r/RWrapperUtils.scala --- @@ -35,13 +35,37 @@ object RWrapperUtils extends Logging { */

[GitHub] spark pull request #14921: [SPARK-17361][SQL] createExternalTable should fai...

2016-09-01 Thread clockfly
Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/14921#discussion_r77290803 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -314,12 +314,8 @@ case class DataSource( /**

[GitHub] spark pull request #14883: [SPARK-17319] [SQL] Move addJar from HiveSessionS...

2016-09-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14883#discussion_r77290783 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala --- @@ -184,4 +184,17 @@ abstract class

[GitHub] spark pull request #14921: [SPARK-17361][SQL] createExternalTable should fai...

2016-09-01 Thread clockfly
Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/14921#discussion_r77290773 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -314,12 +314,8 @@ case class DataSource( /**

[GitHub] spark pull request #14866: [SPARK-17298][SQL] Require explicit CROSS join fo...

2016-09-01 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14866#discussion_r77290718 --- Diff: R/pkg/R/DataFrame.R --- @@ -2265,7 +2265,7 @@ setMethod("join", signature(x = "SparkDataFrame", y = "SparkDataFrame"),

[GitHub] spark issue #14932: [SPARK-17371] Resubmitted shuffle outputs can get delete...

2016-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14932 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14932: [SPARK-17371] Resubmitted shuffle outputs can get delete...

2016-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14932 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64824/ Test PASSed. ---

[GitHub] spark issue #14932: [SPARK-17371] Resubmitted shuffle outputs can get delete...

2016-09-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14932 **[Test build #64824 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64824/consoleFull)** for PR 14932 at commit

[GitHub] spark pull request #14883: [SPARK-17319] [SQL] Move addJar from HiveSessionS...

2016-09-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14883#discussion_r77290382 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala --- @@ -184,4 +184,17 @@ abstract class

[GitHub] spark issue #14931: [SPARK-17370] Shuffle service files not invalidated when...

2016-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14931 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64823/ Test PASSed. ---

[GitHub] spark issue #14931: [SPARK-17370] Shuffle service files not invalidated when...

2016-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14931 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14931: [SPARK-17370] Shuffle service files not invalidated when...

2016-09-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14931 **[Test build #64823 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64823/consoleFull)** for PR 14931 at commit

[GitHub] spark issue #14915: [SPARK-17356][SQL] Fix out of memory issue when generati...

2016-09-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14915 **[Test build #64828 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64828/consoleFull)** for PR 14915 at commit

[GitHub] spark pull request #14915: [SPARK-17356][SQL] Fix out of memory issue when g...

2016-09-01 Thread clockfly
Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/14915#discussion_r77288334 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala --- @@ -274,6 +274,13 @@ abstract class QueryTest extends PlanTest { val

[GitHub] spark pull request #14915: [SPARK-17356][SQL] Fix out of memory issue when g...

2016-09-01 Thread clockfly
Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/14915#discussion_r77287956 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala --- @@ -274,6 +274,13 @@ abstract class QueryTest extends PlanTest { val

[GitHub] spark pull request #14930: [SPARK-16926] [SQL] Add unit test to compare tabl...

2016-09-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14930 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #14930: [SPARK-16926] [SQL] Add unit test to compare table and p...

2016-09-01 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14930 thanks, merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #14930: [SPARK-16926] [SQL] Add unit test to compare tabl...

2016-09-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14930#discussion_r77287554 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveTableScanSuite.scala --- @@ -143,4 +144,38 @@ class HiveTableScanSuite extends

[GitHub] spark issue #14930: [SPARK-16926] [SQL] Add unit test to compare table and p...

2016-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14930 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14930: [SPARK-16926] [SQL] Add unit test to compare table and p...

2016-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14930 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64822/ Test PASSed. ---

[GitHub] spark issue #14930: [SPARK-16926] [SQL] Add unit test to compare table and p...

2016-09-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14930 **[Test build #64822 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64822/consoleFull)** for PR 14930 at commit

[GitHub] spark issue #14858: [SPARK-17219][ML] Add NaN value handling in Bucketizer

2016-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14858 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64825/ Test PASSed. ---

[GitHub] spark issue #14858: [SPARK-17219][ML] Add NaN value handling in Bucketizer

2016-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14858 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14858: [SPARK-17219][ML] Add NaN value handling in Bucketizer

2016-09-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14858 **[Test build #64825 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64825/consoleFull)** for PR 14858 at commit

[GitHub] spark issue #14924: [SPARK-17299] TRIM/LTRIM/RTRIM should not strips charact...

2016-09-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14924 **[Test build #64827 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64827/consoleFull)** for PR 14924 at commit

[GitHub] spark issue #14900: [WEBUI][SPARK-17342] Style of event timeline is broken

2016-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14900 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14900: [WEBUI][SPARK-17342] Style of event timeline is broken

2016-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14900 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64820/ Test PASSed. ---

[GitHub] spark issue #14900: [WEBUI][SPARK-17342] Style of event timeline is broken

2016-09-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14900 **[Test build #64820 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64820/consoleFull)** for PR 14900 at commit

[GitHub] spark issue #14924: [SPARK-17299] TRIM/LTRIM/RTRIM should not strips charact...

2016-09-01 Thread techaddict
Github user techaddict commented on the issue: https://github.com/apache/spark/pull/14924 @rxin Done 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #14921: [SPARK-17361][SQL] createExternalTable should fail if pa...

2016-09-01 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14921 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request #14913: [SPARK-17358][SQL] Cached table(parquet/orc) shou...

2016-09-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14913#discussion_r77285873 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/fileSourceInterfaces.scala --- @@ -169,6 +169,13 @@ case class

[GitHub] spark issue #14921: [SPARK-17361][SQL] createExternalTable should fail if pa...

2016-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14921 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64819/ Test PASSed. ---

[GitHub] spark issue #14921: [SPARK-17361][SQL] createExternalTable should fail if pa...

2016-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14921 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14921: [SPARK-17361][SQL] createExternalTable should fail if pa...

2016-09-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14921 **[Test build #64819 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64819/consoleFull)** for PR 14921 at commit

[GitHub] spark issue #14854: [SPARK-17283][Core] Cancel job in RDD.take() as soon as ...

2016-09-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14854 **[Test build #64826 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64826/consoleFull)** for PR 14854 at commit

[GitHub] spark issue #14929: [Don't merge][WIP] Better error message for JSON file fo...

2016-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14929 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14929: [Don't merge][WIP] Better error message for JSON file fo...

2016-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14929 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64821/ Test PASSed. ---

[GitHub] spark issue #14929: [Don't merge][WIP] Better error message for JSON file fo...

2016-09-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14929 **[Test build #64821 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64821/consoleFull)** for PR 14929 at commit

[GitHub] spark pull request #14930: [SPARK-16926] [SQL] Add unit test to compare tabl...

2016-09-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14930#discussion_r77285020 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveTableScanSuite.scala --- @@ -143,4 +144,38 @@ class HiveTableScanSuite extends

[GitHub] spark pull request #14883: [SPARK-17319] [SQL] Move addJar from HiveSessionS...

2016-09-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14883#discussion_r77284957 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala --- @@ -184,4 +184,17 @@ abstract class ExternalCatalog

[GitHub] spark issue #14929: [Don't merge][WIP] Better error message for JSON file fo...

2016-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14929 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64818/ Test PASSed. ---

[GitHub] spark issue #14929: [Don't merge][WIP] Better error message for JSON file fo...

2016-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14929 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14929: [Don't merge][WIP] Better error message for JSON file fo...

2016-09-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14929 **[Test build #64818 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64818/consoleFull)** for PR 14929 at commit

[GitHub] spark issue #14866: [SPARK-17298][SQL] Require explicit CROSS join for carte...

2016-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14866 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14866: [SPARK-17298][SQL] Require explicit CROSS join for carte...

2016-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14866 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64814/ Test PASSed. ---

[GitHub] spark issue #14866: [SPARK-17298][SQL] Require explicit CROSS join for carte...

2016-09-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14866 **[Test build #64814 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64814/consoleFull)** for PR 14866 at commit

  1   2   3   4   5   6   7   >