[GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view

2016-10-10 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r82658617 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/catalog/Catalog.scala --- @@ -262,15 +262,33 @@ abstract class Catalog { options: Map[String,

[GitHub] spark issue #15392: [SPARK-17830] Annotate spark.sql package with InterfaceS...

2016-10-10 Thread marmbrus
Github user marmbrus commented on the issue: https://github.com/apache/spark/pull/15392 LGTM, merging to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #14365: [SPARK-16628][SQL] Translate file-based relation schema ...

2016-10-10 Thread yhuai
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/14365 @cloud-fan actually, this conversion was disabled because of this bug. btw, pr that @cloud-fan mentioned is https://github.com/apache/spark/pull/14690. I think it is better to hold

[GitHub] spark issue #15386: [SPARK-17808][PYSPARK] Upgraded version of Pyrolite to 4...

2016-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15386 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66672/ Test FAILed. ---

[GitHub] spark issue #15386: [SPARK-17808][PYSPARK] Upgraded version of Pyrolite to 4...

2016-10-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15386 **[Test build #66672 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66672/consoleFull)** for PR 15386 at commit

[GitHub] spark issue #15386: [SPARK-17808][PYSPARK] Upgraded version of Pyrolite to 4...

2016-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15386 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15319: [SPARK-17733][SQL] InferFiltersFromConstraints rule neve...

2016-10-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15319 **[Test build #3319 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3319/consoleFull)** for PR 15319 at commit

[GitHub] spark issue #15398: [SPARK-17647][SQL] Fix backslash escaping in 'LIKE' patt...

2016-10-10 Thread jodersky
Github user jodersky commented on the issue: https://github.com/apache/spark/pull/15398 cc @viirya, I changed your original code --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15419: [SPARK-17828] [DOCS] Remove unused generate-changelist.p...

2016-10-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15419 **[Test build #3318 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3318/consoleFull)** for PR 15419 at commit

[GitHub] spark issue #15408: [SPARK-17839][CORE] Use Nio's directbuffer instead of Bu...

2016-10-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15408 **[Test build #66674 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66674/consoleFull)** for PR 15408 at commit

[GitHub] spark issue #15419: [SPARK-17828] [DOCS] Remove unused generate-changelist.p...

2016-10-10 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15419 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark issue #15419: [SPARK-17828] [DOCS] Remove unused generate-changelist.p...

2016-10-10 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15419 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #15408: [SPARK-17839][CORE] Use Nio's directbuffer instea...

2016-10-10 Thread sitalkedia
Github user sitalkedia commented on a diff in the pull request: https://github.com/apache/spark/pull/15408#discussion_r82655690 --- Diff: core/src/main/java/org/apache/spark/io/NioBasedBufferedFileInputStream.java --- @@ -0,0 +1,120 @@ +/* + * Licensed under the Apache

[GitHub] spark pull request #15358: [SPARK-17783] [SQL] Hide Credentials in CREATE an...

2016-10-10 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/15358#discussion_r82655758 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -52,9 +52,15 @@ case class CatalogStorageFormat(

[GitHub] spark pull request #15342: [SPARK-11560] [MLLIB] Optimize KMeans implementat...

2016-10-10 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15342#discussion_r82654945 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -258,149 +252,106 @@ class KMeans private ( } }

[GitHub] spark issue #15319: [SPARK-17733][SQL] InferFiltersFromConstraints rule neve...

2016-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15319 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66658/ Test FAILed. ---

[GitHub] spark issue #15319: [SPARK-17733][SQL] InferFiltersFromConstraints rule neve...

2016-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15319 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15319: [SPARK-17733][SQL] InferFiltersFromConstraints rule neve...

2016-10-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15319 **[Test build #66658 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66658/consoleFull)** for PR 15319 at commit

[GitHub] spark issue #15342: [SPARK-11560] [MLLIB] Optimize KMeans implementation / r...

2016-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15342 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15342: [SPARK-11560] [MLLIB] Optimize KMeans implementation / r...

2016-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15342 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66673/ Test FAILed. ---

[GitHub] spark issue #15342: [SPARK-11560] [MLLIB] Optimize KMeans implementation / r...

2016-10-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15342 **[Test build #66673 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66673/consoleFull)** for PR 15342 at commit

[GitHub] spark issue #15342: [SPARK-11560] [MLLIB] Optimize KMeans implementation / r...

2016-10-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15342 **[Test build #66673 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66673/consoleFull)** for PR 15342 at commit

[GitHub] spark pull request #15342: [SPARK-11560] [MLLIB] Optimize KMeans implementat...

2016-10-10 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15342#discussion_r82653577 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -258,149 +252,106 @@ class KMeans private ( } }

[GitHub] spark issue #10342: [SPARK-12388] change default compression to lz4

2016-10-10 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/10342 One thing I noticed when I was reviewing another pr just now: in the future we should also include test cases when pulling in 3rd party code. Otherwise it's pretty difficult to ensure correctness if

[GitHub] spark pull request #15342: [SPARK-11560] [MLLIB] Optimize KMeans implementat...

2016-10-10 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15342#discussion_r82652315 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -258,149 +252,106 @@ class KMeans private ( } }

[GitHub] spark issue #15386: [SPARK-17808][PYSPARK] Upgraded version of Pyrolite to 4...

2016-10-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15386 **[Test build #66672 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66672/consoleFull)** for PR 15386 at commit

[GitHub] spark pull request #15408: [SPARK-17839][CORE] Use Nio's directbuffer instea...

2016-10-10 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15408#discussion_r82652845 --- Diff: core/src/test/java/org/apache/spark/io/NioBasedBufferedFileInputStreamSuite.java --- @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #15342: [SPARK-11560] [MLLIB] Optimize KMeans implementation / r...

2016-10-10 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15342 @sethah OK I will add a new overload of `train` and deprecate the others. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #13675: [SPARK-15957] [ML] RFormula supports forcing to index la...

2016-10-10 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/13675 I just noticed that last item, but otherwise, this looks ready to me. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark issue #15386: [SPARK-17808][PYSPARK] Upgraded version of Pyrolite to 4...

2016-10-10 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/15386 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15386: [SPARK-17808][PYSPARK] Upgraded version of Pyrolite to 4...

2016-10-10 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/15386 Hmm, I don't think there should be a MiMa issue right? It passes locally anyway.. let me try again --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request #15342: [SPARK-11560] [MLLIB] Optimize KMeans implementat...

2016-10-10 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15342#discussion_r82650874 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -258,149 +252,106 @@ class KMeans private ( } }

[GitHub] spark pull request #15316: [SPARK-17751] [SQL] Remove spark.sql.eagerAnalysi...

2016-10-10 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15316#discussion_r82650465 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/AnalysisException.scala --- @@ -43,6 +43,11 @@ class AnalysisException protected[sql] (

[GitHub] spark pull request #14788: [SPARK-17174][SQL] Add the support for TimestampT...

2016-10-10 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14788#discussion_r82650345 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -2548,16 +2548,20 @@ object functions { def to_date(e: Column):

[GitHub] spark issue #15408: [SPARK-17839][CORE] UnsafeSorterSpillReader should use N...

2016-10-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15408 **[Test build #66671 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66671/consoleFull)** for PR 15408 at commit

[GitHub] spark pull request #15408: [SPARK-17839][CORE] UnsafeSorterSpillReader shoul...

2016-10-10 Thread sitalkedia
Github user sitalkedia commented on a diff in the pull request: https://github.com/apache/spark/pull/15408#discussion_r82649972 --- Diff: core/src/main/java/org/apache/spark/io/NioBasedBufferedFileInputStream.java --- @@ -0,0 +1,120 @@ +/* + * Licensed under the Apache

[GitHub] spark pull request #15342: [SPARK-11560] [MLLIB] Optimize KMeans implementat...

2016-10-10 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15342#discussion_r82649893 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -258,149 +252,106 @@ class KMeans private ( } }

[GitHub] spark pull request #15342: [SPARK-11560] [MLLIB] Optimize KMeans implementat...

2016-10-10 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15342#discussion_r82649829 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -258,149 +252,106 @@ class KMeans private ( } }

[GitHub] spark issue #14959: [SPARK-17387][PYSPARK] Creating SparkContext() from pyth...

2016-10-10 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/14959 Thanks for the updates @zjffdu, just 2 minor comments otherwise LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #15386: [SPARK-17808][PYSPARK] Upgraded version of Pyrolite to 4...

2016-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15386 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15408: [SPARK-17839][CORE] UnsafeSorterSpillReader should use N...

2016-10-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15408 **[Test build #66670 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66670/consoleFull)** for PR 15408 at commit

[GitHub] spark issue #15314: [SPARK-17747][ML] WeightCol support non-double datatypes

2016-10-10 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/15314 Yeah, the original fix was small and so it was ok to include it here, but we are expanding the scope of the change so I think it's best to separate it. --- If your project is set up for it, you

[GitHub] spark issue #15386: [SPARK-17808][PYSPARK] Upgraded version of Pyrolite to 4...

2016-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15386 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/6/ Test FAILed. ---

[GitHub] spark issue #15386: [SPARK-17808][PYSPARK] Upgraded version of Pyrolite to 4...

2016-10-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15386 **[Test build #6 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/6/consoleFull)** for PR 15386 at commit

[GitHub] spark pull request #14959: [SPARK-17387][PYSPARK] Creating SparkContext() fr...

2016-10-10 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/14959#discussion_r82649182 --- Diff: python/pyspark/conf.py --- @@ -101,13 +109,25 @@ def __init__(self, loadDefaults=True, _jvm=None, _jconf=None): self._jconf =

[GitHub] spark pull request #14959: [SPARK-17387][PYSPARK] Creating SparkContext() fr...

2016-10-10 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/14959#discussion_r82649091 --- Diff: python/pyspark/context.py --- @@ -121,7 +121,15 @@ def __init__(self, master=None, appName=None, sparkHome=None, pyFiles=None, def

[GitHub] spark pull request #15342: [SPARK-11560] [MLLIB] Optimize KMeans implementat...

2016-10-10 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15342#discussion_r82648980 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -258,149 +252,106 @@ class KMeans private ( } }

[GitHub] spark pull request #15342: [SPARK-11560] [MLLIB] Optimize KMeans implementat...

2016-10-10 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15342#discussion_r82648993 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -43,21 +43,21 @@ import org.apache.spark.util.random.XORShiftRandom

[GitHub] spark issue #15371: [SPARK-17816] [Core] Fix ConcurrentModificationException...

2016-10-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15371 **[Test build #9 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/9/consoleFull)** for PR 15371 at commit

[GitHub] spark pull request #15394: [SPARK-17749][ML] One pass solver for Weighted Le...

2016-10-10 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15394#discussion_r82648263 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala --- @@ -217,7 +215,7 @@ class LinearRegression @Since("1.3.0")

[GitHub] spark issue #15395: [SPARK-17738] [TEST] Fix flaky test in ColumnTypeSuite

2016-10-10 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/15395 @davies I appreciate your efforts. I should have noticed this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #13579: [SPARK-15844] [core] HistoryServer doesn't come up if sp...

2016-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13579 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13579: [SPARK-15844] [core] HistoryServer doesn't come up if sp...

2016-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13579 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66657/ Test FAILed. ---

[GitHub] spark issue #13579: [SPARK-15844] [core] HistoryServer doesn't come up if sp...

2016-10-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13579 **[Test build #66657 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66657/consoleFull)** for PR 13579 at commit

[GitHub] spark issue #15408: [SPARK-17839][CORE] UnsafeSorterSpillReader should use N...

2016-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15408 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #15408: [SPARK-17839][CORE] UnsafeSorterSpillReader shoul...

2016-10-10 Thread sitalkedia
Github user sitalkedia commented on a diff in the pull request: https://github.com/apache/spark/pull/15408#discussion_r82648052 --- Diff: core/src/main/java/org/apache/spark/io/NioBasedBufferedFileInputStream.java --- @@ -0,0 +1,120 @@ +/* + * Licensed under the Apache

[GitHub] spark pull request #15408: [SPARK-17839][CORE] UnsafeSorterSpillReader shoul...

2016-10-10 Thread sitalkedia
Github user sitalkedia commented on a diff in the pull request: https://github.com/apache/spark/pull/15408#discussion_r82648070 --- Diff: core/src/main/java/org/apache/spark/io/NioBasedBufferedFileInputStream.java --- @@ -0,0 +1,120 @@ +/* + * Licensed under the Apache

[GitHub] spark issue #15408: [SPARK-17839][CORE] UnsafeSorterSpillReader should use N...

2016-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15408 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/7/ Test FAILed. ---

[GitHub] spark issue #15408: [SPARK-17839][CORE] UnsafeSorterSpillReader should use N...

2016-10-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15408 **[Test build #7 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/7/consoleFull)** for PR 15408 at commit

[GitHub] spark pull request #15408: [SPARK-17839][CORE] UnsafeSorterSpillReader shoul...

2016-10-10 Thread sitalkedia
Github user sitalkedia commented on a diff in the pull request: https://github.com/apache/spark/pull/15408#discussion_r82647961 --- Diff: core/src/main/java/org/apache/spark/io/NioBasedBufferedFileInputStream.java --- @@ -0,0 +1,120 @@ +/* + * Licensed under the Apache

[GitHub] spark pull request #15408: [SPARK-17839][CORE] UnsafeSorterSpillReader shoul...

2016-10-10 Thread sitalkedia
Github user sitalkedia commented on a diff in the pull request: https://github.com/apache/spark/pull/15408#discussion_r82647991 --- Diff: core/src/main/java/org/apache/spark/io/NioBasedBufferedFileInputStream.java --- @@ -0,0 +1,120 @@ +/* + * Licensed under the Apache

[GitHub] spark pull request #15408: [SPARK-17839][CORE] UnsafeSorterSpillReader shoul...

2016-10-10 Thread sitalkedia
Github user sitalkedia commented on a diff in the pull request: https://github.com/apache/spark/pull/15408#discussion_r82648011 --- Diff: core/src/main/java/org/apache/spark/io/NioBasedBufferedFileInputStream.java --- @@ -0,0 +1,120 @@ +/* + * Licensed under the Apache

[GitHub] spark pull request #15408: [SPARK-17839][CORE] UnsafeSorterSpillReader shoul...

2016-10-10 Thread sitalkedia
Github user sitalkedia commented on a diff in the pull request: https://github.com/apache/spark/pull/15408#discussion_r82647820 --- Diff: core/src/test/java/org/apache/spark/io/NioBasedBufferedFileInputStreamSuite.java --- @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #15408: [SPARK-17839][CORE] UnsafeSorterSpillReader shoul...

2016-10-10 Thread sitalkedia
Github user sitalkedia commented on a diff in the pull request: https://github.com/apache/spark/pull/15408#discussion_r82647832 --- Diff: core/src/test/java/org/apache/spark/io/NioBasedBufferedFileInputStreamSuite.java --- @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #15386: [SPARK-17808][PYSPARK] Upgraded version of Pyrolite to 4...

2016-10-10 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/15386 Thanks @srowen , I wasn't aware of that script. Hopefully this should be good to go now! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark issue #15408: [SPARK-17839][CORE] UnsafeSorterSpillReader should use N...

2016-10-10 Thread sitalkedia
Github user sitalkedia commented on the issue: https://github.com/apache/spark/pull/15408 Thanks @srowen, @rxin for the review comments. I have addressed them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request #15394: [SPARK-17749][ML] One pass solver for Weighted Le...

2016-10-10 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15394#discussion_r82647560 --- Diff: mllib-local/src/main/scala/org/apache/spark/ml/linalg/BLAS.scala --- @@ -244,6 +244,15 @@ private[spark] object BLAS extends Serializable {

[GitHub] spark issue #15316: [SPARK-17751] [SQL] Remove spark.sql.eagerAnalysis and O...

2016-10-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15316 **[Test build #8 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/8/consoleFull)** for PR 15316 at commit

[GitHub] spark pull request #15408: [SPARK-17839][CORE] UnsafeSorterSpillReader shoul...

2016-10-10 Thread sitalkedia
Github user sitalkedia commented on a diff in the pull request: https://github.com/apache/spark/pull/15408#discussion_r82647539 --- Diff: core/src/main/java/org/apache/spark/io/NioBasedBufferedFileInputStream.java --- @@ -0,0 +1,120 @@ +/* + * Licensed under the Apache

[GitHub] spark issue #15408: [SPARK-17839][CORE] UnsafeSorterSpillReader should use N...

2016-10-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15408 **[Test build #7 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/7/consoleFull)** for PR 15408 at commit

[GitHub] spark pull request #15394: [SPARK-17749][ML] One pass solver for Weighted Le...

2016-10-10 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15394#discussion_r82647370 --- Diff: mllib/src/main/scala/org/apache/spark/ml/optim/NormalEquationSolver.scala --- @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #15408: [SPARK-17839][CORE] UnsafeSorterSpillReader shoul...

2016-10-10 Thread sitalkedia
Github user sitalkedia commented on a diff in the pull request: https://github.com/apache/spark/pull/15408#discussion_r82647325 --- Diff: core/src/test/java/org/apache/spark/io/NioBasedBufferedFileInputStreamSuite.java --- @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #13675: [SPARK-15957] [ML] RFormula supports forcing to index la...

2016-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13675 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13675: [SPARK-15957] [ML] RFormula supports forcing to index la...

2016-10-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13675 **[Test build #2 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/2/consoleFull)** for PR 13675 at commit

[GitHub] spark issue #13675: [SPARK-15957] [ML] RFormula supports forcing to index la...

2016-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13675 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/2/ Test PASSed. ---

[GitHub] spark issue #15148: [SPARK-5992][ML] Locality Sensitive Hashing

2016-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15148 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15148: [SPARK-5992][ML] Locality Sensitive Hashing

2016-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15148 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4/ Test PASSed. ---

[GitHub] spark issue #15148: [SPARK-5992][ML] Locality Sensitive Hashing

2016-10-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15148 **[Test build #4 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/4/consoleFull)** for PR 15148 at commit

[GitHub] spark pull request #15342: [SPARK-11560] [MLLIB] Optimize KMeans implementat...

2016-10-10 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15342#discussion_r82646051 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -558,6 +475,7 @@ object KMeans { * Trains a k-means model using

[GitHub] spark pull request #15342: [SPARK-11560] [MLLIB] Optimize KMeans implementat...

2016-10-10 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15342#discussion_r82634889 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -258,149 +252,106 @@ class KMeans private ( } }

[GitHub] spark pull request #15342: [SPARK-11560] [MLLIB] Optimize KMeans implementat...

2016-10-10 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15342#discussion_r82625386 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -258,149 +252,106 @@ class KMeans private ( } }

[GitHub] spark pull request #15342: [SPARK-11560] [MLLIB] Optimize KMeans implementat...

2016-10-10 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15342#discussion_r82633045 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -258,149 +252,106 @@ class KMeans private ( } }

[GitHub] spark issue #15386: [SPARK-17808][PYSPARK] Upgraded version of Pyrolite to 4...

2016-10-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15386 **[Test build #6 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/6/consoleFull)** for PR 15386 at commit

[GitHub] spark pull request #15371: [SPARK-17816] [Core] Fix ConcurrentModificationEx...

2016-10-10 Thread seyfe
Github user seyfe commented on a diff in the pull request: https://github.com/apache/spark/pull/15371#discussion_r82645595 --- Diff: project/MimaExcludes.scala --- @@ -55,7 +55,11 @@ object MimaExcludes {

[GitHub] spark issue #15395: [SPARK-17738] [TEST] Fix flaky test in ColumnTypeSuite

2016-10-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15395 **[Test build #3317 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3317/consoleFull)** for PR 15395 at commit

[GitHub] spark issue #13579: [SPARK-15844] [core] HistoryServer doesn't come up if sp...

2016-10-10 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/13579 That doesn't answer my question, though. Why can't the history server explicitly set that value to false after all the settings having been read from wherever? --- If your project is set up for

[GitHub] spark pull request #15316: [SPARK-17751] [SQL] Remove spark.sql.eagerAnalysi...

2016-10-10 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/15316#discussion_r82643571 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/AnalysisException.scala --- @@ -43,6 +43,11 @@ class AnalysisException protected[sql] (

[GitHub] spark issue #13194: [SPARK-15402] [ML] [PySpark] PySpark ml.evaluation shoul...

2016-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13194 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/5/ Test PASSed. ---

[GitHub] spark issue #13194: [SPARK-15402] [ML] [PySpark] PySpark ml.evaluation shoul...

2016-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13194 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15399: [SPARK-17819][SQL] Support default database in connectio...

2016-10-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15399 Thank you for commenting, @gatorsmile . So far, I asked @rxin and you. I'll find another committer more closer this part. --- If your project is set up for it, you can reply to this email

[GitHub] spark issue #13194: [SPARK-15402] [ML] [PySpark] PySpark ml.evaluation shoul...

2016-10-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13194 **[Test build #5 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/5/consoleFull)** for PR 13194 at commit

[GitHub] spark pull request #15148: [SPARK-5992][ML] Locality Sensitive Hashing

2016-10-10 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/15148#discussion_r82641642 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHash.scala --- @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request #15148: [SPARK-5992][ML] Locality Sensitive Hashing

2016-10-10 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/15148#discussion_r82641617 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHash.scala --- @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark issue #13194: [SPARK-15402] [ML] [PySpark] PySpark ml.evaluation shoul...

2016-10-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13194 **[Test build #5 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/5/consoleFull)** for PR 13194 at commit

[GitHub] spark issue #14731: [SPARK-17159] [streaming]: optimise check for new files ...

2016-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14731 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66656/ Test PASSed. ---

[GitHub] spark issue #14731: [SPARK-17159] [streaming]: optimise check for new files ...

2016-10-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14731 **[Test build #66656 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66656/consoleFull)** for PR 14731 at commit

[GitHub] spark issue #14731: [SPARK-17159] [streaming]: optimise check for new files ...

2016-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14731 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14653: [SPARK-10931][PYSPARK][ML] PySpark ML Models should cont...

2016-10-10 Thread davidnavas
Github user davidnavas commented on the issue: https://github.com/apache/spark/pull/14653 @holdenk happy to help if I can, is there something a mere mortal like myself can accomplish? [dunno how to poke jenkins hereabouts] --- If your project is set up for it, you can reply to this

[GitHub] spark issue #15420: [SPARK-17855][CORE] Remove query string from jar url

2016-10-10 Thread invkrh
Github user invkrh commented on the issue: https://github.com/apache/spark/pull/15420 @srowen I have tested the code on spark 1.6.2. It works fine. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #13675: [SPARK-15957] [ML] RFormula supports forcing to index la...

2016-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13675 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/1/ Test FAILed. ---

<    1   2   3   4   5   6   7   8   >