[GitHub] spark issue #15607: [SPARK-16137][SPARKR] randomForest for R

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15607 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67438/ Test FAILed. ---

[GitHub] spark issue #15607: [SPARK-16137][SPARKR] randomForest for R

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15607 **[Test build #67438 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67438/consoleFull)** for PR 15607 at commit

[GitHub] spark issue #15607: [SPARK-16137][SPARKR] randomForest for R

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15607 **[Test build #67438 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67438/consoleFull)** for PR 15607 at commit

[GitHub] spark issue #15607: [SPARK-16137][SPARKR] randomForest for R

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15607 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15605: [WIP] [SPARK-18067] [SQL] SortMergeJoin adds shuffle if ...

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15605 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15605: [WIP] [SPARK-18067] [SQL] SortMergeJoin adds shuffle if ...

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15605 **[Test build #67431 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67431/consoleFull)** for PR 15605 at commit

[GitHub] spark issue #15605: [WIP] [SPARK-18067] [SQL] SortMergeJoin adds shuffle if ...

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15605 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67431/ Test FAILed. ---

[GitHub] spark pull request #15607: [SPARK-16137][SPARKR] randomForest for R

2016-10-23 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/spark/pull/15607 [SPARK-16137][SPARKR] randomForest for R ## What changes were proposed in this pull request? Random Forest Regression and Classification for R Clean-up/reordering generics.R

[GitHub] spark issue #15581: [SPARK-18044][STREAMING] FileStreamSource should not inf...

2016-10-23 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/15581 @zsxwing shall we backport [this](https://github.com/apache/spark/pull/14803) first? Seems in 2.0 we don't support partitioned file source. --- If your project is set up for it, you can reply

[GitHub] spark issue #14426: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14426 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67425/ Test PASSed. ---

[GitHub] spark issue #14426: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14426 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15606: [SPARK-18070][SQL] binary operator should not consider n...

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15606 **[Test build #67437 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67437/consoleFull)** for PR 15606 at commit

[GitHub] spark issue #14426: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14426 **[Test build #67425 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67425/consoleFull)** for PR 14426 at commit

[GitHub] spark issue #15606: [SPARK-18070][SQL] binary operator should not consider n...

2016-10-23 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/15606 cc @gatorsmile @yhuai --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #15553: [SPARK-18008] [build] Add support for -Dmaven.test.skip=...

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15553 **[Test build #67436 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67436/consoleFull)** for PR 15553 at commit

[GitHub] spark pull request #15606: [SPARK-18070][SQL] binary operator should not con...

2016-10-23 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/15606 [SPARK-18070][SQL] binary operator should not consider nullability when comparing input types ## What changes were proposed in this pull request? Binary operator requires its inputs to

[GitHub] spark issue #15553: [SPARK-18008] [build] Add support for -Dmaven.test.skip=...

2016-10-23 Thread mridulm
Github user mridulm commented on the issue: https://github.com/apache/spark/pull/15553 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15596: [SQL] Remove shuffle codes in CollectLimitExec

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15596 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67427/ Test FAILed. ---

[GitHub] spark issue #14136: [SPARK-16282][SQL] Implement percentile SQL function.

2016-10-23 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/14136 @rxin @hvanhovell Thanks for your advice, I'll address them ASAP! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #15596: [SQL] Remove shuffle codes in CollectLimitExec

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15596 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15596: [SQL] Remove shuffle codes in CollectLimitExec

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15596 **[Test build #67427 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67427/consoleFull)** for PR 15596 at commit

[GitHub] spark issue #14136: [SPARK-16282][SQL] Implement percentile SQL function.

2016-10-23 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14136 @jiangxb1987 can you add some test cases based on Herman's comment? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #13891: [SPARK-6685][MLLIB]Use DSYRK to compute AtA in ALS

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13891 **[Test build #67435 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67435/consoleFull)** for PR 13891 at commit

[GitHub] spark issue #13891: [SPARK-6685][MLLIB]Use DSYRK to compute AtA in ALS

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13891 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13891: [SPARK-6685][MLLIB]Use DSYRK to compute AtA in ALS

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13891 **[Test build #67434 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67434/consoleFull)** for PR 13891 at commit

[GitHub] spark issue #13891: [SPARK-6685][MLLIB]Use DSYRK to compute AtA in ALS

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13891 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67434/ Test FAILed. ---

[GitHub] spark pull request #15541: [SPARK-17637][Scheduler]Packed scheduling for Spa...

2016-10-23 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/15541#discussion_r84621271 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala --- @@ -250,24 +251,24 @@ private[spark] class TaskSchedulerImpl(

[GitHub] spark issue #13891: [SPARK-6685][MLLIB]Use DSYRK to compute AtA in ALS

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13891 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #13891: [SPARK-6685][MLLIB]Use DSYRK to compute AtA in ALS

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13891 **[Test build #67432 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67432/consoleFull)** for PR 13891 at commit

[GitHub] spark issue #13891: [SPARK-6685][MLLIB]Use DSYRK to compute AtA in ALS

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13891 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67432/ Test FAILed. ---

[GitHub] spark issue #14638: [SPARK-11374][SQL] Support `skip.header.line.count` opti...

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14638 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67426/ Test PASSed. ---

[GitHub] spark issue #14638: [SPARK-11374][SQL] Support `skip.header.line.count` opti...

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14638 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14638: [SPARK-11374][SQL] Support `skip.header.line.count` opti...

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14638 **[Test build #67426 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67426/consoleFull)** for PR 14638 at commit

[GitHub] spark pull request #15541: [SPARK-17637][Scheduler]Packed scheduling for Spa...

2016-10-23 Thread zhzhan
Github user zhzhan commented on a diff in the pull request: https://github.com/apache/spark/pull/15541#discussion_r84621076 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala --- @@ -250,24 +251,24 @@ private[spark] class TaskSchedulerImpl(

[GitHub] spark pull request #15596: [SQL] Remove shuffle codes in CollectLimitExec

2016-10-23 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/15596#discussion_r84621075 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/BufferedRowIterator.java --- @@ -39,7 +39,7 @@ protected int partitionIndex = -1;

[GitHub] spark issue #15541: [SPARK-17637][Scheduler]Packed scheduling for Spark task...

2016-10-23 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/15541 One concern I have is the cluster of machines with different codes. It is possibly if you construct your cluster with solution like ec2 and buy different kinds of nodes. In this case, the balance

[GitHub] spark issue #15541: [SPARK-17637][Scheduler]Packed scheduling for Spark task...

2016-10-23 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/15541 LGTM. I have a question for the legacy code, but not related to this change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #13891: [SPARK-6685][MLLIB]Use DSYRK to compute AtA in ALS

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13891 **[Test build #67434 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67434/consoleFull)** for PR 13891 at commit

[GitHub] spark issue #15597: [SPARK-18063][SQL] Failed to infer constraints over mult...

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15597 **[Test build #67433 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67433/consoleFull)** for PR 15597 at commit

[GitHub] spark issue #15605: [WIP] [SPARK-18067] [SQL] SortMergeJoin adds shuffle if ...

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15605 **[Test build #67431 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67431/consoleFull)** for PR 15605 at commit

[GitHub] spark issue #13891: [SPARK-6685][MLLIB]Use DSYRK to compute AtA in ALS

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13891 **[Test build #67432 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67432/consoleFull)** for PR 13891 at commit

[GitHub] spark issue #15605: [WIP] [SPARK-18067] [SQL] SortMergeJoin adds shuffle if ...

2016-10-23 Thread tejasapatil
Github user tejasapatil commented on the issue: https://github.com/apache/spark/pull/15605 cc @hvanhovell --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark pull request #15605: [WIP] [SPARK-18067] [SQL] SortMergeJoin adds shuf...

2016-10-23 Thread tejasapatil
GitHub user tejasapatil opened a pull request: https://github.com/apache/spark/pull/15605 [WIP] [SPARK-18067] [SQL] SortMergeJoin adds shuffle if join predicates have non partitioned columns ## What changes were proposed in this pull request? See

[GitHub] spark issue #15428: [SPARK-17219][ML] enhanced NaN value handling in Bucketi...

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15428 **[Test build #67430 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67430/consoleFull)** for PR 15428 at commit

[GitHub] spark issue #15428: [SPARK-17219][ML] enhanced NaN value handling in Bucketi...

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15428 **[Test build #67429 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67429/consoleFull)** for PR 15428 at commit

[GitHub] spark issue #15212: [SPARK-17645][MLLIB][ML]add feature selector method base...

2016-10-23 Thread mpjlu
Github user mpjlu commented on the issue: https://github.com/apache/spark/pull/15212 Hi @yanboliang and @srowen , could you please review whether this PR includes all your comments. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request #15541: [SPARK-17637][Scheduler]Packed scheduling for Spa...

2016-10-23 Thread zhzhan
Github user zhzhan commented on a diff in the pull request: https://github.com/apache/spark/pull/15541#discussion_r84619879 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala --- @@ -250,24 +251,24 @@ private[spark] class TaskSchedulerImpl(

[GitHub] spark issue #15541: [SPARK-17637][Scheduler]Packed scheduling for Spark task...

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15541 **[Test build #67428 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67428/consoleFull)** for PR 15541 at commit

[GitHub] spark pull request #15541: [SPARK-17637][Scheduler]Packed scheduling for Spa...

2016-10-23 Thread zhzhan
Github user zhzhan commented on a diff in the pull request: https://github.com/apache/spark/pull/15541#discussion_r84619023 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskAssigner.scala --- @@ -0,0 +1,229 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark issue #15513: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-10-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15513 Could I please hear your thoughts @rxin, @srowen and @jodersky about changing the format to https://github.com/apache/spark/pull/15513#issuecomment-255594355 or

[GitHub] spark pull request #15541: [SPARK-17637][Scheduler]Packed scheduling for Spa...

2016-10-23 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/15541#discussion_r84618189 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskAssigner.scala --- @@ -0,0 +1,229 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark issue #15596: [SQL] Remove shuffle codes in CollectLimitExec

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15596 **[Test build #67427 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67427/consoleFull)** for PR 15596 at commit

[GitHub] spark issue #15513: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-10-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15513 https://github.com/apache/spark/pull/15513#issuecomment-255632253 I initially wanted to propose that idea but I didn't becuase I was worried of ignoring existing name rules in each expression.

[GitHub] spark issue #15588: [SPARK-18039][Scheduler] fix bug maxRegisteredWaitingTim...

2016-10-23 Thread Astralidea
Github user Astralidea commented on the issue: https://github.com/apache/spark/pull/15588 @lw-lin spark.scheduler.minRegisteredResourcesRatio does not work. The reason it may could be I use mesos and it run executor not through driver. but I still need to make sure it

[GitHub] spark issue #14638: [SPARK-11374][SQL] Support `skip.header.line.count` opti...

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14638 **[Test build #67426 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67426/consoleFull)** for PR 14638 at commit

[GitHub] spark issue #15541: [SPARK-17637][Scheduler]Packed scheduling for Spark task...

2016-10-23 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15541 LGTM except a few minor comments. Could @rxin do the final check? Thank you for your work! @zhzhan --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request #15541: [SPARK-17637][Scheduler]Packed scheduling for Spa...

2016-10-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/15541#discussion_r84616602 --- Diff: docs/configuration.md --- @@ -1350,6 +1350,20 @@ Apart from these, the following properties are also available, and may be useful

[GitHub] spark issue #14426: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14426 **[Test build #67425 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67425/consoleFull)** for PR 14426 at commit

[GitHub] spark pull request #15541: [SPARK-17637][Scheduler]Packed scheduling for Spa...

2016-10-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/15541#discussion_r84616347 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskAssigner.scala --- @@ -0,0 +1,229 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #13891: [SPARK-6685][MLLIB]Use DSYRK to compute AtA in ALS

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13891 **[Test build #67424 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67424/consoleFull)** for PR 13891 at commit

[GitHub] spark issue #13891: [SPARK-6685][MLLIB]Use DSYRK to compute AtA in ALS

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13891 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13891: [SPARK-6685][MLLIB]Use DSYRK to compute AtA in ALS

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13891 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67424/ Test FAILed. ---

[GitHub] spark pull request #15513: [SPARK-17963][SQL][Documentation] Add examples (e...

2016-10-23 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15513#discussion_r84615985 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/bitwiseExpressions.scala --- @@ -27,8 +27,16 @@ import

[GitHub] spark issue #15513: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-10-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15513 @gatorsmile Oh, they should be `literal` because in most cases users will give the input as `literal` for those cases. I though I used a word `literal` for those foldable expressions. --- If

[GitHub] spark pull request #15513: [SPARK-17963][SQL][Documentation] Add examples (e...

2016-10-23 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15513#discussion_r84615684 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CallMethodViaReflection.scala --- @@ -43,11 +43,20 @@ import

[GitHub] spark issue #13891: [SPARK-6685][MLLIB]Use DSYRK to compute AtA in ALS

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13891 **[Test build #67424 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67424/consoleFull)** for PR 13891 at commit

[GitHub] spark issue #13891: [SPARK-6685][MLLIB]Use DSYRK to compute AtA in ALS

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13891 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13891: [SPARK-6685][MLLIB]Use DSYRK to compute AtA in ALS

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13891 **[Test build #67423 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67423/consoleFull)** for PR 13891 at commit

[GitHub] spark issue #13891: [SPARK-6685][MLLIB]Use DSYRK to compute AtA in ALS

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13891 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67423/ Test FAILed. ---

[GitHub] spark issue #13891: [SPARK-6685][MLLIB]Use DSYRK to compute AtA in ALS

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13891 **[Test build #67423 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67423/consoleFull)** for PR 13891 at commit

[GitHub] spark pull request #15513: [SPARK-17963][SQL][Documentation] Add examples (e...

2016-10-23 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15513#discussion_r84615167 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Covariance.scala --- @@ -76,8 +76,14 @@ abstract class

[GitHub] spark issue #13891: [SPARK-6685][MLLIB]Use DSYRK to compute AtA in ALS

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13891 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67422/ Test FAILed. ---

[GitHub] spark issue #13891: [SPARK-6685][MLLIB]Use DSYRK to compute AtA in ALS

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13891 **[Test build #67422 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67422/consoleFull)** for PR 13891 at commit

[GitHub] spark issue #13891: [SPARK-6685][MLLIB]Use DSYRK to compute AtA in ALS

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13891 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13891: [SPARK-6685][MLLIB]Use DSYRK to compute AtA in ALS

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13891 **[Test build #67422 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67422/consoleFull)** for PR 13891 at commit

[GitHub] spark issue #15513: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-10-23 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15513 I have another question. I found this PR also use `expressions` in the description when the function only accepts foldable expressions. This is also unclear to the users. --- If your project

[GitHub] spark pull request #15513: [SPARK-17963][SQL][Documentation] Add examples (e...

2016-10-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/15513#discussion_r84613013 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CallMethodViaReflection.scala --- @@ -43,11 +43,20 @@ import

[GitHub] spark issue #15513: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-10-23 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15513 To differentiate literals from expressions, the simplest way is to add `expr` or `expression` into the function name. For the arguments whose names do not contain `expr`, they are treated as

[GitHub] spark issue #15579: Added support for extra command in front of spark.

2016-10-23 Thread sheepduke
Github user sheepduke commented on the issue: https://github.com/apache/spark/pull/15579 @srowen Hi, at first we wanted to add support for numactl only, but later we thought that it is rather better to make it possible for adding the prefix command. It is not only for NUMA, but also

[GitHub] spark issue #13252: [SPARK-15473][SQL] CSV data source writes header for emp...

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13252 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13252: [SPARK-15473][SQL] CSV data source writes header for emp...

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13252 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67421/ Test PASSed. ---

[GitHub] spark issue #13252: [SPARK-15473][SQL] CSV data source writes header for emp...

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13252 **[Test build #67421 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67421/consoleFull)** for PR 13252 at commit

[GitHub] spark issue #15603: [WEBUI][MINOR] Return types in methods + cleanup

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15603 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67420/ Test PASSed. ---

[GitHub] spark issue #15603: [WEBUI][MINOR] Return types in methods + cleanup

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15603 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15603: [WEBUI][MINOR] Return types in methods + cleanup

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15603 **[Test build #67420 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67420/consoleFull)** for PR 15603 at commit

[GitHub] spark issue #15513: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-10-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15513 IMHO, I would like to leave it and prefer to differentiate literal from expression as it throws an exception, for example, when a column is given as an argument for literal, the exception

[GitHub] spark issue #15604: [SPARK-18066] [CORE] [TESTS] Add Pool usage policies tes...

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15604 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #15604: [SPARK-18066] [CORE] [TESTS] Add Pool usage policies tes...

2016-10-23 Thread erenavsarogullari
Github user erenavsarogullari commented on the issue: https://github.com/apache/spark/pull/15604 cc @kayousterhout @markhamstra --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #15604: Add Pool usage policies test coverage for FIFO & ...

2016-10-23 Thread erenavsarogullari
GitHub user erenavsarogullari opened a pull request: https://github.com/apache/spark/pull/15604 Add Pool usage policies test coverage for FIFO & FAIR Schedulers ## What changes were proposed in this pull request? The following FIFO & FAIR Schedulers Pool usage cases need to have

[GitHub] spark issue #15513: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-10-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15513 Thanks @gatorsmile. I will double-check if there is any instance more that misses default value. For the format, I asked @rxin initially to avoid change a lot repeatedly. Could I

[GitHub] spark issue #15441: [SPARK-4411] [Web UI] Add "kill" link for jobs in the UI

2016-10-23 Thread ajbozarth
Github user ajbozarth commented on the issue: https://github.com/apache/spark/pull/15441 @srowen Addressed the try-finally, this look good to go now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request #15513: [SPARK-17963][SQL][Documentation] Add examples (e...

2016-10-23 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15513#discussion_r84604637 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentile.scala --- @@ -49,21 +49,29 @@ import

[GitHub] spark pull request #15513: [SPARK-17963][SQL][Documentation] Add examples (e...

2016-10-23 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15513#discussion_r84604598 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/xml/xpath.scala --- @@ -150,8 +206,16 @@ case class XPathString(xml:

[GitHub] spark issue #15553: [SPARK-18008] [build] Add support for -Dmaven.test.skip=...

2016-10-23 Thread mridulm
Github user mridulm commented on the issue: https://github.com/apache/spark/pull/15553 @srowen This is explicitly supports maven.test.skip=true - the rationale for using it can be project specific (generating clean builds for various profile combinations, internal release builds from

[GitHub] spark issue #13252: [SPARK-15473][SQL] CSV data source writes header for emp...

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13252 **[Test build #67421 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67421/consoleFull)** for PR 13252 at commit

[GitHub] spark pull request #15602: [SPARK-18058][SQL] [BRANCH-2.0]Comparing column t...

2016-10-23 Thread CodingCat
Github user CodingCat closed the pull request at: https://github.com/apache/spark/pull/15602 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #15602: [SPARK-18058][SQL] [BRANCH-2.0]Comparing column types ig...

2016-10-23 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15602 Merging to branch-2.0. Thanks! Can you close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #15541: [SPARK-17637][Scheduler]Packed scheduling for Spark task...

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15541 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67418/ Test PASSed. ---

[GitHub] spark issue #15541: [SPARK-17637][Scheduler]Packed scheduling for Spark task...

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15541 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15541: [SPARK-17637][Scheduler]Packed scheduling for Spark task...

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15541 **[Test build #67418 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67418/consoleFull)** for PR 15541 at commit

  1   2   3   >