[GitHub] spark issue #15729: [SPARK-18133] [branch-2.0] [Examples] [ML] [Python ML Pi...

2016-11-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15729 **[Test build #67958 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67958/consoleFull)** for PR 15729 at commit

[GitHub] spark issue #15697: [SparkR][Test]:remove unnecessary suppressWarnings

2016-11-01 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15697 For the specific failure here, it was due to not syncing the latest version between the releases for Winodws and the others (when R 3.3.2 was released). As we use a fixed version, R 3.3.1 now

[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15677 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67946/ Test PASSed. ---

[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15677 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #15729: [SPARK-18133] [branch-2.0] [Examples] [ML] [Pytho...

2016-11-01 Thread jagadeesanas2
GitHub user jagadeesanas2 opened a pull request: https://github.com/apache/spark/pull/15729 [SPARK-18133] [branch-2.0] [Examples] [ML] [Python ML Pipeline Exampl… ## What changes were proposed in this pull request? [Fix] [branch-2.0] In Python 3, there is only one integer

[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-11-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15677 **[Test build #67946 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67946/consoleFull)** for PR 15677 at commit

[GitHub] spark issue #15567: [SPARK-14393][SQL] values generated by non-deterministic...

2016-11-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15567 **[Test build #67957 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67957/consoleFull)** for PR 15567 at commit

[GitHub] spark issue #15314: [SPARK-17747][ML] WeightCol support non-double datatypes

2016-11-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15314 **[Test build #67956 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67956/consoleFull)** for PR 15314 at commit

[GitHub] spark issue #15725: [SPARK-18167] Print out spark confs, and hive confs when...

2016-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15725 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15700: [SPARK-17964][SparkR] Enable SparkR with Mesos client mo...

2016-11-01 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/15700 This might not handle packages the best it can on mesos but that could be a follow-up @sun-rui --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark issue #15725: [SPARK-18167] Print out spark confs, and hive confs when...

2016-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15725 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67950/ Test PASSed. ---

[GitHub] spark issue #15705: [SPARK-18183] [SPARK-18184] Fix INSERT [INTO|OVERWRITE] ...

2016-11-01 Thread ericl
Github user ericl commented on the issue: https://github.com/apache/spark/pull/15705 I think you don't have to since this is just the test suite. On Tue, Nov 1, 2016, 8:49 PM Wenchen Fan wrote: > *@cloud-fan* commented on this pull request.

[GitHub] spark issue #15725: [SPARK-18167] Print out spark confs, and hive confs when...

2016-11-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15725 **[Test build #67950 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67950/consoleFull)** for PR 15725 at commit

[GitHub] spark pull request #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION sho...

2016-11-01 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/15704#discussion_r86076296 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala --- @@ -226,6 +227,63 @@ class HiveDDLSuite } }

[GitHub] spark pull request #15728: [SPARK-18133] [branch-2.0] [Examples] [ML] [Pytho...

2016-11-01 Thread jagadeesanas2
Github user jagadeesanas2 closed the pull request at: https://github.com/apache/spark/pull/15728 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #15728: [SPARK-18133] [branch-2.0] [Examples] [ML] [Python ML Pi...

2016-11-01 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/15728 could you close this and create a PR against branch-2.0 instead of master? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION sho...

2016-11-01 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/15704#discussion_r86075964 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -418,27 +419,53 @@ case class AlterTableRenamePartitionCommand(

[GitHub] spark issue #15314: [SPARK-17747][ML] WeightCol support non-double datatypes

2016-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15314 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION sho...

2016-11-01 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/15704#discussion_r86075872 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -418,27 +419,53 @@ case class AlterTableRenamePartitionCommand(

[GitHub] spark issue #15314: [SPARK-17747][ML] WeightCol support non-double datatypes

2016-11-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15314 **[Test build #67955 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67955/consoleFull)** for PR 15314 at commit

[GitHub] spark issue #15314: [SPARK-17747][ML] WeightCol support non-double datatypes

2016-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15314 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67955/ Test FAILed. ---

[GitHub] spark issue #15314: [SPARK-17747][ML] WeightCol support non-double datatypes

2016-11-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15314 **[Test build #67955 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67955/consoleFull)** for PR 15314 at commit

[GitHub] spark pull request #15484: [SPARK-17868][SQL] Do not use bitmasks during par...

2016-11-01 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15484#discussion_r86075526 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -229,10 +235,14 @@ class Analyzer( * Group

[GitHub] spark pull request #15484: [SPARK-17868][SQL] Do not use bitmasks during par...

2016-11-01 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15484#discussion_r86075344 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -229,10 +235,14 @@ class Analyzer( * Group

[GitHub] spark pull request #15484: [SPARK-17868][SQL] Do not use bitmasks during par...

2016-11-01 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15484#discussion_r86075252 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -216,10 +216,16 @@ class Analyzer( * Group

[GitHub] spark pull request #15024: [SPARK-17470][SQL] unify path for data source tab...

2016-11-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/15024#discussion_r86075163 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/sources/PathOptionSuite.scala --- @@ -0,0 +1,97 @@ +/* +* Licensed to the Apache Software

[GitHub] spark pull request #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION sho...

2016-11-01 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/15704#discussion_r86075107 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -418,27 +419,53 @@ case class AlterTableRenamePartitionCommand(

[GitHub] spark pull request #15702: [SPARK-18124] Observed delay based Event Time Wat...

2016-11-01 Thread CodingCat
Github user CodingCat commented on a diff in the pull request: https://github.com/apache/spark/pull/15702#discussion_r86075063 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulAggregate.scala --- @@ -104,85 +110,105 @@ case class

[GitHub] spark pull request #15673: [SPARK-17992][SQL] Return all partitions from Hiv...

2016-11-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15673 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #15697: [SparkR][Test]:remove unnecessary suppressWarnings

2016-11-01 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/15697 @HyukjinKwon the time window when download of an older version for windows could fail seem concerning. Is there a way to address that? --- If your project is set up for it, you can reply to

[GitHub] spark issue #15673: [SPARK-17992][SQL] Return all partitions from HiveShim w...

2016-11-01 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15673 Merging in master. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #15608: [SPARK-17838][SparkR] Check named arguments for o...

2016-11-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15608 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION sho...

2016-11-01 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/15704#discussion_r86074588 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -204,6 +207,38 @@ class AstBuilder extends

[GitHub] spark issue #15673: [SPARK-17992][SQL] Return all partitions from HiveShim w...

2016-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15673 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15608: [SPARK-17838][SparkR] Check named arguments for options ...

2016-11-01 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/15608 merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #15673: [SPARK-17992][SQL] Return all partitions from HiveShim w...

2016-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15673 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67949/ Test PASSed. ---

[GitHub] spark issue #15673: [SPARK-17992][SQL] Return all partitions from HiveShim w...

2016-11-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15673 **[Test build #67949 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67949/consoleFull)** for PR 15673 at commit

[GitHub] spark issue #15659: [SPARK-1267][SPARK-18129] Allow PySpark to be pip instal...

2016-11-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15659 **[Test build #67954 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67954/consoleFull)** for PR 15659 at commit

[GitHub] spark pull request #15659: [SPARK-1267][SPARK-18129] Allow PySpark to be pip...

2016-11-01 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/15659#discussion_r86073517 --- Diff: python/setup.py --- @@ -0,0 +1,170 @@ +#!/usr/bin/env python + +# +# Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] spark pull request #15659: [SPARK-1267][SPARK-18129] Allow PySpark to be pip...

2016-11-01 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/15659#discussion_r86073446 --- Diff: python/setup.py --- @@ -0,0 +1,180 @@ +#!/usr/bin/env python + +# +# Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] spark pull request #15659: [SPARK-1267][SPARK-18129] Allow PySpark to be pip...

2016-11-01 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/15659#discussion_r86073257 --- Diff: python/pyspark/version.py --- @@ -0,0 +1,19 @@ +#!/usr/bin/env python + +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request #15659: [SPARK-1267][SPARK-18129] Allow PySpark to be pip...

2016-11-01 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/15659#discussion_r86073111 --- Diff: python/pyspark/version.py --- @@ -0,0 +1,19 @@ +#!/usr/bin/env python + +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] spark issue #15659: [SPARK-1267][SPARK-18129] Allow PySpark to be pip instal...

2016-11-01 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/15659 This looks to be low-ish risk given it is mostly build & script changes. It would be great to get more python developers to review and test this out. --- If your project is set up for it,

[GitHub] spark pull request #15659: [SPARK-1267][SPARK-18129] Allow PySpark to be pip...

2016-11-01 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/15659#discussion_r86072893 --- Diff: dev/run-tests.py --- @@ -583,6 +589,7 @@ def main(): modules_with_python_tests = [m for m in test_modules if m.python_test_goals]

[GitHub] spark pull request #15659: [SPARK-1267][SPARK-18129] Allow PySpark to be pip...

2016-11-01 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/15659#discussion_r86072643 --- Diff: python/setup.py --- @@ -0,0 +1,180 @@ +#!/usr/bin/env python + +# +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] spark issue #15726: [SPARK-18107][SQL][FOLLOW-UP] Insert overwrite statement...

2016-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15726 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67945/ Test PASSed. ---

[GitHub] spark issue #15726: [SPARK-18107][SQL][FOLLOW-UP] Insert overwrite statement...

2016-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15726 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15726: [SPARK-18107][SQL][FOLLOW-UP] Insert overwrite statement...

2016-11-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15726 **[Test build #67945 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67945/consoleFull)** for PR 15726 at commit

[GitHub] spark issue #15723: [SPARK-18214][SQL] Simplify RuntimeReplaceable type coer...

2016-11-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15723 **[Test build #67953 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67953/consoleFull)** for PR 15723 at commit

[GitHub] spark issue #15723: [SPARK-18214][SQL] Simplify RuntimeReplaceable type coer...

2016-11-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15723 **[Test build #3393 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3393/consoleFull)** for PR 15723 at commit

[GitHub] spark issue #15671: [SPARK-18206][ML]Add instrumentation logs to ML training...

2016-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15671 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67947/ Test PASSed. ---

[GitHub] spark issue #15671: [SPARK-18206][ML]Add instrumentation logs to ML training...

2016-11-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15671 **[Test build #67947 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67947/consoleFull)** for PR 15671 at commit

[GitHub] spark issue #15671: [SPARK-18206][ML]Add instrumentation logs to ML training...

2016-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15671 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #15724: [SPARK-18216][SQL] Make Column.expr public

2016-11-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15724 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #15660: [SPARK-18133][Examples] [ML] [Python ML Pipeline Example...

2016-11-01 Thread jagadeesanas2
Github user jagadeesanas2 commented on the issue: https://github.com/apache/spark/pull/15660 @yanboliang PR for branch-2.0 https://github.com/apache/spark/pull/15728 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark issue #15711: [SPARK-18192] Support all file formats in structured str...

2016-11-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15711 **[Test build #67952 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67952/consoleFull)** for PR 15711 at commit

[GitHub] spark issue #15693: [SPARK-18125][SQL] Fix a compilation error in codegen du...

2016-11-01 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/15693 @hvanhovell any more thoughts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15724: [SPARK-18216][SQL] Make Column.expr public

2016-11-01 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15724 Thanks - merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15711: [SPARK-18192] Support all file formats in structured str...

2016-11-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15711 **[Test build #3392 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3392/consoleFull)** for PR 15711 at commit

[GitHub] spark issue #15711: [SPARK-18192] Support all file formats in structured str...

2016-11-01 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15711 @marmbrus I ended up adding test cases since they were trivial to add (and an existing test case was asserting that text would not be supported). --- If your project is set up for it, you can reply

[GitHub] spark issue #15728: [SPARK-18133] [branch-2.0] [Examples] [ML] [Python ML Pi...

2016-11-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15728 **[Test build #67951 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67951/consoleFull)** for PR 15728 at commit

[GitHub] spark pull request #15024: [SPARK-17470][SQL] unify path for data source tab...

2016-11-01 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/15024#discussion_r86070024 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -91,7 +73,8 @@ case class CreateTableLikeCommand(

[GitHub] spark pull request #15024: [SPARK-17470][SQL] unify path for data source tab...

2016-11-01 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/15024#discussion_r86070455 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -207,6 +207,9 @@ private[spark] class HiveExternalCatalog(conf:

[GitHub] spark pull request #15024: [SPARK-17470][SQL] unify path for data source tab...

2016-11-01 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/15024#discussion_r86069832 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -85,14 +86,7 @@ case class

[GitHub] spark pull request #15024: [SPARK-17470][SQL] unify path for data source tab...

2016-11-01 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/15024#discussion_r86069964 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -665,15 +665,7 @@ case class AlterTableSetLocationCommand(

[GitHub] spark pull request #15024: [SPARK-17470][SQL] unify path for data source tab...

2016-11-01 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/15024#discussion_r86070624 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -383,8 +389,22 @@ private[spark] class HiveExternalCatalog(conf:

[GitHub] spark pull request #15024: [SPARK-17470][SQL] unify path for data source tab...

2016-11-01 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/15024#discussion_r86070959 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -513,6 +555,16 @@ private[spark] class HiveExternalCatalog(conf:

[GitHub] spark pull request #15024: [SPARK-17470][SQL] unify path for data source tab...

2016-11-01 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/15024#discussion_r86070329 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/sources/PathOptionSuite.scala --- @@ -0,0 +1,97 @@ +/* +* Licensed to the Apache Software

[GitHub] spark pull request #15024: [SPARK-17470][SQL] unify path for data source tab...

2016-11-01 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/15024#discussion_r86070568 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -259,10 +266,9 @@ private[spark] class HiveExternalCatalog(conf:

[GitHub] spark pull request #15024: [SPARK-17470][SQL] unify path for data source tab...

2016-11-01 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/15024#discussion_r86070169 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -541,3 +434,123 @@ case class DataSource( }

[GitHub] spark pull request #15024: [SPARK-17470][SQL] unify path for data source tab...

2016-11-01 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/15024#discussion_r86066888 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala --- @@ -196,18 +196,32 @@ class InMemoryCatalog(

[GitHub] spark pull request #15728: [SPARK-18133] [branch-2.0] [Examples] [ML] [Pytho...

2016-11-01 Thread jagadeesanas2
GitHub user jagadeesanas2 opened a pull request: https://github.com/apache/spark/pull/15728 [SPARK-18133] [branch-2.0] [Examples] [ML] [Python ML Pipeline Example has syntax errors] ## What changes were proposed in this pull request? [Fix] [branch-2.0] In Python 3, there

[GitHub] spark issue #15725: [SPARK-18167] Print out spark confs, and hive confs when...

2016-11-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15725 **[Test build #67950 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67950/consoleFull)** for PR 15725 at commit

[GitHub] spark issue #15725: [SPARK-18167] Print out spark confs, and hive confs when...

2016-11-01 Thread JoshRosen
Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/15725 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15668: [SPARK-18137][SQL]Fix RewriteDistinctAggregates Unresolv...

2016-11-01 Thread windpiger
Github user windpiger commented on the issue: https://github.com/apache/spark/pull/15668 @cloud-fan yes,It is simpler,I check the query plan, my test case `sql("SELECTpercentile_approx(key, 0.9)" + ", count(distinct key),sum(distinct key) FROM src LIMIT 1")`

[GitHub] spark issue #15692: [SPARK-18177][ML][PYSPARK] Add missing 'subsamplingRate'...

2016-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15692 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67948/ Test PASSed. ---

[GitHub] spark issue #15692: [SPARK-18177][ML][PYSPARK] Add missing 'subsamplingRate'...

2016-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15692 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15692: [SPARK-18177][ML][PYSPARK] Add missing 'subsamplingRate'...

2016-11-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15692 **[Test build #67948 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67948/consoleFull)** for PR 15692 at commit

[GitHub] spark issue #15727: [SPARK-17895] Improve doc for rangeBetween and rowsBetwe...

2016-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15727 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #15727: [SPARK-17895] Improve doc for rangeBetween and ro...

2016-11-01 Thread david-weiluo-ren
GitHub user david-weiluo-ren opened a pull request: https://github.com/apache/spark/pull/15727 [SPARK-17895] Improve doc for rangeBetween and rowsBetween ## What changes were proposed in this pull request? Copied description for row and range based frame boundary from

[GitHub] spark issue #15703: [SPARK-18186] Migrate HiveUDAFFunction to TypedImperativ...

2016-11-01 Thread liancheng
Github user liancheng commented on the issue: https://github.com/apache/spark/pull/15703 OK, now it's ready for review and merge. cc @yhuai @JoshRosen @cloud-fan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request #15705: [SPARK-18183] [SPARK-18184] Fix INSERT [INTO|OVER...

2016-11-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15705#discussion_r86069348 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala --- @@ -180,7 +180,16 @@ class PlanParserSuite extends

[GitHub] spark issue #15673: [SPARK-17992][SQL] Return all partitions from HiveShim w...

2016-11-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15673 **[Test build #67949 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67949/consoleFull)** for PR 15673 at commit

[GitHub] spark issue #15673: [SPARK-17992][SQL] Return all partitions from HiveShim w...

2016-11-01 Thread mallman
Github user mallman commented on the issue: https://github.com/apache/spark/pull/15673 Rebased. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #15692: [SPARK-18177][ML][PYSPARK] Add missing 'subsamplingRate'...

2016-11-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15692 **[Test build #67948 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67948/consoleFull)** for PR 15692 at commit

[GitHub] spark issue #15692: [SPARK-18177][ML][PYSPARK] Add missing 'subsamplingRate'...

2016-11-01 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/15692 that's ok. I have delete the params. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-11-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15677 **[Test build #67946 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67946/consoleFull)** for PR 15677 at commit

[GitHub] spark issue #15671: [SPARK-18206][ML]Add instrumentation logs to ML training...

2016-11-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15671 **[Test build #67947 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67947/consoleFull)** for PR 15671 at commit

[GitHub] spark issue #14937: [SPARK-8519][SPARK-11560] [ML] [MLlib] Optimize KMeans i...

2016-11-01 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/14937 A small update: I have run a few tests on a refactored version of this patch which avoids some data copying. I have found at least one case where the current patch is faster, but many where it is

[GitHub] spark issue #15725: [SPARK-18167] Print out spark confs, and hive confs when...

2016-11-01 Thread ericl
Github user ericl commented on the issue: https://github.com/apache/spark/pull/15725 Oh cool it flaked on that run jenkins retest this please. // let's try to get a successful run for comparison --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark issue #15669: [SPARK-18160][CORE][YARN] spark.files & spark.jars shoul...

2016-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15669 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15702: [SPARK-18124] Observed delay based Event Time Watermarks

2016-11-01 Thread koeninger
Github user koeninger commented on the issue: https://github.com/apache/spark/pull/15702 Given the concerns Ofir raised about a single far future event screwing up monotonic event time, do you want to document that problem even if there isn't an enforced filter for it? --- If your

[GitHub] spark issue #15669: [SPARK-18160][CORE][YARN] spark.files & spark.jars shoul...

2016-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15669 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67941/ Test PASSed. ---

[GitHub] spark issue #15669: [SPARK-18160][CORE][YARN] spark.files & spark.jars shoul...

2016-11-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15669 **[Test build #67941 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67941/consoleFull)** for PR 15669 at commit

[GitHub] spark pull request #15702: [SPARK-18124] Observed delay based Event Time Wat...

2016-11-01 Thread koeninger
Github user koeninger commented on a diff in the pull request: https://github.com/apache/spark/pull/15702#discussion_r86066774 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -536,6 +535,41 @@ class Dataset[T] private[sql]( } /**

[GitHub] spark pull request #15702: [SPARK-18124] Observed delay based Event Time Wat...

2016-11-01 Thread koeninger
Github user koeninger commented on a diff in the pull request: https://github.com/apache/spark/pull/15702#discussion_r86067616 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulAggregate.scala --- @@ -104,85 +110,105 @@ case class

[GitHub] spark pull request #15702: [SPARK-18124] Observed delay based Event Time Wat...

2016-11-01 Thread koeninger
Github user koeninger commented on a diff in the pull request: https://github.com/apache/spark/pull/15702#discussion_r86066376 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -536,6 +535,41 @@ class Dataset[T] private[sql]( } /**

[GitHub] spark pull request #15702: [SPARK-18124] Observed delay based Event Time Wat...

2016-11-01 Thread koeninger
Github user koeninger commented on a diff in the pull request: https://github.com/apache/spark/pull/15702#discussion_r86066082 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -536,6 +535,41 @@ class Dataset[T] private[sql]( } /**

[GitHub] spark issue #15675: [SPARK-18144][SQL] logging StreamingQueryListener$QueryS...

2016-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15675 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15675: [SPARK-18144][SQL] logging StreamingQueryListener$QueryS...

2016-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15675 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67942/ Test PASSed. ---

  1   2   3   4   5   6   7   8   >