[GitHub] spark issue #16323: [SPARK-18911] [SQL] Define CatalogStatistics to interact...

2016-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16323 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70295/ Test FAILed. ---

[GitHub] spark issue #16324: [SPARK-18910][SQL]Resolve faile to use UDF that jar file...

2016-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16324 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70296/ Test FAILed. ---

[GitHub] spark issue #16324: [SPARK-18910][SQL]Resolve faile to use UDF that jar file...

2016-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16324 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16323: [SPARK-18911] [SQL] Define CatalogStatistics to interact...

2016-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16323 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #16323: [SPARK-18911] [SQL] Define CatalogStatistics to interact...

2016-12-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16323 **[Test build #70295 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70295/consoleFull)** for PR 16323 at commit

[GitHub] spark issue #16324: [SPARK-18910][SQL]Resolve faile to use UDF that jar file...

2016-12-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16324 **[Test build #70296 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70296/testReport)** for PR 16324 at commit

[GitHub] spark issue #16324: [SPARK-18910][SQL]Resolve faile to use UDF that jar file...

2016-12-16 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16324 Please add the description in the JIRA to the PR description. FYI, you still can edit the description after you create the PR. --- If your project is set up for it, you can reply to this email

[GitHub] spark issue #16290: [SPARK-18817] [SPARKR] [SQL] Set default warehouse dir t...

2016-12-16 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16290 I finished my review. cc @cloud-fan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #16301: [SPARK-18849][ML][SPARKR][DOC] vignettes final ch...

2016-12-16 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/16301#discussion_r92916892 --- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd --- @@ -496,9 +508,114 @@ count(carsDF_test) head(carsDF_test) ``` - ### Models

[GitHub] spark issue #16194: [SPARK-18767][ML] Unify Models' toString methods

2016-12-16 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/16194 @sethah No. Just for the convenience in repl. It's somewhat confusing when the model's desc is just the uid of its trainer when I work in repl. --- If your project is set up for it, you can

[GitHub] spark issue #16249: [SPARK-18828][SPARKR] Refactor scripts for R

2016-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16249 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70294/ Test FAILed. ---

[GitHub] spark issue #16249: [SPARK-18828][SPARKR] Refactor scripts for R

2016-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16249 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16249: [SPARK-18828][SPARKR] Refactor scripts for R

2016-12-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16249 **[Test build #70294 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70294/testReport)** for PR 16249 at commit

[GitHub] spark pull request #16290: [SPARK-18817] [SPARKR] [SQL] Set default warehous...

2016-12-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16290#discussion_r92916658 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -819,7 +819,13 @@ private[sql] class SQLConf extends Serializable

[GitHub] spark pull request #16319: [SPARK-18699] SQL - parsing CSV should return nul...

2016-12-16 Thread kubatyszko
Github user kubatyszko commented on a diff in the pull request: https://github.com/apache/spark/pull/16319#discussion_r92916668 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala --- @@ -246,9 +246,9 @@ private[csv] object

[GitHub] spark issue #16291: [SPARK-18838][CORE] Use separate executor service for ea...

2016-12-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16291 **[Test build #70299 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70299/testReport)** for PR 16291 at commit

[GitHub] spark issue #16291: [SPARK-18838][CORE] Use separate executor service for ea...

2016-12-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16291 **[Test build #70298 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70298/testReport)** for PR 16291 at commit

[GitHub] spark issue #16291: [SPARK-18838][CORE] Use separate executor service for ea...

2016-12-16 Thread sitalkedia
Github user sitalkedia commented on the issue: https://github.com/apache/spark/pull/16291 Jenkins test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #16282: [DO_NOT_MERGE]Try to fix kafka

2016-12-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16282 **[Test build #70297 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70297/testReport)** for PR 16282 at commit

[GitHub] spark issue #16282: [DO_NOT_MERGE]Try to fix kafka

2016-12-16 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/16282 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #16324: Resolve faile to use UDF that jar file in hdfs.

2016-12-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16324 **[Test build #70296 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70296/testReport)** for PR 16324 at commit

[GitHub] spark pull request #16324: Resolve faile to use UDF that jar file in hdfs.

2016-12-16 Thread shenh062326
GitHub user shenh062326 opened a pull request: https://github.com/apache/spark/pull/16324 Resolve faile to use UDF that jar file in hdfs. ## What changes were proposed in this pull request? In SparkContext, setURLStreamHandlerFactory method on URL with an instance of

[GitHub] spark issue #15544: [SPARK-17997] [SQL] Add an aggregation function for coun...

2016-12-16 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15544 @wzhfy let's close this one for now. I think we can revisit it in the future when we introduce more advanced statistics. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark issue #15666: [SPARK-11421] [Core][Python][R] Added ability for addJar...

2016-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15666 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70293/ Test PASSed. ---

[GitHub] spark issue #15666: [SPARK-11421] [Core][Python][R] Added ability for addJar...

2016-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15666 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15666: [SPARK-11421] [Core][Python][R] Added ability for addJar...

2016-12-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15666 **[Test build #70293 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70293/testReport)** for PR 15666 at commit

[GitHub] spark pull request #16290: [SPARK-18817] [SPARKR] [SQL] Set default warehous...

2016-12-16 Thread bdwyer2
Github user bdwyer2 commented on a diff in the pull request: https://github.com/apache/spark/pull/16290#discussion_r92916155 --- Diff: R/pkg/inst/tests/testthat/test_context.R --- @@ -72,6 +72,20 @@ test_that("repeatedly starting and stopping SparkSession", { } })

[GitHub] spark issue #16290: [SPARK-18817] [SPARKR] [SQL] Set default warehouse dir t...

2016-12-16 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/16290 @felixcheung @bdwyer2 Could you take another look ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request #16308: [SPARK-18350][SQL][WIP] Support session local tim...

2016-12-16 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/16308#discussion_r92916070 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -30,21 +30,44 @@ import

[GitHub] spark issue #16228: [WIP] [SPARK-17076] [SQL] Cardinality estimation for joi...

2016-12-16 Thread wzhfy
Github user wzhfy commented on the issue: https://github.com/apache/spark/pull/16228 To solve [the two issues](https://github.com/apache/spark/pull/16228#issuecomment-265946299) I mentioned above, a separate PR is sent [here](https://github.com/apache/spark/pull/16323). We need

[GitHub] spark issue #16323: [SPARK-18911] [SQL] Define CatalogStatistics to interact...

2016-12-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16323 **[Test build #70295 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70295/consoleFull)** for PR 16323 at commit

[GitHub] spark pull request #16323: [SPARK-18911] [SQL] Define CatalogStatistics to i...

2016-12-16 Thread wzhfy
GitHub user wzhfy opened a pull request: https://github.com/apache/spark/pull/16323 [SPARK-18911] [SQL] Define CatalogStatistics to interact with metastore and convert it to Statistics based on cbo switch ## What changes were proposed in this pull request? Statistics

[GitHub] spark pull request #16305: [SPARK-18895][TESTS] Fix resource-closing-related...

2016-12-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16305 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #16305: [SPARK-18895][TESTS] Fix resource-closing-related and pa...

2016-12-16 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/16305 Thanks @HyukjinKwon - Merging into master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #16308: [SPARK-18350][SQL][WIP] Support session local tim...

2016-12-16 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/16308#discussion_r92915894 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -120,7 +128,10 @@ object Cast { > SELECT

[GitHub] spark pull request #16308: [SPARK-18350][SQL][WIP] Support session local tim...

2016-12-16 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/16308#discussion_r92915851 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -111,7 +112,8 @@ case class CatalogTablePartition(

[GitHub] spark issue #16308: [SPARK-18350][SQL][WIP] Support session local timezone.

2016-12-16 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/16308 I'd rename all the zoneId to timeZoneId to reduce confusion .. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request #16308: [SPARK-18350][SQL][WIP] Support session local tim...

2016-12-16 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/16308#discussion_r92915771 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -120,7 +128,10 @@ object Cast { > SELECT

[GitHub] spark pull request #16308: [SPARK-18350][SQL][WIP] Support session local tim...

2016-12-16 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/16308#discussion_r92915757 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -110,6 +110,14 @@ object Cast { case (_:

[GitHub] spark pull request #16308: [SPARK-18350][SQL][WIP] Support session local tim...

2016-12-16 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/16308#discussion_r92915708 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -30,21 +30,44 @@ import

[GitHub] spark pull request #16189: [SPARK-18761][CORE] Introduce "task reaper" to ov...

2016-12-16 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/16189#discussion_r92915680 --- Diff: core/src/test/scala/org/apache/spark/JobCancellationSuite.scala --- @@ -209,6 +209,41 @@ class JobCancellationSuite extends SparkFunSuite with

[GitHub] spark issue #16030: [SPARK-18108][SQL] Fix a schema inconsistent bug that ma...

2016-12-16 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/16030 okay! I'll make a JIRA later and thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #16319: [SPARK-18699] SQL - parsing CSV should return nul...

2016-12-16 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/16319#discussion_r92915632 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala --- @@ -246,9 +246,9 @@ private[csv] object

[GitHub] spark issue #16319: [SPARK-18699] SQL - parsing CSV should return null for c...

2016-12-16 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/16319 @HyukjinKwon Thanks for your pinging! I left some comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #16249: [SPARK-18828][SPARKR] Refactor scripts for R

2016-12-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16249 **[Test build #70294 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70294/testReport)** for PR 16249 at commit

[GitHub] spark pull request #13909: [SPARK-16213][SQL] Reduce runtime overhead of a p...

2016-12-16 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/13909#discussion_r92915607 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -56,33 +58,93 @@ case class

[GitHub] spark issue #16030: [SPARK-18108][SQL] Fix a schema inconsistent bug that ma...

2016-12-16 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16030 This was the behavior change your PR proposed before, I think it makes sense, you can send a PR to fix it in Spark 2.2 --- If your project is set up for it, you can reply to this email and have

[GitHub] spark issue #16312: [SPARK-18862][SPARKR][ML] Split SparkR mllib.R into mult...

2016-12-16 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/16312 I like how they are grouped. not sure why tests are failing though --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #15915: [SPARK-18485][CORE] Underlying integer overflow when cre...

2016-12-16 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/15915 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #16305: [SPARK-18895][TESTS] Fix resource-closing-related and pa...

2016-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16305 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70291/ Test PASSed. ---

[GitHub] spark issue #16305: [SPARK-18895][TESTS] Fix resource-closing-related and pa...

2016-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16305 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16305: [SPARK-18895][TESTS] Fix resource-closing-related and pa...

2016-12-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16305 **[Test build #70291 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70291/testReport)** for PR 16305 at commit

[GitHub] spark issue #16320: [SPARK-18877][SQL] `CSVInferSchema.inferField` on Decima...

2016-12-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/16320 Actually, I made the end-to-end test based on the example of the use case in JIRA first. And, I removed that from here because the current test case is the minimal version of that. --- If

[GitHub] spark pull request #16320: [SPARK-18877][SQL] `CSVInferSchema.inferField` on...

2016-12-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/16320#discussion_r92915371 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala --- @@ -85,7 +85,9 @@ private[csv] object

[GitHub] spark pull request #16261: [SPARK-18836] [CORE] Serialize one copy of task m...

2016-12-16 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/16261#discussion_r92914999 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -1009,13 +1009,14 @@ class DAGScheduler( } val

[GitHub] spark pull request #16189: [SPARK-18761][CORE] Introduce "task reaper" to ov...

2016-12-16 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/16189#discussion_r92914921 --- Diff: core/src/test/scala/org/apache/spark/JobCancellationSuite.scala --- @@ -209,6 +209,41 @@ class JobCancellationSuite extends SparkFunSuite with

[GitHub] spark pull request #16189: [SPARK-18761][CORE] Introduce "task reaper" to ov...

2016-12-16 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/16189#discussion_r92914965 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -148,9 +161,23 @@ private[spark] class Executor( } def

[GitHub] spark pull request #16189: [SPARK-18761][CORE] Introduce "task reaper" to ov...

2016-12-16 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/16189#discussion_r92914792 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -229,9 +259,12 @@ private[spark] class Executor( //

[GitHub] spark pull request #16189: [SPARK-18761][CORE] Introduce "task reaper" to ov...

2016-12-16 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/16189#discussion_r92914957 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -432,6 +465,93 @@ private[spark] class Executor( } /**

[GitHub] spark pull request #16189: [SPARK-18761][CORE] Introduce "task reaper" to ov...

2016-12-16 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/16189#discussion_r92914715 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -161,12 +163,7 @@ private[spark] class Executor( * @param

[GitHub] spark pull request #16189: [SPARK-18761][CORE] Introduce "task reaper" to ov...

2016-12-16 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/16189#discussion_r92914906 --- Diff: core/src/test/scala/org/apache/spark/JobCancellationSuite.scala --- @@ -209,6 +209,83 @@ class JobCancellationSuite extends SparkFunSuite with

[GitHub] spark pull request #16189: [SPARK-18761][CORE] Introduce "task reaper" to ov...

2016-12-16 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/16189#discussion_r92914831 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -432,6 +465,93 @@ private[spark] class Executor( } /**

[GitHub] spark pull request #16189: [SPARK-18761][CORE] Introduce "task reaper" to ov...

2016-12-16 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/16189#discussion_r92914652 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -148,9 +161,23 @@ private[spark] class Executor( } def

[GitHub] spark pull request #16189: [SPARK-18761][CORE] Introduce "task reaper" to ov...

2016-12-16 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/16189#discussion_r92914887 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -432,6 +465,93 @@ private[spark] class Executor( } /**

[GitHub] spark issue #16263: [SPARK-18281][SQL][PySpark] Consumes the returned local ...

2016-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16263 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70292/ Test PASSed. ---

[GitHub] spark issue #16263: [SPARK-18281][SQL][PySpark] Consumes the returned local ...

2016-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16263 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16263: [SPARK-18281][SQL][PySpark] Consumes the returned local ...

2016-12-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16263 **[Test build #70292 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70292/testReport)** for PR 16263 at commit

[GitHub] spark issue #16320: [SPARK-18877][SQL] `CSVInferSchema.inferField` on Decima...

2016-12-16 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/16320 @dongjoon-hyun would we need a end-to-end test too? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #16304: [SPARK-18894][SS] Fix event time watermark delay thresho...

2016-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16304 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70284/ Test FAILed. ---

[GitHub] spark issue #16304: [SPARK-18894][SS] Fix event time watermark delay thresho...

2016-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16304 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16304: [SPARK-18894][SS] Fix event time watermark delay thresho...

2016-12-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16304 **[Test build #70284 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70284/testReport)** for PR 16304 at commit

[GitHub] spark pull request #16320: [SPARK-18877][SQL] `CSVInferSchema.inferField` on...

2016-12-16 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16320#discussion_r92914568 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala --- @@ -85,7 +85,9 @@ private[csv] object

[GitHub] spark issue #16305: [SPARK-18895][TESTS] Fix resource-closing-related and pa...

2016-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16305 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70286/ Test PASSed. ---

[GitHub] spark issue #16305: [SPARK-18895][TESTS] Fix resource-closing-related and pa...

2016-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16305 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15666: [SPARK-11421] [Core][Python][R] Added ability for addJar...

2016-12-16 Thread mariusvniekerk
Github user mariusvniekerk commented on the issue: https://github.com/apache/spark/pull/15666 Rebased. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #15666: [SPARK-11421] [Core][Python][R] Added ability for addJar...

2016-12-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15666 **[Test build #70293 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70293/testReport)** for PR 15666 at commit

[GitHub] spark issue #16305: [SPARK-18895][TESTS] Fix resource-closing-related and pa...

2016-12-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16305 **[Test build #70286 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70286/testReport)** for PR 16305 at commit

[GitHub] spark issue #16319: [SPARK-18699] SQL - parsing CSV should return null for c...

2016-12-16 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/16319 Let's put `[WIP]` in the PR title, for example, (`[WIP][SPARK-18699] ... `) if you are working on this to follow the suggestion in the JIRA. It seems we need to update the PR description (and

[GitHub] spark issue #16322: [SPARK-18908][SS] Creating StreamingQueryException shoul...

2016-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16322 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16322: [SPARK-18908][SS] Creating StreamingQueryException shoul...

2016-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16322 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70288/ Test PASSed. ---

[GitHub] spark issue #16322: [SPARK-18908][SS] Creating StreamingQueryException shoul...

2016-12-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16322 **[Test build #70288 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70288/testReport)** for PR 16322 at commit

[GitHub] spark issue #16263: [SPARK-18281][SQL][PySpark] Consumes the returned local ...

2016-12-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16263 **[Test build #70292 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70292/testReport)** for PR 16263 at commit

[GitHub] spark issue #16291: [SPARK-18838][CORE] Use separate executor service for ea...

2016-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16291 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70290/ Test FAILed. ---

[GitHub] spark issue #16304: [SPARK-18894][SS] Fix event time watermark delay thresho...

2016-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16304 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16291: [SPARK-18838][CORE] Use separate executor service for ea...

2016-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16291 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16304: [SPARK-18894][SS] Fix event time watermark delay thresho...

2016-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16304 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70282/ Test FAILed. ---

[GitHub] spark issue #16291: [SPARK-18838][CORE] Use separate executor service for ea...

2016-12-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16291 **[Test build #70290 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70290/testReport)** for PR 16291 at commit

[GitHub] spark issue #16304: [SPARK-18894][SS] Fix event time watermark delay thresho...

2016-12-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16304 **[Test build #70282 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70282/testReport)** for PR 16304 at commit

[GitHub] spark pull request #16319: SPARK-18906 SQL - parsing CSV should return null ...

2016-12-16 Thread kubatyszko
Github user kubatyszko commented on a diff in the pull request: https://github.com/apache/spark/pull/16319#discussion_r92913976 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala --- @@ -246,9 +246,9 @@ private[csv] object

[GitHub] spark pull request #16320: [SPARK-18877][SQL] `CSVInferSchema.inferField` on...

2016-12-16 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16320#discussion_r92913834 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala --- @@ -85,7 +85,9 @@ private[csv] object

[GitHub] spark pull request #16319: SPARK-18906 SQL - parsing CSV should return null ...

2016-12-16 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16319#discussion_r92913320 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala --- @@ -246,9 +246,9 @@ private[csv] object

[GitHub] spark issue #16319: SPARK-18906 SQL - parsing CSV should return null for cer...

2016-12-16 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/16319 Can you describe which case this PR fixes? I think you meant https://issues.apache.org/jira/browse/SPARK-18699 --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark issue #16305: [SPARK-18895][TESTS] Fix resource-closing-related and pa...

2016-12-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16305 **[Test build #70291 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70291/testReport)** for PR 16305 at commit

[GitHub] spark pull request #16305: [SPARK-18895][TESTS] Fix resource-closing-related...

2016-12-16 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16305#discussion_r92912445 --- Diff: core/src/main/scala/org/apache/spark/deploy/RPackageUtils.scala --- @@ -231,8 +236,10 @@ private[deploy] object RPackageUtils extends Logging

[GitHub] spark pull request #16263: [SPARK-18281][SQL][PySpark] Consumes the returned...

2016-12-16 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16263#discussion_r92912335 --- Diff: python/pyspark/rdd.py --- @@ -2349,7 +2352,12 @@ def toLocalIterator(self): """ with SCCallSiteSync(self.context) as css:

[GitHub] spark pull request #16305: [SPARK-18895][TESTS] Fix resource-closing-related...

2016-12-16 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16305#discussion_r92912156 --- Diff: core/src/main/scala/org/apache/spark/deploy/RPackageUtils.scala --- @@ -231,8 +236,10 @@ private[deploy] object RPackageUtils extends Logging

[GitHub] spark issue #16282: [DO_NOT_MERGE]Try to fix kafka

2016-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16282 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16282: [DO_NOT_MERGE]Try to fix kafka

2016-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16282 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70281/ Test PASSed. ---

[GitHub] spark issue #16282: [DO_NOT_MERGE]Try to fix kafka

2016-12-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16282 **[Test build #70281 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70281/testReport)** for PR 16282 at commit

[GitHub] spark pull request #16305: [SPARK-18895][TESTS] Fix resource-closing-related...

2016-12-16 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/16305#discussion_r92911599 --- Diff: core/src/main/scala/org/apache/spark/deploy/RPackageUtils.scala --- @@ -231,8 +236,10 @@ private[deploy] object RPackageUtils extends Logging {

  1   2   3   4   5   >