[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95054651 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object CaseKeyWhen

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95054605 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ConditionalExpressionSuite.scala --- @@ -137,4 +139,48 @@ class

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95054575 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ConditionalExpressionSuite.scala --- @@ -137,4 +139,48 @@ class

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95054547 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object CaseKeyWhen

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95054508 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object CaseKeyWhen

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95054387 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object CaseKeyWhen

[GitHub] spark issue #16493: [SPARK-19093][SQL] Cached tables are not used in Subquer...

2017-01-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16493 **[Test build #71006 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71006/testReport)** for PR 16493 at commit

[GitHub] spark issue #16493: [SPARK-19093][SQL] Cached tables are not used in Subquer...

2017-01-06 Thread dilipbiswal
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/16493 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #16493: [SPARK-19093][SQL] Cached tables are not used in Subquer...

2017-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16493 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71005/ Test FAILed. ---

[GitHub] spark issue #16493: [SPARK-19093][SQL] Cached tables are not used in Subquer...

2017-01-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16493 **[Test build #71005 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71005/testReport)** for PR 16493 at commit

[GitHub] spark issue #16493: [SPARK-19093][SQL] Cached tables are not used in Subquer...

2017-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16493 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #16400: [SPARK-18941][SQL][DOC] Add a new behavior docume...

2017-01-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16400#discussion_r95053274 --- Diff: docs/sql-programming-guide.md --- @@ -1362,6 +1362,13 @@ options. - Dataset and DataFrame API `explode` has been deprecated,

[GitHub] spark pull request #16400: [SPARK-18941][SQL][DOC] Add a new behavior docume...

2017-01-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16400#discussion_r95053222 --- Diff: docs/sql-programming-guide.md --- @@ -1362,6 +1362,13 @@ options. - Dataset and DataFrame API `explode` has been deprecated,

[GitHub] spark issue #16493: [SPARK-19093][SQL] Cached tables are not used in Subquer...

2017-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16493 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71004/ Test PASSed. ---

[GitHub] spark issue #16493: [SPARK-19093][SQL] Cached tables are not used in Subquer...

2017-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16493 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16493: [SPARK-19093][SQL] Cached tables are not used in Subquer...

2017-01-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16493 **[Test build #71004 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71004/testReport)** for PR 16493 at commit

[GitHub] spark issue #16488: [MINOR] Bump R version to 2.2.0.

2017-01-06 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/16488 Yeah I think it does get automatically updated during the release but its good to keep this in sync this just for the development builds etc. --- If your project is set up for it, you can reply

[GitHub] spark issue #16493: [SPARK-19093][SQL] Cached tables are not used in Subquer...

2017-01-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16493 **[Test build #71005 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71005/testReport)** for PR 16493 at commit

[GitHub] spark issue #16344: [SPARK-18929][ML] Add Tweedie distribution in GLM

2017-01-06 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/16344 @srowen @yanboliang I'm closing this PR since it does not seem to be very clean to integrate into the current GLM setup. I appreciate all the comments and discussions. --- If your

[GitHub] spark pull request #16400: [SPARK-18941][SQL][DOC] Add a new behavior docume...

2017-01-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16400#discussion_r95052715 --- Diff: docs/sql-programming-guide.md --- @@ -1362,6 +1362,13 @@ options. - Dataset and DataFrame API `explode` has been deprecated,

[GitHub] spark pull request #16400: [SPARK-18941][SQL][DOC] Add a new behavior docume...

2017-01-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16400#discussion_r95052705 --- Diff: docs/sql-programming-guide.md --- @@ -1362,6 +1362,13 @@ options. - Dataset and DataFrame API `explode` has been deprecated,

[GitHub] spark pull request #16400: [SPARK-18941][SQL][DOC] Add a new behavior docume...

2017-01-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16400#discussion_r95052691 --- Diff: docs/sql-programming-guide.md --- @@ -1362,6 +1362,13 @@ options. - Dataset and DataFrame API `explode` has been deprecated,

[GitHub] spark pull request #16344: [SPARK-18929][ML] Add Tweedie distribution in GLM

2017-01-06 Thread actuaryzhang
Github user actuaryzhang closed the pull request at: https://github.com/apache/spark/pull/16344 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request #16400: [SPARK-18941][SQL][DOC] Add a new behavior docume...

2017-01-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16400#discussion_r95052654 --- Diff: docs/sql-programming-guide.md --- @@ -1362,6 +1362,13 @@ options. - Dataset and DataFrame API `explode` has been deprecated,

[GitHub] spark issue #15505: [SPARK-17931][CORE] taskScheduler has some unneeded seri...

2017-01-06 Thread witgo
Github user witgo commented on the issue: https://github.com/apache/spark/pull/15505 @kayousterhout Okay, I'll do the code revision this weekend. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request #16439: [SPARK-19026]SPARK_LOCAL_DIRS(multiple directorie...

2017-01-06 Thread zuotingbing
Github user zuotingbing commented on a diff in the pull request: https://github.com/apache/spark/pull/16439#discussion_r95052089 --- Diff: core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala --- @@ -445,12 +445,24 @@ private[deploy] class Worker( //

[GitHub] spark pull request #16439: [SPARK-19026]SPARK_LOCAL_DIRS(multiple directorie...

2017-01-06 Thread zuotingbing
Github user zuotingbing commented on a diff in the pull request: https://github.com/apache/spark/pull/16439#discussion_r95052088 --- Diff: core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala --- @@ -445,12 +445,24 @@ private[deploy] class Worker( //

[GitHub] spark pull request #16493: [SPARK-19093][SQL] Cached tables are not used in ...

2017-01-06 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/16493#discussion_r95052038 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala --- @@ -565,4 +567,82 @@ class CachedTableSuite extends QueryTest with

[GitHub] spark pull request #16493: [SPARK-19093][SQL] Cached tables are not used in ...

2017-01-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16493#discussion_r95051560 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala --- @@ -565,4 +577,67 @@ class CachedTableSuite extends QueryTest with

[GitHub] spark issue #16495: SPARK-16920: Add a stress test for evaluateEachIteration...

2017-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16495 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #16493: [SPARK-19093][SQL] Cached tables are not used in ...

2017-01-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16493#discussion_r95051550 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala --- @@ -565,4 +577,67 @@ class CachedTableSuite extends QueryTest with

[GitHub] spark issue #16495: SPARK-16920: Add a stress test for evaluateEachIteration...

2017-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16495 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71003/ Test PASSed. ---

[GitHub] spark issue #16495: SPARK-16920: Add a stress test for evaluateEachIteration...

2017-01-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16495 **[Test build #71003 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71003/testReport)** for PR 16495 at commit

[GitHub] spark pull request #16493: [SPARK-19093][SQL] Cached tables are not used in ...

2017-01-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16493#discussion_r95051546 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala --- @@ -565,4 +567,82 @@ class CachedTableSuite extends QueryTest with

[GitHub] spark issue #16493: [SPARK-19093][SQL] Cached tables are not used in Subquer...

2017-01-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16493 **[Test build #71004 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71004/testReport)** for PR 16493 at commit

[GitHub] spark pull request #16493: [SPARK-19093][SQL] Cached tables are not used in ...

2017-01-06 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/16493#discussion_r95051398 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala --- @@ -131,6 +132,12 @@ class CacheManager extends Logging {

[GitHub] spark issue #15119: [SPARK-17568][CORE][DEPLOY] Add spark-submit option to o...

2017-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15119 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71001/ Test PASSed. ---

[GitHub] spark issue #15119: [SPARK-17568][CORE][DEPLOY] Add spark-submit option to o...

2017-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15119 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15119: [SPARK-17568][CORE][DEPLOY] Add spark-submit option to o...

2017-01-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15119 **[Test build #71001 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71001/testReport)** for PR 15119 at commit

[GitHub] spark pull request #16493: [SPARK-19093][SQL] Cached tables are not used in ...

2017-01-06 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/16493#discussion_r95050805 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala --- @@ -131,6 +132,12 @@ class CacheManager extends Logging {

[GitHub] spark pull request #16493: [SPARK-19093][SQL] Cached tables are not used in ...

2017-01-06 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/16493#discussion_r95050799 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala --- @@ -565,4 +567,82 @@ class CachedTableSuite extends QueryTest with

[GitHub] spark pull request #16493: [SPARK-19093][SQL] Cached tables are not used in ...

2017-01-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16493#discussion_r95050745 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala --- @@ -131,6 +132,12 @@ class CacheManager extends Logging {

[GitHub] spark issue #16485: [SPARK-19099] correct the wrong time display in history ...

2017-01-06 Thread 351zyf
Github user 351zyf commented on the issue: https://github.com/apache/spark/pull/16485 But the time display on history server web UI is not correct. It is 8 hours eralier than the actual time here. Am I using the wrong configuration ? --- If your project is set up for

[GitHub] spark pull request #16493: [SPARK-19093][SQL] Cached tables are not used in ...

2017-01-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16493#discussion_r95050711 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala --- @@ -565,4 +567,82 @@ class CachedTableSuite extends QueryTest with

[GitHub] spark pull request #16493: [SPARK-19093][SQL] Cached tables are not used in ...

2017-01-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16493#discussion_r95050708 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala --- @@ -565,4 +567,82 @@ class CachedTableSuite extends QueryTest with

[GitHub] spark issue #16493: [SPARK-19093][SQL] Cached tables are not used in Subquer...

2017-01-06 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16493 In the test suite, we can have such a helper function to count `InMemoryRelation` ```Scala private def getNumInMemoryRelations(plan: LogicalPlan): Int = { var sum = plan.collect

[GitHub] spark pull request #16480: [SPARK-18194][ML] Log instrumentation in OneVsRes...

2017-01-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16480 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #15413: [SPARK-17847][ML] Reduce shuffled data size of GaussianM...

2017-01-06 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/15413 OK, I'll just wait so @sethah can make a final pass and so @yanboliang can merge the 2 tests. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request #16454: [SPARK-19055][SQL][PySpark] Fix SparkSession init...

2017-01-06 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/16454#discussion_r95050517 --- Diff: python/pyspark/sql/tests.py --- @@ -1886,6 +1887,28 @@ def test_hivecontext(self): self.assertTrue(os.path.exists(metastore_path))

[GitHub] spark issue #16480: [SPARK-18194][ML] Log instrumentation in OneVsRest, Cros...

2017-01-06 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/16480 Merging with master. Not backporting unless people request it since this memory leak is very minor. Thanks @sueann ! --- If your project is set up for it, you can reply to this email and

[GitHub] spark issue #16495: SPARK-16920: Add a stress test for evaluateEachIteration...

2017-01-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16495 **[Test build #71003 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71003/testReport)** for PR 16495 at commit

[GitHub] spark pull request #16495: SPARK-16920: Add a stress test for evaluateEachIt...

2017-01-06 Thread mhmoudr
GitHub user mhmoudr opened a pull request: https://github.com/apache/spark/pull/16495 SPARK-16920: Add a stress test for evaluateEachIteration for 2000 trees ## What changes were proposed in this pull request? Just adding a test to prove error by tree is working for 2000

[GitHub] spark issue #16493: [SPARK-19093][SQL] Cached tables are not used in Subquer...

2017-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16493 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70999/ Test PASSed. ---

[GitHub] spark issue #16493: [SPARK-19093][SQL] Cached tables are not used in Subquer...

2017-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16493 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16493: [SPARK-19093][SQL] Cached tables are not used in Subquer...

2017-01-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16493 **[Test build #70999 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70999/testReport)** for PR 16493 at commit

[GitHub] spark issue #16492: [SPARK-19113][SS][Tests]Set UncaughtExceptionHandler in ...

2017-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16492 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16492: [SPARK-19113][SS][Tests]Set UncaughtExceptionHandler in ...

2017-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16492 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70998/ Test PASSed. ---

[GitHub] spark issue #16492: [SPARK-19113][SS][Tests]Set UncaughtExceptionHandler in ...

2017-01-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16492 **[Test build #70998 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70998/testReport)** for PR 16492 at commit

[GitHub] spark issue #16138: [WIP][SPARK-16609] Add to_date/to_timestamp with format ...

2017-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16138 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70997/ Test PASSed. ---

[GitHub] spark issue #16138: [WIP][SPARK-16609] Add to_date/to_timestamp with format ...

2017-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16138 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16138: [WIP][SPARK-16609] Add to_date/to_timestamp with format ...

2017-01-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16138 **[Test build #70997 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70997/testReport)** for PR 16138 at commit

[GitHub] spark pull request #16493: [SPARK-19093][SQL] Cached tables are not used in ...

2017-01-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16493#discussion_r95049506 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala --- @@ -565,4 +567,82 @@ class CachedTableSuite extends QueryTest with

[GitHub] spark pull request #16493: [SPARK-19093][SQL] Cached tables are not used in ...

2017-01-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16493#discussion_r95049495 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala --- @@ -565,4 +567,82 @@ class CachedTableSuite extends QueryTest with

[GitHub] spark issue #16493: [SPARK-19093][SQL] Cached tables are not used in Subquer...

2017-01-06 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16493 @dilipbiswal Could you post the nested subquery in the PR description? It can help the other reviewers understand the fix. Thanks! --- If your project is set up for it, you can reply to this

[GitHub] spark issue #16494: [SPARK-17975][MLLIB] Fix EMLDAOptimizer failing with Cla...

2017-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16494 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16494: [SPARK-17975][MLLIB] Fix EMLDAOptimizer failing with Cla...

2017-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16494 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71002/ Test PASSed. ---

[GitHub] spark issue #16493: [SPARK-19093][SQL] Cached tables are not used in Subquer...

2017-01-06 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16493 Although the test cases can be improved, the code fix looks good to me. cc @JoshRosen @hvanhovell --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #16494: [SPARK-17975][MLLIB] Fix EMLDAOptimizer failing with Cla...

2017-01-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16494 **[Test build #71002 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71002/testReport)** for PR 16494 at commit

[GitHub] spark issue #14451: [SPARK-16848][SQL] Check schema validation for user-spec...

2017-01-06 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14451 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request #16387: [SPARK-18986][Core] ExternalAppendOnlyMap shouldn...

2017-01-06 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16387#discussion_r95048733 --- Diff: core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala --- @@ -115,6 +115,7 @@ class ExternalAppendOnlyMap[K, V, C](

[GitHub] spark pull request #16430: [SPARK-17077] [SQL] Cardinality estimation for pr...

2017-01-06 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/16430#discussion_r95048331 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/ProjectEstimationSuite.scala --- @@ -0,0 +1,51 @@ +/* + *

[GitHub] spark pull request #15819: [SPARK-18372][SQL][Branch-1.6].Staging directory ...

2017-01-06 Thread merlintang
Github user merlintang closed the pull request at: https://github.com/apache/spark/pull/15819 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark issue #15819: [SPARK-18372][SQL][Branch-1.6].Staging directory fail to...

2017-01-06 Thread merlintang
Github user merlintang commented on the issue: https://github.com/apache/spark/pull/15819 Many thanks, Xiao. I learnt lots. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15819: [SPARK-18372][SQL][Branch-1.6].Staging directory fail to...

2017-01-06 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15819 @merlintang Can you close this PR? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #15819: [SPARK-18372][SQL][Branch-1.6].Staging directory fail to...

2017-01-06 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15819 Thanks! Merging to 1.6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #16492: [SPARK-19113][SS][Tests]Set UncaughtExceptionHandler in ...

2017-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16492 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16492: [SPARK-19113][SS][Tests]Set UncaughtExceptionHandler in ...

2017-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16492 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70995/ Test PASSed. ---

[GitHub] spark issue #16492: [SPARK-19113][SS][Tests]Set UncaughtExceptionHandler in ...

2017-01-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16492 **[Test build #70995 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70995/testReport)** for PR 16492 at commit

[GitHub] spark issue #16494: [SPARK-17975][MLLIB] Fix EMLDAOptimizer failing with Cla...

2017-01-06 Thread imatiach-msft
Github user imatiach-msft commented on the issue: https://github.com/apache/spark/pull/16494 @jkbradley @vanzin @skyluc @luluorta @uncleGen @kanzhang Could you please take a look at this pull request to fix the method fromEdges in EdgeRDD class used by LDA? Thank you! --- If your

[GitHub] spark issue #16480: [SPARK-18194][ML] Log instrumentation in OneVsRest, Cros...

2017-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16480 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #16491: [SPARK-19110][ML][MLLIB]:DistributedLDAModel retu...

2017-01-06 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/16491#discussion_r95047025 --- Diff: mllib/src/test/scala/org/apache/spark/ml/clustering/LDASuite.scala --- @@ -260,6 +260,14 @@ class LDASuite extends SparkFunSuite with

[GitHub] spark issue #16480: [SPARK-18194][ML] Log instrumentation in OneVsRest, Cros...

2017-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16480 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70996/ Test PASSed. ---

[GitHub] spark issue #16480: [SPARK-18194][ML] Log instrumentation in OneVsRest, Cros...

2017-01-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16480 **[Test build #70996 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70996/testReport)** for PR 16480 at commit

[GitHub] spark issue #16494: [SPARK-17975][MLLIB] Fix EMLDAOptimizer failing with Cla...

2017-01-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16494 **[Test build #71002 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71002/testReport)** for PR 16494 at commit

[GitHub] spark pull request #16494: [SPARK-17975][MLLIB] Fix EMLDAOptimizer failing w...

2017-01-06 Thread imatiach-msft
GitHub user imatiach-msft opened a pull request: https://github.com/apache/spark/pull/16494 [SPARK-17975][MLLIB] Fix EMLDAOptimizer failing with ClassCastException ## What changes were proposed in this pull request? LDA fails with a ClassCastException when run on a dataset

[GitHub] spark issue #15119: [SPARK-17568][CORE][DEPLOY] Add spark-submit option to o...

2017-01-06 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/15119 @vanzin and @themodernlife , I have this fixed up to use the additional repositories when loading ivy settings from a file. Added a new test for loading a settings and fixed up the docs for

[GitHub] spark issue #16473: [SPARK-19069] [CORE] Expose task 'status' and 'duration'...

2017-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16473 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16473: [SPARK-19069] [CORE] Expose task 'status' and 'duration'...

2017-01-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16473 **[Test build #71000 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71000/testReport)** for PR 16473 at commit

[GitHub] spark issue #16473: [SPARK-19069] [CORE] Expose task 'status' and 'duration'...

2017-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16473 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71000/ Test FAILed. ---

[GitHub] spark pull request #16491: [SPARK-19110][ML][MLLIB]:DistributedLDAModel retu...

2017-01-06 Thread wangmiao1981
Github user wangmiao1981 commented on a diff in the pull request: https://github.com/apache/spark/pull/16491#discussion_r95045854 --- Diff: mllib/src/test/scala/org/apache/spark/ml/clustering/LDASuite.scala --- @@ -260,6 +260,14 @@ class LDASuite extends SparkFunSuite with

[GitHub] spark issue #15119: [SPARK-17568][CORE][DEPLOY] Add spark-submit option to o...

2017-01-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15119 **[Test build #71001 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71001/testReport)** for PR 15119 at commit

[GitHub] spark issue #16493: [SPARK-19093][SQL] Cached tables are not used in Subquer...

2017-01-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16493 **[Test build #70999 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70999/testReport)** for PR 16493 at commit

[GitHub] spark issue #16473: [SPARK-19069] [CORE] Expose task 'status' and 'duration'...

2017-01-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16473 **[Test build #71000 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71000/testReport)** for PR 16473 at commit

[GitHub] spark issue #16473: [SPARK-19069] [CORE] Expose task 'status' and 'duration'...

2017-01-06 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/16473 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request #16493: [SPARK-19093][SQL] Cached tables are not used in ...

2017-01-06 Thread dilipbiswal
GitHub user dilipbiswal opened a pull request: https://github.com/apache/spark/pull/16493 [SPARK-19093][SQL] Cached tables are not used in SubqueryExpression ## What changes were proposed in this pull request? Consider the plans inside subquery expressions while looking up cache

[GitHub] spark pull request #16387: [SPARK-18986][Core] ExternalAppendOnlyMap shouldn...

2017-01-06 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/16387#discussion_r95044381 --- Diff: core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala --- @@ -115,6 +115,7 @@ class ExternalAppendOnlyMap[K, V, C](

[GitHub] spark issue #16492: [SPARK-19113][SS][Tests]Set UncaughtExceptionHandler in ...

2017-01-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16492 **[Test build #70998 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70998/testReport)** for PR 16492 at commit

[GitHub] spark pull request #16443: [SPARK-19042] Remove query string from jar url fo...

2017-01-06 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/16443#discussion_r95044096 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -34,12 +34,14 @@ import org.apache.spark.deploy.SparkHadoopUtil import

[GitHub] spark issue #16138: [WIP][SPARK-16609] Add to_date/to_timestamp with format ...

2017-01-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16138 **[Test build #70997 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70997/testReport)** for PR 16138 at commit

[GitHub] spark issue #16480: [SPARK-18194][ML] Log instrumentation in OneVsRest, Cros...

2017-01-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16480 **[Test build #70996 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70996/testReport)** for PR 16480 at commit

  1   2   3   4   >