Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95313666
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/SQLBuilder.scala ---
@@ -219,6 +219,9 @@ class SQLBuilder private (
case
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16344
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16344
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user actuaryzhang reopened a pull request:
https://github.com/apache/spark/pull/16344
[SPARK-18929][ML] Add Tweedie distribution in GLM
## What changes were proposed in this pull request?
I propose to add the full Tweedie family into the
GeneralizedLinearRegression
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15480
**[Test build #71115 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71115/testReport)**
for PR 15480 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16487
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16487
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71112/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16487
**[Test build #71112 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71112/testReport)**
for PR 16487 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12064
**[Test build #71114 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71114/testReport)**
for PR 12064 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95310611
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
---
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache
Github user gczsjdy commented on the issue:
https://github.com/apache/spark/pull/16476
@chenghao-intel
I think that the optimize rule will fold the parameters that have different
types with param0, and then disorganize the parameters' index. Thanks.
@rxin
I have removed
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r95310486
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -117,8 +117,31 @@ object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95310499
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
---
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache
Github user yhuai commented on the issue:
https://github.com/apache/spark/pull/16487
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/16510
This is pretty useful!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95309414
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
---
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16517
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/7/
Test PASSed.
---
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95309984
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
---
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95309902
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
---
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95309603
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
---
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95309481
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
---
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16517
**[Test build #7 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/7/testReport)**
for PR 16517 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16517
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r95309134
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -117,8 +117,31 @@ object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95308910
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
---
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95308787
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
---
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16497#discussion_r95308691
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -81,7 +96,11 @@ case class
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/16522
Hi, @vanzin and @zsxwing .
The PR passes the tests. Could you review this PR again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/16440
Hi, @srowen .
Could you merge this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16487
LGTM pending test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95307494
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -510,32 +542,90 @@ class Analyzer(
* Replaces
Github user wangmiao1981 commented on the issue:
https://github.com/apache/spark/pull/16523
cc @yanboliang
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user tanejagagan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16497#discussion_r95307385
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -51,16 +51,31 @@ import
Github user tanejagagan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16497#discussion_r95307232
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -51,16 +51,31 @@ import
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r95306902
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -117,8 +117,31 @@ object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16487#discussion_r95306656
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
@@ -469,9 +475,7 @@ class DataFrameReader private[sql](sparkSession:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r95306485
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -117,8 +117,31 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95306192
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -125,11 +132,16 @@ private[hive] class
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r95306125
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -117,8 +117,31 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95306084
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -125,11 +132,16 @@ private[hive] class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12064
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71113/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12064
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user tanejagagan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16497#discussion_r95305820
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -81,7 +96,11 @@ case class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12064
**[Test build #71113 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71113/testReport)**
for PR 12064 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95305635
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -510,32 +542,90 @@ class Analyzer(
* Replaces
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95305370
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -174,6 +176,7 @@ case class CatalogTable(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95305390
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -510,32 +542,90 @@ class Analyzer(
* Replaces
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12064
**[Test build #71113 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71113/testReport)**
for PR 12064 at commit
Github user witgo commented on a diff in the pull request:
https://github.com/apache/spark/pull/15505#discussion_r95305125
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala ---
@@ -592,47 +579,6 @@ class TaskSetManagerSuite extends SparkFunSuite
Github user witgo commented on the issue:
https://github.com/apache/spark/pull/15505
@squito In the local mode, the performance is relatively less important, we
only guarantee that there will be no performance degradation on it.
---
If your project is set up for it, you can reply to
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95304793
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
---
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95304745
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -510,32 +542,90 @@ class Analyzer(
* Replaces
Github user zdh2292390 commented on the issue:
https://github.com/apache/spark/pull/16415
@jkbradley @srowen Can anyone check my latest commit please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95304509
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
---
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95304037
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -510,32 +542,90 @@ class Analyzer(
* Replaces
Github user witgo commented on a diff in the pull request:
https://github.com/apache/spark/pull/15505#discussion_r95304052
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -149,7 +149,12 @@ private[spark] object Utils extends Logging {
/**
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95303945
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -510,32 +542,90 @@ class Analyzer(
* Replaces
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16487#discussion_r95303491
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/MetastoreDataSourcesSuite.scala
---
@@ -1169,26 +1169,6 @@ class MetastoreDataSourcesSuite
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16487
**[Test build #71112 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71112/testReport)**
for PR 16487 at commit
Github user tanejagagan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16497#discussion_r95303304
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -126,10 +152,15 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r95303089
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -117,8 +117,31 @@ object
Github user tanejagagan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16497#discussion_r95303054
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -126,10 +152,15 @@ case class
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/15413
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/15413
Merged into master. Thanks for all reviews.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15413#discussion_r95302720
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/clustering/GaussianMixtureSuite.scala
---
@@ -126,9 +143,93 @@ class GaussianMixtureSuite extends
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16233
Sorry, I have not finished the review. Need to buy a milk for my baby. Will
continue the review soon. : )
---
If your project is set up for it, you can reply to this email and have your
reply
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95302345
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -50,6 +50,36 @@ object SimpleAnalyzer extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95302084
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -510,32 +542,90 @@ class Analyzer(
* Replaces
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/16465
Gentle ping for @joshrosen to @davies maybe?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16487
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16487
**[Test build #71110 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71110/testReport)**
for PR 16487 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16487
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71110/
Test FAILed.
---
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/14725
I don't think the wrappers are public APIs per-se, but I agree reducing the
amount of boilerplate scala code required to expose the ML stuff is good if we
can make it robust :)
---
If your
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r95300754
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/OrderingSuite.scala
---
@@ -127,4 +127,17 @@ class OrderingSuite extends
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r95300735
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -117,8 +117,31 @@ object
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16514
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71109/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16514
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95300580
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -50,6 +50,36 @@ object SimpleAnalyzer extends
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16514
**[Test build #71109 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71109/testReport)**
for PR 16514 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16255#discussion_r95300466
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -200,6 +200,8 @@ object RemoveAliasOnlyProject
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r95300097
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/OrderingSuite.scala
---
@@ -127,4 +127,17 @@ class OrderingSuite extends
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/15480
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r9536
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -117,8 +117,31 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16481#discussion_r95299609
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -413,17 +413,22 @@ case class DataSource(
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16500
I'm wondering if we need the metadata cache anymore. Now we store
partitions in the metastore, and have a cache for leaf files, what's the
benefit of metadata cache?
---
If your project is set
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16487#discussion_r95298994
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -385,6 +380,8 @@ final class DataFrameWriter[T] private[sql](ds:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16517
**[Test build #7 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/7/testReport)**
for PR 16517 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16517#discussion_r95298791
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveWriterContainers.scala ---
@@ -1,356 +0,0 @@
-/*
- * Licensed to the Apache
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/14725
Sure, I can add a better docstring. This is just for developers and
doesn't have to be used, but it can be used to avoid creating more
Java-friendly functions only because they have arrays -
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16487#discussion_r95298747
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -385,6 +380,8 @@ final class DataFrameWriter[T] private[sql](ds:
Github user witgo commented on a diff in the pull request:
https://github.com/apache/spark/pull/15505#discussion_r95298151
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskDescription.scala ---
@@ -52,7 +55,36 @@ private[spark] class TaskDescription(
val
Github user hhbyyh commented on the issue:
https://github.com/apache/spark/pull/15211
Sent an update to include a R unit test. Yet I met a problem that there's a
constant scaling difference between LinearSVC and R 1071 (which essentially is
LibSVM). It's possible that it's caused by
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16497#discussion_r95297133
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -51,16 +51,31 @@ import
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16497#discussion_r95297232
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -81,7 +96,11 @@ case class Percentile(
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16497#discussion_r95297644
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -91,9 +110,16 @@ case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16497#discussion_r95297633
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -126,10 +152,15 @@ case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16497#discussion_r95297609
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -126,10 +152,15 @@ case class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16487
**[Test build #71110 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71110/testReport)**
for PR 16487 at commit
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16497#discussion_r95295321
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -126,10 +152,15 @@ case class
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16497#discussion_r95294516
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -51,16 +51,31 @@ import
1 - 100 of 459 matches
Mail list logo
