[GitHub] spark issue #16690: [SPARK-19347] ReceiverSupervisorImpl can add block to Re...

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16690 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #16690: [SPARK-19347] ReceiverSupervisorImpl can add bloc...

2017-01-24 Thread jinxing64
GitHub user jinxing64 opened a pull request: https://github.com/apache/spark/pull/16690 [SPARK-19347] ReceiverSupervisorImpl can add block to ReceiverTracker multiple times because of askWithRetry. ## What changes were proposed in this pull request?

[GitHub] spark issue #16689: [SPARK-19342][SPARKR] bug fixed in collect method for co...

2017-01-24 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/16689 Oh. it was all written in the PR description... I removed my uesless comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark issue #12135: [SPARK-14352][SQL] approxQuantile should support multi c...

2017-01-24 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/12135 yes spark-18285 https://issues.apache.org/jira/plugins/servlet/mobile#issue/SPARK-18285 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request #16660: [SPARK-19311][SQL] fix UDT hierarchy issue

2017-01-24 Thread gmoehler
Github user gmoehler commented on a diff in the pull request: https://github.com/apache/spark/pull/16660#discussion_r97504006 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala --- @@ -71,7 +73,104 @@ object UDT { } +// object

[GitHub] spark pull request #16660: [SPARK-19311][SQL] fix UDT hierarchy issue

2017-01-24 Thread gmoehler
Github user gmoehler commented on a diff in the pull request: https://github.com/apache/spark/pull/16660#discussion_r97503551 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala --- @@ -71,7 +73,104 @@ object UDT { } +// object

[GitHub] spark pull request #16660: [SPARK-19311][SQL] fix UDT hierarchy issue

2017-01-24 Thread gmoehler
Github user gmoehler commented on a diff in the pull request: https://github.com/apache/spark/pull/16660#discussion_r97503371 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala --- @@ -71,7 +73,104 @@ object UDT { } +// object

[GitHub] spark pull request #16660: [SPARK-19311][SQL] fix UDT hierarchy issue

2017-01-24 Thread gmoehler
Github user gmoehler commented on a diff in the pull request: https://github.com/apache/spark/pull/16660#discussion_r97503434 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala --- @@ -71,7 +73,104 @@ object UDT { } +// object

[GitHub] spark issue #12135: [SPARK-14352][SQL] approxQuantile should support multi c...

2017-01-24 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/12135 LGTM. @zhengruifeng did you manage to add a JIRA for exposing multi-col support in SparkR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #16689: [SPARK-19342][SPARKR] bug fixed in collect method for co...

2017-01-24 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/16689 (I might be wrong but was suspecting that it returns `NA` first as `logical` when we collect via `SerDe.scala` and then it ends up `numeric` due to the type coercion when `NA` is located first

[GitHub] spark pull request #16660: [SPARK-19311][SQL] fix UDT hierarchy issue

2017-01-24 Thread gmoehler
Github user gmoehler commented on a diff in the pull request: https://github.com/apache/spark/pull/16660#discussion_r97500817 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala --- @@ -71,7 +73,104 @@ object UDT { } +// object

[GitHub] spark issue #16676: delete useless var ā€œjā€

2017-01-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16676 **[Test build #71927 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71927/testReport)** for PR 16676 at commit

[GitHub] spark issue #16676: delete useless var ā€œjā€

2017-01-24 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/16676 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request #16661: [SPARK-19313][ML][MLLIB] GaussianMixture should l...

2017-01-24 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/16661#discussion_r97499446 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/GaussianMixture.scala --- @@ -272,6 +277,10 @@ class GaussianMixture private ( }

[GitHub] spark issue #16687: [SPARK-19343][DStreams] Do once optimistic checkpoint be...

2017-01-24 Thread uncleGen
Github user uncleGen commented on the issue: https://github.com/apache/spark/pull/16687 cc @zsxwing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #16689: [SPARK-19342][SPARKR] bug fixed in collect method for co...

2017-01-24 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/16689 Oh @felixcheung , I was writing a comment but I just saw you. I was looking into this for my curiosity. Isn't this due to R type coercion rule with POSIXlt? ```r >

[GitHub] spark pull request #16660: [SPARK-19311][SQL] fix UDT hierarchy issue

2017-01-24 Thread gmoehler
Github user gmoehler commented on a diff in the pull request: https://github.com/apache/spark/pull/16660#discussion_r97498083 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala --- @@ -71,7 +73,104 @@ object UDT { } +// object

[GitHub] spark pull request #16660: [SPARK-19311][SQL] fix UDT hierarchy issue

2017-01-24 Thread gmoehler
Github user gmoehler commented on a diff in the pull request: https://github.com/apache/spark/pull/16660#discussion_r97498043 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala --- @@ -20,13 +20,15 @@ package org.apache.spark.sql import

[GitHub] spark pull request #16660: [SPARK-19311][SQL] fix UDT hierarchy issue

2017-01-24 Thread gmoehler
Github user gmoehler commented on a diff in the pull request: https://github.com/apache/spark/pull/16660#discussion_r97498057 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala --- @@ -71,7 +73,104 @@ object UDT { } +// object

[GitHub] spark issue #16689: [SPARK-19342][SPARKR] bug fixed in collect method for co...

2017-01-24 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/16689 Thanks! I can verify this case and the fix. Could you please add some tests for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark issue #15945: [SPARK-12978][SQL] Merge unnecessary partial aggregates

2017-01-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15945 **[Test build #71926 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71926/testReport)** for PR 15945 at commit

[GitHub] spark issue #15945: [SPARK-12978][SQL] Merge unnecessary partial aggregates

2017-01-24 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/15945 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #16387: [SPARK-18986][Core] ExternalAppendOnlyMap shouldn't fail...

2017-01-24 Thread samkum
Github user samkum commented on the issue: https://github.com/apache/spark/pull/16387 Hi, No, I havent test this with out the ExternalAppendOnlyMap fix if this is what you are asking. I tested it with changes to both the classes: TaskMemoryManager and

[GitHub] spark issue #12896: [SPARK-14489][ML][PYSPARK] ALS unknown user/item predict...

2017-01-24 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/12896 Reviving after a hiatus. Updated since tags. I've actually recently come across a number of users hitting this issue in production and are unable to use ALS with cross-validation as a result.

[GitHub] spark pull request #16663: [SPARK-18823][SPARKR] add support for assigning t...

2017-01-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16663 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #16663: [SPARK-18823][SPARKR] add support for assigning to colum...

2017-01-24 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/16663 merged to master and 2.1.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #14907: [SPARK-17351] Refactor JDBCRDD to expose ResultSet -> Se...

2017-01-24 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14907 We exposed `JdbcUtils.resultSetToRows`, but forgot to add a test case. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #16552: [SPARK-19152][SQL]DataFrameWriter.saveAsTable support hi...

2017-01-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16552 **[Test build #71925 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71925/testReport)** for PR 16552 at commit

[GitHub] spark pull request #16138: [SPARK-16609] Add to_date/to_timestamp with forma...

2017-01-24 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/16138#discussion_r97493826 --- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R --- @@ -1177,6 +1177,9 @@ test_that("column functions", { c17 <- cov(c, c1) + cov("c", "c1") +

[GitHub] spark issue #16476: [SPARK-19084][SQL] Implement expression field

2017-01-24 Thread gczsjdy
Github user gczsjdy commented on the issue: https://github.com/apache/spark/pull/16476 ping @rxin @gatorsmile @tejasapatil @viirya --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #16552: [SPARK-19152][SQL]DataFrameWriter.saveAsTable support hi...

2017-01-24 Thread windpiger
Github user windpiger commented on the issue: https://github.com/apache/spark/pull/16552 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #15880: [SPARK-17913][SQL] compare atomic and string type column...

2017-01-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15880 **[Test build #71924 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71924/testReport)** for PR 15880 at commit

[GitHub] spark issue #16552: [SPARK-19152][SQL]DataFrameWriter.saveAsTable support hi...

2017-01-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16552 **[Test build #71923 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71923/testReport)** for PR 16552 at commit

[GitHub] spark issue #16606: [SPARK-19246][SQL]CataLogTable's partitionSchema order a...

2017-01-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16606 **[Test build #71922 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71922/testReport)** for PR 16606 at commit

[GitHub] spark pull request #16138: [SPARK-16609] Add to_date/to_timestamp with forma...

2017-01-24 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/16138#discussion_r97492683 --- Diff: R/pkg/R/functions.R --- @@ -1746,7 +1750,7 @@ setMethod("toRadians", #' to_date(df$c) #' to_date(df$c, '-MM-dd') #' }

[GitHub] spark pull request #16552: [SPARK-19152][SQL]DataFrameWriter.saveAsTable sup...

2017-01-24 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16552#discussion_r97492625 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ddl.scala --- @@ -65,6 +65,11 @@ case class CreateTempViewUsing( }

[GitHub] spark pull request #16552: [SPARK-19152][SQL]DataFrameWriter.saveAsTable sup...

2017-01-24 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16552#discussion_r97492569 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ddl.scala --- @@ -65,6 +65,11 @@ case class CreateTempViewUsing( }

[GitHub] spark issue #16552: [SPARK-19152][SQL]DataFrameWriter.saveAsTable support hi...

2017-01-24 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16552 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #16606: [SPARK-19246][SQL]CataLogTable's partitionSchema order a...

2017-01-24 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16606 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #15880: [SPARK-17913][SQL] compare atomic and string type column...

2017-01-24 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/15880 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #16668: [SPARK-18788][SPARKR] Add API for getNumPartition...

2017-01-24 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/16668#discussion_r97492412 --- Diff: R/pkg/R/DataFrame.R --- @@ -3406,3 +3406,28 @@ setMethod("randomSplit", } sapply(sdfs, dataFrame)

[GitHub] spark issue #16138: [SPARK-16609] Add to_date/to_timestamp with format funct...

2017-01-24 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16138 The failed test is `udf5.q` in `HiveComparisonTest`, but I can't find `SELECT to_date('2001-10-30 10:30:00', '')` in it, can you point out where we write such a test? --- If your project is set

[GitHub] spark issue #16138: [SPARK-16609] Add to_date/to_timestamp with format funct...

2017-01-24 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/16138 @anabranch right, since there is little work done on the R side and this is mostly a pass through, just checking if the functions are callable without error like the test you have added should

[GitHub] spark issue #15945: [SPARK-12978][SQL] Merge unnecessary partial aggregates

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15945 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16552: [SPARK-19152][SQL]DataFrameWriter.saveAsTable support hi...

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16552 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71918/ Test FAILed. ---

[GitHub] spark issue #15880: [SPARK-17913][SQL] compare atomic and string type column...

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15880 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16688: [TESTS][SQL] Setup testdata at the beginning for tests t...

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16688 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16594: [SPARK-17078] [SQL] Show stats when explain

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16594 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16594: [SPARK-17078] [SQL] Show stats when explain

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16594 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71921/ Test FAILed. ---

[GitHub] spark issue #16552: [SPARK-19152][SQL]DataFrameWriter.saveAsTable support hi...

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16552 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15945: [SPARK-12978][SQL] Merge unnecessary partial aggregates

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15945 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71917/ Test FAILed. ---

[GitHub] spark issue #16552: [SPARK-19152][SQL]DataFrameWriter.saveAsTable support hi...

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16552 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16606: [SPARK-19246][SQL]CataLogTable's partitionSchema order a...

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16606 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15880: [SPARK-17913][SQL] compare atomic and string type column...

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15880 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71916/ Test FAILed. ---

[GitHub] spark issue #16552: [SPARK-19152][SQL]DataFrameWriter.saveAsTable support hi...

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16552 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71920/ Test FAILed. ---

[GitHub] spark issue #16606: [SPARK-19246][SQL]CataLogTable's partitionSchema order a...

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16606 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71912/ Test FAILed. ---

[GitHub] spark issue #16688: [TESTS][SQL] Setup testdata at the beginning for tests t...

2017-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16688 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71919/ Test FAILed. ---

<    1   2   3   4   5