Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r99531337
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -31,10 +31,11 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16680#discussion_r99530531
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVUtils.scala
---
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16680#discussion_r99530062
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala
---
@@ -39,22 +37,76 @@ private[csv] object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16680#discussion_r99530031
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVFileFormat.scala
---
@@ -170,32 +111,21 @@ class CSVFileFormat
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16787
**[Test build #72426 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72426/testReport)**
for PR 16787 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16803
**[Test build #72425 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72425/testReport)**
for PR 16803 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16787
**[Test build #72424 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72424/testReport)**
for PR 16787 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16787
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72424/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16787
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/16738
@kayousterhout
Thanks a lot again : )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16791
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/16803#discussion_r99528722
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -480,7 +479,12 @@ object SparkSubmit extends CommandLineUtils {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16757#discussion_r99528500
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -154,56 +155,97 @@ class SimpleTestOptimizer extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16757#discussion_r99528351
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -154,56 +155,97 @@ class SimpleTestOptimizer extends
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16787
**[Test build #72424 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72424/testReport)**
for PR 16787 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16138
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72422/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16138
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16138
**[Test build #72422 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72422/testReport)**
for PR 16138 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16138#discussion_r99527096
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala ---
@@ -354,31 +354,58 @@ class DateFunctionsSuite extends QueryTest with
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16787
**[Test build #72423 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72423/testReport)**
for PR 16787 at commit
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16738
LGTM! Thanks for fixing this! I'll merge this tomorrow once tests pass and
pending any further comments from @srowen
---
If your project is set up for it, you can reply to this email and
Github user anshbansal commented on the issue:
https://github.com/apache/spark/pull/16789
@srowen Will read them and get back
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/16738
@kayousterhout
Thanks a lot for helping this pr thus far. I think the proposal is quite
clear. I've already refined. Please take another look.
---
If your project is set up for it, you can
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16787
**[Test build #72423 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72423/testReport)**
for PR 16787 at commit
Github user uncleGen commented on the issue:
https://github.com/apache/spark/pull/16815
cc @srowen @zsxwing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16664
Just finished this round of reviews. Thanks!
This PR enables the QueryExecutionListener when users using the
DataFrameWriter methods. However, it still misses the other code paths,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16762
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16762
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72421/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16762
**[Test build #72421 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72421/testReport)**
for PR 16762 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16664
Could you update the PR title to `[SPARK-18120][SQL] Call
QueryExecutionListener callback methods for DataFrameWriter methods`
---
If your project is set up for it, you can reply to this email
Github user zhoucen commented on the issue:
https://github.com/apache/spark/pull/16816
@uncleGen Okï¼
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user uncleGen commented on the issue:
https://github.com/apache/spark/pull/16816
It is too tiny to make a pr, so let us close it, OK?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16738#discussion_r99523053
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -799,7 +799,7 @@ private[spark] class TaskSetManager(
if
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16737#discussion_r99522959
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/source/libsvm/LibSVMOptions.scala ---
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16726#discussion_r99522843
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveTableScanSuite.scala
---
@@ -166,13 +166,11 @@ class HiveTableScanSuite extends
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16816
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16809
This is a behavior change rather than a bug fix, but I think this new
behavior makes more sense. cc @gatorsmile to confirm.
---
If your project is set up for it, you can reply to this email and
GitHub user zhoucen opened a pull request:
https://github.com/apache/spark/pull/16816
Code style improvement
Use 2-space indentation in general.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhoucen/spark patch-1
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99521880
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SparkSQLQueryExecutionListenerSuite.scala
---
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99521699
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SparkSQLQueryExecutionListenerSuite.scala
---
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99521679
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SparkSQLQueryExecutionListenerSuite.scala
---
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99521620
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SparkSQLQueryExecutionListenerSuite.scala
---
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99521628
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SparkSQLQueryExecutionListenerSuite.scala
---
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/16783
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/16810
It's great, +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99520106
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1047,4 +1047,14 @@ object StaticSQLConf {
"SQL
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99520045
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -893,6 +896,12 @@ object SparkSession {
}
}
+
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/16810#discussion_r99519864
--- Diff: docs/building-spark.md ---
@@ -63,57 +63,30 @@ with Maven profile settings and so on like the direct
Maven build. Example:
This
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16787
please resolve the conflict, now you need to remove the duplicated
functions between HiveUtils and HiveClientImpl
---
If your project is set up for it, you can reply to this email and have your
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16636
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16636
LGTM, merging to master!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16636#discussion_r99519100
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -79,6 +79,25 @@ class HiveDDLSuite
}
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99518656
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -893,6 +896,12 @@ object SparkSession {
}
}
+
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99518378
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1047,4 +1047,14 @@ object StaticSQLConf {
"SQL
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99518295
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1047,4 +1047,14 @@ object StaticSQLConf {
"SQL
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99518239
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1047,4 +1047,14 @@ object StaticSQLConf {
"SQL
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16803#discussion_r99518229
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitUtilsSuite.scala ---
@@ -258,4 +259,53 @@ class SparkSubmitUtilsSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16803#discussion_r99518186
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -480,7 +479,12 @@ object SparkSubmit extends CommandLineUtils {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99518130
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -218,7 +247,14 @@ final class DataFrameWriter[T] private[sql](ds:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16803
This should be taged as `[BUILD]`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99518083
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -218,7 +247,14 @@ final class DataFrameWriter[T] private[sql](ds:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16138
**[Test build #72422 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72422/testReport)**
for PR 16138 at commit
Github user anabranch commented on the issue:
https://github.com/apache/spark/pull/16138
@felixcheung thanks, made those changes :). Hopefully this will start
passing sometime :P
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/16809
cc @cloud-fan @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16762
**[Test build #72421 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72421/testReport)**
for PR 16762 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16760
@dilipbiswal Does that mean your test cases cover all the EXISTS scenarios
in `SubquerySuite.scala`?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16762
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16815
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16815
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72420/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16815
**[Test build #72420 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72420/testReport)**
for PR 16815 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16809
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16809
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72419/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16809
**[Test build #72419 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72419/testReport)**
for PR 16809 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16727
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/16727
This looks good, merging into master. Thanks for doing this cleanup work
@zhengruifeng :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user ericl commented on the issue:
https://github.com/apache/spark/pull/16797
I agree that bringing back schema inference would be cleaner. One problem
with doing something parquet-specific is that this would need to be repeated
with each file format, e.g. orc, csv, json,
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/16785
The rewritten logic is not correct. I am working to improve this with other
approach.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/16727
ping @yanboliang ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/16620
@squito
Thanks a lot for helping this PR thus far.
I've added unit test in `DAGSchedulerSuite`, but not sure if it is exactly
what you suggest.
I created a `mockTaskSchedulerImpl`.
Github user zuotingbing commented on the issue:
https://github.com/apache/spark/pull/16614
@srowen Happy Chinese New Year !
Sorry for the late reply. It sounds more sensible to test this behavior
everywhere since all the test cases used the directory, right? Thank you for
your
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16815
**[Test build #72420 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72420/testReport)**
for PR 16815 at commit
GitHub user uncleGen opened a pull request:
https://github.com/apache/spark/pull/16815
[SPARK-19407][SS] defaultFS is used FileSystem.get instead of getting it
from uri scheme
## What changes were proposed in this pull request?
```
Caused by:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16809
**[Test build #72419 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72419/testReport)**
for PR 16809 at commit
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/16638
Happy Chinese New Year ! @gatorsmile
The Spring Festival holiday just ended, and I return to work today, what
work do I need to do?
---
If your project is set up for it, you can reply
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/16776
@gatorsmile Updated! Thanks for reviewing!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16664
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16664
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72417/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16664
**[Test build #72417 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72417/testReport)**
for PR 16664 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16814
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16814
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72418/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16814
**[Test build #72418 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72418/testReport)**
for PR 16814 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16607
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16607
LGTM
Merging with master
Thanks @Krimit !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16814
**[Test build #72418 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72418/testReport)**
for PR 16814 at commit
GitHub user zero323 opened a pull request:
https://github.com/apache/spark/pull/16814
[SPARK-19467][ML][PYTHON]Remove cyclic imports from pyspark.ml.pipeline
## What changes were proposed in this pull request?
Remove cyclic imports between `pyspark.ml.pipeline` and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16798
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72416/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16798
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16798
**[Test build #72416 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72416/testReport)**
for PR 16798 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16810
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16810#discussion_r99503085
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala
---
@@ -63,17 +63,16 @@ private[hive] object
1 - 100 of 178 matches
Mail list logo
