Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16910
**[Test build #72808 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72808/testReport)**
for PR 16910 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16870
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72799/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16870
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user windpiger opened a pull request:
https://github.com/apache/spark/pull/16910
[SPARK-19575][SQL]Reading from or writing to a hive serde table with a non
pre-existing location should succeed
## What changes were proposed in this pull request?
This PR is a
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16870
**[Test build #72799 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72799/testReport)**
for PR 16870 at commit
Github user sureshthalamati commented on the issue:
https://github.com/apache/spark/pull/16891
Thank you for reviewing the PR @cloud-fan. Addressed the review comments,
please let me know if it requires any further changes.
---
If your project is set up for it, you can reply to
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/16868
Very thoughtful consideration. Thanks for your explanation and suggestion!
@tejasapatil what do you think? @gatorsmile @cloud-fan
---
If your project is set up for it, you can reply to
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16870
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16870
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72798/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16870
**[Test build #72798 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72798/testReport)**
for PR 16870 at commit
Github user sureshthalamati commented on a diff in the pull request:
https://github.com/apache/spark/pull/16891#discussion_r100737587
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCWriteSuite.scala ---
@@ -75,7 +75,7 @@ class JDBCWriteSuite extends
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16891
**[Test build #72807 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72807/testReport)**
for PR 16891 at commit
Github user sureshthalamati commented on a diff in the pull request:
https://github.com/apache/spark/pull/16891#discussion_r100737505
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/CaseInsensitiveMap.scala
---
@@ -23,16 +23,30 @@ package
Github user sureshthalamati commented on a diff in the pull request:
https://github.com/apache/spark/pull/16891#discussion_r100737377
--- Diff:
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala
---
@@ -149,4 +155,29 @@ class
Github user sureshthalamati commented on a diff in the pull request:
https://github.com/apache/spark/pull/16891#discussion_r100737351
--- Diff:
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala
---
@@ -62,6 +62,12 @@ class
Github user sureshthalamati commented on a diff in the pull request:
https://github.com/apache/spark/pull/16891#discussion_r100737390
--- Diff:
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala
---
@@ -149,4 +155,29 @@ class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16908
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16908
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72805/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16908
**[Test build #72805 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72805/testReport)**
for PR 16908 at commit
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/16868
Very serious consideration. Thanks for your explanation and suggestion!
what do you think? @gatorsmile @cloud-fan
---
If your project is set up for it, you can reply to this email and have
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16672
Could you move the test cases to `DDLSuite.scala`? This is not for Hive
specific. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user titicaca commented on the issue:
https://github.com/apache/spark/pull/16689
Yes. The JIRA id is SPARK-19342. Thank you for the help and advices :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16909
**[Test build #72806 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72806/testReport)**
for PR 16909 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16672#discussion_r100735110
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1431,4 +1432,133 @@ class HiveDDLSuite
}
Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/16909
@rxin : can you please recommend someone who could review this PR ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16672#discussion_r100735007
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1431,4 +1432,133 @@ class HiveDDLSuite
}
Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/16909
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
GitHub user tejasapatil opened a pull request:
https://github.com/apache/spark/pull/16909
[SPARK-13450] Introduce UnsafeRowExternalArray. Change SortMergeJoin and
WindowExec to use it
## What issue does this PR address ?
Jira:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16672#discussion_r100734735
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1431,4 +1432,133 @@ class HiveDDLSuite
}
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16908
**[Test build #72805 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72805/testReport)**
for PR 16908 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16908
cc @srowen @anshbansal
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/16908
[SPARK-19574][ML][Documentation] Fix Liquid Exception: Start indices amount
is not equal to end indices amount
### What changes were proposed in this pull request?
```
Liquid Exception:
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16902
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/16902
Good catch. LGTM. Thanks!
Merging to master and 2.1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16789#discussion_r100733678
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaTokenizerExample.java
---
@@ -35,13 +35,11 @@
import
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16672
**[Test build #72804 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72804/testReport)**
for PR 16672 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16777#discussion_r100730262
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -116,48 +114,66 @@ object TypeCoercion {
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16750
**[Test build #72803 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72803/testReport)**
for PR 16750 at commit
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/16776
https://issues.apache.org/jira/browse/SPARK-19573 is created to track the
issue on non-consistent na-droping.
---
If your project is set up for it, you can reply to this email and have your
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r100729875
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
---
@@ -859,6 +859,48 @@ class CSVSuite extends QueryTest
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r100729866
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -58,13 +59,15 @@ private[sql] class JSONOptions(
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16777
@gatorsmile, Can we make this merged and then add test cases for them
separately? It seems the results are the same. I ran two tests as below:
```scala
val integralTypes =
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16776
**[Test build #72802 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72802/testReport)**
for PR 16776 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16907
**[Test build #72801 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72801/testReport)**
for PR 16907 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16776#discussion_r100727960
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameStatFunctions.scala ---
@@ -58,49 +58,54 @@ final class DataFrameStatFunctions
GitHub user zjffdu opened a pull request:
https://github.com/apache/spark/pull/16907
[SPARK-19582][SPARKR] Allow to disable hive in sparkR shell
## What changes were proposed in this pull request?
SPARK-15236 do this for scala shell, this ticket is for sparkR shell. This
is not
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16777#discussion_r100727682
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -116,48 +114,66 @@ object TypeCoercion {
Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/16868
>> we don't need to do check whether the targetTable.storage.locationUri is
the same with sourceTable.storage.locationUri
We should not do that check for external tables. But continue
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16878
**[Test build #72800 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72800/testReport)**
for PR 16878 at commit
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/16672#discussion_r100725345
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -754,6 +754,8 @@ case class AlterTableSetLocationCommand(
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16870
**[Test build #72799 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72799/testReport)**
for PR 16870 at commit
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/16672
ok, let me create a new pr for hive serde tables, and continue to finish
this pr~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16870
**[Test build #72798 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72798/testReport)**
for PR 16870 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16620
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72797/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16620
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16620
**[Test build #72797 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72797/testReport)**
for PR 16620 at commit
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/16870#discussion_r100723941
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala ---
@@ -500,6 +527,23 @@ class DateFunctionsSuite extends QueryTest with
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/16870#discussion_r100723919
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala ---
@@ -477,6 +483,27 @@ class DateFunctionsSuite extends QueryTest with
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16777
I see what you mean. The code paths are now different. Let me try to
investigate it and split them.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16777#discussion_r100723132
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -116,48 +114,66 @@ object TypeCoercion {
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16776
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16776
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72795/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16776
**[Test build #72795 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72795/testReport)**
for PR 16776 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16776
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16776
**[Test build #72794 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72794/testReport)**
for PR 16776 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16776
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72794/
Test PASSed.
---
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/16906
Let me take a look tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user zjffdu commented on the issue:
https://github.com/apache/spark/pull/16906
@holdenk Please help review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/16868
Do you mean that we don't need to do check whether the
targetTable.storage.locationUri is the same with
sourceTable.storage.locationUri or not ? @tejasapatil
---
If your project is set
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/16733
okay, I'll close this and jira, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user maropu closed the pull request at:
https://github.com/apache/spark/pull/16733
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16777#discussion_r100719964
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -116,48 +114,66 @@ object TypeCoercion {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16777#discussion_r100719832
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -116,48 +114,66 @@ object TypeCoercion {
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16777
Yeah, the first PR is for refactoring and cleaning up
`findWiderTypeForTwo`. We need to add the test cases for the behavior changes.
We might also need to document this in the release note,
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16733
I prefer to closing it now. If users hit this again, we can revisit it.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16906
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/16868
There are two main uses of EXTERNAL tables I am aware of:
1. Ingest data from non-hive locations into Hive tables. This can be
covered by adding test case for reading from external
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16906
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72796/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16906
**[Test build #72796 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72796/testReport)**
for PR 16906 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16777#discussion_r100716751
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -116,48 +114,66 @@ object TypeCoercion {
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16777
Do you mean two PRs for cleaning up the logics here and the support of
array type coercion?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/16868
In @tejasapatil's comment, Whether we need to be exactly the same as Hive?
@gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16777#discussion_r100716252
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -116,48 +114,66 @@ object TypeCoercion {
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16620
**[Test build #72797 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72797/testReport)**
for PR 16620 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16777
I think we need to separate the changes from the support of `Type coercion
between ArrayTypes`? Could you submit another PR at first? We might need extra
test cases for this change.
---
If
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/16733
yea, I think we do not need to handle this.
Either way, it'd be better to just add checking the exception in tests?;
```
intercept[NoSuchElementException] {
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16800#discussion_r100715216
--- Diff: R/pkg/R/mllib_classification.R ---
@@ -39,6 +46,116 @@ setClass("MultilayerPerceptronClassificationModel",
representation(jobj = "jobj"
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16777#discussion_r100715180
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -116,48 +114,66 @@ object TypeCoercion {
Github user gczsjdy commented on the issue:
https://github.com/apache/spark/pull/16476
@gatorsmile Hi, this patch has passed all tests, is there some code I
still need to modify? Thank you for working on this.
---
If your project is set up for it, you can reply to this email and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16906
**[Test build #72796 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72796/testReport)**
for PR 16906 at commit
GitHub user zjffdu opened a pull request:
https://github.com/apache/spark/pull/16906
[SPARK-19570][PYSPARK] Allow to disable hive in pyspark shell
## What changes were proposed in this pull request?
SPARK-15236 do this for scala shell, this ticket is for pyspark shell. This
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16776
**[Test build #72795 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72795/testReport)**
for PR 16776 at commit
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/16868
I think @tejasapatil's suggestion is reasonable, because the location is
specified by users, So the sourceTable.storage.locationUri and
targetTable.storage.locationUri can be same or
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16776
**[Test build #72794 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72794/testReport)**
for PR 16776 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16733
I think we can close this PR, @maropu ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16868
Please add a test case based on what @tejasapatil suggested. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/16776#discussion_r100713371
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameStatFunctions.scala ---
@@ -63,44 +63,49 @@ final class DataFrameStatFunctions
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16870
Could you also add one more case for verifying `to_date` on "2016-02-29"
and "2017-02-29"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/16868
I think there is no need to do this validation, because the location is
specified by users, So the targetTable.storage.lcaotionUri and
sourceTable.storage.locationUri can be same or
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16870#discussion_r100713312
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala ---
@@ -500,6 +527,23 @@ class DateFunctionsSuite extends QueryTest with
1 - 100 of 341 matches
Mail list logo
